mosaicstack/stack
25
0
Fork 1
Code Issues 366 Pull Requests 13 Actions Packages Projects Releases 15 Wiki Activity

cli: bus host start releases host.lock and the broker on every failure after the reply, and handles the child error event, row 111 (#1605)

Browse Source 
Dewey approve, comment 28331, manifest 5e888f93. Sage gate on be6f2ed8c
plus the patch: every package suite green (cli 178); test-queue failed
review.test.mjs:123 once under load (16s vs 3.7s), passed 28/28 rerun alone;
release 14, task 98. Dewey note a (ended() rejects on a child error and skips
release()) is recorded for the next row that touches host.mjs.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
This commit is contained in:
jason.woltje
2026-10-13 18:59:06 -05:00
co-authored by Claude Opus 5.5
parent e60410566c
commit 9774d70db5
2 changed files with 183 additions and 30 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/cli/tests/host.test.mjs
+132 -5
View File
@@ -108,14 +108,14 @@ function failSends(t, fake) {
});
}
// Makes the next fork throw (`where` "fork") or the new child's sends throw
// Makes the nth new child's fork throw (`where` "fork") or its sends throw
// ("send"), through the `send` that node installs on a new child: a fork
// throws when the install does. Every child it saw is killed after the test,
// the one a throwing fork started included.
function throwOn(t, where) {
// throws when the install does. Other children are left alone. Every child
// it saw is killed after the test, the one a throwing fork started included.
function throwOn(t, where, nth = 0) {
const children = [];
const onChild = ({ process: child }) => {
children.push(child);
if (children.push(child) - 1 !== nth) return;
let send;
Object.defineProperty(child, "send", {
configurable: true,
@@ -135,6 +135,22 @@ function throwOn(t, where) {
});
}
// Every child this process creates while the test runs, in fork order. Each
// is killed after the test, so a start that leaves a child running fails the
// test rather than hang the file.
function forksSeen(t) {
const children = [];
const onChild = ({ process: child }) => children.push(child);
subscribe("child_process", onChild);
t.after(() => {
unsubscribe("child_process", onChild);
for (const child of children) child.kill("SIGKILL");
});
return children;
}
const gone = (child) => child.exitCode !== null || child.signalCode !== null;
const epipe = (child) => {
child.kill("SIGKILL");
return Object.assign(new Error("write EPIPE"), { code: "EPIPE", errno: -32, syscall: "write" });
@@ -407,6 +423,117 @@ test("a broker that misses its boot wait leaves no host.lock and no host.json",
assert.equal(existsSync(join(f.dataRoot, "bus", "writer.lock")), false);
});
for (const where of ["fork", "send"])
test(`a notifier ${where} that throws stops the broker and leaves no host.lock and no host.json`, async (t) => {
const root = tmp(t);
const f = fixture(root);
makeDeployment(root, { dmRecipient: IDS.owner });
const boot = bootConfig({ system: loadSystem({ env: f.env }), businessId: "acme", env: f.env });
const children = forksSeen(t);
throwOn(t, where, 1);
const started = startHost({ boot, business: "acme", notifier: { binding: "test-seat" }, log: () => {} });
t.after(async () => (await started.catch(() => null))?.close(0));
await assert.rejects(started, (e) => e.message === `${where} failed`);
assert.equal(children.length, 2);
assert.ok(gone(children[0]), "the broker has ended");
// A fork that throws returns no child to stop; throwOn kills it.
if (where === "send") assert.ok(gone(children[1]), "the notifier has ended");
assert.equal(existsSync(hostLock(f.dataRoot)), false);
assert.equal(existsSync(hostFile(f.dataRoot)), false);
assert.equal(existsSync(join(f.dataRoot, "bus", "writer.lock")), false);
});
for (const withNotifier of [true, false])
test(`a boot reply with no reader for the business refuses with exit 3 naming it, ${withNotifier ? "before the notifier starts" : "with no notifier"}, and leaves no host.lock and no live broker`, async (t) => {
const root = tmp(t);
const f = fixture(root);
makeDeployment(root, { dmRecipient: IDS.owner });
const boot = bootConfig({ system: loadSystem({ env: f.env }), businessId: "acme", env: f.env });
const children = forksSeen(t);
const started = startHost({ boot, business: "other", notifier: withNotifier ? { binding: "test-seat" } : null, log: () => {} });
t.after(async () => (await started.catch(() => null))?.close(0));
await assert.rejects(started, (e) => e.exitCode === 3 && e.message === "broker has no reader for business other");
assert.equal(children.length, 1, "no notifier was started");
assert.ok(gone(children[0]), "the broker has ended");
assert.equal(existsSync(hostLock(f.dataRoot)), false);
assert.equal(existsSync(hostFile(f.dataRoot)), false);
assert.equal(existsSync(join(f.dataRoot, "bus", "writer.lock")), false);
});
test("a host.json that can't be written stops both children and leaves no host.lock", async (t) => {
const root = tmp(t);
const f = fixture(root);
makeDeployment(root, { dmRecipient: IDS.owner });
const discord = await fakeDiscord(t);
const boot = bootConfig({ system: loadSystem({ env: f.env }), businessId: "acme", env: f.env });
const children = forksSeen(t);
// The host writes host.json through this name with the `wx` flag.
mkdirSync(hostDir(f.dataRoot), { recursive: true, mode: 0o700 });
writeFileSync(`${hostFile(f.dataRoot)}.${process.pid}.tmp`, "");
const started = startHost({ boot, business: "acme", notifier: { binding: "test-seat", base: discord.base, pollMs: 100 }, log: () => {} });
t.after(async () => (await started.catch(() => null))?.close(0));
await assert.rejects(started, (e) => e.code === "EEXIST");
assert.equal(children.length, 2);
assert.ok(children.every(gone), "the broker and the notifier have ended");
assert.equal(existsSync(hostLock(f.dataRoot)), false);
assert.equal(existsSync(hostFile(f.dataRoot)), false);
assert.equal(existsSync(join(f.dataRoot, "bus", "writer.lock")), false);
});
for (const [name, op] of [["broker", "boot"], ["notifier", "start"]])
test(`an error event on the ${name} before it replies fails the start at once, and leaves no host.lock and no live child`, { timeout: 8000 }, async (t) => {
const root = tmp(t);
const f = fixture(root);
makeDeployment(root, { dmRecipient: IDS.owner });
const boot = bootConfig({ system: loadSystem({ env: f.env }), businessId: "acme", env: f.env });
const children = forksSeen(t);
// The send fails, and the child, still running, never gets the message.
failSends(t, (child, m) => (m?.op === op ? Object.assign(new Error("write EPIPE"), { code: "EPIPE" }) : null));
const started = startHost({ boot, business: "acme", notifier: { binding: "test-seat" }, log: () => {} });
t.after(async () => (await started.catch(() => null))?.close(0));
await assert.rejects(started, (e) => e.exitCode === 1 && e.message === `${name} failed before it replied: write EPIPE`);
assert.ok(children.every(gone), "every child has ended");
assert.equal(existsSync(hostLock(f.dataRoot)), false);
assert.equal(existsSync(hostFile(f.dataRoot)), false);
});
test("an error event on the broker while the notifier starts fails the start once the notifier replies", async (t) => {
const root = tmp(t);
const f = fixture(root);
makeDeployment(root, { dmRecipient: IDS.owner });
const discord = await fakeDiscord(t);
const boot = bootConfig({ system: loadSystem({ env: f.env }), businessId: "acme", env: f.env });
const children = forksSeen(t);
spySends(t, (m) => {
if (m?.op === "start") process.nextTick(() => children[0].emit("error", new Error("write EPIPE")));
});
const started = startHost({ boot, business: "acme", notifier: { binding: "test-seat", base: discord.base, pollMs: 100 }, log: () => {} });
t.after(async () => (await started.catch(() => null))?.close(0));
await assert.rejects(started, (e) => e.exitCode === 1 && e.message === "broker failed: write EPIPE");
assert.ok(children.every(gone), "the broker and the notifier have ended");
assert.equal(existsSync(hostLock(f.dataRoot)), false);
assert.equal(existsSync(hostFile(f.dataRoot)), false);
});
for (const [n, name, line] of [[0, "broker", "broker channel broken (broker error: write EPIPE); stopping the host"], [1, "notifier", "notifier error (write EPIPE); stopping the host"]])
test(`an error event on the ${name} once the host is up stops the host with exit 1, and leaves no host.lock and no host.json`, { timeout: 15000 }, async (t) => {
const root = tmp(t);
const f = fixture(root);
makeDeployment(root, { dmRecipient: IDS.owner });
const discord = await fakeDiscord(t);
const boot = bootConfig({ system: loadSystem({ env: f.env }), businessId: "acme", env: f.env });
const children = forksSeen(t);
const logs = [];
const host = await startHost({ boot, business: "acme", notifier: { binding: "test-seat", base: discord.base, pollMs: 100 }, log: (l) => logs.push(l) });
t.after(() => host.close(0));
children[n].emit("error", new Error("write EPIPE"));
assert.equal(await host.done, 1);
assert.ok(logs.includes(line), logs.join("\n"));
assert.ok(children.every(gone), "the broker and the notifier have ended");
assert.equal(existsSync(hostLock(f.dataRoot)), false);
assert.equal(existsSync(hostFile(f.dataRoot)), false);
});
test("a broker reply that misses the wait breaks the channel: the late reply answers nothing, later requests refuse, the host exits 1", { timeout: 30000 }, async (t) => {
const root = tmp(t);
const f = fixture(root);