mosaicstack/stack
25
0
Fork 1
Code Issues 358 Pull Requests 13 Actions Packages Projects Releases 15 Wiki Activity

docs(build-log): row 48 round 1 (dewey) and landing (sage)

Browse Source 
Co-Authored-By: Claude Opus 5.5 <[email protected]>
This commit is contained in:
jason.woltje
2026-10-10 03:55:40 -05:00
co-authored by Claude Opus 5.5
parent f7c2d5cfe3
commit 99d9cff92d
1 changed files with 22 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
BUILD-LOG.md
+22
View File
@@ -3971,3 +3971,25 @@ Round 1 (CHAT-01 cc83ee4f, candidate deac7434): Filbert approved (comment 27087,
The manifest checked 6/6 in the canonical tree. The candidate landed as 0aa5e7b5 through a temporary index, and `queue review verify-commit 52 HEAD` matched all 6 paths. Gate on a detached worktree of c92cfb8f plus the candidate: webui 22/0, conversation 182/0, control-board 124/0, test-auth 15, test-conductor 17, test-config 24, test-discord 66, test-extension-package 18, test-foundation 44, test-queue 27 (29 in the canonical tree), test-release 14, test-task 98, all 0 failed. `node docs/plans/chat-01/check.mjs` PASS: 100 shape, 76 reference, 22 lifecycle. No `mosaic-chat-*` unit, shim or fake pi was left at 08:31:02Z. Darkwing's test-task 26/2 was their gate's missing Docker and model; this one ran the two live checks.
The non-blocking notes go to #1540: Filbert's N2 stale comment above the `---- engine exit` header in `cohort.test.mjs` (a follow-up, not a round 2, since it's a comment inside the frozen manifest), Darkwing's untested guards (`nopopulated`, `nomembers`, and the invocation, scope and boot checks), the E4 deadline and request-timeout overlap, Dewey's K15 and process-group items, Filbert's N3 and N5, and the five unpinned shared `startStop` effects in the model (N1) for the next CHAT-01 amendment. #1539 is unchanged.
### 2026-10-10 — Dewey, row 48 round 1 in review: commit.test close wait and test-task recall Docker skip (#1534)
Before: `pausedCommit` in `packages/queue/tests/commit.test.mjs` awaited the child's `exit`, which can fire before stderr is drained, so the `cannot lock ref 'HEAD'` match could see an empty `childErr`. In `scripts/test-task.sh` the live recall pair ("user recall run succeeds", "recalled user name") ran without a Docker check, so a gate without Docker scored 26/2. That was Darkwing's result on rows 51 and 52.
After: `pausedCommit` waits on `close`. The recall pair runs only when `docker info` succeeds, the same test the three live blocks above it use. Otherwise it prints `skip live recall pair: user recall run, recalled user name (docker daemon unavailable)` and changes neither PASS nor FAIL. The checks are unchanged. Diff +16/-10, two files.
Evidence, with Docker made unreachable through `DOCKER_HOST=unix:///nonexistent/docker.sock`: base 26 passed, 2 failed; candidate 26 passed, 0 failed, with the skip line. With Docker present: candidate 98/0, recall response "Jason". A mutant with the recall run replaced by `false` gives 96 passed, 2 failed, rc 1. To show exit against close, a scratch copy delayed the paused commit's stderr 0.5 s past its exit. `--test-name-pattern="F1: a"` gave 6 pass, 2 fail on `exit` and 8/0 on `close`. Gate on a worktree of 2d935f59 plus the candidate, 08:37:42Z-08:40:41Z: queue node 148/0, test-auth 15, test-conductor 17, test-config 24, test-discord 66, test-extension-package 18, test-foundation 44, test-queue 27, test-release 14, test-task 98, and test-task without Docker 26, all with 0 failed. test-queue skipped verify and render outside the canonical root; both passed in the canonical tree at rev 317.
Follow-ups, out of scope: when the recall run writes no record, the name check reads the newest one (the mutant printed the fork child's `mosaico`); and "no agent identity on headless run" passes vacuously without a `system-prompt.md`.
Records: manifest 285a4ec1 (3 files, `agents/dewey/work/queue-48/`), revs 317-319 (5e87c41f), request comment 27097, notes comment 27098. REQUEST to Darkwing and Filbert. No push.
### 2026-10-10 — Sage, row 48 landed: commit.test close wait and test-task recall Docker skip (#1534)
Round 1 (candidate 285a4ec1, 3 files): Darkwing approved (comment 27099, rev 320) and Filbert approved (comment 27100, rev 321). Both reproduced the stderr race: waiting on `exit` gives 6/2 when git's stderr arrives late, and waiting on `close` gives 8/0. Darkwing ran the Docker-present, run-fails branch with a fake `docker info`, and both recall checks failed with rc 1. Filbert's mutants showed the skip changes neither count, except `skippass`, which only the count would reveal (their N1, not asked for).
The manifest checked 3/3 in the canonical tree. The candidate landed as f7c2d5cf through a temporary index, and `queue review verify-commit 48 HEAD` matched all 3 paths. Gate on a detached worktree of 560373c3 plus the candidate: queue 148/0, webui 22/0, conversation 182/0, control-board 124/0, test-auth 15, test-conductor 17, test-config 24, test-discord 66, test-extension-package 18, test-foundation 44, test-queue 27 (29 in the canonical tree), test-release 14, all 0 failed. test-task ran twice: 98/0 with Docker, the recall pair passing with response "Jason", and 26/0 with `DOCKER_HOST` unreachable, printing `skip live recall pair: ...`. No `mosaic-chat-*` unit, shim or fake pi was left at 08:54:45Z.
Correction to my first landing commit message: it named a07b3784 as the gate base. The worktree was created at 03:50:07 local, before a07b3784 (03:50:10) and after 560373c3 (03:50:00), so the base was 560373c3. I amended the unpushed commit before pushing; a07b3784 adds only Filbert's SESSIONS line.
The recall check's content stayed out of scope. Dewey's two follow-ups (the name check reads the newest run record, and "no agent identity on headless run" passes when `system-prompt.md` is absent) and Darkwing's note 2 (the guards ask `docker info`, but the runs use `docker compose run`) go to #1541.