Commit Graph
5 Commits
Author SHA1 Message Date
marcie befc40ccf4 framework tools/git: P1b — read-only viewers join the R1/R4 contract (pr-diff, pr-view, pr-metadata, pr-list)
usage_error contract (stderr + exit 2), strict option-like value
guards, missing -n checks; pr-list usage() default exit 2. Four suites
enrolled (population 93). Closes the viewer gap from the #1464 census:
carriers now 20 of the 22; remaining non-carriers are the deliberate
design-first class (ci-queue-wait, pr-merge, pr-ci-wait, mosaic-worktree).
2026-08-28 21:29:41 -05:00
marcieandorch-01 7aba12aeed mosaic CLI: embedded brain-tool dispatch layer (watch, q, comms) (#1463)
ci/woodpecker/pr/ci Pipeline was successful
Co-authored-by: marcie <[email protected]>
2026-08-29 02:00:18 +00:00
marcieandorch-01 80a5c4d57a framework tools/git: R1/R4 usage-error contract across 16 wrappers (P1, census-corrected per review 358) (#1464)
Co-authored-by: marcie <[email protected]>
2026-08-29 01:59:41 +00:00
marcie 41f1bc0d37 framework tools/git: enroll issue-comment suites in framework-shell CI
ci/woodpecker/pr/ci Pipeline was successful
Codex review of a27b7dc9 (blocker): check-test-enumeration.sh rejects
unenumerated test files.

- test-issue-comment-usage-contract.sh enrolled in test:framework-shell
  (hermetic by construction: PATH stubs, sandboxed runner, no network).
- test-issue-comment-readback.sh enrolled and its stale exclusion removed.
  The exclusion's own note anticipated this: 'joins CI after the
  wrapper-half hermeticity fix' - that fix (neutralizing seat-exported
  MOSAIC_GIT_IDENTITY / MOSAIC_BRAIN_HOME that escape the sandboxed HOME)
  landed in a27b7dc9. Suite green in brain and worktree trees tonight.

Enumeration guard: OK (population 73, enumerated 60, excluded 14).
2026-08-28 16:59:45 -05:00
marcie a27b7dc9be framework tools/git: sync issue-comment R1/R4 + hermeticity hardening from brain
ci/woodpecker/pr/ci Pipeline failed
Upstream of brain commits 08a00149 + 971586ef + the arm-6 sandbox fix
(brain 5th commit of 2026-08-28 series):

- R1: -b/--body is the canonical comment flag (matches issue-create,
  issue-edit, pr-create, pr-edit); -c/--comment stays a compatible alias.
- R4: usage errors print to stderr and exit 2, distinct from provider,
  credential, and verification failures (exit 1). Value-less flags fail
  loudly (previously -c with no value died silently at rc=1 via set -e on
  the failed shift 2). gh failures on the GitHub path normalize to exit 1
  (gh's own usage errors exit 2 and would collide with the reserved code).
- Tests: new usage-contract suite (help rc, unknown/missing/value-less rc=2
  on stderr, alias parse acceptance under a sandboxed runner, GitHub-path
  exit normalization with a stubbed gh, zero provider contact on parser
  failure); readback suite gains case 11 (full verified write via -b) and
  neutralizes seat-exported MOSAIC_GIT_IDENTITY / MOSAIC_BRAIN_HOME that
  escape the sandboxed HOME (documented HTTP 401 / fail-loud shapes).

Driver: a fleet seat full-stopped on an issue-comment usage error because
usage failures were indistinguishable from provider failures and the stop
gate treated every wrapper failure as blocking.
2026-08-28 16:45:07 -05:00