stack

628 Commits 384 Branches 35 Tags

4 Commits

Author	SHA1	Message	Date
Hermes AgentandClaude Opus 4.8	16481ece3d	fix(tools): attribute read-back to acting identity and paginate fully (#865 ) ci/woodpecker/pr/ci Pipeline was successful Details Round 2 remediation for the read-back verification in issue-comment.sh and pr-review.sh. BLOCKER A (invocation attribution): id-above-boundary + content/state match only proves temporal ordering — a concurrent write from a different identity could satisfy it while this tea invocation created nothing. Both wrappers now resolve the acting identity once via curl GET /api/v1/user and additionally require the accepted record's author login to equal that identity. Residual same-identity same-body/state concurrency is documented in-code (tea 0.11.1 emits no reliable created-record id to close it further). BLOCKER B (pagination): the comments and reviews list reads now walk every page (?limit=&page=1,2,… until a short/empty page) for both the pre-write boundary and the post-write read-back, so a record beyond page 1 is still found. Adds regressions: concurrent different-identity write fails closed (comments and reviews); a matching review beyond page 1 is still found. README updated. Co-Authored-By: Claude Opus 4.8 <[email protected]>	2026-07-21 19:02:25 -05:00
Hermes AgentandClaude Opus 4.8	10fdd49e32	fix(tools): bound Gitea read-back to this write; verify approve/reject state (#865 ) ci/woodpecker/pr/ci Pipeline was successful Details Review remediation for two correctness holes in the #865 fix: BLOCKER 1 — issue-comment.sh read-back was body-only across all history: if `tea comment` silently no-opped (the #865 bug) while an identically bodied comment already existed from a prior run, the read-back matched the OLD comment and falsely reported success. Now record the pre-write maximum comment id as a boundary and require a comment with id > boundary AND exact body match; monotonic Gitea ids make id > boundary mean "created by this write". Fails closed otherwise. BLOCKER 2 — pr-review.sh approve/reject trusted tea's exit code for the review STATE (same never-trust-exit-zero defect class as #865). Removed the TODO deferral and added a real bounded read-back: record the max review id before `tea pr approve`/`reject`, then require a review with id > boundary, the expected state (APPROVED / REQUEST_CHANGES), and commit_id equal to the PR's current head. Fails closed if absent. Tests: extended test-pr-review-gitea-comment.sh to model and assert the new review-state read-back (guardrails preserved, assertions added). Added test-issue-comment-readback.sh proving the pre-existing-identical-body false positive now fails closed and a genuinely new comment verifies. Co-Authored-By: Claude Opus 4.8 <[email protected]>	2026-07-21 18:21:02 -05:00
Hermes AgentandClaude Opus 4.8	a27f1fa7df	fix(tools): use top-level tea comment invocation and formalize --login passthrough (#865 ) ci/woodpecker/pr/ci Pipeline was successful Details issue-comment.sh called the non-existent `tea issue comment` subcommand form; tea 0.11.1 silently no-ops and exits 0 instead of erroring, producing a false-success write. Switch to the top-level `tea comment <index> <body>` form and add fail-closed REST read-back verification so the wrapper no longer trusts tea's exit code alone. pr-review.sh's comment path was already fixed for this bug by #812/#835 (routes through a read-back-verified REST comment API instead of any tea comment subcommand); this change formalizes an explicit --login override flag there too and documents the after-detection last-wins --login ordering, consistent with issue-comment.sh. Co-Authored-By: Claude Opus 4.8 <[email protected]>	2026-07-21 17:50:43 -05:00
Hermes Agent	880c28b191	docs(glpi-skills): genericize operator-specific content per review ci/woodpecker/pr/ci Pipeline was successful Details	2026-07-20 19:45:50 -05:00