launchpad: row 303 (#1810): R9 asserts the rehearsal directory is set before the placeholders check joins it, so a null shows the rehearsal output (mos-1422, Vikunja 589); unrun

agents/launchpad/work/queue-303/BUILD.md

@@ -0,0 +1,26 @@
+# Row 303 build notes (Launchpad): R9 shows its output when rehearse makes no directory (#1810)
+
+Brief: docs/plans/2026-10-23_r9-guard-row.md (Vikunja 589). Reviewer Duckworth, gate owner Sage.
+Base 80793d824 (refactor after row 294 landed at d3059c2c3). Branch launchpad/row303.
+
+## Change
+
+One added line in packages/cli/tests/stack-release.test.mjs, R9 only, at :2178:
+
+    assert.ok(r.dir!==null, r.out+r.err);
+
+It sits right after R9's exit-code check and right before the `includes` check whose message builds
+`join(r.dir,'placeholders')`. rehearse() (:2040) sets `dir` to null when the output has no
+`rehearsal directory:` line, so the guard fails first and its message carries the rehearsal's
+output and stderr, including the FAIL line that stopped it. This is a test-only change to a
+pre-existing test, approved under mos-1272 and mos-1316 (mos-1422 point 2). It adds an assertion
+and changes none. No other line in R9 or any other test changes. The lines the brief names (:2058,
+:2113, :2126, :2267, :2280) put r.dir in a template, where a null prints as `null` and the message
+still carries r.out, so they get no guard.
+
+MANIFEST.sha256 lists the one changed path, hashed from the commit that adds this file.
+
+## Gate
+
+Duckworth approves the diff. stack-release.test.mjs runs whole and green on Sage's gate, in a gap.
+Not run yet.

agents/launchpad/work/queue-303/MANIFEST.sha256

@@ -0,0 +1 @@
+e936808bb12361acf164b675fe40ead416720dfd48c5d51ea5bfee1e1893cc33  packages/cli/tests/stack-release.test.mjs

packages/cli/tests/stack-release.test.mjs

@@ -2175,6 +2175,7 @@ test('R9 mos-0963: a role reference left outside placeholders/, or left on an en
  ownScript(e,'for(const [name,r] of Object.entries(b.roles??{})){strip(r?.vars);swap(name,r?.credentials)}','for(const [name,r] of Object.entries(b.roles??{})){strip(r?.vars);if(name!=="pm")swap(name,r?.credentials)}');
  const r=await rehearse(e,B,'--backup',e.act,'--port',await freePort(),'--timeout','3');
  assert.equal(r.code,1,r.out+r.err);
+ assert.ok(r.dir!==null, r.out+r.err);
  assert.ok(r.out.includes(`FAIL credential-ref-live: pm gitea is ${tok}, not a file in ${join(r.dir,'placeholders')}\n`),r.out);
  assert.deepEqual(r.names.slice(-3),['FAIL credential-ref-live','PASS backup-unchanged','PASS live-config-unchanged']);
  assert.equal(existsSync(rh(e,'host-args.log')),false);assert.equal(existsSync(rh(e,'console-args.log')),false);