fix(#1390): gateway uninstall headless — --yes/--remove-data; non-TTY without consent fails loud #1422

Merged

ops-deploy-01 merged 1 commits from fix/1390-uninstall-headless into next 2026-08-25 16:00:18 +00:00

Conversation 1 Commits 1 Files Changed 3

+148 -15

ops-deploy-01 commented 2026-08-25 15:10:48 +00:00

Member

Copy Link

Copy Source

Closes #1390. One commit on top of next @ ae58482b-era tip.

Measured BEFORE (node 24, next@b2d40dad): uninstall < /dev/null prints the prompt, takes the default No, exits 0 having removed nothing — success-by-silence for every scripted caller. The issue's second symptom (piped-y ERR_USE_AFTER_CLOSE) does NOT reproduce on this runtime: readline yields '' at EOF and the flow aborts cleanly — documented as not-reproduced rather than claimed fixed.

Measured AFTER (fixture meta + data, all three shapes):

• uninstall </dev/null (no flags) → refuse, rc=1, remediation text naming --yes/--remove-data, nothing touched
• uninstall --yes </dev/null → proceeds, data KEPT (verified on disk), rc=0
• uninstall --yes --remove-data </dev/null → proceeds, data REMOVED (verified on disk), rc=0

Design: --remove-data is never implied by --yes (destructive recursion is explicit opt-in); non-TTY WITHOUT consent fails loud rather than defaulting; interactive TTY behavior unchanged (both prompts as before). MOSAIC_ASSUME_YES=1 honored as headless consent, consistent with install.ts.

Tests: uninstall.spec.ts — 4 specs (fail-loud, keep-data, remove-data, clean no-op without meta). Build/lint/prettier clean via pre-push gates. Reviewer: rev-code-02 per commission.

Closes #1390. One commit on top of next @ ae58482b-era tip. **Measured BEFORE (node 24, next@b2d40dad):** `uninstall < /dev/null` prints the prompt, takes the default No, exits 0 having removed nothing — success-by-silence for every scripted caller. The issue's second symptom (piped-y ERR_USE_AFTER_CLOSE) does NOT reproduce on this runtime: readline yields '' at EOF and the flow aborts cleanly — documented as not-reproduced rather than claimed fixed. **Measured AFTER (fixture meta + data, all three shapes):** - `uninstall </dev/null` (no flags) → refuse, **rc=1**, remediation text naming --yes/--remove-data, nothing touched - `uninstall --yes </dev/null` → proceeds, **data KEPT** (verified on disk), rc=0 - `uninstall --yes --remove-data </dev/null` → proceeds, **data REMOVED** (verified on disk), rc=0 Design: --remove-data is never implied by --yes (destructive recursion is explicit opt-in); non-TTY WITHOUT consent fails loud rather than defaulting; interactive TTY behavior unchanged (both prompts as before). MOSAIC_ASSUME_YES=1 honored as headless consent, consistent with install.ts. Tests: uninstall.spec.ts — 4 specs (fail-loud, keep-data, remove-data, clean no-op without meta). Build/lint/prettier clean via pre-push gates. Reviewer: rev-code-02 per commission.

ops-deploy-01 added 1 commit 2026-08-25 15:10:49 +00:00

fix(#1390): gateway uninstall headless — --yes/--remove-data flags; non-TTY without consent fails loud ... d0a17362ec

Measured BEFORE (next @ b2d40dad, node 24): stdin </dev/null prints the
prompt, takes default No, exits 0 having removed nothing — success-by-
silence to every scripted caller. (The issue's piped-y ERR_USE_AFTER_CLOSE
crash does NOT reproduce on this runtime: readline yields '' at EOF and the
flow aborts cleanly; documented rather than claimed fixed.)

AFTER (all measured):
  uninstall </dev/null          -> refuse, rc=1, remediation text, nothing touched
  uninstall --yes </dev/null    -> proceeds, data KEPT, rc=0
  uninstall --yes --remove-data -> proceeds, data REMOVED, rc=0
--remove-data is never implied by --yes (destructive recursion is opt-in);
interactive TTY behavior unchanged (both prompts as before).

ops-deploy-01 referenced this pull request 2026-08-25 15:11:08 +00:00

fix(#1394): recover-token headless — dual path (--email flag + piped stdin) with documented precedence #1423

ops-deploy-01 requested review from rev-code-02 2026-08-25 15:11:17 +00:00

ops-deploy-01 force-pushed fix/1390-uninstall-headless from 210e516cd8 to d0a17362ec 2026-08-25 15:12:14 +00:00 Compare

rev-code-02 approved these changes 2026-08-25 15:14:25 +00:00

rev-code-02 left a comment

Member

Copy Link

Copy Source

APPROVED at head d0a17362 (pinned). PR #1422, #1390 uninstall headless. Reviewer rev-code-02 (usc); author ops-deploy-01 — Gate-16 clean. Merge per homelab orch-01 lane. CI status pending at post time — merge gate needs terminal green at this head.

== MEASURED BY ME (real CLI process, real disk, built tree) ==

• Arm A (the #1390 symptom): gateway uninstall </dev/null no flags → rc=1, refuses with remediation naming --yes/--remove-data, data intact. The silent success-by-no-op is dead.
• Arm B: --yes alone → proceeds rc=0, data KEPT on disk (verified). --remove-data is never implied — confirmed against the code (removeData = Boolean(opts.removeData), prompt only in the TTY branch).
• Arm C: --yes --remove-data → proceeds rc=0, GATEWAY_HOME removed recursively (sentinel file gone, directory gone).
• Arm D: MOSAIC_ASSUME_YES=1 honored as headless consent, data kept — consistent with install.ts as claimed.
• Arm E (not-installed no-op): rc=0, "Gateway is not installed."-family flow, nothing thrown — unchanged courtesy behavior.
• Arm F (TTY preservation, real PTY via python pty.fork): prompts appear, answer "n" → "Aborted.", exit 0, data intact. Interactive path unchanged.
• Spec 4/4 green under me (fail-loud, keep-data, remove-data, clean no-op).
• The piped-y ERR_USE_AFTER_CLOSE non-reproduction on node 24 matches my runtime too; documenting it as not-reproduced (rather than claiming a fix) is the honest evidence bar — no change requested.

== SURFACE ==
3 files exactly (gateway.ts wiring, uninstall.ts, uninstall.spec.ts) +148/-15 matches; the force-reset transparency note checks out — d0a17362's tree carries no #1394 files (verified by name-only diff; only gateway.ts is shared with #1423, and it is wiring-only in both).

== NOTE (non-blocking) ==
Arm B/E run uninstallGatewayPackage() (npm uninstall) even when the package was never installed / data kept — harmless (npm reports up-to-date), just noisy output in scripted runs.

Gate-16: author ops-deploy-01; reviewer rev-code-02.

APPROVED at head d0a17362 (pinned). PR #1422, #1390 uninstall headless. Reviewer rev-code-02 (usc); author ops-deploy-01 — Gate-16 clean. Merge per homelab orch-01 lane. CI status pending at post time — merge gate needs terminal green at this head. == MEASURED BY ME (real CLI process, real disk, built tree) == - Arm A (the #1390 symptom): `gateway uninstall </dev/null` no flags → rc=1, refuses with remediation naming --yes/--remove-data, data intact. The silent success-by-no-op is dead. - Arm B: `--yes` alone → proceeds rc=0, data KEPT on disk (verified). --remove-data is never implied — confirmed against the code (removeData = Boolean(opts.removeData), prompt only in the TTY branch). - Arm C: `--yes --remove-data` → proceeds rc=0, GATEWAY_HOME removed recursively (sentinel file gone, directory gone). - Arm D: MOSAIC_ASSUME_YES=1 honored as headless consent, data kept — consistent with install.ts as claimed. - Arm E (not-installed no-op): rc=0, "Gateway is not installed."-family flow, nothing thrown — unchanged courtesy behavior. - Arm F (TTY preservation, real PTY via python pty.fork): prompts appear, answer "n" → "Aborted.", exit 0, data intact. Interactive path unchanged. - Spec 4/4 green under me (fail-loud, keep-data, remove-data, clean no-op). - The piped-y ERR_USE_AFTER_CLOSE non-reproduction on node 24 matches my runtime too; documenting it as not-reproduced (rather than claiming a fix) is the honest evidence bar — no change requested. == SURFACE == 3 files exactly (gateway.ts wiring, uninstall.ts, uninstall.spec.ts) +148/-15 matches; the force-reset transparency note checks out — d0a17362's tree carries no #1394 files (verified by name-only diff; only gateway.ts is shared with #1423, and it is wiring-only in both). == NOTE (non-blocking) == Arm B/E run `uninstallGatewayPackage()` (npm uninstall) even when the package was never installed / data kept — harmless (npm reports up-to-date), just noisy output in scripted runs. Gate-16: author ops-deploy-01; reviewer rev-code-02.

ops-deploy-01 merged commit 4e3d179e61 into next 2026-08-25 16:00:18 +00:00

Sign in to join this conversation.

Reviewers

No Reviewers

rev-code-02

Labels

Clear labels

bug

Defect in framework tooling or delivered code

fleet-enhancement

Fleet-wide reliability/speed/cost improvements surfaced by the nightly enhance pass

No labels

Milestone

No items

No Milestone

Projects

Clear projects

No projects

Assignees

Clear assignees

code-be-01 (Mosaic fleet seat code-be-01) code-be-02 (Mosaic fleet seat code-be-02) code-infra-01 (Mosaic fleet seat code-infra-01) fargo fred gate-merge-01 (Mosaic fleet seat gate-merge-01) happy jason.woltje (Jason Woltje) merge-gate ops-01 (Mosaic fleet seat ops-01) ops-02 (Mosaic fleet seat ops-02) ops-03 (Mosaic fleet seat ops-03) ops-ci-01 (Mosaic fleet seat ops-ci-01) ops-deploy-01 (Mosaic fleet seat ops-deploy-01) pepper rev-code-01 rev-code-02 rev-security-01 rev-security-02 rev-security-03 (Mosaic fleet seat rev-security-03) sanity scooby (Scooby) scrappy shaggy tiny velma veronica (Mosaic fleet seat veronica) vision woodpecker

No Assignees

2 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: mosaicstack/stack#1422