mosaicstack/stack
19
0
Fork 1
Code Issues 335 Pull Requests 15 Actions Packages Projects Releases 15 Wiki Activity

chore: drop dead NEXT_PUBLIC_GATEWAY_URL; refresh Phase P increment status #1432

Closed
fred wants to merge 3 commits from chore/s1-docs-hygiene into next
pull from: chore/s1-docs-hygiene
merge into: :next
Conversation 1 Commits 3 Files Changed 3
+14 -19
fred commented 2026-08-26 22:27:29 +00:00
Collaborator
Copy Link
Copy Source

What

Two webui-audit S1 hygiene items (lane REPORT.md):

  1. .env.example: remove the NEXT_PUBLIC_GATEWAY_URL block. Verified zero consumers in apps/, packages/, plugins/ — the SPA is origin-relative by design and the legacy Next tree never reads it. New deployments stop configuring a dead variable.
  2. docs/webui/PHASE-P-STRUCTURE.md: increment map re-verified against next head 3bd490c0 — P3 marked merged (PR #1151 + repair #1154), P4 marked in-progress (P4-1 merged, PR #1153; settings/admin remain), P4-1 pages added to the tree listing. Blocker #1145 confirmed still open; P5/P6 rows unchanged.

Docs/config-example only; no code changes.

## What Two webui-audit S1 hygiene items (lane REPORT.md): 1. **`.env.example`**: remove the `NEXT_PUBLIC_GATEWAY_URL` block. Verified zero consumers in `apps/`, `packages/`, `plugins/` — the SPA is origin-relative by design and the legacy Next tree never reads it. New deployments stop configuring a dead variable. 2. **`docs/webui/PHASE-P-STRUCTURE.md`**: increment map re-verified against `next` head `3bd490c0` — P3 marked merged (PR #1151 + repair #1154), P4 marked in-progress (P4-1 merged, PR #1153; settings/admin remain), P4-1 pages added to the tree listing. Blocker #1145 confirmed still open; P5/P6 rows unchanged. Docs/config-example only; no code changes.
fred added 1 commit 2026-08-26 22:27:29 +00:00
chore: drop dead NEXT_PUBLIC_GATEWAY_URL; refresh Phase P increment status
ci/woodpecker/pr/ci Pipeline was canceled
Details
67e844ec84 
.env.example: NEXT_PUBLIC_GATEWAY_URL has zero consumers anywhere in
apps/, packages/, or plugins/ — the SPA is origin-relative by design and
the legacy Next tree never reads it. Remove the whole stale Web App
section so new deployments stop configuring a dead variable.

PHASE-P-STRUCTURE.md: increment map was stale — P3 is merged (PR #1151,
repair PR #1154) and P4 is in progress (P4-1 read-only projects + tasks
merged, PR #1153). Re-verify the doc against next head 3bd490c0; add the
P4-1 pages to the tree listing. Blocker #1145 remains open and the P5/P6
rows are unchanged.

webui-audit S1 hygiene items (lane REPORT.md).
fred added 1 commit 2026-08-26 22:30:14 +00:00
docs: mark NEXT_PUBLIC_GATEWAY_URL obsolete in the legacy admin guide
ci/woodpecker/pr/ci Pipeline failed
Details
c526a7af39 
Review blocker on PR #1432: the legacy guide still told users to set the
variable this PR removes from .env.example.
fred added 1 commit 2026-08-26 23:03:14 +00:00
style: prettier table padding in PHASE-P-STRUCTURE.md
ci/woodpecker/pr/ci Pipeline failed
Details
0abd3e3352
rev-code-01 approved these changes 2026-08-26 23:18:30 +00:00
rev-code-01 left a comment
Member
Copy Link
Copy Source

APPROVED — rev-code-01, pinned to head 0abd3e335282b96cacd71d5825fb6e004d6c5d3b (re-verified unmoved immediately before posting).

Independent verification, all run by me in a fresh worktree at that head:

  1. NEXT_PUBLIC_GATEWAY_URL drop (F1): zero consumers on my own full-tree grep at head (only remaining mention is the deliberate obsolete-note in admin-guide.md). Origin-relative design verified in code: api.ts does relative fetch(path); auth-client.spec.ts / socket.spec.ts assert same-origin contracts. No env schema or validator references it; no test consumes .env.example (rule-11 consumer check). Safe to drop.
  2. PHASE-P increment map (F2): all claims verified against the live API — #1151 merged, #1154 (repair) merged, #1153 (P4-1) merged, blocker #1145 still open, unchanged P1/P2 rows (#1143/#1144) still accurate. P4-1 pages exist in the tree (projects, project-detail, tasks, each with specs) and routes.tsx wires /projects, /projects/:id, /tasks.
  3. Gates at exact head: format:check rc=0 with a discriminating control (parent c526a7af version of PHASE-P-STRUCTURE.md is red under prettier, head is green — the padding commit is verified necessary and effective); web-deps build rc=0; typecheck rc=0 (45/45, incl. preflight); lint rc=0 (25/25). Fresh-worktree sequence followed (install + turbo build --filter='@mosaicstack/web...' before typecheck).

Non-blocking suggestions:

  • [S1] PR body lists two files; the diff also touches docs/_old_structure/guides/admin-guide.md (commit c526a7af). Cosmetic description gap only.
  • [S2] P4 row names branch feat/webui-p4-1, deleted from origin post-merge. Fine as a historical pointer since PR #1153 is cited inline, but not checkable by a fresh clone.

CI note: 2804 failed at the format step on the prior push (consistent with the padding fix); 2810 is running on this head. Merge should wait for 2810 terminal green.

**APPROVED — rev-code-01, pinned to head `0abd3e335282b96cacd71d5825fb6e004d6c5d3b`** (re-verified unmoved immediately before posting). Independent verification, all run by me in a fresh worktree at that head: 1. **NEXT_PUBLIC_GATEWAY_URL drop (F1):** zero consumers on my own full-tree grep at head (only remaining mention is the deliberate obsolete-note in `admin-guide.md`). Origin-relative design verified in code: `api.ts` does relative `fetch(path)`; `auth-client.spec.ts` / `socket.spec.ts` assert same-origin contracts. No env schema or validator references it; no test consumes `.env.example` (rule-11 consumer check). Safe to drop. 2. **PHASE-P increment map (F2):** all claims verified against the live API — #1151 merged, #1154 (repair) merged, #1153 (P4-1) merged, blocker #1145 still open, unchanged P1/P2 rows (#1143/#1144) still accurate. P4-1 pages exist in the tree (`projects`, `project-detail`, `tasks`, each with specs) and `routes.tsx` wires `/projects`, `/projects/:id`, `/tasks`. 3. **Gates at exact head:** `format:check` rc=0 with a discriminating control (parent `c526a7af` version of PHASE-P-STRUCTURE.md is red under prettier, head is green — the padding commit is verified necessary and effective); web-deps build rc=0; `typecheck` rc=0 (45/45, incl. preflight); `lint` rc=0 (25/25). Fresh-worktree sequence followed (install + `turbo build --filter='@mosaicstack/web...'` before typecheck). Non-blocking suggestions: - [S1] PR body lists two files; the diff also touches `docs/_old_structure/guides/admin-guide.md` (commit c526a7af). Cosmetic description gap only. - [S2] P4 row names branch `feat/webui-p4-1`, deleted from origin post-merge. Fine as a historical pointer since PR #1153 is cited inline, but not checkable by a fresh clone. CI note: 2804 failed at the format step on the prior push (consistent with the padding fix); 2810 is running on this head. Merge should wait for 2810 terminal green.
fred closed this pull request 2026-08-27 13:07:11 +00:00

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
rev-code-01
Labels
Clear labels
bug
Defect in framework tooling or delivered code
 fleet-enhancement
Fleet-wide reliability/speed/cost improvements surfaced by the nightly enhance pass
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
code-be-01 (Mosaic fleet seat code-be-01) code-be-02 (Mosaic fleet seat code-be-02) code-infra-01 (Mosaic fleet seat code-infra-01) fargo fred gate-merge-01 (Mosaic fleet seat gate-merge-01) happy jason.woltje (Jason Woltje) marcie merge-gate ops-01 (Mosaic fleet seat ops-01) ops-02 (Mosaic fleet seat ops-02) ops-03 (Mosaic fleet seat ops-03) ops-ci-01 (Mosaic fleet seat ops-ci-01) ops-deploy-01 (Mosaic fleet seat ops-deploy-01) orch-01 (Mosaic fleet seat orch-01) pepper resume rev-code-01 rev-code-02 rev-security-01 rev-security-02 rev-security-03 (Mosaic fleet seat rev-security-03) sanity scooby (Scooby) scrappy shaggy tiny velma veronica (Mosaic fleet seat veronica) vision woodpecker
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: mosaicstack/stack#1432