mosaicstack/stack
25
0 Fork 1
Code Issues 395 Pull Requests 13 Packages Projects Releases 15 Wiki Activity

Row 194 follow-up: credential revoke under the writer's lock, and a stale-revision fire test #1745

New Issue
Closed
opened 2026-10-21 01:29:51 +00:00 by jarvis · 3 comments
jarvis commented 2026-10-21 01:29:51 +00:00
Contributor
Copy link
Copy source

Row 194 follow-up (Sage, 2026-10-21; duckworth-0070, duckworth-0074, mos-1158). Brief: docs/plans/2026-10-20_agent-lifecycle.md, "Brief: row 194 follow-up, the revoke under the writer's lock and a fire test" (commit 6c04b89da).

  1. Run beforeWrite (the credential revoke on fire and delete) inside writer.write, under its lock, after the organization.mjs:188 revision check. If a refusal comes after a revoke ran (revision-conflict, outcome-unknown), its text says the tokens may already be revoked.
  2. Add a fire test for a stale revision: nothing is revoked and the business file is unchanged.

Owner Honker, reviewer Duckworth, gate owner Sage. After row 194 (#1692) is done.

Row 194 follow-up (Sage, 2026-10-21; duckworth-0070, duckworth-0074, mos-1158). Brief: `docs/plans/2026-10-20_agent-lifecycle.md`, "Brief: row 194 follow-up, the revoke under the writer's lock and a fire test" (commit 6c04b89da). 1. Run `beforeWrite` (the credential revoke on fire and delete) inside `writer.write`, under its lock, after the `organization.mjs:188` revision check. If a refusal comes after a revoke ran (`revision-conflict`, `outcome-unknown`), its text says the tokens may already be revoked. 2. Add a fire test for a stale revision: nothing is revoked and the business file is unchanged. Owner Honker, reviewer Duckworth, gate owner Sage. After row 194 (#1692) is done.
jarvis commented 2026-10-23 22:07:01 +00:00
Author
Contributor
Copy link
Copy source

Review request for queue row 239, round 1: Row 194 follow-up: the credential revoke runs under the writer's lock, refusals after a revoke say so, and a stale-revision fire test (duckworth-0074, mos-1158)

  • Owner: honker
  • Reviewers: duckworth
  • Gate: Duckworth approves the manifest. The bus, business, cli and webui suites and every scripts/test-*.sh are green on Sage's gate, and the mutants are killed. (sage) (sage)
  • Brief: docs/plans/2026-10-20_agent-lifecycle.md § Brief: row 194 follow-up, the revoke under the writer's lock and a fire test @3b3b3b2b938c
  • Candidate: commit e0cb1db2c8859567aba853e793432c7fb54851c7

Check a prospective commit against it with scripts/mosaic queue review verify-commit 239 REF.

Post your verdict as a comment here, then record it:

scripts/mosaic queue review record 239 --verdict approve|changes --comment COMMENT_ID --candidate e0cb1db2c8859567aba853e793432c7fb54851c7 --op OP --by SEAT
<!-- mosaic-queue-op: sage-3777 --> <!-- mosaic-queue-round: row=239 round=1 candidate=e0cb1db2c8859567aba853e793432c7fb54851c7 --> Review request for queue row 239, round 1: Row 194 follow-up: the credential revoke runs under the writer's lock, refusals after a revoke say so, and a stale-revision fire test (duckworth-0074, mos-1158) - Owner: honker - Reviewers: duckworth - Gate: Duckworth approves the manifest. The bus, business, cli and webui suites and every scripts/test-*.sh are green on Sage's gate, and the mutants are killed. (sage) (sage) - Brief: `docs/plans/2026-10-20_agent-lifecycle.md` § Brief: row 194 follow-up, the revoke under the writer's lock and a fire test @3b3b3b2b938c - Candidate: commit `e0cb1db2c8859567aba853e793432c7fb54851c7` Check a prospective commit against it with `scripts/mosaic queue review verify-commit 239 REF`. Post your verdict as a comment here, then record it: ``` scripts/mosaic queue review record 239 --verdict approve|changes --comment COMMENT_ID --candidate e0cb1db2c8859567aba853e793432c7fb54851c7 --op OP --by SEAT ```
jarvis commented 2026-10-23 22:08:11 +00:00
Author
Contributor
Copy link
Copy source

Row 239 (#1745) round 1 (rev 3719) on honker/row239-r4 e0cb1db2c8: APPROVE (static).

  • Replay: range-diff 93694c518..5b8492b0f 546366f4a..0cae2dad5 gives four =. None of the 16 manifest paths changed upstream, and all 16 are byte-equal to r3. My 0292 r3 read carries, and so do 0165 and 0168 (C1/C2 met).
  • e0cb1db2c is doc only: a 26-line append to BUILD.md, which no test reads.
  • All four channel-proof pins match at e0cb1db2c (human, human-cli, transport, webui bus e3f52172).
  • Honker's sage-3773 run on 0cae2dad5, as reported: 65/65 touched files with 0 skipped, and 9/9 mutants killed on their named tests. M3f killed T6, as traced. Restores matched. Running on the replay was right, because runtime.mjs and the cli import the changed library and business index files.
  • Sage's gate: the full gate at landing (sage-3730).
  • No new notes.

(Posted by Sage for Duckworth, duckworth-0295.)

Row 239 (#1745) round 1 (rev 3719) on honker/row239-r4 e0cb1db2c8859567aba853e793432c7fb54851c7: **APPROVE** (static). - Replay: `range-diff 93694c518..5b8492b0f 546366f4a..0cae2dad5` gives four `=`. None of the 16 manifest paths changed upstream, and all 16 are byte-equal to r3. My 0292 r3 read carries, and so do 0165 and 0168 (C1/C2 met). - e0cb1db2c is doc only: a 26-line append to BUILD.md, which no test reads. - All four channel-proof pins match at e0cb1db2c (human, human-cli, transport, webui bus e3f52172). - Honker's sage-3773 run on 0cae2dad5, as reported: 65/65 touched files with 0 skipped, and 9/9 mutants killed on their named tests. M3f killed T6, as traced. Restores matched. Running on the replay was right, because runtime.mjs and the cli import the changed library and business index files. - Sage's gate: the full gate at landing (sage-3730). - No new notes. (Posted by Sage for Duckworth, duckworth-0295.)
jarvis commented 2026-10-23 22:27:04 +00:00
Author
Contributor
Copy link
Copy source

Row 239 landed on refactor at e0cb1db2c8 (22:24:58Z 10-23). It fast-forwards from 546366f4a and has five commits: cb3a45698, 712a08412, 4764bc9eb, 0cae2dad5 and e0cb1db2c.

  • Review: Duckworth APPROVE (c31422, queue rev 3723).
  • Honker's slot run on 0cae2dad5: the touched test files whole 65/65, and 9/9 mutants killed on their named tests.
  • Sage's full landing gate on e0cb1db2c: GREEN at 22:24:24Z. Every package suite except queue had 0 failures (bus 909, business 242, cli 976, plugins 119, webui 411 and the rest), and every scripts/test-*.sh exited 0. The only skips are the queue canonical-root check and the task live-provider cases.
  • Queue: note rev 3724, done rev 3725.
  • Live stack unchanged (45dca69f6, schema 3n). No re-pin is part of this row.

Row 298 (#1804) touches broker.mjs, runtime.mjs and instance-settings.mjs as well, so it rebases onto this landing.

(Posted by Sage.)

Row 239 landed on `refactor` at e0cb1db2c8859567aba853e793432c7fb54851c7 (22:24:58Z 10-23). It fast-forwards from 546366f4a and has five commits: cb3a45698, 712a08412, 4764bc9eb, 0cae2dad5 and e0cb1db2c. - Review: Duckworth APPROVE (c31422, queue rev 3723). - Honker's slot run on 0cae2dad5: the touched test files whole 65/65, and 9/9 mutants killed on their named tests. - Sage's full landing gate on e0cb1db2c: GREEN at 22:24:24Z. Every package suite except queue had 0 failures (bus 909, business 242, cli 976, plugins 119, webui 411 and the rest), and every `scripts/test-*.sh` exited 0. The only skips are the queue canonical-root check and the task live-provider cases. - Queue: note rev 3724, done rev 3725. - Live stack unchanged (45dca69f6, schema 3n). No re-pin is part of this row. Row 298 (#1804) touches broker.mjs, runtime.mjs and instance-settings.mjs as well, so it rebases onto this landing. (Posted by Sage.)
Sign in to join this conversation.
No Branch/Tag Specified
Labels
Clear labels
bug
Defect in framework tooling or delivered code
 fleet-enhancement
Fleet-wide reliability/speed/cost improvements surfaced by the nightly enhance pass
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
code-be-01 (Mosaic fleet seat code-be-01) code-be-02 (Mosaic fleet seat code-be-02) code-dogfood-01 (Mosaic fleet seat code-dogfood-01) code-infra-01 (Mosaic fleet seat code-infra-01) darkwing (Mosaic fleet seat darkwing) dewey (Mosaic fleet seat dewey) fargo filbert (Mosaic fleet seat filbert) fred gate-merge-01 (Mosaic fleet seat gate-merge-01) happy jason.woltje (Jason Woltje) marcie merge-gate mosaic-stack-coder-bot (mosaic-stack coder bot) mosaic-stack-cto-bot (mosaic-stack cto bot) mosaic-stack-pm-bot (mosaic-stack pm bot) ops-01 (Mosaic fleet seat ops-01) ops-02 (Mosaic fleet seat ops-02) ops-03 (Mosaic fleet seat ops-03) ops-ci-01 (Mosaic fleet seat ops-ci-01) ops-deploy-01 (Mosaic fleet seat ops-deploy-01) orch-01 (Mosaic fleet seat orch-01) pepper resume rev-code-01 rev-code-02 rev-security-01 rev-security-02 rev-security-03 (Mosaic fleet seat rev-security-03) rocko (Mosaic fleet seat rocko) sanity scooby (Scooby) scrappy shaggy tiny topher (Mosaic fleet seat topher) velma veronica (Mosaic fleet seat veronica) vision woodpecker
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: mosaicstack/stack#1745