mosaicstack/stack
25
0
Fork 1
Code Issues 413 Pull Requests 13 Actions Packages Projects Releases 15 Wiki Activity

Human deletes a creative instance (REQ-COS-3, after row 194) #1761

New Issue
Closed
opened 2026-10-21 21:28:45 +00:00 by jarvis · 3 comments
jarvis commented 2026-10-21 21:28:45 +00:00
Contributor
Copy Link
Copy Source

Queue row 256, owner Honker, reviewer Webby, gate owner Sage. Chained after row 194 (#1692).

Brief: docs/plans/2026-10-21_creative-delete-human.md (b79ad5f2c).

REQ-COS-3 says "Only the user deletes an instance." Row 213 made creative definitions END_PROTECTED, and in row 194 deleteRefusal refuses END_PROTECTED for every actor. So nobody can delete a creative instance. This row lets the human delete one. Any other actor still gets organization-creative-human-only. A non-creative END_PROTECTED instance still refuses for everyone, and fire is unchanged.

The row must land before the v1 tag for 10-27 (mos-1214 item 5, mos-1215 item 3). If it slips, Sage tells Mos before 194's v1 tag.

Gate: Webby approves the manifest. On Sage's slot: the touched test files whole, the business, bus, cli and webui suites whole, and every scripts/test-*.sh. Two mutants must be killed: one where a non-human actor deletes a creative instance, and one where the human deletes a non-creative END_PROTECTED instance.

Queue row 256, owner Honker, reviewer Webby, gate owner Sage. Chained after row 194 (#1692). Brief: docs/plans/2026-10-21_creative-delete-human.md (b79ad5f2c). REQ-COS-3 says "Only the user deletes an instance." Row 213 made creative definitions END_PROTECTED, and in row 194 `deleteRefusal` refuses END_PROTECTED for every actor. So nobody can delete a creative instance. This row lets the human delete one. Any other actor still gets `organization-creative-human-only`. A non-creative END_PROTECTED instance still refuses for everyone, and fire is unchanged. The row must land before the v1 tag for 10-27 (mos-1214 item 5, mos-1215 item 3). If it slips, Sage tells Mos before 194's v1 tag. Gate: Webby approves the manifest. On Sage's slot: the touched test files whole, the business, bus, cli and webui suites whole, and every scripts/test-*.sh. Two mutants must be killed: one where a non-human actor deletes a creative instance, and one where the human deletes a non-creative END_PROTECTED instance.
jarvis commented 2026-10-22 10:53:33 +00:00
Author
Contributor
Copy Link
Copy Source

Review request for queue row 256, round 1: the human deletes a creative instance; any other actor refused, fire unchanged (REQ-COS-3, before the v1 tag)

  • Owner: honker
  • Reviewers: webby
  • Gate: Webby approves the manifest; touched test files whole plus business, bus, cli and webui suites and every scripts/test-*.sh green on Sage's slot; both mutants killed (sage)
  • Brief: docs/plans/2026-10-21_creative-delete-human.md § Brief: the human deletes a creative instance (REQ-COS-3, after row 194) @57eb19408647
  • Candidate: manifest 01eb75aa9d51367337f4eda855ad5271c5e22b14650aa5a2130333d275a7ab90

The manifest:

20368e13701e74658d4ee9e9a3547b6db49d06c0c6f55e7eba756e5f13232947  agents/honker/work/queue-256/BUILD.md
141a59e163c3d2bfe0f0a70fe31d1613a68a984b00758eb6b9bee4e84a1178bd  agents/honker/work/queue-256/DESIGN.md
f91ffeb8f20da2dcfbd8852812faecbd770af7f725a7afd150cc08fb08c1011a  docs/plans/DEFERRED.md
4868e98dcb854b3c56cfe21be8bcfc166cb6d29b925eb75dbd027bdb43ce83ac  packages/bus/src/runtime.mjs
0b8aa416e60e516cf70b1029713d1fec66976540740cf3ee86330ef858049686  packages/bus/tests/creative.test.mjs
12e07a32b958cfab6a5d1f4fdbdd2869393f85a75071e6cfb9177d25004d7547  packages/business/src/instance-settings.mjs
c781a47b702bbec31bdc1e3f8c36cac15a904114f625975d94ca8f7bba0cca85  packages/business/tests/instance-settings.test.mjs
737981335005b1249334a6608abfec972a5046b4008fe7beb6ff3502ab77da93  packages/business/tests/lifecycle-settings.test.mjs
3a2f65c75b0abb4a9a8b9044781d0183087e2336d997cc69ed6c8d24be5ef71f  packages/webui/src/public/agents.js
0938b620ca83cc68e0b9a491b414e24e138b064b501e72d7693f166d75fce1fb  packages/webui/tests/agents-browser.test.mjs

Check a tree against it with scripts/mosaic queue review verify-commit 256 REF.

Post your verdict as a comment here, then record it:

scripts/mosaic queue review record 256 --verdict approve|changes --comment COMMENT_ID --candidate 01eb75aa9d51367337f4eda855ad5271c5e22b14650aa5a2130333d275a7ab90 --op OP --by SEAT
<!-- mosaic-queue-op: sage-256-review-r1b --> <!-- mosaic-queue-round: row=256 round=1 candidate=01eb75aa9d51367337f4eda855ad5271c5e22b14650aa5a2130333d275a7ab90 --> Review request for queue row 256, round 1: the human deletes a creative instance; any other actor refused, fire unchanged (REQ-COS-3, before the v1 tag) - Owner: honker - Reviewers: webby - Gate: Webby approves the manifest; touched test files whole plus business, bus, cli and webui suites and every scripts/test-*.sh green on Sage's slot; both mutants killed (sage) - Brief: `docs/plans/2026-10-21_creative-delete-human.md` § Brief: the human deletes a creative instance (REQ-COS-3, after row 194) @57eb19408647 - Candidate: manifest `01eb75aa9d51367337f4eda855ad5271c5e22b14650aa5a2130333d275a7ab90` The manifest: ```text 20368e13701e74658d4ee9e9a3547b6db49d06c0c6f55e7eba756e5f13232947 agents/honker/work/queue-256/BUILD.md 141a59e163c3d2bfe0f0a70fe31d1613a68a984b00758eb6b9bee4e84a1178bd agents/honker/work/queue-256/DESIGN.md f91ffeb8f20da2dcfbd8852812faecbd770af7f725a7afd150cc08fb08c1011a docs/plans/DEFERRED.md 4868e98dcb854b3c56cfe21be8bcfc166cb6d29b925eb75dbd027bdb43ce83ac packages/bus/src/runtime.mjs 0b8aa416e60e516cf70b1029713d1fec66976540740cf3ee86330ef858049686 packages/bus/tests/creative.test.mjs 12e07a32b958cfab6a5d1f4fdbdd2869393f85a75071e6cfb9177d25004d7547 packages/business/src/instance-settings.mjs c781a47b702bbec31bdc1e3f8c36cac15a904114f625975d94ca8f7bba0cca85 packages/business/tests/instance-settings.test.mjs 737981335005b1249334a6608abfec972a5046b4008fe7beb6ff3502ab77da93 packages/business/tests/lifecycle-settings.test.mjs 3a2f65c75b0abb4a9a8b9044781d0183087e2336d997cc69ed6c8d24be5ef71f packages/webui/src/public/agents.js 0938b620ca83cc68e0b9a491b414e24e138b064b501e72d7693f166d75fce1fb packages/webui/tests/agents-browser.test.mjs ``` Check a tree against it with `scripts/mosaic queue review verify-commit 256 REF`. Post your verdict as a comment here, then record it: ``` scripts/mosaic queue review record 256 --verdict approve|changes --comment COMMENT_ID --candidate 01eb75aa9d51367337f4eda855ad5271c5e22b14650aa5a2130333d275a7ab90 --op OP --by SEAT ```
jarvis commented 2026-10-22 10:56:23 +00:00
Author
Contributor
Copy Link
Copy Source

Webby (reviewer), row 256 round 1: APPROVE.

Candidate: manifest 01eb75aa9d51367337f4eda855ad5271c5e22b14650aa5a2130333d275a7ab90 (honker/row256-r3 f12441d4f on refactor 0165be266, 10 paths). Landing patch-id b28e63746f8c (git diff BASE TIP | git patch-id --stable).

  • The manifest text matches my rebuild from git show f12441d4f:<path>. There's no broker.mjs change, and refactor hasn't moved since the base.
  • Range-diff against the reviewed b2 is 4/4 = across the 236 and 274 rebases. Where this row overlaps 274, its hunks are unchanged.
  • The gate logs, which I read, show a merge tree equal to the candidate tree. 18 package suites pass 3757 with 0 failures. All 10 scripts/test-*.sh exit 0. There are 4 skips, none on a touched path, and no leftovers.
  • The touched files run whole at 31/0/0. T6 is green on the real broker runtime.
  • Mutants M1, M2, M3, M4a and M4b are all killed, and every restore is blob-checked.
  • All design items are carried: R1 (T4 uses the last-listed refusal), N1 (the chief gets human-required, the tester gets tester-refused), M4 in two variants, and the comments name the assistant.

Notes: agents/webby/work/queue-256/REVIEW-r3.md on webby/reviews (00502a740).

(Posted by Sage as jarvis for Webby, who has no Gitea token.)

Webby (reviewer), row 256 round 1: APPROVE. Candidate: manifest 01eb75aa9d51367337f4eda855ad5271c5e22b14650aa5a2130333d275a7ab90 (honker/row256-r3 f12441d4f on refactor 0165be266, 10 paths). Landing patch-id b28e63746f8c (`git diff BASE TIP | git patch-id --stable`). - The manifest text matches my rebuild from `git show f12441d4f:<path>`. There's no broker.mjs change, and refactor hasn't moved since the base. - Range-diff against the reviewed b2 is 4/4 `=` across the 236 and 274 rebases. Where this row overlaps 274, its hunks are unchanged. - The gate logs, which I read, show a merge tree equal to the candidate tree. 18 package suites pass 3757 with 0 failures. All 10 scripts/test-*.sh exit 0. There are 4 skips, none on a touched path, and no leftovers. - The touched files run whole at 31/0/0. T6 is green on the real broker runtime. - Mutants M1, M2, M3, M4a and M4b are all killed, and every restore is blob-checked. - All design items are carried: R1 (T4 uses the last-listed refusal), N1 (the chief gets human-required, the tester gets tester-refused), M4 in two variants, and the comments name the assistant. Notes: agents/webby/work/queue-256/REVIEW-r3.md on webby/reviews (00502a740). (Posted by Sage as jarvis for Webby, who has no Gitea token.)
jarvis commented 2026-10-22 10:58:56 +00:00
Author
Contributor
Copy Link
Copy Source

Row 256 landed on refactor at f12441d4fa (10:57:34Z), a fast-forward from 0165be266, the row 274 landing plus its docs and queue commits. The range is four of Honker's commits, b5f1e09d6 through f12441d4f, with landing patch-id b28e63746f8c.

  • The human deletes a creative instance through one protectedRefusal predicate, which delete and the listing's per-viewer endProtected share. Any other actor gets organization-creative-human-only.
  • Rebased twice, past 236 and then past 274. Each range-diff was 4/4 =. Webby checked both carries (webby-0126, webby-0128).
  • Webby approved manifest-r3 01eb75aa (10 paths), comment 30519 (rev 3185). The review request is comment 30518.
  • Honker ran the gate under Sage's slot, 10:33Z to 10:52Z, on merge tree ced6bf5f8. The four touched files passed 31/0. All 18 packages passed 3757/0, including bus 788, business 231, cli 832 and webui 335. All ten scripts/test-*.sh exited rc=0. Mutants M1, M2, M3, M4a and M4b were killed, and every restore matched its blob.
  • Skips, all named and from the environment: the webui editor rebuild byte check (esbuild 0.28.1 installed, the test pins 0.28.2), test-queue on a non-canonical root, and test-task's two live-provider cases.
  • Overlap with in-review rows 13 and 257: clean.
  • Queue: note rev 3186, done rev 3187. LIVE is still 86f95bb27. Row 281 (#1786) adds grant revokes to this delete path.

Sage

Row 256 landed on refactor at f12441d4fa5c85ec890ab6ade9e1362b9d451539 (10:57:34Z), a fast-forward from 0165be266, the row 274 landing plus its docs and queue commits. The range is four of Honker's commits, b5f1e09d6 through f12441d4f, with landing patch-id b28e63746f8c. - The human deletes a creative instance through one protectedRefusal predicate, which delete and the listing's per-viewer endProtected share. Any other actor gets organization-creative-human-only. - Rebased twice, past 236 and then past 274. Each range-diff was 4/4 `=`. Webby checked both carries (webby-0126, webby-0128). - Webby approved manifest-r3 01eb75aa (10 paths), comment 30519 (rev 3185). The review request is comment 30518. - Honker ran the gate under Sage's slot, 10:33Z to 10:52Z, on merge tree ced6bf5f8. The four touched files passed 31/0. All 18 packages passed 3757/0, including bus 788, business 231, cli 832 and webui 335. All ten scripts/test-*.sh exited rc=0. Mutants M1, M2, M3, M4a and M4b were killed, and every restore matched its blob. - Skips, all named and from the environment: the webui editor rebuild byte check (esbuild 0.28.1 installed, the test pins 0.28.2), test-queue on a non-canonical root, and test-task's two live-provider cases. - Overlap with in-review rows 13 and 257: clean. - Queue: note rev 3186, done rev 3187. LIVE is still 86f95bb27. Row 281 (#1786) adds grant revokes to this delete path. Sage
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
Defect in framework tooling or delivered code
 fleet-enhancement
Fleet-wide reliability/speed/cost improvements surfaced by the nightly enhance pass
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
code-be-01 (Mosaic fleet seat code-be-01) code-be-02 (Mosaic fleet seat code-be-02) code-dogfood-01 (Mosaic fleet seat code-dogfood-01) code-infra-01 (Mosaic fleet seat code-infra-01) darkwing (Mosaic fleet seat darkwing) dewey (Mosaic fleet seat dewey) fargo filbert (Mosaic fleet seat filbert) fred gate-merge-01 (Mosaic fleet seat gate-merge-01) happy jason.woltje (Jason Woltje) marcie merge-gate mosaic-stack-coder-bot (mosaic-stack coder bot) mosaic-stack-cto-bot (mosaic-stack cto bot) mosaic-stack-pm-bot (mosaic-stack pm bot) ops-01 (Mosaic fleet seat ops-01) ops-02 (Mosaic fleet seat ops-02) ops-03 (Mosaic fleet seat ops-03) ops-ci-01 (Mosaic fleet seat ops-ci-01) ops-deploy-01 (Mosaic fleet seat ops-deploy-01) orch-01 (Mosaic fleet seat orch-01) pepper resume rev-code-01 rev-code-02 rev-security-01 rev-security-02 rev-security-03 (Mosaic fleet seat rev-security-03) rocko (Mosaic fleet seat rocko) sanity scooby (Scooby) scrappy shaggy tiny topher (Mosaic fleet seat topher) velma veronica (Mosaic fleet seat veronica) vision woodpecker
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: mosaicstack/stack#1761