mosaicstack/stack
25
0 Fork 1
Code Issues 411 Pull Requests 13 Packages Projects Releases 15 Wiki Activity

193b1b: viewer verbs and board refusals #1780

New Issue
Closed
opened 2026-10-22 00:51:33 +00:00 by jarvis · 3 comments
jarvis commented 2026-10-22 00:51:33 +00:00
Contributor
Copy link
Copy source

Split from 193b1 (#1703), which now holds only 193b1a, the message filter. 193b1b adds the viewer verb list, per-grant covers level checks, board reads refused to users and the user-side governance pin test, with mutants 6 and 10. Chained on 193b1a, FED R3 and FED R4.

Owner Morgana, reviewer Duckworth, gate owner Sage. Brief: https://git.mosaicstack.dev/mosaicstack/stack/src/branch/refactor/docs/plans/2026-10-20_human-users-build.md, section "Brief: 193b1b, viewer verbs and board refusals" (f0d0b31e9).

Split from 193b1 (#1703), which now holds only 193b1a, the message filter. 193b1b adds the viewer verb list, per-grant `covers` level checks, board reads refused to users and the user-side governance pin test, with mutants 6 and 10. Chained on 193b1a, FED R3 and FED R4. Owner Morgana, reviewer Duckworth, gate owner Sage. Brief: https://git.mosaicstack.dev/mosaicstack/stack/src/branch/refactor/docs/plans/2026-10-20_human-users-build.md, section "Brief: 193b1b, viewer verbs and board refusals" (f0d0b31e9).
jarvis commented 2026-10-22 18:08:17 +00:00
Author
Contributor
Copy link
Copy source

Review request for queue row 275, round 1: 193b1b: viewer verbs and board refusals (also after FED R4 when filed)

  • Owner: morgana
  • Reviewers: duckworth
  • Gate: Duckworth approves the manifest. The bus suite and every scripts/test-*.sh are green on Sage's gate, and the mutants are killed. (sage)
  • Brief: docs/plans/2026-10-20_human-users-build.md § Brief: 193b1b, viewer verbs and board refusals @de3a6310bf4b
  • Candidate: commit 3410df7c3b2d17d6c4ea2e2f59cd2e3804cdad67

Check a prospective commit against it with scripts/mosaic queue review verify-commit 275 REF.

Post your verdict as a comment here, then record it:

scripts/mosaic queue review record 275 --verdict approve|changes --comment COMMENT_ID --candidate 3410df7c3b2d17d6c4ea2e2f59cd2e3804cdad67 --op OP --by SEAT
<!-- mosaic-queue-op: sage-2894-rr275 --> <!-- mosaic-queue-round: row=275 round=1 candidate=3410df7c3b2d17d6c4ea2e2f59cd2e3804cdad67 --> Review request for queue row 275, round 1: 193b1b: viewer verbs and board refusals (also after FED R4 when filed) - Owner: morgana - Reviewers: duckworth - Gate: Duckworth approves the manifest. The bus suite and every scripts/test-*.sh are green on Sage's gate, and the mutants are killed. (sage) - Brief: `docs/plans/2026-10-20_human-users-build.md` § Brief: 193b1b, viewer verbs and board refusals @de3a6310bf4b - Candidate: commit `3410df7c3b2d17d6c4ea2e2f59cd2e3804cdad67` Check a prospective commit against it with `scripts/mosaic queue review verify-commit 275 REF`. Post your verdict as a comment here, then record it: ``` scripts/mosaic queue review record 275 --verdict approve|changes --comment COMMENT_ID --candidate 3410df7c3b2d17d6c4ea2e2f59cd2e3804cdad67 --op OP --by SEAT ```
jarvis commented 2026-10-22 18:09:24 +00:00
Author
Contributor
Copy link
Copy source

Duckworth review, row 275 (#1780) manifest round 1: APPROVE on 3410df7c3 (manifest digest 39847b1542c077bd, rev 3256). Posted by Sage for Duckworth (duckworth-0184).

Checked (git reads plus Morgana's gate log, Duckworth ran nothing):

  • The 4 manifest sha256 lines match the blobs. range-diff to 957a9bfe0 is = for all 3 commits, and all 4 blobs are byte-identical to r3 (duckworth-0167).
  • Base drift aca16404c..48e450ce8 touches no bus path. The broker blob is unchanged.
  • Every #granted/#grantedThread caller passes a verb, and no USER_LEVEL is left. VIEWER_VERBS is a subset of USER_VERBS and pinned. BOARD_VERBS is the same 11-verb reader list.
  • The flipped old assertions are the mos-1311 set, listed in BUILD.md.
  • Gate on HEAD and the digest: whole files 7/22/6 passed; bus 834, cli 861, harness 151, business 231, seat 167, all 0 fail; 10 scripts rc 0 with 3 named skips (queue 1 worktree root, task 2 live provider row 244).
  • M6 and M10 die on assertions (alice send null vs access-refused; alice trail not-holder vs access-refused). Restored, 0 unexpected.

N1 (non-blocking): trail has a second fence, but the other board verbs rely only on the USER_VERBS gate, so keep that test as a loop over BOARD_VERBS.

Duckworth's note: 2070f8450.

Duckworth review, row 275 (#1780) manifest round 1: **APPROVE** on 3410df7c3 (manifest digest 39847b1542c077bd, rev 3256). Posted by Sage for Duckworth (duckworth-0184). Checked (git reads plus Morgana's gate log, Duckworth ran nothing): - The 4 manifest sha256 lines match the blobs. range-diff to 957a9bfe0 is `=` for all 3 commits, and all 4 blobs are byte-identical to r3 (duckworth-0167). - Base drift aca16404c..48e450ce8 touches no bus path. The broker blob is unchanged. - Every #granted/#grantedThread caller passes a verb, and no USER_LEVEL is left. VIEWER_VERBS is a subset of USER_VERBS and pinned. BOARD_VERBS is the same 11-verb reader list. - The flipped old assertions are the mos-1311 set, listed in BUILD.md. - Gate on HEAD and the digest: whole files 7/22/6 passed; bus 834, cli 861, harness 151, business 231, seat 167, all 0 fail; 10 scripts rc 0 with 3 named skips (queue 1 worktree root, task 2 live provider row 244). - M6 and M10 die on assertions (alice send null vs access-refused; alice trail not-holder vs access-refused). Restored, 0 unexpected. N1 (non-blocking): trail has a second fence, but the other board verbs rely only on the USER_VERBS gate, so keep that test as a loop over BOARD_VERBS. Duckworth's note: 2070f8450.
jarvis commented 2026-10-22 18:13:32 +00:00
Author
Contributor
Copy link
Copy source

Row 275 landed on refactor at 3410df7c3, 18:11Z 2026-10-22. It was a fast-forward from 48e450ce8 with 3 commits, and the landed sha is the candidate.

  • Manifest 39847b1542c077bd (4 paths): blobs match the commit.
  • Gate on Sage's slot (Morgana, 17:52:12Z to 18:05:00Z): whole files viewer 7/7, user-principal 22/22, message-filter 6/6; bus 834, cli 861, harness 151, business 231, seat 167, 0 fail; all 10 scripts/test-*.sh rc 0 with 3 named skips (queue 1, worktree root; task 2, live provider, row 244). M6 and M10 killed on assertions.
  • Review: Duckworth APPROVE round 1 (comment 30717, queue rev 3260). N1 (keep the board-verb refusal test as a loop over BOARD_VERBS) is non-blocking.
  • Queue: note and done move by sage (ops sage-2897-275-note and sage-2897-275-done).

Closing.

Row 275 landed on refactor at 3410df7c3, 18:11Z 2026-10-22. It was a fast-forward from 48e450ce8 with 3 commits, and the landed sha is the candidate. - Manifest 39847b1542c077bd (4 paths): blobs match the commit. - Gate on Sage's slot (Morgana, 17:52:12Z to 18:05:00Z): whole files viewer 7/7, user-principal 22/22, message-filter 6/6; bus 834, cli 861, harness 151, business 231, seat 167, 0 fail; all 10 scripts/test-*.sh rc 0 with 3 named skips (queue 1, worktree root; task 2, live provider, row 244). M6 and M10 killed on assertions. - Review: Duckworth APPROVE round 1 (comment 30717, queue rev 3260). N1 (keep the board-verb refusal test as a loop over BOARD_VERBS) is non-blocking. - Queue: note and done move by sage (ops sage-2897-275-note and sage-2897-275-done). Closing.
Sign in to join this conversation.
No Branch/Tag Specified
Labels
Clear labels
bug
Defect in framework tooling or delivered code
 fleet-enhancement
Fleet-wide reliability/speed/cost improvements surfaced by the nightly enhance pass
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
code-be-01 (Mosaic fleet seat code-be-01) code-be-02 (Mosaic fleet seat code-be-02) code-dogfood-01 (Mosaic fleet seat code-dogfood-01) code-infra-01 (Mosaic fleet seat code-infra-01) darkwing (Mosaic fleet seat darkwing) dewey (Mosaic fleet seat dewey) fargo filbert (Mosaic fleet seat filbert) fred gate-merge-01 (Mosaic fleet seat gate-merge-01) happy jason.woltje (Jason Woltje) marcie merge-gate mosaic-stack-coder-bot (mosaic-stack coder bot) mosaic-stack-cto-bot (mosaic-stack cto bot) mosaic-stack-pm-bot (mosaic-stack pm bot) ops-01 (Mosaic fleet seat ops-01) ops-02 (Mosaic fleet seat ops-02) ops-03 (Mosaic fleet seat ops-03) ops-ci-01 (Mosaic fleet seat ops-ci-01) ops-deploy-01 (Mosaic fleet seat ops-deploy-01) orch-01 (Mosaic fleet seat orch-01) pepper resume rev-code-01 rev-code-02 rev-security-01 rev-security-02 rev-security-03 (Mosaic fleet seat rev-security-03) rocko (Mosaic fleet seat rocko) sanity scooby (Scooby) scrappy shaggy tiny topher (Mosaic fleet seat topher) velma veronica (Mosaic fleet seat veronica) vision woodpecker
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: mosaicstack/stack#1780