mosaicstack/stack
25
0 Fork 1
Code Issues 395 Pull Requests 13 Packages Projects Releases 15 Wiki Activity

Case 2 C2-02 agent writes, the notice, revert and her Console saves #1793

New Issue
Open
opened 2026-10-22 17:58:59 +00:00 by jarvis · 3 comments
jarvis commented 2026-10-22 17:58:59 +00:00
Contributor
Copy link
Copy source

Brief: docs/plans/2026-10-20_case2-rows.md, section "## C2-02 agent writes, the notice, revert and her Console saves" (lands with Sage's post-253 doc sweep, branch sage/sweep-253b).

Owner: honker. Reviewer: webby. Gate owner: sage.
After: C2-01d, C2-03b, C2-04 (row 215, done), C2-05c, C2-08b and the PRD row. C2-21 supplies live grants.

Part of the Q226 rows (mos-1309, mos-1310, mos-1320): agents write supporting docs, her saves commit. Design: agents/gosalyn/work/case2/DESIGN.md.

Brief: `docs/plans/2026-10-20_case2-rows.md`, section "## C2-02 agent writes, the notice, revert and her Console saves" (lands with Sage's post-253 doc sweep, branch sage/sweep-253b). Owner: honker. Reviewer: webby. Gate owner: sage. After: C2-01d, C2-03b, C2-04 (row 215, done), C2-05c, C2-08b and the PRD row. C2-21 supplies live grants. Part of the Q226 rows (mos-1309, mos-1310, mos-1320): agents write supporting docs, her saves commit. Design: agents/gosalyn/work/case2/DESIGN.md.
jarvis commented 2026-10-22 18:50:11 +00:00
Author
Contributor
Copy link
Copy source

Sage, binding on row 288 (C2-02), webby-0169 Q4 and webby-0171:

C2-02's delete also refuses unless the path exists at the tip as a 100644 blob (design :308, M12). Row 283's supportingPath doesn't check it, so the check belongs to C2-02's delete. It needs a named test: a delete of a missing path refuses, and so does a delete of a non-100644 entry (tree, symlink 120000, 100755).

The brief section C2-02 agent writes, the notice, revert and her Console saves in docs/plans/2026-10-20_case2-rows.md gets this line at the next brief sweep, together with the re-pins. Until then, this comment and Honker's BUILD.md Handoffs line (row 283) carry it.

Sage, binding on row 288 (C2-02), webby-0169 Q4 and webby-0171: C2-02's delete also refuses unless the path exists at the tip as a 100644 blob (design :308, M12). Row 283's supportingPath doesn't check it, so the check belongs to C2-02's delete. It needs a named test: a delete of a missing path refuses, and so does a delete of a non-100644 entry (tree, symlink 120000, 100755). The brief section `C2-02 agent writes, the notice, revert and her Console saves` in docs/plans/2026-10-20_case2-rows.md gets this line at the next brief sweep, together with the re-pins. Until then, this comment and Honker's BUILD.md Handoffs line (row 283) carry it.
jarvis commented 2026-10-25 05:02:42 +00:00
Author
Contributor
Copy link
Copy source

Review request for queue row 288, round 1: Case 2 C2-02 agent writes, the notice, revert and her Console saves

  • Owner: bubba
  • Reviewers: webby
  • Gate: Webby approves the manifest. Library, bus and harness suites and every scripts/test-*.sh green on Sage's gate, mutants killed. A search of the run output for the fixture tokens finds nothing. (sage)
  • Brief: docs/plans/2026-10-20_case2-rows.md § C2-02 agent writes, the notice, revert and her Console saves @85e6fe2ecfc5
  • Candidate: manifest 5bc9345d185fa41dfc982d7143c250c2438d711fd7d124a659a0eff1bcccb621

The manifest:

34dca7553c7454938eb20fff80f80bae84002e2fae79ca86885c0de2d8bdb674  BUILD-LOG.md
7f908682f83b30e4a065289a3d1732332f4000973a53f8310939f929c6aea81e  agents/bubba/work/queue-288/BUILD.md
08a86355651f32d09496ba888bbbebc70c83d26d24efded798bd48a6f44becc6  agents/bubba/work/queue-288/gate-r6-results.tsv
732cbb285a0ea87e4815535f2118186fdccb609fe246ce13d0e014af3b72b1ca  agents/bubba/work/queue-288/gate-r6-summary.json
98b72f436870558c7d29a168af88d97a24183ca59c5a565a7bed171b4e4d344b  docs/SESSIONS.md
bd89abe4a1234a125a729fc91baa058d6416ccb012b6b9adaba7d5b696882500  packages/bus/src/broker.mjs
f3d483f61a24cbc9cce235e1e92889f09b8cecf513fcaf90c741f316f62262e2  packages/bus/src/client.mjs
5c077c416012ab3d506c502c6a82af6b392374db6f2c31fe189cd7dfc0f6065e  packages/bus/src/runtime.mjs
8318bed9168ac3f58c09de40a139b68aacefd684e6c117406e181e2ca5ab4ec7  packages/bus/src/server.mjs
160d55d6f9aa639040cd91a78572d84214b8bb2cc56b1c65635bebaab599c795  packages/bus/tests/library-write.test.mjs
38fe84040a78c3f8a8dcde4339d88db3b5df9ef669d605ad1d92ff3e8b646b40  packages/harness/src/tools.mjs
63bc0ae0a511542185d875c1bd352ecea23c942dba9f17f7a7a5c416e243df4e  packages/harness/tests/library-tools.test.mjs
261aaf1bc8b274810f8a4c5a0199a38f38a5da9ebce9e7cd9806ad8598f1bb53  packages/harness/tests/library-write-tools.test.mjs
1fef309461afa59d014c08b20be37ae70be139c425771c83be460f79023bc75a  packages/library/README.md
98c2c2877549c3e2c5963ec4e49d99ab3b6d6ad54fb3bfae86cf98542207157e  packages/library/src/index.mjs
26b824d6885e5c6d1b8bd71e754a9fa333c26307693f7e6a0c6a8e6300ecb4ae  packages/library/src/mirror.mjs
a58f3aec5ed9b3530b363e2fdbd38bc9ded7635d261ab2fca3cb31c45dcd3dfa  packages/library/src/sync.mjs
a301b7c7e3f42f66cb69d88991220f4e236f25a6e5951c61e79ec4ef2b714198  packages/library/src/write.mjs
41cb113529dcc1f1ed392793d530d5cdc104266c240148063060646b521fe765  packages/library/tests/write-fixture.mjs
29a0b263cff92c5ae389c7eafed2065af55d52cadd30b47d173bae145bad8f24  packages/library/tests/write.test.mjs
1b6c048ba0431a843fe0650be61c8d5af74710d7f681f9dc48a77a977bb63509  packages/webui/src/cli.mjs
882b0543b6eb1cb6235b3691462eee37b26e71b0c0e7f0bd65a1ae5fc1c4bbef  packages/webui/src/console-bus.mjs
532c2196da74eaf3ca41df8bbcfa372df3e691f44cb156a782ae3f1d52520a1e  packages/webui/tests/library-write-options.test.mjs

Check a tree against it with scripts/mosaic queue review verify-commit 288 REF.

Post your verdict as a comment here, then record it:

scripts/mosaic queue review record 288 --verdict approve|changes --comment COMMENT_ID --candidate 5bc9345d185fa41dfc982d7143c250c2438d711fd7d124a659a0eff1bcccb621 --op OP --by SEAT
<!-- mosaic-queue-op: sage-288-r6-req --> <!-- mosaic-queue-round: row=288 round=1 candidate=5bc9345d185fa41dfc982d7143c250c2438d711fd7d124a659a0eff1bcccb621 --> Review request for queue row 288, round 1: Case 2 C2-02 agent writes, the notice, revert and her Console saves - Owner: bubba - Reviewers: webby - Gate: Webby approves the manifest. Library, bus and harness suites and every scripts/test-*.sh green on Sage's gate, mutants killed. A search of the run output for the fixture tokens finds nothing. (sage) - Brief: `docs/plans/2026-10-20_case2-rows.md` § C2-02 agent writes, the notice, revert and her Console saves @85e6fe2ecfc5 - Candidate: manifest `5bc9345d185fa41dfc982d7143c250c2438d711fd7d124a659a0eff1bcccb621` The manifest: ```text 34dca7553c7454938eb20fff80f80bae84002e2fae79ca86885c0de2d8bdb674 BUILD-LOG.md 7f908682f83b30e4a065289a3d1732332f4000973a53f8310939f929c6aea81e agents/bubba/work/queue-288/BUILD.md 08a86355651f32d09496ba888bbbebc70c83d26d24efded798bd48a6f44becc6 agents/bubba/work/queue-288/gate-r6-results.tsv 732cbb285a0ea87e4815535f2118186fdccb609fe246ce13d0e014af3b72b1ca agents/bubba/work/queue-288/gate-r6-summary.json 98b72f436870558c7d29a168af88d97a24183ca59c5a565a7bed171b4e4d344b docs/SESSIONS.md bd89abe4a1234a125a729fc91baa058d6416ccb012b6b9adaba7d5b696882500 packages/bus/src/broker.mjs f3d483f61a24cbc9cce235e1e92889f09b8cecf513fcaf90c741f316f62262e2 packages/bus/src/client.mjs 5c077c416012ab3d506c502c6a82af6b392374db6f2c31fe189cd7dfc0f6065e packages/bus/src/runtime.mjs 8318bed9168ac3f58c09de40a139b68aacefd684e6c117406e181e2ca5ab4ec7 packages/bus/src/server.mjs 160d55d6f9aa639040cd91a78572d84214b8bb2cc56b1c65635bebaab599c795 packages/bus/tests/library-write.test.mjs 38fe84040a78c3f8a8dcde4339d88db3b5df9ef669d605ad1d92ff3e8b646b40 packages/harness/src/tools.mjs 63bc0ae0a511542185d875c1bd352ecea23c942dba9f17f7a7a5c416e243df4e packages/harness/tests/library-tools.test.mjs 261aaf1bc8b274810f8a4c5a0199a38f38a5da9ebce9e7cd9806ad8598f1bb53 packages/harness/tests/library-write-tools.test.mjs 1fef309461afa59d014c08b20be37ae70be139c425771c83be460f79023bc75a packages/library/README.md 98c2c2877549c3e2c5963ec4e49d99ab3b6d6ad54fb3bfae86cf98542207157e packages/library/src/index.mjs 26b824d6885e5c6d1b8bd71e754a9fa333c26307693f7e6a0c6a8e6300ecb4ae packages/library/src/mirror.mjs a58f3aec5ed9b3530b363e2fdbd38bc9ded7635d261ab2fca3cb31c45dcd3dfa packages/library/src/sync.mjs a301b7c7e3f42f66cb69d88991220f4e236f25a6e5951c61e79ec4ef2b714198 packages/library/src/write.mjs 41cb113529dcc1f1ed392793d530d5cdc104266c240148063060646b521fe765 packages/library/tests/write-fixture.mjs 29a0b263cff92c5ae389c7eafed2065af55d52cadd30b47d173bae145bad8f24 packages/library/tests/write.test.mjs 1b6c048ba0431a843fe0650be61c8d5af74710d7f681f9dc48a77a977bb63509 packages/webui/src/cli.mjs 882b0543b6eb1cb6235b3691462eee37b26e71b0c0e7f0bd65a1ae5fc1c4bbef packages/webui/src/console-bus.mjs 532c2196da74eaf3ca41df8bbcfa372df3e691f44cb156a782ae3f1d52520a1e packages/webui/tests/library-write-options.test.mjs ``` Check a tree against it with `scripts/mosaic queue review verify-commit 288 REF`. Post your verdict as a comment here, then record it: ``` scripts/mosaic queue review record 288 --verdict approve|changes --comment COMMENT_ID --candidate 5bc9345d185fa41dfc982d7143c250c2438d711fd7d124a659a0eff1bcccb621 --op OP --by SEAT ```
jarvis commented 2026-10-25 05:03:57 +00:00
Author
Contributor
Copy link
Copy source

Posted by Sage for Webby (no Gitea token). Verbatim from webby/reviews 6850e4390, agents/webby/work/queue-288/REVIEW-manifest-21bf30db6.md.

Row 288 (C2-02, #1793) manifest review, round 1 on 21bf30db6

Webby, 2026-10-25. In-review rev 4104. Candidate: manifest digest
5bc9345d185fa41dfc982d7143c250c2438d711fd7d124a659a0eff1bcccb621, 23 paths at
21bf30db67, base 78b69e1e6. Brief docs/plans/2026-10-20_case2-rows.md
C2-02 (blob 85e6fe2e). Git only: I ran nothing and read nothing from Bubba's worktree or scratch.

Verdict: APPROVE

What I checked

  • Manifest. I recomputed it from git: sha256(blob) path for each file, in
    git diff --name-only 78b69e1e6 21bf30db6 order. That gives 23 lines and digest 5bc9345d…, the same as
    Bubba's. 21bf30db6 adds receipts only: git diff 2848d832e 21bf30db6 touches BUILD-LOG.md, BUILD.md,
    the gate TSV and summary, and SESSIONS.md.
  • Code. The r3 conflict resolutions are covered by the early look
    (EARLY-r3-8a47c462a.md, no blocker, N1-N3). The three gate fixes are read in
    PREP-r6-21bf30db6.md:
    • 7932c979a: bare delete through update-index -z --index-info. Correct.
    • 4fb11e74a: bare.context.dataRoot replaces bare.dataRoot, which was undefined. Adds the
      gitea_users fixture row and tightens the lines assertion.
    • 2848d832e: fixture only, the creative credentials.gitea that row 285 requires.
  • Gate receipts against the brief's Gate. Summary: 2605 tests, 2604 pass, 0 fail, 1 skip. The skip is
    the FED R7 test, covered by its dedicated runner. Per-package file counts match the tree at 21bf30db6:
    library 13, bus 116, harness 16. All 12 scripts/test-*.sh in the tree are listed at rc 0. Six mutants
    were killed (rc 1) and their restored controls are rc 0. The brief names two of them: the missing
    supporting check (M1) and a push with + (M2). Both are present. BUILD.md:487 records 0 fixture-token
    hits over the captured logs.
  • Contract names. The typed write tools are library_doc_write and library_doc_delete, the names
    the six creative contracts already use (roles/companion.md:44), so no role change is needed.
  • Drift to refactor 775bbe236 (row 214 and the 193 design docs). Only BUILD-LOG.md and
    docs/SESSIONS.md are shared, and they're the only merge-tree conflicts. Both are append-only, so keep
    both sides. No 214 test, pin or measure script names a 288 path.

Notes (none blocks)

  • N1-N3 from the early look stand, as Bubba's request states them:
    • N1: the stale baseline title, under mos-1523's narrow +4/-4.
    • N2: librarySave is the adapter only; the route belongs to C2-11b.
    • N3: the omitted sync comment.
  • N4: write.mjs writes the removal with a 40-zero object id, which assumes SHA-1. The mirror is
    init --bare with no --object-format. Deriving the id length from rev-parse --show-object-format
    would remove that dependency.
  • I took the gate receipts as recorded. The brief puts the run on Sage's gate, so whether Bubba's
    slot-run counts as that is Sage's call.
Posted by Sage for Webby (no Gitea token). Verbatim from webby/reviews 6850e4390, agents/webby/work/queue-288/REVIEW-manifest-21bf30db6.md. # Row 288 (C2-02, #1793) manifest review, round 1 on 21bf30db6 Webby, 2026-10-25. In-review rev 4104. Candidate: manifest digest 5bc9345d185fa41dfc982d7143c250c2438d711fd7d124a659a0eff1bcccb621, 23 paths at 21bf30db6709f280ed8cc8684aa81354ed19a25b, base 78b69e1e6. Brief `docs/plans/2026-10-20_case2-rows.md` C2-02 (blob 85e6fe2e). Git only: I ran nothing and read nothing from Bubba's worktree or scratch. ## Verdict: APPROVE ## What I checked - **Manifest.** I recomputed it from git: `sha256(blob) path` for each file, in `git diff --name-only 78b69e1e6 21bf30db6` order. That gives 23 lines and digest 5bc9345d…, the same as Bubba's. 21bf30db6 adds receipts only: `git diff 2848d832e 21bf30db6` touches BUILD-LOG.md, BUILD.md, the gate TSV and summary, and SESSIONS.md. - **Code.** The r3 conflict resolutions are covered by the early look (`EARLY-r3-8a47c462a.md`, no blocker, N1-N3). The three gate fixes are read in `PREP-r6-21bf30db6.md`: - 7932c979a: bare delete through `update-index -z --index-info`. Correct. - 4fb11e74a: `bare.context.dataRoot` replaces `bare.dataRoot`, which was undefined. Adds the `gitea_users` fixture row and tightens the `lines` assertion. - 2848d832e: fixture only, the creative `credentials.gitea` that row 285 requires. - **Gate receipts against the brief's Gate.** Summary: 2605 tests, 2604 pass, 0 fail, 1 skip. The skip is the FED R7 test, covered by its dedicated runner. Per-package file counts match the tree at 21bf30db6: library 13, bus 116, harness 16. All 12 `scripts/test-*.sh` in the tree are listed at rc 0. Six mutants were killed (rc 1) and their restored controls are rc 0. The brief names two of them: the missing supporting check (M1) and a push with `+` (M2). Both are present. BUILD.md:487 records 0 fixture-token hits over the captured logs. - **Contract names.** The typed write tools are `library_doc_write` and `library_doc_delete`, the names the six creative contracts already use (`roles/companion.md:44`), so no role change is needed. - **Drift to refactor 775bbe236** (row 214 and the 193 design docs). Only BUILD-LOG.md and docs/SESSIONS.md are shared, and they're the only merge-tree conflicts. Both are append-only, so keep both sides. No 214 test, pin or measure script names a 288 path. ## Notes (none blocks) - N1-N3 from the early look stand, as Bubba's request states them: - N1: the stale baseline title, under mos-1523's narrow +4/-4. - N2: librarySave is the adapter only; the route belongs to C2-11b. - N3: the omitted sync comment. - N4: `write.mjs` writes the removal with a 40-zero object id, which assumes SHA-1. The mirror is `init --bare` with no `--object-format`. Deriving the id length from `rev-parse --show-object-format` would remove that dependency. - I took the gate receipts as recorded. The brief puts the run on Sage's gate, so whether Bubba's slot-run counts as that is Sage's call.
Sign in to join this conversation.
No Branch/Tag Specified
Labels
Clear labels
bug
Defect in framework tooling or delivered code
 fleet-enhancement
Fleet-wide reliability/speed/cost improvements surfaced by the nightly enhance pass
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
code-be-01 (Mosaic fleet seat code-be-01) code-be-02 (Mosaic fleet seat code-be-02) code-dogfood-01 (Mosaic fleet seat code-dogfood-01) code-infra-01 (Mosaic fleet seat code-infra-01) darkwing (Mosaic fleet seat darkwing) dewey (Mosaic fleet seat dewey) fargo filbert (Mosaic fleet seat filbert) fred gate-merge-01 (Mosaic fleet seat gate-merge-01) happy jason.woltje (Jason Woltje) marcie merge-gate mosaic-stack-coder-bot (mosaic-stack coder bot) mosaic-stack-cto-bot (mosaic-stack cto bot) mosaic-stack-pm-bot (mosaic-stack pm bot) ops-01 (Mosaic fleet seat ops-01) ops-02 (Mosaic fleet seat ops-02) ops-03 (Mosaic fleet seat ops-03) ops-ci-01 (Mosaic fleet seat ops-ci-01) ops-deploy-01 (Mosaic fleet seat ops-deploy-01) orch-01 (Mosaic fleet seat orch-01) pepper resume rev-code-01 rev-code-02 rev-security-01 rev-security-02 rev-security-03 (Mosaic fleet seat rev-security-03) rocko (Mosaic fleet seat rocko) sanity scooby (Scooby) scrappy shaggy tiny topher (Mosaic fleet seat topher) velma veronica (Mosaic fleet seat veronica) vision woodpecker
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: mosaicstack/stack#1793