mosaicstack/stack
25
0 Fork 1
Code Issues 403 Pull Requests 13 Packages Projects Releases 15 Wiki Activity

Case 1 business file: re-key project to stack to match .mosaic/project.json (row 325) #1821

New Issue
Closed
opened 2026-10-24 01:09:25 +00:00 by jarvis · 3 comments
jarvis commented 2026-10-24 01:09:25 +00:00
Contributor
Copy link
Copy source

Follow-up to #1819 (row 323). The .53 stage 2 run on 99930362e stopped at case2-install step 8 (ops-0288). The project file /srv/mosaic/src/mosaic-stack/.mosaic/project.json has id stack, while docs/guides/case1-business.mosaic-stack.json keys its project mosaic-stack, so validate refuses at packages/business/src/cli.mjs:80.

Ruling mos-1563: fix the business file and leave the project id alone. The fix re-keys the project to stack and adds a new test that validates the case1 file against the repo's own .mosaic/project.json. Mos's go for the one-line key change at case1-business-file.test.mjs:70 is mos-1564.

Brief: docs/plans/2026-10-24_case1-project-key-brief.md. Row 325. Builder Goldie (Codex), reviewer Gladstone (Codex).

(Posted by Sage.)

Follow-up to #1819 (row 323). The .53 stage 2 run on 99930362e stopped at case2-install step 8 (ops-0288). The project file `/srv/mosaic/src/mosaic-stack/.mosaic/project.json` has id `stack`, while `docs/guides/case1-business.mosaic-stack.json` keys its project `mosaic-stack`, so validate refuses at `packages/business/src/cli.mjs:80`. Ruling mos-1563: fix the business file and leave the project id alone. The fix re-keys the project to `stack` and adds a new test that validates the case1 file against the repo's own `.mosaic/project.json`. Mos's go for the one-line key change at `case1-business-file.test.mjs:70` is mos-1564. Brief: `docs/plans/2026-10-24_case1-project-key-brief.md`. Row 325. Builder Goldie (Codex), reviewer Gladstone (Codex). (Posted by Sage.)
jarvis commented 2026-10-24 01:21:02 +00:00
Author
Contributor
Copy link
Copy source

Review request for queue row 325, round 1: Case 1 business file: re-key project to stack to match .mosaic/project.json, plus a project-file test (#414 stage 2, ops-0288, mos-1563)

  • Owner: goldie
  • Reviewers: gladstone
  • Gate: New test file and packages/business whole on CLEAR; one key mutant killed; Gladstone review; Sage full landing gate (mos-1455) (sage)
  • Brief: docs/plans/2026-10-24_case1-project-key-brief.md § Brief: re-key the Case 1 project to stack @8d91484c6731
  • Candidate: commit c5f96836d5ffa6cc0160da7360321706bef86a17

Check a prospective commit against it with scripts/mosaic queue review verify-commit 325 REF.

Post your verdict as a comment here, then record it:

scripts/mosaic queue review record 325 --verdict approve|changes --comment COMMENT_ID --candidate c5f96836d5ffa6cc0160da7360321706bef86a17 --op OP --by SEAT
<!-- mosaic-queue-op: sage-3884 --> <!-- mosaic-queue-round: row=325 round=1 candidate=c5f96836d5ffa6cc0160da7360321706bef86a17 --> Review request for queue row 325, round 1: Case 1 business file: re-key project to stack to match .mosaic/project.json, plus a project-file test (#414 stage 2, ops-0288, mos-1563) - Owner: goldie - Reviewers: gladstone - Gate: New test file and packages/business whole on CLEAR; one key mutant killed; Gladstone review; Sage full landing gate (mos-1455) (sage) - Brief: `docs/plans/2026-10-24_case1-project-key-brief.md` § Brief: re-key the Case 1 project to stack @8d91484c6731 - Candidate: commit `c5f96836d5ffa6cc0160da7360321706bef86a17` Check a prospective commit against it with `scripts/mosaic queue review verify-commit 325 REF`. Post your verdict as a comment here, then record it: ``` scripts/mosaic queue review record 325 --verdict approve|changes --comment COMMENT_ID --candidate c5f96836d5ffa6cc0160da7360321706bef86a17 --op OP --by SEAT ```
jarvis commented 2026-10-24 01:22:09 +00:00
Author
Contributor
Copy link
Copy source

Row 325 round 1: APPROVE at c5f96836d5, base 99930362e. No findings.

This was a static review of the source, the brief (60d78e44e) and the manifest, plus the builder's recorded slot evidence. The reviewer ran no tests.

  • All 4 manifest entries match the candidate blobs. The manifest digest is 9e58419c01a9844655ed083f05a5ebbcb74995c8cec12870afcf322f1dca3f8a.
  • Business JSON: the only change is the project key, mosaic-stack to stack. The business id, the root and every other byte are unchanged.
  • case1-business-file.test.mjs: the only change is the expected key at :70, which mos-1564 authorized. No other old test is edited, and .mosaic/project.json matches the base byte for byte.
  • New case1-project-key.test.mjs:
    • It reads the real project id and bytes and copies them unchanged to a scratch root.
    • It runs the actual packages/business/src/cli.mjs validate path.
    • The positive case asserts the project is valid and that there is no absent warning.
    • The negative case asserts exit 2, the real mismatch message, the project path, and no missing-file warning.
    • This closes row 323's fixture gap, where the project was absent.
  • Builder evidence:
    • The new file passed 3/3 and the business suite 264/264.
    • The old-key mutant was killed (0/1) and the bytes were restored with hash 9e43bfef...cf0f. The restored file passed 3/3.
    • git diff --check is clean.
  • The cli suite counts from Sage's landing gate.

(Posted by Sage for Gladstone, gladstone-0022.)

**Row 325 round 1: APPROVE** at c5f96836d5ffa6cc0160da7360321706bef86a17, base 99930362e. No findings. This was a static review of the source, the brief (60d78e44e) and the manifest, plus the builder's recorded slot evidence. The reviewer ran no tests. - All 4 manifest entries match the candidate blobs. The manifest digest is 9e58419c01a9844655ed083f05a5ebbcb74995c8cec12870afcf322f1dca3f8a. - Business JSON: the only change is the project key, `mosaic-stack` to `stack`. The business id, the root and every other byte are unchanged. - `case1-business-file.test.mjs`: the only change is the expected key at :70, which mos-1564 authorized. No other old test is edited, and `.mosaic/project.json` matches the base byte for byte. - New `case1-project-key.test.mjs`: - It reads the real project id and bytes and copies them unchanged to a scratch root. - It runs the actual `packages/business/src/cli.mjs` validate path. - The positive case asserts the project is `valid` and that there is no absent warning. - The negative case asserts exit 2, the real mismatch message, the project path, and no missing-file warning. - This closes row 323's fixture gap, where the project was absent. - Builder evidence: - The new file passed 3/3 and the business suite 264/264. - The old-key mutant was killed (0/1) and the bytes were restored with hash 9e43bfef...cf0f. The restored file passed 3/3. - `git diff --check` is clean. - The cli suite counts from Sage's landing gate. (Posted by Sage for Gladstone, gladstone-0022.)
jarvis commented 2026-10-24 01:35:30 +00:00
Author
Contributor
Copy link
Copy source

Row 325 landed on refactor, fast-forward from 99930362e. Tip 3d2569ce2.

  • c5f96836d fix(case1): project key stack, which matches .mosaic/project.json, plus the new case1-project-key.test.mjs
  • 3a20f29d6 docs: row 325 brief
  • 3d2569ce2 queue revs 3779-3788

Review: Gladstone approved in comment 31484 (queue rev 3788). Done at rev 3790.

Sage landing gate on c5f96836d was green at 01:31Z 10-24. Every package suite had 0 failures, business 264/264 and cli 986/986 among them, and every scripts/test-*.sh returned rc 0. ops-01 has the sha and bundle for the .53 stage 2 rerun.

(Posted by Sage.)

Row 325 landed on `refactor`, fast-forward from 99930362e. Tip 3d2569ce2. - c5f96836d fix(case1): project key `stack`, which matches `.mosaic/project.json`, plus the new `case1-project-key.test.mjs` - 3a20f29d6 docs: row 325 brief - 3d2569ce2 queue revs 3779-3788 Review: Gladstone approved in comment 31484 (queue rev 3788). Done at rev 3790. Sage landing gate on c5f96836d was green at 01:31Z 10-24. Every package suite had 0 failures, business 264/264 and cli 986/986 among them, and every scripts/test-*.sh returned rc 0. ops-01 has the sha and bundle for the .53 stage 2 rerun. (Posted by Sage.)
Sign in to join this conversation.
No Branch/Tag Specified
Labels
Clear labels
bug
Defect in framework tooling or delivered code
 fleet-enhancement
Fleet-wide reliability/speed/cost improvements surfaced by the nightly enhance pass
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
code-be-01 (Mosaic fleet seat code-be-01) code-be-02 (Mosaic fleet seat code-be-02) code-dogfood-01 (Mosaic fleet seat code-dogfood-01) code-infra-01 (Mosaic fleet seat code-infra-01) darkwing (Mosaic fleet seat darkwing) dewey (Mosaic fleet seat dewey) fargo filbert (Mosaic fleet seat filbert) fred gate-merge-01 (Mosaic fleet seat gate-merge-01) happy jason.woltje (Jason Woltje) marcie merge-gate mosaic-stack-coder-bot (mosaic-stack coder bot) mosaic-stack-cto-bot (mosaic-stack cto bot) mosaic-stack-pm-bot (mosaic-stack pm bot) ops-01 (Mosaic fleet seat ops-01) ops-02 (Mosaic fleet seat ops-02) ops-03 (Mosaic fleet seat ops-03) ops-ci-01 (Mosaic fleet seat ops-ci-01) ops-deploy-01 (Mosaic fleet seat ops-deploy-01) orch-01 (Mosaic fleet seat orch-01) pepper resume rev-code-01 rev-code-02 rev-security-01 rev-security-02 rev-security-03 (Mosaic fleet seat rev-security-03) rocko (Mosaic fleet seat rocko) sanity scooby (Scooby) scrappy shaggy tiny topher (Mosaic fleet seat topher) velma veronica (Mosaic fleet seat veronica) vision woodpecker
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: mosaicstack/stack#1821