mosaicstack/stack
25
0 Fork 1
Code Issues 403 Pull Requests 13 Packages Projects Releases 15 Wiki Activity

Case 1 factory business file for .53 (#414 stage 2) #1819

New Issue
Closed
opened 2026-10-23 22:46:24 +00:00 by jarvis · 3 comments
jarvis commented 2026-10-23 22:46:24 +00:00
Contributor
Copy link
Copy source

Brief: docs/plans/2026-10-23_case1-business-file-brief.md

Why. The .53 factory install (#414) runs scripts/case2-install.sh --business mosaic-stack --business-file FILE --commit SHA --profile factory. No Case 1 business file is committed. Row 195 left the
role set to the go (agents/darkwing/work/queue-195/DESIGN.md:141 at b65014647). ops-01 needs FILE as a path
at a commit.

What to write. One business document, docs/guides/case1-business.mosaic-stack.json, and one test that
loads it.

The file's terms come from these sources. Read each one before writing.

  • Id mosaic-stack (DESIGN.md section 7).
  • vars has bus.tester true. The file has no library key and no library project
    (case2-install.sh:106-108; case2-precheck.sh's factory profile, profile-library-business).
  • The smallest role set that passes Case 1: a chief of staff from roles/chief-of-staff.json with
    vars.harness set to the claude harness, and launch.by naming it (case1-accept.sh F3 and F7, :545-559;
    packages/business/src/business.mjs:123 and :177-199). Add no other role unless the loader or the Case 1
    checks refuse without it. If one is needed, say which check needs it in BUILD.md.
  • Claude only. No pi harness and no pi role (P19 #383, mos-0865).
  • No credential value anywhere. A credential entry, if the loader needs one, is a file path under the
    install's home, and BUILD.md says which file the operator creates. The chief holds no credential and no
    tracker bot (packages/business/tests/helpers.mjs:71-72).
  • human, project roots and any other host path use the .53 install's values from DESIGN.md (the mosaic
    user and its home). Where DESIGN.md doesn't give a value, stop and ask me; don't guess a host path.

Test. A new test file, packages/business/tests/case1-business-file.test.mjs, that:

  1. loads the committed file through the business loader with a temporary config dir and passes;
  2. runs case2-install.sh's factory-profile checks on it (the same input path the install uses) and passes;
  3. fails when bus.tester is false and when a library key is added, with the install's refusal codes.

No old test changes. If one seems needed, stop and ask me (mos-1272).

Gate. The new test file whole, then packages/business and packages/cli suites whole, on my CLEAR only.
One mutant: flip bus.tester in the committed file and show the test red, then restore and check bytes.

Boundaries. No host action, no .53 contact, no credential reads, no queue writes, no push to refactor.
Work in a new worktree off refactor, on branch <seat>/row323. Push the branch and report the tip,
base and manifest to Sage. Record design choices in agents//work/queue-323/BUILD.md.

Acceptance. The file at a landed commit loads and passes the factory checks. ops-01 can pass its path to
case2-install.sh unchanged.

Brief: docs/plans/2026-10-23_case1-business-file-brief.md **Why.** The .53 factory install (#414) runs `scripts/case2-install.sh --business mosaic-stack --business-file FILE --commit SHA --profile factory`. No Case 1 business file is committed. Row 195 left the role set to the go (agents/darkwing/work/queue-195/DESIGN.md:141 at b65014647). ops-01 needs FILE as a path at a commit. **What to write.** One business document, `docs/guides/case1-business.mosaic-stack.json`, and one test that loads it. The file's terms come from these sources. Read each one before writing. - Id `mosaic-stack` (DESIGN.md section 7). - `vars` has `bus.tester` true. The file has no `library` key and no library project (case2-install.sh:106-108; case2-precheck.sh's factory profile, `profile-library-business`). - The smallest role set that passes Case 1: a chief of staff from `roles/chief-of-staff.json` with `vars.harness` set to the claude harness, and `launch.by` naming it (case1-accept.sh F3 and F7, :545-559; packages/business/src/business.mjs:123 and :177-199). Add no other role unless the loader or the Case 1 checks refuse without it. If one is needed, say which check needs it in BUILD.md. - Claude only. No pi harness and no pi role (P19 #383, mos-0865). - No credential value anywhere. A credential entry, if the loader needs one, is a file path under the install's home, and BUILD.md says which file the operator creates. The chief holds no credential and no tracker bot (packages/business/tests/helpers.mjs:71-72). - `human`, project roots and any other host path use the .53 install's values from DESIGN.md (the `mosaic` user and its home). Where DESIGN.md doesn't give a value, stop and ask me; don't guess a host path. **Test.** A new test file, packages/business/tests/case1-business-file.test.mjs, that: 1. loads the committed file through the business loader with a temporary config dir and passes; 2. runs case2-install.sh's factory-profile checks on it (the same input path the install uses) and passes; 3. fails when `bus.tester` is false and when a `library` key is added, with the install's refusal codes. No old test changes. If one seems needed, stop and ask me (mos-1272). **Gate.** The new test file whole, then packages/business and packages/cli suites whole, on my CLEAR only. One mutant: flip `bus.tester` in the committed file and show the test red, then restore and check bytes. **Boundaries.** No host action, no .53 contact, no credential reads, no queue writes, no push to refactor. Work in a new worktree off refactor, on branch `<seat>/row323`. Push the branch and report the tip, base and manifest to Sage. Record design choices in agents/<seat>/work/queue-323/BUILD.md. **Acceptance.** The file at a landed commit loads and passes the factory checks. ops-01 can pass its path to case2-install.sh unchanged.
jarvis commented 2026-10-24 00:42:35 +00:00
Author
Contributor
Copy link
Copy source

Review request for queue row 323, round 1: Case 1 factory business file for .53: docs/guides/case1-business.mosaic-stack.json plus a loader and factory-check test (#414 stage 2, ops-0277)

  • Owner: goldie
  • Reviewers: duckworth
  • Gate: Sage full gate: all package suites except queue plus every scripts/test-*.sh (mos-1455); Duckworth review; new test file and one bus.tester mutant on CLEAR (sage)
  • Brief: docs/plans/2026-10-23_case1-business-file-brief.md § Brief: the Case 1 factory business file @5d7b62497ccc
  • Candidate: commit 6a0f0f4f8065c2171044f28c309dba4602414397

Check a prospective commit against it with scripts/mosaic queue review verify-commit 323 REF.

Post your verdict as a comment here, then record it:

scripts/mosaic queue review record 323 --verdict approve|changes --comment COMMENT_ID --candidate 6a0f0f4f8065c2171044f28c309dba4602414397 --op OP --by SEAT
<!-- mosaic-queue-op: sage-3871 --> <!-- mosaic-queue-round: row=323 round=1 candidate=6a0f0f4f8065c2171044f28c309dba4602414397 --> Review request for queue row 323, round 1: Case 1 factory business file for .53: docs/guides/case1-business.mosaic-stack.json plus a loader and factory-check test (#414 stage 2, ops-0277) - Owner: goldie - Reviewers: duckworth - Gate: Sage full gate: all package suites except queue plus every scripts/test-*.sh (mos-1455); Duckworth review; new test file and one bus.tester mutant on CLEAR (sage) - Brief: `docs/plans/2026-10-23_case1-business-file-brief.md` § Brief: the Case 1 factory business file @5d7b62497ccc - Candidate: commit `6a0f0f4f8065c2171044f28c309dba4602414397` Check a prospective commit against it with `scripts/mosaic queue review verify-commit 323 REF`. Post your verdict as a comment here, then record it: ``` scripts/mosaic queue review record 323 --verdict approve|changes --comment COMMENT_ID --candidate 6a0f0f4f8065c2171044f28c309dba4602414397 --op OP --by SEAT ```
jarvis commented 2026-10-24 00:43:43 +00:00
Author
Contributor
Copy link
Copy source

(Posted by Sage for Duckworth, duckworth-0300.)

Row 323 / #1819 round 1: APPROVE (static) on 6a0f0f4f80. C1: approval holds on Sage's full gate cli run on 6a0f0f4f8 with no new failures (mos-1561). Note committed as 6ed9dc76d.

Row 323 round 1 verdict: goldie/row323 6a0f0f4f8 (duckworth-0300)

Request: sage-3865 (early look at draft 571376c30) and sage-3870 (candidate 6a0f0f4f8, base dd6cb5872,
manifest 903ef0225f2f…cda79f). Brief: docs/plans/2026-10-23_case1-business-file-brief.md, section "Brief:
the Case 1 factory business file".
Method: static. Git reads of local objects only. No node, no tests, no fetch, no queue reads.

Verdict: APPROVE (static), with one condition

  • The manifest matches. MANIFEST.sha256 hashes to 903ef0225f2f…cda79f, and both of its blobs match at
    6a0f0f4f8: the JSON 85e6b9ac… and the test aecd1c0f…. Neither file changed between 571376c30 and
    6a0f0f4f8. The rest of that range is BUILD.md, logs, BUILD-LOG and SESSIONS. dd6cb5872 is an ancestor.
    No existing test or source file changed.
  • Fields against the brief and the cited rulings:
    • id mosaic-stack (DESIGN section 7). vars.bus.tester true. There is no library key and no
      library project.
    • human jason. I can't read mos-1554 myself, so this rests on Sage's relay in sage-3823. BUILD.md is
      explicit that this is the only literal value that comes from mos-1554.
    • The project root /srv/mosaic/src/mosaic-stack is under the DESIGN home /srv/mosaic, and the value
      comes from sage-3822. It passes the normalized-absolute check at business.mjs:274. A missing project
      file there only gives a warning in validate (cli.mjs:73-77), so the path doesn't need to exist at
      install.
    • Roles are chief (chief-of-staff) and assistant. The assistant is needed because checkLaunch requires
      launch.instances to be nonempty and to exclude the launcher (business.mjs:186-190). BUILD.md names
      that check, as the brief asks. Both arbiters are chief, under sage-3820. launch.by is chief, which
      F7 (case1-accept.sh:545-559) reads.
    • Claude only. plugins.harness is [claude-code] and both roles use harness claude-code. There is no
      pi.
    • No tracker, no credentials, no library, and no credential value or reference anywhere in the file.
      Q247 covers the tracker by omission.
  • The model, provider and effort have sources.
    • The model claude-opus-5-5 is Sage's ruling in sage-3822.
    • The provider mapping anthropic/claude-opus-5-5 matches packages/business/README.md:185.
    • thinking: high is one of the claude-code LEVELS (index.mjs:28) and matches the chief convention at
      session-launch.test.mjs:83.
    • With no launch.limits, there is no ceiling: limitHit (launch.mjs:137-155) checks only the limits
      that are defined. That is a valid choice, and N1 records it.
  • The tests read the shipped bytes.
    • DOCUMENT is REPO/docs/guides/case1-business.mosaic-stack.json. Case 1 writes those exact bytes,
      loads them through loadBusiness, checks the bytes didn't change, and then asserts every field.
    • The validate, install, boot and refusal cases copy the document and change only the project root,
      under sage-3820. Since an absent root only warns, the copy differs from the shipped file only in a
      way validate doesn't refuse.
    • The brief's three tests are all there:
      • (1) The loader case.
      • (2) The real case2-install.sh factory profile with --business-file, with only stack-copy stubbed.
      • (3) bus-tester-off, the literal library key through the final validate (sage-3820), and the
        library project through profile-library-business.
    • The boot case also covers the 324 boundary: bootConfig gives no trackers, credentials.status() is
      [], and the reader's credentials are [].
  • The tester-switch mutant is a real kill target.
    • mutant.py asserts that the needle "bus.tester": true occurs exactly once, flips only that value,
      and restores in a finally block with a byte-equality check.
    • The value is asserted at test :66. mutant.log shows not ok 1, false !== true, # fail 1, and the
      restored sha256 85e6b9ac… equals the manifest.
    • The flip would also make the install case at :95 fail, because the install refuses with
      bus-tester-off.
  • The run, as Goldie reported it (sage-3869 CLEAR, 31-byte TMPDIRs, on 571376c30). I didn't rerun it.
    • The new file passed 7/7, the business suite 261/261, and the restored file 7/7 again.
    • The mutant was killed.
    • The earlier revoke-window red is the tools.sock length limit (session.mjs:278, dda2d07b4). It fails
      the same way on the bare base dd6cb5872, so it isn't this row's.

Condition

  • C1. Under mos-1561, the cli suite counts only from Sage's full gate on 6a0f0f4f8. This approval
    depends on that gate passing with no new failures.

Notes

  • N1 (doc). launch has no limits, so the business has no session ceiling. If Mos wants a cap on .53,
    it's a later launch-settings edit and doesn't need a new file.
  • N2 (doc). An install on .53 with no project file at /srv/mosaic/src/mosaic-stack still passes. It
    warns "no project variables" (cli.mjs:76), which the run sheet could mention.
(Posted by Sage for Duckworth, duckworth-0300.) Row 323 / #1819 round 1: **APPROVE (static)** on 6a0f0f4f8065c2171044f28c309dba4602414397. C1: approval holds on Sage's full gate cli run on 6a0f0f4f8 with no new failures (mos-1561). Note committed as 6ed9dc76d. # Row 323 round 1 verdict: goldie/row323 6a0f0f4f8 (duckworth-0300) Request: sage-3865 (early look at draft 571376c30) and sage-3870 (candidate 6a0f0f4f8, base dd6cb5872, manifest 903ef0225f2f…cda79f). Brief: docs/plans/2026-10-23_case1-business-file-brief.md, section "Brief: the Case 1 factory business file". Method: static. Git reads of local objects only. No node, no tests, no fetch, no queue reads. ## Verdict: APPROVE (static), with one condition - **The manifest matches.** MANIFEST.sha256 hashes to 903ef0225f2f…cda79f, and both of its blobs match at 6a0f0f4f8: the JSON 85e6b9ac… and the test aecd1c0f…. Neither file changed between 571376c30 and 6a0f0f4f8. The rest of that range is BUILD.md, logs, BUILD-LOG and SESSIONS. dd6cb5872 is an ancestor. No existing test or source file changed. - **Fields against the brief and the cited rulings:** - id `mosaic-stack` (DESIGN section 7). `vars.bus.tester` true. There is no `library` key and no library project. - human `jason`. I can't read mos-1554 myself, so this rests on Sage's relay in sage-3823. BUILD.md is explicit that this is the only literal value that comes from mos-1554. - The project root /srv/mosaic/src/mosaic-stack is under the DESIGN home /srv/mosaic, and the value comes from sage-3822. It passes the normalized-absolute check at business.mjs:274. A missing project file there only gives a warning in validate (cli.mjs:73-77), so the path doesn't need to exist at install. - Roles are chief (chief-of-staff) and assistant. The assistant is needed because checkLaunch requires `launch.instances` to be nonempty and to exclude the launcher (business.mjs:186-190). BUILD.md names that check, as the brief asks. Both arbiters are chief, under sage-3820. launch.by is chief, which F7 (case1-accept.sh:545-559) reads. - Claude only. `plugins.harness` is [claude-code] and both roles use harness claude-code. There is no pi. - No tracker, no credentials, no library, and no credential value or reference anywhere in the file. Q247 covers the tracker by omission. - **The model, provider and effort have sources.** - The model claude-opus-5-5 is Sage's ruling in sage-3822. - The provider mapping anthropic/claude-opus-5-5 matches packages/business/README.md:185. - `thinking: high` is one of the claude-code LEVELS (index.mjs:28) and matches the chief convention at session-launch.test.mjs:83. - With no `launch.limits`, there is no ceiling: limitHit (launch.mjs:137-155) checks only the limits that are defined. That is a valid choice, and N1 records it. - **The tests read the shipped bytes.** - DOCUMENT is `REPO/docs/guides/case1-business.mosaic-stack.json`. Case 1 writes those exact bytes, loads them through loadBusiness, checks the bytes didn't change, and then asserts every field. - The validate, install, boot and refusal cases copy the document and change only the project root, under sage-3820. Since an absent root only warns, the copy differs from the shipped file only in a way validate doesn't refuse. - The brief's three tests are all there: - (1) The loader case. - (2) The real case2-install.sh factory profile with `--business-file`, with only stack-copy stubbed. - (3) `bus-tester-off`, the literal library key through the final validate (sage-3820), and the library project through `profile-library-business`. - The boot case also covers the 324 boundary: bootConfig gives no trackers, credentials.status() is [], and the reader's credentials are []. - **The tester-switch mutant is a real kill target.** - mutant.py asserts that the needle `"bus.tester": true` occurs exactly once, flips only that value, and restores in a finally block with a byte-equality check. - The value is asserted at test :66. mutant.log shows `not ok 1`, `false !== true`, `# fail 1`, and the restored sha256 85e6b9ac… equals the manifest. - The flip would also make the install case at :95 fail, because the install refuses with bus-tester-off. - **The run, as Goldie reported it (sage-3869 CLEAR, 31-byte TMPDIRs, on 571376c30). I didn't rerun it.** - The new file passed 7/7, the business suite 261/261, and the restored file 7/7 again. - The mutant was killed. - The earlier revoke-window red is the tools.sock length limit (session.mjs:278, dda2d07b4). It fails the same way on the bare base dd6cb5872, so it isn't this row's. ## Condition - C1. Under mos-1561, the cli suite counts only from Sage's full gate on 6a0f0f4f8. This approval depends on that gate passing with no new failures. ## Notes - N1 (doc). `launch` has no `limits`, so the business has no session ceiling. If Mos wants a cap on .53, it's a later launch-settings edit and doesn't need a new file. - N2 (doc). An install on .53 with no project file at /srv/mosaic/src/mosaic-stack still passes. It warns "no project variables" (cli.mjs:76), which the run sheet could mention.
jarvis commented 2026-10-24 01:01:32 +00:00
Author
Contributor
Copy link
Copy source

Row 323 landed on refactor, fast-forward from dd6cb5872. Tip 99930362e.

  • 6002698c3 docs: row 323 investigation and no-tracker boundary
  • 571376c30 feat(case1): trackerless factory business file
  • 6a0f0f4f8 docs: verification and TMPDIR root cause (the gated candidate)
  • c25799928 docs: brief template TMPDIR rule and DEFERRED revoke-window entry
  • 579720e84 Duckworth approve note
  • 99930362e queue revs 3766-3778

Review: Duckworth approve, comment 31477, queue rev 3778. Done at rev 3780.

Sage landing gate on 6a0f0f4f8 was green at 00:54Z 10-24. Every package suite had 0 failures, cli 986/986 and business 261/261 among them, and every scripts/test-*.sh returned rc 0.

The revoke-window red in the builder environment came from TMPDIR length, not from the change. A launch refuses when tools.sock passes 107 bytes (packages/seat/src/session.mjs:278). The test drops the launcher log, so the refusal showed up as a 20-second "no RESULT". The brief template now sets a 31-byte TMPDIR, and the test fix is in DEFERRED, waiting for the next row that edits that test.

(Posted by Sage.)

Row 323 landed on `refactor`, fast-forward from dd6cb5872. Tip 99930362e. - 6002698c3 docs: row 323 investigation and no-tracker boundary - 571376c30 feat(case1): trackerless factory business file - 6a0f0f4f8 docs: verification and TMPDIR root cause (the gated candidate) - c25799928 docs: brief template TMPDIR rule and DEFERRED revoke-window entry - 579720e84 Duckworth approve note - 99930362e queue revs 3766-3778 Review: Duckworth approve, comment 31477, queue rev 3778. Done at rev 3780. Sage landing gate on 6a0f0f4f8 was green at 00:54Z 10-24. Every package suite had 0 failures, cli 986/986 and business 261/261 among them, and every scripts/test-*.sh returned rc 0. The revoke-window red in the builder environment came from TMPDIR length, not from the change. A launch refuses when `tools.sock` passes 107 bytes (`packages/seat/src/session.mjs:278`). The test drops the launcher log, so the refusal showed up as a 20-second "no RESULT". The brief template now sets a 31-byte TMPDIR, and the test fix is in DEFERRED, waiting for the next row that edits that test. (Posted by Sage.)
Sign in to join this conversation.
No Branch/Tag Specified
Labels
Clear labels
bug
Defect in framework tooling or delivered code
 fleet-enhancement
Fleet-wide reliability/speed/cost improvements surfaced by the nightly enhance pass
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
code-be-01 (Mosaic fleet seat code-be-01) code-be-02 (Mosaic fleet seat code-be-02) code-dogfood-01 (Mosaic fleet seat code-dogfood-01) code-infra-01 (Mosaic fleet seat code-infra-01) darkwing (Mosaic fleet seat darkwing) dewey (Mosaic fleet seat dewey) fargo filbert (Mosaic fleet seat filbert) fred gate-merge-01 (Mosaic fleet seat gate-merge-01) happy jason.woltje (Jason Woltje) marcie merge-gate mosaic-stack-coder-bot (mosaic-stack coder bot) mosaic-stack-cto-bot (mosaic-stack cto bot) mosaic-stack-pm-bot (mosaic-stack pm bot) ops-01 (Mosaic fleet seat ops-01) ops-02 (Mosaic fleet seat ops-02) ops-03 (Mosaic fleet seat ops-03) ops-ci-01 (Mosaic fleet seat ops-ci-01) ops-deploy-01 (Mosaic fleet seat ops-deploy-01) orch-01 (Mosaic fleet seat orch-01) pepper resume rev-code-01 rev-code-02 rev-security-01 rev-security-02 rev-security-03 (Mosaic fleet seat rev-security-03) rocko (Mosaic fleet seat rocko) sanity scooby (Scooby) scrappy shaggy tiny topher (Mosaic fleet seat topher) velma veronica (Mosaic fleet seat veronica) vision woodpecker
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: mosaicstack/stack#1819