fix(framework): detect installed tool drift (#1194) #1195

Merged

Mos merged 5 commits from fix/1194-framework-drift-detection into main 2026-08-13 10:43:12 +00:00

Conversation 4 Commits 5 Files Changed 10

+499 -5

5 Commits

Author	SHA1	Message	Date
coder-mos1	3d7953671c	fix(framework): treat an exact operator entry as a file, not a subtree (#1194) ... Ultron's REQUEST_CHANGES finding B1 on PR #1195: a bare operator manifest entry such as `tools/git` was matched as an implicit directory prefix, so declaring one directory silently exempted every framework file beneath it from drift detection. A drift blind spot is exactly what #1194 exists to close. An exact entry is now a file carve-out. Subtree ownership must be declared explicitly as `dir/**`. The same rule is applied on both sides of the Bash/TS parity boundary: `_mo_matches` in tools/_lib/manifest.sh drops its prefix clause, and `resolveOwnership` in src/framework/manifest.ts routes operator globs through a new `matchesOperatorGlob` that requires equality when the pattern has no `*`. Verified by measurement rather than by report. The new regression declares operator entry `tools/git`, drifts `tools/git/guard.sh` beneath it, and asserts the checker exits 1 with `STALE git/guard.sh`: at c59a55f8 (broken): FAILED (failures=1) -- rc 0, summary `stale=0` at this tree (fixed): Ran 6 tests, OK The failure at the old head is the point. A fixture that passes on the broken tree measures nothing, and this file's neighbour (#1174) has spent ten rounds proving it. Also two shellcheck-only mechanical fixes in manifest.sh: SC1087 (brace the expansion before `[`) and SC2155 (split `local` from the assignment so the return status is not masked). Not validated here: the full package typecheck could not be run in this workspace -- node_modules is absent and the host filesystem is full. CI covers it. Reviewed-by: gate-ultron-01 (finding B1)	2026-08-13 05:28:05 -05:00
coder3	c59a55f8f2	fix(framework): classify BusyBox timeout status (#1194)	2026-08-13 02:50:53 -05:00
coder3	f01be762af	fix(framework): support portable doctor timeout (#1194)	2026-08-13 02:36:33 -05:00
coder3	8b97d3ee7b	fix(framework): fail closed on drift blind spots (#1194)	2026-08-13 02:25:21 -05:00
coder3	f9e1be5391	fix(framework): detect installed tool drift (#1194)	2026-08-13 01:42:32 -05:00