fleet: put the bootstrapped Node on PANE_PATH (#1256) #1258

Merged

gate-merge-01 merged 4 commits from fix/1256-fleet-pane-path-node into next 2026-08-20 18:31:31 +00:00

Conversation 6 Commits 4 Files Changed 2

+97

4 Commits

Author	SHA1	Message	Date
ops-03	ce765fa70e	merge: absorb next into fix/1256-fleet-pane-path-node — bring image pin (cb9a0d1) and 4 days of base drift; no functional change to branch content	2026-08-20 11:20:34 -05:00
fred	6dc35e5bf2	fleet(test): attribute FIRST-position to the fixture, not to the fix ... Comment-only. The colon-padding note said the anchored regex 'rejects the directory in FIRST position — which is exactly where the fix puts it'. True in this fixture, which runs env -i with no MOSAIC_RUNTIME_BIN so the bootstrap directory leads, but stated as a property of the fix. In general the directory sits second, after MOSAIC_RUNTIME_BIN, and it reads as a contradiction of the source comment corrected in c7ee3cb. Found in review by rhodey, who also noted the same sentence is live in the PR description. No executable line changed.	2026-08-16 17:20:01 -05:00
fred	c7ee3cb5ce	fix(fleet): correct ordering claim in pane-PATH comment ... The comment said the bootstrapped-node candidate 'is first'; it is inserted second, after MOSAIC_RUNTIME_BIN. The ordering itself is correct — an explicit override should outrank a bootstrap — so this is a wording defect in a load-bearing comment, not a behaviour change. No executable line is touched. Found in review by mos-claude (review 166).	2026-08-16 17:01:18 -05:00
fred	a972249a2b	fleet: put the bootstrapped Node on PANE_PATH (#1256) ... On a host with no system Node, tools/install.sh bootstraps one into ~/.mosaic/node/current/bin and records it in ~/.profile. The fleet unit runs `env -i ... bash --noprofile --norc`, so ~/.profile is never read — that is deliberate — and _build_runtime_bin_prefix did not name the directory itself. Runtime binaries are `#!/usr/bin/env node`, so the pane resolved `mosaic` and then died on `env: 'node': No such file or directory` after an install that reported success. Measured on a greenfield VM. The existing `npm config get prefix` branch cannot cover it: that reports a package prefix (~/.npm-global), never a Node runtime directory. The test case asserts the property rather than the string — it runs the pane for real with a Node-shebang `mosaic` and requires the pane to have executed. A PATH substring check would pass on a fix that put the directory in the wrong position. Red without the launcher change, green with it, rest of the suite unaffected.	2026-08-16 15:02:04 -05:00