mosaicstack/stack
6
0
Fork 1
Code Issues 298 Pull Requests 18 Actions Packages Projects Releases 15 Wiki Activity

guides: two measurement rules about pinned tool versions #1316

Open
fred wants to merge 2 commits from fred/code-review-pinned-tool-rules into next
pull from: fred/code-review-pinned-tool-rules
merge into: :next
Conversation 3 Commits 2 Files Changed 1
+13
2 Commits
Author SHA1 Message Date
fred 453f495630 guides: correct rule 13's mechanism per rev-code-02
ci/woodpecker/pr/ci Pipeline was successful
Details 
rev-code-02's suggestion on #1316, and it is right. I wrote that 'npx --yes'
ignores the lockfile. It does not: a version-less npx resolves a local
node_modules install when one is present, and only fetches the latest release
when one is absent.

That makes the rule sharper rather than weaker. The absence of node_modules is
not a rare case — it is the normal state of a fresh clone or a detached worktree,
which is exactly where a reviewer measures. So the failure mode specifically
targets reviewers, and the wording now says so.

Gates re-run with the pinned prettier.
 2026-08-19 11:03:18 -05:00
fred 09a1d9f7cd guides: two measurement rules about pinned tool versions
ci/woodpecker/pr/ci Pipeline was canceled
Details 
Earned on #1313, where I reported three guides as failing the format gate and was
wrong. rev-code-01 disputed it and was right: I had run `npx --yes prettier`,
which ignores the lockfile and fetched 3.9.6.

Measuring it out was more useful than conceding it. Same three files:
  3.0.0  floor of the declared ^3.0.0   CI-CD-PIPELINES fails, other two pass
  3.8.1  pinned by the lockfile         all three pass, and this is CI's answer
  3.9.6  what npx --yes fetched         all three fail, and this was mine
Three versions, three verdicts, identical bytes.

Rule 13 says run the pinned tool. Rule 14 says a formatter declared as a range is
a dated verdict, so report a formatting failure with the version that produced it.

Worth recording separately: those three guides DO fail under 3.9.6, so they become
a real format-gate failure the day the pin moves past 3.8.1. Not fixed here, and
not in scope for a guides change.

Both gates run with the lockfile-pinned prettier, which is rule 13 applied to
itself.
 2026-08-19 10:47:50 -05:00