fix(git-tools): issue-view shows comment bodies and names the real tea failure (#1357)

Conversation 1 Commits 2 Files Changed 9

+247 -12

2 Commits

Author	SHA1	Message	Date
fred	62321700a3	fix(git): review follow-ups for #1357 (S1, S2, indent) ci/woodpecker/pr/ci Pipeline was successful Details S1: get_gitea_login_for_repo_override() now distinguishes "tea is not installed" from "no tea login named X exists", mirroring the host path. The old message diagnosed a cause that was never checked and pointed at seat-logins.sh, which cannot run without tea. Branch 6 in test-gitea-login-resolution.sh pins it (tea removed from PATH); reverting the fix fails that branch. S2: issue-list/pr-list/pr-view override-path error now points at the lines above for the cause instead of suggesting a default tea login. verify-release.mjs: indent of the #1356 test line fixed (cosmetic).	2026-08-21 18:12:12 -05:00
fred	341be60723	fix(git-tools): issue-view shows comment bodies and names the real tea failure (#1357 ) Four defects in issue-view.sh, each pinned by the new hermetic suite test-issue-view-comments.sh (mock tea + curl, sandboxed repo): F1 tea exits 1 in any repo with extensions.worktreeconfig=true. The wrapper now names that as a git-config condition and falls back to the API. F2 The API fallback dumped raw issue JSON, which carries only a comment COUNT. It now fetches /comments and renders issue + comment bodies. F3 The tea path never passed --comments, so comment bodies were never shown non-interactively. It now does. F4 Every tea failure printed the REVOKED OR STALE TOKEN note. The wrapper now relays tea's own error line and only hints at credentials when tea did. The suite joins ci.yml and the verify-release canonical list (mirror test). Closes #1357	2026-08-21 18:06:06 -05:00

Author

SHA1

Message

Date

fred

62321700a3

fix(git): review follow-ups for #1357 (S1, S2, indent)

ci/woodpecker/pr/ci Pipeline was successful

Details

S1: get_gitea_login_for_repo_override() now distinguishes "tea is not
installed" from "no tea login named X exists", mirroring the host path.
The old message diagnosed a cause that was never checked and pointed at
seat-logins.sh, which cannot run without tea. Branch 6 in
test-gitea-login-resolution.sh pins it (tea removed from PATH); reverting
the fix fails that branch.

S2: issue-list/pr-list/pr-view override-path error now points at the
lines above for the cause instead of suggesting a default tea login.

verify-release.mjs: indent of the #1356 test line fixed (cosmetic).

2026-08-21 18:12:12 -05:00

fred

341be60723

fix(git-tools): issue-view shows comment bodies and names the real tea failure (#1357 )

Four defects in issue-view.sh, each pinned by the new hermetic suite
test-issue-view-comments.sh (mock tea + curl, sandboxed repo):

F1  tea exits 1 in any repo with extensions.worktreeconfig=true. The wrapper
    now names that as a git-config condition and falls back to the API.
F2  The API fallback dumped raw issue JSON, which carries only a comment
    COUNT. It now fetches /comments and renders issue + comment bodies.
F3  The tea path never passed --comments, so comment bodies were never shown
    non-interactively. It now does.
F4  Every tea failure printed the REVOKED OR STALE TOKEN note. The wrapper now
    relays tea's own error line and only hints at credentials when tea did.

The suite joins ci.yml and the verify-release canonical list (mirror test).

Closes #1357

2026-08-21 18:06:06 -05:00

fix(git-tools): issue-view shows comment bodies and names the real tea failure (#1357) #1365