mosaicstack/stack
19
0
Fork 1
Code Issues 335 Pull Requests 16 Actions Packages Projects Releases 15 Wiki Activity

framework tools/git: R1/R4 contract across all 22 wrappers (P1) #1464

Open
marcie wants to merge 17 commits from mosaic-cli-p1-wrappers into mosaic-cli-p0
pull from: mosaic-cli-p1-wrappers
merge into: :mosaic-cli-p0
Conversation 0 Commits 17 Files Changed 36
+2483 -132
marcie commented 2026-08-28 23:13:35 +00:00
Member
Copy Link
Copy Source

Completes the wrapper-family remediation (P1; Jason remediation list 2026-08-28). All 22 agent-facing wrappers now share the usage-error contract:

  • Usage errors print to stderr and exit 2 (unknown option, missing required, value-less flags, and semantic invocation checks: mutual exclusion, integer/format validation, title-or-issue). Provider, credential, and verification failures exit 1; gh failures on GitHub paths are normalized to 1 (gh's own usage errors exit 2 and would collide).
  • Comment carriers (issue-close, issue-reopen, pr-close, pr-review) take -b/--body canonical with -c/--comment alias, matching issue-comment and the create/edit family.
  • lane-brief: getopts replaced with while/case carrying R2 long-flag aliases (--repo --milestone --label/--labels --login --limit); its login-resolution failure reclassified exit 2 -> 1 (credential class).
  • Every conversion ships an enrolled usage-contract suite (CI population 88; enumeration guard OK). Template bug fixed across all suites (expect_stderr unbound $desc).
  • Verification: all suites pass in both the brain tree and this worktree. Three pre-existing suites (pr-review-gitea-comment, issue-create-interactive-auth, pr-edit) are tty/stdout-sensitive: stash-verified identical failures on clean origin/next under redirected stdout; CI passes them (green pipeline 2942/1 on the base PR).

Stacked on #1462 (merge that first).

Completes the wrapper-family remediation (P1; Jason remediation list 2026-08-28). All 22 agent-facing wrappers now share the usage-error contract: - Usage errors print to stderr and exit 2 (unknown option, missing required, value-less flags, and semantic invocation checks: mutual exclusion, integer/format validation, title-or-issue). Provider, credential, and verification failures exit 1; gh failures on GitHub paths are normalized to 1 (gh's own usage errors exit 2 and would collide). - Comment carriers (issue-close, issue-reopen, pr-close, pr-review) take -b/--body canonical with -c/--comment alias, matching issue-comment and the create/edit family. - lane-brief: getopts replaced with while/case carrying R2 long-flag aliases (--repo --milestone --label/--labels --login --limit); its login-resolution failure reclassified exit 2 -> 1 (credential class). - Every conversion ships an enrolled usage-contract suite (CI population 88; enumeration guard OK). Template bug fixed across all suites (expect_stderr unbound $desc). - Verification: all suites pass in both the brain tree and this worktree. Three pre-existing suites (pr-review-gitea-comment, issue-create-interactive-auth, pr-edit) are tty/stdout-sensitive: stash-verified identical failures on clean origin/next under redirected stdout; CI passes them (green pipeline 2942/1 on the base PR). Stacked on #1462 (merge that first).
marcie added 11 commits 2026-08-28 23:13:36 +00:00
framework tools/git: issue-close R1/R4 conversion (P1 first wrapper) 7a38eed18a 
Same contract as issue-comment (PR #1462): -b/--body canonical comment
flag with -c/--comment alias; usage errors stderr + exit 2 (unknown
option, missing -i, value-less flags); provider failures normalized to
exit 1 on the GitHub path (gh's own usage errors exit 2 and would
collide with the reserved status).

New suite test-issue-close-usage-contract.sh, enrolled in
framework-shell CI (enumeration guard OK, population 74). Probe
assertions split: parser arms must contact zero providers; sandbox arms
may issue detection reads only (tea login list), never gh/curl.
Existing fail-closed suite still green. Mirrored to the brain tree.
framework tools/git: issue-reopen + pr-close R1/R4 conversions (P1) 7e4de270dc 
Same contract as issue-close (7a38eed1): -b/--body canonical comment
flag with -c/--comment alias; usage errors stderr + exit 2 (unknown
option, missing required, value-less flags); GitHub-path provider
failures normalized to exit 1.

Both new suites enrolled in framework-shell CI (enumeration guard OK,
population 76). pr-close's suite uses FAILING provider stubs (exit 99):
its API fallback treats a successful curl as a closed PR, so exit-0
stubs let sandbox arms succeed (measured); post-sandbox contact
assertions are correspondingly scoped, parser arms remain zero-contact.
Mirrored to the brain tree; all usage-contract suites green in both.
framework tools/git: pr-review R1/R4 conversion (P1) 31a447a46f 
-b/--body canonical review comment flag with -c/--comment alias; usage
errors stderr + exit 2 (unknown option, missing -n/-a, value-less
flags including -a/-l/-r/-H, and the semantic check: request-changes
without a comment). Existing pr-review suites still green.

Suite enrolled in framework-shell CI (enumeration guard OK); mirrored
to the brain tree.
framework tools/git: issue-edit R1/R4 conversion (P1) dff486b43a 
issue-edit already used long-flag-first parsing; this adds the rc=2
usage-error contract (unknown option, missing -i, value-less flags
across all five options), the exit-code line in help, and the enrolled
usage-contract suite (population 78). Mirrored to the brain tree.
framework tools/git: issue-create R1/R4 conversion + template bug fix (P1) c43b1a1293 
- issue-create: usage() default exit is now 2 (usage-error contract);
  unknown option, missing title, and value-less -t/-b/-l/-m land there
  with stderr messages; exit-code line added to help. Interactive
  -i/--interactive unchanged (boolean, no value arm). Existing
  body-safety and interactive-auth suites still green.
- Template bug fixed across ALL seven usage-contract suites:
  expect_stderr referenced an unbound $desc (should be $2); latent
  until issue-create's capitalized 'Unknown option' missed the
  case-sensitive grep and fired it. All seven re-verified green.
- Suite enrolled (population 79); mirrored to the brain tree.
framework tools/git: pr-edit R1/R4 conversion (P1) b8b396d9f5 
usage() default exit 2; semantic invocation checks (mutual exclusion,
integer/format validation, missing edit option, --login-only-for-Gitea)
exit 2; value guards on all value-taking options; existing pr-edit
suite still green; usage-contract suite enrolled (population 80);
mirrored to the brain tree.
framework tools/git: pr-create R1/R4 conversion (P1) cf971f93f8 
usage() default exit 2 (usage-error contract); value guards on all
seven value-taking options; -d/--draft stays boolean. Existing
fallback-default-base suite green (29/29). Usage-contract suite
enrolled (population 81); mirrored to the brain tree.
framework tools/git: issue-assign R1/R4 conversion (P1) 0467d28191 
usage() default exit 2; value guards on -i/-a/-l/-m; -r stays boolean.
Suite enrolled (population 82); mirrored to the brain tree.
framework tools/git: milestone-close, milestone-list, issue-view R1/R4 conversions (P1) bb23cb6feb 
usage_error contract (stderr + exit 2) with value guards on every
value-taking option and the missing-required checks (milestone-close
-t, issue-view -i). Three suites enrolled (population 85); green in
both trees; mirrored to the brain tree.
framework tools/git: issue-list, milestone-create, lane-brief R1/R4 conversions (P1 complete) c8b4af59c3 
- issue-list + milestone-create: usage() default exit 2, value guards,
  missing-title via usage_error.
- lane-brief: getopts replaced with a while/case parser carrying R2
  long-flag aliases (--repo --milestone --label/--labels --login
  --limit) beside the short forms; login-resolution failure reclassified
  from exit 2 to exit 1 (credential class, not an invocation defect).
- Three suites enrolled (population 88); lane-brief pr-linkage suite
  still ALL PASS; green in both trees; mirrored to the brain tree.

With this, every agent-facing wrapper in tools/git carries the R1/R4
usage-error contract (22/22 non-guard wrappers; guards keep their own
contracts).
framework tools/git: restore exec bit on test-lane-brief-pr-linkage.sh (stash cycle side effect)
ci/woodpecker/pr/ci Pipeline was canceled
Details
e15e7fe822
marcie added 1 commit 2026-08-28 23:15:39 +00:00
framework tools/git: pr-review validates --action before provider contact (codex blocker on PR #1464)
ci/woodpecker/pr/ci Pipeline was canceled
Details
da4a5b2f19 
An unsupported --action previously reached platform detection (and
could touch the provider) before failing with a provider-class status;
comment-without-body exited 1 mid-switch. Both now fail fast with
usage_error (rc 2, stderr) immediately after argument parsing. Test
arms added including the zero-provider-contact assertion for
invalid-action runs.
marcie added 1 commit 2026-08-28 23:18:34 +00:00
framework tools/git: pr-review body-required actions fail fast (codex suggestion on PR #1464)
ci/woodpecker/pr/ci Pipeline was canceled
Details
ca91586222 
request-changes and comment both validate their required body
immediately after argument parsing (rc 2, stderr, zero provider
contact). The repo-host-override suite's action-message expectation
updated to the new wording; suite green.
marcie added 1 commit 2026-08-28 23:26:57 +00:00
framework tools/git: strict value guards + provider-failure normalization family-wide (codex blockers on PR #1464)
ci/woodpecker/pr/ci Pipeline is pending
Details
d326e6572a 
- Value guards now reject option-like values: --anything always, and
  single-dash flag shapes (-h, -i). Previously -b --help consumed
  --help as the body and performed the write (codex example:
  issue-close -i --help proceeding to 'Closed GitHub issue #--help').
  Multi-char dash-leading text (-start of a list) stays a legal value.
- Every remaining direct provider exec (gh/tea/CMD arrays across
  issue-create/edit/assign/list/view, milestone-*, pr-create/edit,
  pr-close, issue-close/reopen) wrapped with rc capture and normalized
  to exit 1 with a stderr message — provider exit 2 no longer collides
  with the reserved usage-error status.
- All 16 usage-contract suites gained option-like and short-flag arms
  (16/16 green). Existing suites re-verified; test-pr-edit and
  test-issue-create-interactive-auth fail identically with these
  changes stashed (environment-coupled, not regressions; documented).
marcie added 1 commit 2026-08-28 23:29:13 +00:00
framework tools/git: guards reject all option-shaped values; usage_error routes usage to stderr (codex round on PR #1464)
ci/woodpecker/pr/ci Pipeline is pending
Details
90f982afaa 
- Option-like value = any token starting with '-' followed by an
  alphanumeric (-h, -ab, --help); multi-character short clusters were
  still accepted (codex blocker). Bare '-' is reserved (future stdin).
- usage_error now prints the usage text to stderr as well (codex
  should-fix): usage output belonged to stdout only on the help path.
- 16/16 usage-contract suites green.
marcie added 1 commit 2026-08-28 23:32:05 +00:00
framework tools/git: lookup-pipeline pipefail + provider-normalization test arm (codex round on PR #1464)
ci/woodpecker/pr/ci Pipeline was canceled
Details
7db25b8820 
- issue-assign + milestone-create: set -o pipefail; the remove-assignee
  lookup pipeline now fails loud on provider failure instead of reading
  an empty result as a silent no-assignees skip (codex blocker). A
  successful lookup with zero assignees still skips the edit.
- test-issue-assign-usage-contract: 6b arm proves provider-exit
  normalization end to end (gh stub exiting 2 on issue edit -> wrapper
  exit 1 with the normalized stderr message; codex should-fix).
- Battery: 23/23 suites green.
marcie added 1 commit 2026-08-28 23:34:20 +00:00
framework tools/git: provider-normalization arms on issue-close and milestone-list (codex should-fix)
ci/woodpecker/pr/ci Pipeline was successful
Details
34e56f242e 
gh stub exiting 2 on the close/api path -> wrapper exit 1 with the
normalized stderr message; mirrors the issue-assign 6b arm. All
touched suites green; brain mirror updated.
All checks were successful
ci/woodpecker/pr/ci Pipeline was successful
Details
You are not authorized to merge this pull request.
This pull request can be merged automatically.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin mosaic-cli-p1-wrappers:mosaic-cli-p1-wrappers
git checkout mosaic-cli-p1-wrappers
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Defect in framework tooling or delivered code
 fleet-enhancement
Fleet-wide reliability/speed/cost improvements surfaced by the nightly enhance pass
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
code-be-01 (Mosaic fleet seat code-be-01) code-be-02 (Mosaic fleet seat code-be-02) code-infra-01 (Mosaic fleet seat code-infra-01) fargo fred gate-merge-01 (Mosaic fleet seat gate-merge-01) happy jason.woltje (Jason Woltje) marcie merge-gate ops-01 (Mosaic fleet seat ops-01) ops-02 (Mosaic fleet seat ops-02) ops-03 (Mosaic fleet seat ops-03) ops-ci-01 (Mosaic fleet seat ops-ci-01) ops-deploy-01 (Mosaic fleet seat ops-deploy-01) orch-01 (Mosaic fleet seat orch-01) pepper resume rev-code-01 rev-code-02 rev-security-01 rev-security-02 rev-security-03 (Mosaic fleet seat rev-security-03) sanity scooby (Scooby) scrappy shaggy tiny velma veronica (Mosaic fleet seat veronica) vision woodpecker
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: mosaicstack/stack#1464