mosaicstack/stack
19
0
Fork 1
Code Issues 335 Pull Requests 14 Actions Packages Projects Releases 15 Wiki Activity

fix(cli): remove side-effect from agent:end state updater (#133) #147

Merged
jason.woltje merged 3 commits from fix/tui-agent-end-state into main 2026-03-15 19:09:14 +00:00
Conversation 0 Commits 3 Files Changed 4
+293 -31
jason.woltje commented 2026-03-15 19:09:00 +00:00
Owner
Copy Link
Copy Source

Summary

  • Fixes React rule violation in Socket.IO handler in TUI app
  • The original code called (a side effect) inside a state updater, which violates React's requirement that state updaters be pure functions
  • Fix: use a to track current stream text so can read the final value and update state outside any updater callback

Changes

  • : Added to mirror state; refactored , , and handlers to use ref-based approach; now performs all state updates at the top level without nesting

Test plan

  • TUI connects to gateway and streams agent responses correctly
  • Streaming text accumulates and is committed to messages list on
  • Model switching () and provider switching () work as before
  • Session management (conversationId tracking) works as before

Closes #133

🤖 Generated with Claude Code

## Summary - Fixes React rule violation in Socket.IO handler in TUI app - The original code called (a side effect) inside a state updater, which violates React's requirement that state updaters be pure functions - Fix: use a to track current stream text so can read the final value and update state outside any updater callback ## Changes - : Added to mirror state; refactored , , and handlers to use ref-based approach; now performs all state updates at the top level without nesting ## Test plan - [ ] TUI connects to gateway and streams agent responses correctly - [ ] Streaming text accumulates and is committed to messages list on - [ ] Model switching () and provider switching () work as before - [ ] Session management (conversationId tracking) works as before Closes #133 🤖 Generated with [Claude Code](https://claude.com/claude-code)
jason.woltje added 3 commits 2026-03-15 19:09:01 +00:00
fix(cli): remove side-effect from agent:end state updater (#133) 5a64b90910 
Use a ref to track current stream text so agent:end can commit the
final message without calling setMessages inside a setCurrentStreamText
updater function, which violates React's rule that state updaters must
be pure.

Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
style(gateway): fix prettier formatting in agent.service and git-tools 9a9bf9525f 
Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
style(gateway): fix prettier formatting in coord.controller
ci/woodpecker/push/ci Pipeline failed
Details
8820299301 
Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
jason.woltje merged commit 76abf11eba into main 2026-03-15 19:09:14 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Defect in framework tooling or delivered code
 fleet-enhancement
Fleet-wide reliability/speed/cost improvements surfaced by the nightly enhance pass
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
code-be-01 (Mosaic fleet seat code-be-01) code-be-02 (Mosaic fleet seat code-be-02) code-infra-01 (Mosaic fleet seat code-infra-01) fargo fred gate-merge-01 (Mosaic fleet seat gate-merge-01) happy jason.woltje (Jason Woltje) marcie merge-gate ops-01 (Mosaic fleet seat ops-01) ops-02 (Mosaic fleet seat ops-02) ops-03 (Mosaic fleet seat ops-03) ops-ci-01 (Mosaic fleet seat ops-ci-01) ops-deploy-01 (Mosaic fleet seat ops-deploy-01) orch-01 (Mosaic fleet seat orch-01) pepper resume rev-code-01 rev-code-02 rev-security-01 rev-security-02 rev-security-03 (Mosaic fleet seat rev-security-03) sanity scooby (Scooby) scrappy shaggy tiny velma veronica (Mosaic fleet seat veronica) vision woodpecker
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: mosaicstack/stack#147