fix(webui): sp17 one field of one workflow step saves in three clicks, one workflow editor (#1873) #1982

Merged
jason.woltje merged 5 commits from sp17-workflow-clicks into refactor 2026-11-16 18:40:01 +00:00
Owner

What changes

Changing one field of one workflow step and saving it takes 3 clicks at 1440 wide, down from 6. At 390 it takes 4, down from 7. From the organization's own page it takes 2.

  • Each workflow on the organization page's Workflows card lists its steps as links. A step link opens that step's form on the graph page with the caret in the title and Save in view.
  • One editor. The old form editor on the organization page is removed. The graph page covers every field it changed.
  • A Save in flight holds the workflow poll, so a poll no longer puts the old step back over a saved one.
  • An edit is kept, and named on the card, through a bus restart.
  • No edit is dropped without a word: an open edit goes into the pending workflow when another step is opened, and Save with a new step typed in the add form says it is not added yet.

How

  • packages/webui/src/public/workflows.js, workflows.css, packs.css (old editor rules removed), bus.js (2 lines, the landing hook). No server change, no route, no schema.
  • Each organization counts its workflow writes. A read that began before a write ended, or answers during one, is dropped.

Tests

  • workflows-browser.test.mjs, packs-workflows-browser.test.mjs, org-live-edit-browser.test.mjs. The click test records every trusted click at 1440 and 390 and checks the count and the sequence. The poll test is red without the fix. The org-live-edit-browser "E2E6 P2-2" race is fixed here: the test now waits for the autonomy read too.
  • Lane gate on 370048f22: 192 webui files, each alone, 1561 pass, 0 fail, 4 skipped (org-quick-live).
  • Lead check after rebase onto ff096afa2, on 6fe3625fa: 9 files, 106 pass, 0 fail. The rebase range-diff shows all five commits unchanged.

Review

Three rounds by fresh claude-opus-5-5 reviewers. Rounds 1 and 2 asked for changes (two findings, then one), each fixed with a test that failed first. Round 3 approved.

Left for later

  • Save closes an add form in which only the state was changed, without saying so. Such a step could never be added.
  • A card step link followed while the add form is open announces nothing.
  • The Restart bus button has no draft guard. The edit is kept and named through the restart.
  • A parked edit with a blank title draws an empty step box.
  • MosaicWorkflows.section() is now a stub that workspace.js still calls.
  • Workflow branches, triggers and gates are not part of this change.
## What changes Changing one field of one workflow step and saving it takes 3 clicks at 1440 wide, down from 6. At 390 it takes 4, down from 7. From the organization's own page it takes 2. - Each workflow on the organization page's Workflows card lists its steps as links. A step link opens that step's form on the graph page with the caret in the title and Save in view. - One editor. The old form editor on the organization page is removed. The graph page covers every field it changed. - A Save in flight holds the workflow poll, so a poll no longer puts the old step back over a saved one. - An edit is kept, and named on the card, through a bus restart. - No edit is dropped without a word: an open edit goes into the pending workflow when another step is opened, and Save with a new step typed in the add form says it is not added yet. ## How - `packages/webui/src/public/workflows.js`, `workflows.css`, `packs.css` (old editor rules removed), `bus.js` (2 lines, the landing hook). No server change, no route, no schema. - Each organization counts its workflow writes. A read that began before a write ended, or answers during one, is dropped. ## Tests - `workflows-browser.test.mjs`, `packs-workflows-browser.test.mjs`, `org-live-edit-browser.test.mjs`. The click test records every trusted click at 1440 and 390 and checks the count and the sequence. The poll test is red without the fix. The `org-live-edit-browser` "E2E6 P2-2" race is fixed here: the test now waits for the autonomy read too. - Lane gate on 370048f22: 192 webui files, each alone, 1561 pass, 0 fail, 4 skipped (`org-quick-live`). - Lead check after rebase onto ff096afa2, on 6fe3625fa: 9 files, 106 pass, 0 fail. The rebase range-diff shows all five commits unchanged. ## Review Three rounds by fresh claude-opus-5-5 reviewers. Rounds 1 and 2 asked for changes (two findings, then one), each fixed with a test that failed first. Round 3 approved. ## Left for later - Save closes an add form in which only the state was changed, without saying so. Such a step could never be added. - A card step link followed while the add form is open announces nothing. - The Restart bus button has no draft guard. The edit is kept and named through the restart. - A parked edit with a blank title draws an empty step box. - `MosaicWorkflows.section()` is now a stub that workspace.js still calls. - Workflow branches, triggers and gates are not part of this change.
jason.woltje added 5 commits 2026-11-16 18:39:58 +00:00
jason.woltje merged commit 6fe3625fae into refactor 2026-11-16 18:40:01 +00:00
Sign in to join this conversation.