fix(webui): Stop in the agent drawer keeps its state per agent and says plainly when an organization is archived or unavailable (#1873) #1993

Merged
jason.woltje merged 2 commits from sp20-drawer-stop into refactor 2026-11-18 20:37:43 +00:00
Owner

What changes

Two gaps in Stop in the agent drawer, both fixed the way #1990 fixed them for Restart. No server file changes and no new route.

  • Archived or unavailable organization. Stop said "Outcome unknown". It now says Not stopped: <org> is archived, so its agents are not changed. Nothing changed. or Not stopped: <org> is not available to this Console. Nothing changed. Stop and Restart read these lines from one helper.
  • Stop state per agent. Stop kept one shared state for the page. A question, a cancel or a finished Stop in one drawer could wipe another drawer's running Stop. Each agent's Stop now keeps its own state. Restart's behaviour and tests are unchanged.

How

  • packages/webui/src/public/workspace.js.
  • Tests: agent-drawer-browser.

Tests

  • Four new tests, each red on the base, plus one from the review round: two Stops running at once, and a successful Stop.
  • Lane gate on the commit before the last rebase: 198 webui test files, 1688 pass, 0 fail, 4 skipped (org-quick-live).
  • Lead check after the rebase, in a clean environment: 8 browser and drawer test files, 111 pass, 0 fail.

Review

One fresh claude-opus-5-5 reviewer: approve, with one P3 (no test had two Stops running at once, and none covered a successful Stop). The second commit adds that test and changes no behaviour. No reviewer read it.

Left for later

Nothing.

## What changes Two gaps in Stop in the agent drawer, both fixed the way #1990 fixed them for Restart. No server file changes and no new route. - **Archived or unavailable organization.** Stop said "Outcome unknown". It now says `Not stopped: <org> is archived, so its agents are not changed. Nothing changed.` or `Not stopped: <org> is not available to this Console. Nothing changed.` Stop and Restart read these lines from one helper. - **Stop state per agent.** Stop kept one shared state for the page. A question, a cancel or a finished Stop in one drawer could wipe another drawer's running Stop. Each agent's Stop now keeps its own state. Restart's behaviour and tests are unchanged. ## How - `packages/webui/src/public/workspace.js`. - Tests: `agent-drawer-browser`. ## Tests - Four new tests, each red on the base, plus one from the review round: two Stops running at once, and a successful Stop. - Lane gate on the commit before the last rebase: 198 webui test files, 1688 pass, 0 fail, 4 skipped (`org-quick-live`). - Lead check after the rebase, in a clean environment: 8 browser and drawer test files, 111 pass, 0 fail. ## Review One fresh claude-opus-5-5 reviewer: approve, with one P3 (no test had two Stops running at once, and none covered a successful Stop). The second commit adds that test and changes no behaviour. No reviewer read it. ## Left for later Nothing.
jason.woltje added 2 commits 2026-11-18 20:37:36 +00:00
jason.woltje merged commit e1642be760 into refactor 2026-11-18 20:37:43 +00:00
Sign in to join this conversation.