fix(bus): a bus that picked up the shared proxy says on its catalogue that a restart is needed to start agents on these models (#1873) #1998

Merged
jason.woltje merged 2 commits from pickup-launch into refactor 2026-11-19 19:03:42 +00:00
Owner

What changes

A running organization bus picks up the shared model proxy without a restart (lane proxy-pickup). It then serves accounts and the model catalogue, but an agent launch on those models still refuses model-provider-unavailable, and the Routing panel gave no reason. This change says why.

  • While a bus holds a proxy client it picked up after boot, and the catalogue reads ready, the catalogue answer carries one more notice, after its own: "Restart this organization to start agents on these models."
  • No notice on an unavailable catalogue (a fence, a key collision, a down proxy): a restart does not fix those. No notice on a bus that booted with the proxy, on a disabled catalogue, after refused settings or after a dropped client.
  • The launch refusal is unchanged.

One function, explainCatalogue in packages/bus/src/runtime.mjs, and one new test file. The Routing panel already renders catalogue.notices, so there is no webui change.

No bus schema change, no new verb, no new refusal code, no grant or role change. Nothing under roles/, contracts/ or packages/queue/.

Why a launch still needs a restart

A launch on a late client needs what only the start path builds: the key issuer (ModelKeys) with every agent registered, the sweep timer, the organization and authority wrappers that revoke keys on fire and delete, and the proxy in the host launcher's boot config. Building those late needs a new host op or a change to the Console launcher's start path, and a rule for what a dropped proxy does to live keys. The lane report lists the smallest change for that. It waits for an owner ruling.

Tests

  • packages/bus/tests/pickup-launch.test.mjs, 8 tests: the notice on a picked-up bus and on the bus that ran init; its order after the catalogue's own notices; no notice on a boot-proxy bus, a disabled catalogue or a fenced one, and the notice back once the fence is gone; refused settings and a dropped client keep their cause line; a real launcher refuses as before with one admission answer; key scan of stderr, answers, the launch log and files.
  • Mutants on the final version: 9 of 10 killed. The survivor differs only on a disabled catalogue, which no reader passes through.
  • Lane gate on 196505e6e: 415 files (bus, model-proxy, webui), 3975 pass, 0 fail, 5 skipped (4 org-quick-live, 1 triage-settings-browser).
  • Lead check in a clean environment: 115 test files that the diff touches or that import the changed source, 1326 pass, 0 fail, 0 skipped.

Review

One fresh claude-opus-5-5 reviewer. No P1. One P2: the notice also showed on a fenced catalogue, where a restart does not help. Fixed in the second commit with the change the reviewer proposed (notice only when ready), and the fenced test now asserts no notice. Two P3, both fixed. The Lead read the fix diff. No second re-check was run for it.

Left for later

  • The launch log line on a picked-up bus still names only model-provider-unavailable.
  • The dashboard button reads "Restart bus" while the notice says "Restart this organization".
  • A bus that booted with a proxy whose key reconcile failed shows a ready catalogue and refuses launches with no notice. This predates the lane.
  • Launching on a picked-up proxy without a restart.
## What changes A running organization bus picks up the shared model proxy without a restart (lane proxy-pickup). It then serves accounts and the model catalogue, but an agent launch on those models still refuses `model-provider-unavailable`, and the Routing panel gave no reason. This change says why. - While a bus holds a proxy client it picked up after boot, and the catalogue reads `ready`, the catalogue answer carries one more notice, after its own: "Restart this organization to start agents on these models." - No notice on an unavailable catalogue (a fence, a key collision, a down proxy): a restart does not fix those. No notice on a bus that booted with the proxy, on a disabled catalogue, after refused settings or after a dropped client. - The launch refusal is unchanged. One function, `explainCatalogue` in `packages/bus/src/runtime.mjs`, and one new test file. The Routing panel already renders `catalogue.notices`, so there is no webui change. No bus schema change, no new verb, no new refusal code, no grant or role change. Nothing under `roles/`, `contracts/` or `packages/queue/`. ## Why a launch still needs a restart A launch on a late client needs what only the start path builds: the key issuer (ModelKeys) with every agent registered, the sweep timer, the organization and authority wrappers that revoke keys on fire and delete, and the proxy in the host launcher's boot config. Building those late needs a new host op or a change to the Console launcher's start path, and a rule for what a dropped proxy does to live keys. The lane report lists the smallest change for that. It waits for an owner ruling. ## Tests - `packages/bus/tests/pickup-launch.test.mjs`, 8 tests: the notice on a picked-up bus and on the bus that ran init; its order after the catalogue's own notices; no notice on a boot-proxy bus, a disabled catalogue or a fenced one, and the notice back once the fence is gone; refused settings and a dropped client keep their cause line; a real launcher refuses as before with one admission answer; key scan of stderr, answers, the launch log and files. - Mutants on the final version: 9 of 10 killed. The survivor differs only on a disabled catalogue, which no reader passes through. - Lane gate on 196505e6e: 415 files (bus, model-proxy, webui), 3975 pass, 0 fail, 5 skipped (4 `org-quick-live`, 1 `triage-settings-browser`). - Lead check in a clean environment: 115 test files that the diff touches or that import the changed source, 1326 pass, 0 fail, 0 skipped. ## Review One fresh claude-opus-5-5 reviewer. No P1. One P2: the notice also showed on a fenced catalogue, where a restart does not help. Fixed in the second commit with the change the reviewer proposed (notice only when `ready`), and the fenced test now asserts no notice. Two P3, both fixed. The Lead read the fix diff. No second re-check was run for it. ## Left for later - The launch log line on a picked-up bus still names only `model-provider-unavailable`. - The dashboard button reads "Restart bus" while the notice says "Restart this organization". - A bus that booted with a proxy whose key reconcile failed shows a ready catalogue and refuses launches with no notice. This predates the lane. - Launching on a picked-up proxy without a restart.
jason.woltje added 2 commits 2026-11-19 19:03:36 +00:00
A picked-up client serves accounts and the catalogue, but a launch on it is refused at bus
admission (model-provider-unavailable): the host launcher keeps its boot system with no proxy,
and the bus has no ModelKeys. While the bus holds a late client and the catalogue is not
disabled, the catalogue appends one notice after its own: "Restart this organization to start
agents on these models." A boot proxy, a disabled catalogue, refused settings and a dropped
client carry no such notice. Tests cover the launch refusal, refused settings, a dropped
client and a key scan over the launch path.
A bus booted with the proxy on a fenced instance reads the same unavailable catalogue, so the
notice sent the owner to a restart that stops running agents and starts none. The test proves
that and shows the notice again once the fence is gone. The disabled check goes away with it;
the disabled test now says the routes verb answers disabled itself.
jason.woltje merged commit 196505e6ef into refactor 2026-11-19 19:03:42 +00:00
Sign in to join this conversation.