feat(webui): settings slice 1: Settings pages say why an organization can't see your models and name the fix (#1873) #2000

Merged
jason.woltje merged 5 commits from settings-s1 into refactor 2026-11-19 20:41:01 +00:00
Owner

What changes

Settings redesign slice 1 (lane settings-s1): each Settings page says what is true and names the fix. UI only, on existing endpoints.

  • Routing (packages/webui/src/public/display.js, bus.js). When an organization can't see the owner's models the page says why: the model service is not set up or not running (with a link to its page), or the bus names its cause (that line and Check again). Restart is offered only where the bus names no cause or one a restart clears.
  • Model setup page. After init it keeps a list of organizations whose catalogue is not ready, each with its own Restart button. After a sign-in it reads the whole status again and works out the next step from what it reads. Only the next step's button shows. Done steps, Fence, Init lock and unit controls sit behind "Technical details".
  • Ride all placement. The Ride all box from #1999 now sits below "Organizations that need a restart". With an account added, Ride all is the next step while at least one organization can ride.
  • Triage drawer and Triage page (triage-settings.js, triage-route-http.mjs, decision-http.mjs). Refusals read as plain lines with a link to the fix. The harness refusal names Claude Code.
  • An organization whose bus will not start (console-restart.js) keeps the restart refusal text on screen and keeps the instance pages reachable.

No new bus verb, no schema change, no new refusal code, no grant or role change. Nothing under roles/, contracts/, packages/queue/ or packages/bus/.

Tests

  • New: packages/webui/tests/settings-s1-browser.test.mjs. Extended: proxy-setup-browser, triage-drawer-browser, triage-settings-browser, routes-browser and others.
  • Lead check in a clean environment on the rebased tip: 187 files, 2316 pass, 1 fail, 2 skip on c9d64a341. The one fail was packages/plugins/tests/harness.test.mjs (a hand-coded harness name list in triage-settings.js). The last commit removes the list; that file and the four touched or nearest webui files then pass alone on fbaae25d0 (55 pass, 0 fail). The Lead read the last commit's source diff line by line.

Review

Three review rounds on the first range, each by a fresh claude-opus-5-5 reviewer, ending approve with P1 0, P2 0, P3 11. The branch was then rebased onto 2db4f24fd with six conflict hunks against #1999. A fresh reviewer re-checked the rebase: approve, P1 0, P2 0, P3 4. Ride-default's Ride all code block is byte-identical between 2db4f24fd and this tip.

Left for later

  • When the owner can't send changes, the next step is a Ride all button that leads to a disabled Ride all button with no reason shown.
  • With Ride all as the next step there are two Ride all buttons, and the first only scrolls to the second.
  • In two states the next-step line says every organization can see the models while the box below lists one that can't.
  • The Ride all text says "proxy" where this page now says "model service".
  • The screenshots were not retaken after the rebase.
  • The eleven P3 items of re-check 3. A fix lane follows this landing.
## What changes Settings redesign slice 1 (lane settings-s1): each Settings page says what is true and names the fix. UI only, on existing endpoints. - **Routing** (`packages/webui/src/public/display.js`, `bus.js`). When an organization can't see the owner's models the page says why: the model service is not set up or not running (with a link to its page), or the bus names its cause (that line and Check again). Restart is offered only where the bus names no cause or one a restart clears. - **Model setup page.** After init it keeps a list of organizations whose catalogue is not ready, each with its own Restart button. After a sign-in it reads the whole status again and works out the next step from what it reads. Only the next step's button shows. Done steps, Fence, Init lock and unit controls sit behind "Technical details". - **Ride all placement.** The Ride all box from #1999 now sits below "Organizations that need a restart". With an account added, Ride all is the next step while at least one organization can ride. - **Triage drawer and Triage page** (`triage-settings.js`, `triage-route-http.mjs`, `decision-http.mjs`). Refusals read as plain lines with a link to the fix. The harness refusal names Claude Code. - **An organization whose bus will not start** (`console-restart.js`) keeps the restart refusal text on screen and keeps the instance pages reachable. No new bus verb, no schema change, no new refusal code, no grant or role change. Nothing under `roles/`, `contracts/`, `packages/queue/` or `packages/bus/`. ## Tests - New: `packages/webui/tests/settings-s1-browser.test.mjs`. Extended: `proxy-setup-browser`, `triage-drawer-browser`, `triage-settings-browser`, `routes-browser` and others. - Lead check in a clean environment on the rebased tip: 187 files, 2316 pass, 1 fail, 2 skip on c9d64a341. The one fail was packages/plugins/tests/harness.test.mjs (a hand-coded harness name list in triage-settings.js). The last commit removes the list; that file and the four touched or nearest webui files then pass alone on fbaae25d0 (55 pass, 0 fail). The Lead read the last commit's source diff line by line. ## Review Three review rounds on the first range, each by a fresh claude-opus-5-5 reviewer, ending approve with P1 0, P2 0, P3 11. The branch was then rebased onto 2db4f24fd with six conflict hunks against #1999. A fresh reviewer re-checked the rebase: approve, P1 0, P2 0, P3 4. Ride-default's Ride all code block is byte-identical between 2db4f24fd and this tip. ## Left for later - When the owner can't send changes, the next step is a Ride all button that leads to a disabled Ride all button with no reason shown. - With Ride all as the next step there are two Ride all buttons, and the first only scrolls to the second. - In two states the next-step line says every organization can see the models while the box below lists one that can't. - The Ride all text says "proxy" where this page now says "model service". - The screenshots were not retaken after the rebase. - The eleven P3 items of re-check 3. A fix lane follows this landing.
jason.woltje added 5 commits 2026-11-19 20:40:54 +00:00
jason.woltje merged commit fbaae25d06 into refactor 2026-11-19 20:41:01 +00:00
Sign in to join this conversation.