fix(webui, model-proxy): settings follow-ups: Model setup says what is true in each state, Ride all reads the change log again before each add, and ride-fence is green again (#1873) #2002

Merged
jason.woltje merged 5 commits from settings-p3 into refactor 2026-11-19 22:18:22 +00:00
Owner

What changes

Follow-up fixes left by #2000 (settings slice 1) and #1999 (Ride all), lane settings-p3. Small fixes only.

  • Model setup page (packages/webui/src/public/display.js). The next-step line no longer says every organization can see the models while the Ride all box lists one that can't. When the owner can't send changes, Ride all is not offered as the next step. There is one Ride all button, not two. The Ride all text says "model service" like the rest of the page. An organization that took cliproxy while Ride all ran shows as already using it. On a single-business Console a stand-in organization shows "Moving it is not available on this Console." and no Move button.
  • The eleven P3 items of the slice 1 re-check (display.js, bus.js, console-restart.js): wording, focus and repaint fixes on Routing, Model setup, Health and the stopped-organization page.
  • Ride all reads again before each add (packages/model-proxy/src/admin-control.mjs). It now reads the organization's file and change log again, not only the proxy receipts, so an add then remove on the Settings page during a run is not put back. If either can't be read, the organization is skipped.
  • Single-business Console (packages/webui/src/cli.mjs). The bus-running skip line no longer tells the owner to do something that cannot work there.
  • Routing help (bus.js) names no harness.
  • packages/model-proxy/tests/ride-fence.test.mjs was red on refactor since #2001: its fixture ran a legacy Claude model on pi, which the harness rule now refuses. The fixture runs that model on claude-code. No assertion changed.

No new route, bus verb, schema change, refusal code, grant or role. Nothing under roles/, contracts/, packages/queue/ or packages/bus/.

Tests

  • Lane gate on dd0a8612c: 221 files, 1994 pass, 1 fail (ride-fence, fixed in the next commit), 6 skip.
  • Lead check in a clean environment on 6c5ec23b4: 321 files, 3346 pass, 0 fail, 6 skip. The list holds every test of each touched package plus all model-proxy and plugins tests.

Review

A fresh claude-opus-5-5 reviewer read the first three commits and asked for changes (P2 1, P3 3). The lane fixed all four. A second fresh reviewer re-checked the whole range, the two later commits line by line: approve, P1 0, P2 0, P3 1. It showed each new test red with its source fix reverted, and could not make Ride all add an organization from stale, missing, unreadable or half-written data.

Left for later

  • Model setup's done line counts an organization whose owner took the model service off on purpose, so the page keeps saying some organizations "still need a step" (display.js, near line 950). It goes into the Settings layout slice.
## What changes Follow-up fixes left by #2000 (settings slice 1) and #1999 (Ride all), lane settings-p3. Small fixes only. - **Model setup page** (`packages/webui/src/public/display.js`). The next-step line no longer says every organization can see the models while the Ride all box lists one that can't. When the owner can't send changes, Ride all is not offered as the next step. There is one Ride all button, not two. The Ride all text says "model service" like the rest of the page. An organization that took cliproxy while Ride all ran shows as already using it. On a single-business Console a stand-in organization shows "Moving it is not available on this Console." and no Move button. - **The eleven P3 items of the slice 1 re-check** (`display.js`, `bus.js`, `console-restart.js`): wording, focus and repaint fixes on Routing, Model setup, Health and the stopped-organization page. - **Ride all reads again before each add** (`packages/model-proxy/src/admin-control.mjs`). It now reads the organization's file and change log again, not only the proxy receipts, so an add then remove on the Settings page during a run is not put back. If either can't be read, the organization is skipped. - **Single-business Console** (`packages/webui/src/cli.mjs`). The `bus-running` skip line no longer tells the owner to do something that cannot work there. - **Routing help** (`bus.js`) names no harness. - **`packages/model-proxy/tests/ride-fence.test.mjs`** was red on refactor since #2001: its fixture ran a legacy Claude model on pi, which the harness rule now refuses. The fixture runs that model on claude-code. No assertion changed. No new route, bus verb, schema change, refusal code, grant or role. Nothing under `roles/`, `contracts/`, `packages/queue/` or `packages/bus/`. ## Tests - Lane gate on dd0a8612c: 221 files, 1994 pass, 1 fail (ride-fence, fixed in the next commit), 6 skip. - Lead check in a clean environment on 6c5ec23b4: 321 files, 3346 pass, 0 fail, 6 skip. The list holds every test of each touched package plus all model-proxy and plugins tests. ## Review A fresh claude-opus-5-5 reviewer read the first three commits and asked for changes (P2 1, P3 3). The lane fixed all four. A second fresh reviewer re-checked the whole range, the two later commits line by line: approve, P1 0, P2 0, P3 1. It showed each new test red with its source fix reverted, and could not make Ride all add an organization from stale, missing, unreadable or half-written data. ## Left for later - Model setup's done line counts an organization whose owner took the model service off on purpose, so the page keeps saying some organizations "still need a step" (`display.js`, near line 950). It goes into the Settings layout slice.
jason.woltje added 5 commits 2026-11-19 22:18:19 +00:00
jason.woltje merged commit 6c5ec23b47 into refactor 2026-11-19 22:18:22 +00:00
Sign in to join this conversation.