feat(webui): Model setup shows the service's last lines, when the service key was made and the setup history, to the instance owner only (#1873) #2008

Merged
jason.woltje merged 4 commits from settings-s5b into refactor 2026-11-20 06:39:21 +00:00
Owner

What changes

Lane settings-s5b: the page halves of the three Model setup reads that #2006 added. Browser side only: packages/webui/src/public/bus.js, display.js, shell.css and tests.

  • The service's last lines. From GET /api/proxy/admin/log. They open in step 1 when setup stops, and again under Technical details. The page shows what the route returns and adds no source of its own.
  • When the service key was made. From GET /api/proxy/admin/service-key. Never the key. The page says renewing it is not built yet.
  • Setup history. From GET /api/proxy/admin/history, a page at a time. A withheld entry shows as a plain row. An empty page with an older page still offers Show older. The raw receipts list is gone; the history shows the same records in words.
  • Owner only. A viewer who is not the instance owner sees none of the three, and the page makes no call to /api/proxy/admin/ for them.
  • Lazy reads. Each read waits until its box opens. A failed read says so with Read again.
  • Slice 5 follow-up. Leaving Models for any other page drops its pending focus request.

No new route, bus verb, schema change, refusal code, grant, role or config format. No server file.

Tests

  • New: packages/webui/tests/settings-s5b-browser.test.mjs (16 checks and a shots test). All 16 fail on the old base. Each review fix has a test that fails without it.
  • Lane gate on de39750eb: 225 files, 2100 pass, 0 fail, 9 skip.
  • Lead check in a clean environment: de39750eb on base e6f6f5445: 499 files, 5165 pass, 0 fail, 9 skip.

Review

A fresh claude-opus-5-5 reviewer asked for eight changes and the lane fixed all eight. A second fresh reviewer found two small items, the lane fixed both, and the reviewer approved.

Left for later

  • The history does not show display names, the provider on a sign-in entry, or failed attempts. The reads do not carry them.
  • The log lines have no severity, and a failed start carries no wait time, so the page cannot mark the failing line or say how long it waited.
  • The log route gives one code for two different "not configured" causes.
  • Key renewal.
  • For a viewer who is not the owner, the Technical details summary still shows with an empty body, as before this change.
  • The page halves of programs and access health, and layout slices 6 to 8.
## What changes Lane settings-s5b: the page halves of the three Model setup reads that #2006 added. Browser side only: `packages/webui/src/public/bus.js`, `display.js`, `shell.css` and tests. - **The service's last lines.** From `GET /api/proxy/admin/log`. They open in step 1 when setup stops, and again under Technical details. The page shows what the route returns and adds no source of its own. - **When the service key was made.** From `GET /api/proxy/admin/service-key`. Never the key. The page says renewing it is not built yet. - **Setup history.** From `GET /api/proxy/admin/history`, a page at a time. A withheld entry shows as a plain row. An empty page with an older page still offers Show older. The raw receipts list is gone; the history shows the same records in words. - **Owner only.** A viewer who is not the instance owner sees none of the three, and the page makes no call to `/api/proxy/admin/` for them. - **Lazy reads.** Each read waits until its box opens. A failed read says so with Read again. - **Slice 5 follow-up.** Leaving Models for any other page drops its pending focus request. No new route, bus verb, schema change, refusal code, grant, role or config format. No server file. ## Tests - New: `packages/webui/tests/settings-s5b-browser.test.mjs` (16 checks and a shots test). All 16 fail on the old base. Each review fix has a test that fails without it. - Lane gate on de39750eb: 225 files, 2100 pass, 0 fail, 9 skip. - Lead check in a clean environment: de39750eb on base e6f6f5445: 499 files, 5165 pass, 0 fail, 9 skip. ## Review A fresh claude-opus-5-5 reviewer asked for eight changes and the lane fixed all eight. A second fresh reviewer found two small items, the lane fixed both, and the reviewer approved. ## Left for later - The history does not show display names, the provider on a sign-in entry, or failed attempts. The reads do not carry them. - The log lines have no severity, and a failed start carries no wait time, so the page cannot mark the failing line or say how long it waited. - The log route gives one code for two different "not configured" causes. - Key renewal. - For a viewer who is not the owner, the Technical details summary still shows with an empty body, as before this change. - The page halves of programs and access health, and layout slices 6 to 8.
jason.woltje added 4 commits 2026-11-20 06:39:15 +00:00
jason.woltje merged commit de39750ebb into refactor 2026-11-20 06:39:21 +00:00
Sign in to join this conversation.