feat(webui): Model setup lists the installed programs, turns one off for every organization after a confirm, and shows access health per organization, to the instance owner only (#1873) #2011

Merged
jason.woltje merged 3 commits from settings-s5c into refactor 2026-11-20 09:40:09 +00:00
Owner

What changes

Lane settings-s5c: the page halves of programs and access health, whose server half landed in #2009. Browser side only: packages/webui/src/public/display.js, shell.css and tests.

  • Programs that drive models. Model setup, Advanced, lists the installed programs from the status read and which organizations have each one on, by display name. An organization whose list is null reads "Not known", never off.
  • Turn off for every organization. The page asks first, naming the program, then calls POST /api/proxy/admin/programs/off and words each organization's outcome. A bus that is down never reads as stopped. failed:outcome-unknown says it may have changed. An unknown failed code shows the code. Busy and a failed request each get one plain line.
  • After any answer the page reads the status again and moves focus to the result. It says the list is current only when that read worked. Otherwise it says the list may be out of date and offers Read again.
  • Access. Technical details shows each organization's access health from GET /api/proxy/admin/access, read only when the box opens. Only ok reads Ready. No key, key id or other-keys count is shown. A failed read gets a plain line with Read again.
  • Owner only. A viewer who is not the instance owner sees none of it, and the page sends no request to these routes for them.
  • Shared fix. explain() no longer prints page source for a refusal code named like an object property.

No new route, bus verb, schema change, refusal code, grant, role or config format. No server file. Program names come from the read; none is written in page source.

Tests

  • New: packages/webui/tests/settings-s5c-browser.test.mjs. All 15 new tests fail on the old base. Each review fix has a test that fails without it.
  • Lane gate on 6012ab54d: 226 files, 2133 pass, 0 fail, 10 skip.
  • Lead check in a clean environment on the rebased tip ebfbdb13a: ebfbdb13a on base 6ad11e699: 472 files, 4782 pass, 1 fail, 10 skip. The one fail is the restart test in single-pane-browser.test.mjs, a known flake this change does not touch: run alone three times it passed twice.

Review

A fresh claude-opus-5-5 reviewer found five small items and the lane fixed all five. A second found one more, also fixed. A third approved.

Left for later

  • Programs show by plugin name. A display name and a description for each need a server field.
  • The page cannot warn what turning a program off would hide, and from whom. No read carries it.
  • "Needs attention" cannot name the agent. The access answer has no agent display names.
  • A status read with no programs field gives two lines that disagree. Neither shows old data as new.
  • One code comment in display.js still describes the old reread check.
  • Turning a program on from this page, and the provider select from the plugin (slice A3).
## What changes Lane settings-s5c: the page halves of programs and access health, whose server half landed in #2009. Browser side only: `packages/webui/src/public/display.js`, `shell.css` and tests. - **Programs that drive models.** Model setup, Advanced, lists the installed programs from the status read and which organizations have each one on, by display name. An organization whose list is null reads "Not known", never off. - **Turn off for every organization.** The page asks first, naming the program, then calls `POST /api/proxy/admin/programs/off` and words each organization's outcome. A bus that is down never reads as stopped. `failed:outcome-unknown` says it may have changed. An unknown failed code shows the code. Busy and a failed request each get one plain line. - **After any answer** the page reads the status again and moves focus to the result. It says the list is current only when that read worked. Otherwise it says the list may be out of date and offers Read again. - **Access.** Technical details shows each organization's access health from `GET /api/proxy/admin/access`, read only when the box opens. Only `ok` reads Ready. No key, key id or other-keys count is shown. A failed read gets a plain line with Read again. - **Owner only.** A viewer who is not the instance owner sees none of it, and the page sends no request to these routes for them. - **Shared fix.** `explain()` no longer prints page source for a refusal code named like an object property. No new route, bus verb, schema change, refusal code, grant, role or config format. No server file. Program names come from the read; none is written in page source. ## Tests - New: `packages/webui/tests/settings-s5c-browser.test.mjs`. All 15 new tests fail on the old base. Each review fix has a test that fails without it. - Lane gate on 6012ab54d: 226 files, 2133 pass, 0 fail, 10 skip. - Lead check in a clean environment on the rebased tip ebfbdb13a: ebfbdb13a on base 6ad11e699: 472 files, 4782 pass, 1 fail, 10 skip. The one fail is the restart test in `single-pane-browser.test.mjs`, a known flake this change does not touch: run alone three times it passed twice. ## Review A fresh claude-opus-5-5 reviewer found five small items and the lane fixed all five. A second found one more, also fixed. A third approved. ## Left for later - Programs show by plugin name. A display name and a description for each need a server field. - The page cannot warn what turning a program off would hide, and from whom. No read carries it. - "Needs attention" cannot name the agent. The access answer has no agent display names. - A status read with no programs field gives two lines that disagree. Neither shows old data as new. - One code comment in `display.js` still describes the old reread check. - Turning a program on from this page, and the provider select from the plugin (slice A3).
jason.woltje added 3 commits 2026-11-20 09:40:05 +00:00
jason.woltje merged commit ebfbdb13a0 into refactor 2026-11-20 09:40:09 +00:00
Sign in to join this conversation.