mosaicstack/stack
1
0
Fork 0
Code Issues 22 Pull Requests 7 Actions Packages Projects Releases 13 Wiki Activity

fix(git): harden Gitea PR metadata lookup #517

Closed
jason.woltje wants to merge 1 commits from fix/t_a292e96f-pr-metadata-gitea into main
pull from: fix/t_a292e96f-pr-metadata-gitea
merge into: mosaicstack:main
Conversation 1 Commits 1 Files Changed 2 +65 -10
jason.woltje commented 2026-05-22 15:30:56 +00:00
Owner
Copy Link

Summary

  • fail closed when Gitea PR API returns non-2xx instead of normalizing error JSON into null metadata
  • try explicit, Mosaic credential-loader, and git HTTPS credential tokens before anonymous fallback
  • preserve GitHub behavior and normalize Gitea number/head/base/author/url fields for downstream pr-merge.sh base detection

Verification

  • shellcheck -x -P packages/mosaic/framework/tools/git packages/mosaic/framework/tools/git/pr-metadata.sh packages/mosaic/framework/tools/git/pr-merge.sh
  • live U-Connect Gitea PR #1905 returns number/head/base/state/author/url/mergeable
  • live U-Connect Gitea PR #1908 returns number/head/base/state/author/url/mergeable
  • nonexistent PR returns exit=1 with HTTP 404 error
  • pr-merge.sh baseRefName extraction path returns main for PR #1905

Kanban: t_a292e96f

## Summary - fail closed when Gitea PR API returns non-2xx instead of normalizing error JSON into null metadata - try explicit, Mosaic credential-loader, and git HTTPS credential tokens before anonymous fallback - preserve GitHub behavior and normalize Gitea number/head/base/author/url fields for downstream pr-merge.sh base detection ## Verification - shellcheck -x -P packages/mosaic/framework/tools/git packages/mosaic/framework/tools/git/pr-metadata.sh packages/mosaic/framework/tools/git/pr-merge.sh - live U-Connect Gitea PR #1905 returns number/head/base/state/author/url/mergeable - live U-Connect Gitea PR #1908 returns number/head/base/state/author/url/mergeable - nonexistent PR returns exit=1 with HTTP 404 error - pr-merge.sh baseRefName extraction path returns main for PR #1905 Kanban: t_a292e96f
jason.woltje added 1 commit 2026-05-22 15:30:57 +00:00
fix(git): harden Gitea PR metadata lookup
Some checks failed
ci/woodpecker/push/ci Pipeline failed
Details
ci/woodpecker/pr/ci Pipeline failed
Details
06783958f7
jason.woltje commented 2026-05-22 16:06:54 +00:00
Author
Owner
Copy Link

Closing duplicate Kanban recovery PR. Superseded by PR #518, which carries the fuller fix for Gitea metadata, git.uscllc.com token/login selection, merge dry-run preflight, regression harness, PRD/TASKS, and scratchpad updates for t_a292e96f.

Closing duplicate Kanban recovery PR. Superseded by PR #518, which carries the fuller fix for Gitea metadata, git.uscllc.com token/login selection, merge dry-run preflight, regression harness, PRD/TASKS, and scratchpad updates for t_a292e96f.
jason.woltje closed this pull request 2026-05-22 16:06:55 +00:00
Some checks failed
ci/woodpecker/push/ci Pipeline failed
Details
ci/woodpecker/pr/ci Pipeline failed
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
jason.woltje
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: mosaicstack/stack#517
Delete Branch "fix/t_a292e96f-pr-metadata-gitea"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?