mosaicstack/stack
1
0
Fork 0
Code Issues 31 Pull Requests 5 Actions Packages Projects Releases 15 Wiki Activity

docs(framework): P4.1 — fix stale install.sh comments + cmp-equal early-exit #593

Merged
jason.woltje merged 1 commits from feat/p4-1-comment-cleanup into main 2026-06-21 23:12:32 +00:00
Conversation 0 Commits 1 Files Changed 2 +16 -10
jason.woltje commented 2026-06-21 23:09:55 +00:00
Owner
Copy Link

Closes #592 · non-blocking fast-follow to #590. Fixes 2 stale install.sh comments that contradicted P4's framework-owned overwrite; adds cmp-equal early-exit to the reconcile in both install.sh + file-adapter.ts (no mtime churn). install.sh fixtures 14/14, gate green, prettier clean.

Closes #592 · non-blocking fast-follow to #590. Fixes 2 stale install.sh comments that contradicted P4's framework-owned overwrite; adds cmp-equal early-exit to the reconcile in both install.sh + file-adapter.ts (no mtime churn). install.sh fixtures 14/14, gate green, prettier clean.
jason.woltje added 1 commit 2026-06-21 23:09:56 +00:00
docs(framework): P4.1 — fix stale install.sh comments + cmp-equal early-exit
All checks were successful
ci/woodpecker/push/ci Pipeline was successful
Details
ci/woodpecker/pr/ci Pipeline was successful
Details
02fdbccb39 
Non-blocking fast-follow from #590 dual-engine review:
- install.sh: PRESERVE_PATHS "(never overwritten)" and the seed-block "never be
  overwritten once customized" comments contradicted P4's framework-owned
  overwrite — clarified both (PRESERVE protects from rsync --delete; reconcile
  re-applies framework-owned with backup-once).
- reconcile (install.sh + file-adapter.ts): skip the copy when content already
  matches (cmp-equal early-exit) to avoid mtime churn. Parity preserved.

install.sh fixtures 14/14 green; gate green; prettier clean.

Refs #542, closes #592

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
jason.woltje merged commit 31e7a4d25e into main 2026-06-21 23:12:32 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
fleet-enhancement
Fleet-wide reliability/speed/cost improvements surfaced by the nightly enhance pass
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
jason.woltje
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: mosaicstack/stack#593
Delete Branch "feat/p4-1-comment-cleanup"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?