#942 - fix(wake): #941 follow-up — validate WAKE_SNAPSHOT_TS_FUTURE_SLACK before arithmetic (poll-never-fails) - stack

Conversation 2 Commits 2 Files Changed 3

+123 -5

2 Commits

Author	SHA1	Message	Date
Jason WoltjeandClaude Fable 5	667402457e	fix(wake): #942 review — force base-10 on the slack knob; shape validation is not radix validation ci/woodpecker/pr/ci Pipeline was successful Details '08'/'09' pass ^[0-9]{1,9}$ yet are fatal octal in $((...)) — the same poll-killing mode this PR closes — and '0300' silently means 192, changing the operator's stated intent with no warning. slack=$((10#$slack)) after the regex (which guarantees pure digits, so 10# is safe) makes zero-padded knobs mean what was written instead of rejecting them. Two new D13 sub-cases: '08' survives with metadata kept, and the discrimination test — '0300' with a ts +250s ahead KEEPS the ts (decimal 300) where octal 192 would have dropped it. Co-Authored-By: Claude Fable 5 <[email protected]> Claude-Session: https://claude.ai/code/session_01NsKce8iZuSuRnu3gVMCBKB	2026-07-30 06:04:48 -05:00
Jason WoltjeandClaude Fable 5	313f3087e6	fix(wake): #941 review §2 round 2 — validate WAKE_SNAPSHOT_TS_FUTURE_SLACK before arithmetic ci/woodpecker/pr/ci Pipeline was canceled Details The operator's slack knob was interpolated raw into $((...)) under set -u: '300s'/'5m' -> 'value too great', 'abc' -> 'unbound variable' — all FATAL to the poll, falsifying the PR's own 'poll never fails' invariant, and a negative value silently inverted the guard into deny-all. Now resolved once into a local, validated ^[0-9]{1,9}$, loud fallback to 300 on mismatch. New D13 group: '300s'/'abc'/negative all fall back and KEEP valid metadata; a valid tightened knob (0) still rejects a future ts. Manifest states the skew guarantee explicitly: a surviving snapshot_ts is attested only to within SLACK seconds of the DETECTOR's clock — bounded negative age at render is possible; treat age<=0 as effectively-current, never proof of freshness. Co-Authored-By: Claude Fable 5 <[email protected]> Claude-Session: https://claude.ai/code/session_01NsKce8iZuSuRnu3gVMCBKB	2026-07-30 05:57:17 -05:00

Author

SHA1

Message

Date

Jason WoltjeandClaude Fable 5

667402457e

fix(wake): #942 review — force base-10 on the slack knob; shape validation is not radix validation

ci/woodpecker/pr/ci Pipeline was successful

Details

'08'/'09' pass ^[0-9]{1,9}$ yet are fatal octal in $((...)) — the same
poll-killing mode this PR closes — and '0300' silently means 192, changing the
operator's stated intent with no warning. slack=$((10#$slack)) after the
regex (which guarantees pure digits, so 10# is safe) makes zero-padded knobs
mean what was written instead of rejecting them. Two new D13 sub-cases: '08'
survives with metadata kept, and the discrimination test — '0300' with a ts
+250s ahead KEEPS the ts (decimal 300) where octal 192 would have dropped it.

Co-Authored-By: Claude Fable 5 <[email protected]>
Claude-Session: https://claude.ai/code/session_01NsKce8iZuSuRnu3gVMCBKB

2026-07-30 06:04:48 -05:00

Jason WoltjeandClaude Fable 5

313f3087e6

fix(wake): #941 review §2 round 2 — validate WAKE_SNAPSHOT_TS_FUTURE_SLACK before arithmetic

ci/woodpecker/pr/ci Pipeline was canceled

Details

The operator's slack knob was interpolated raw into $((...)) under set -u:
'300s'/'5m' -> 'value too great', 'abc' -> 'unbound variable' — all FATAL to
the poll, falsifying the PR's own 'poll never fails' invariant, and a negative
value silently inverted the guard into deny-all. Now resolved once into a
local, validated ^[0-9]{1,9}$, loud fallback to 300 on mismatch. New D13
group: '300s'/'abc'/negative all fall back and KEEP valid metadata; a valid
tightened knob (0) still rejects a future ts. Manifest states the skew
guarantee explicitly: a surviving snapshot_ts is attested only to within SLACK
seconds of the DETECTOR's clock — bounded negative age at render is possible;
treat age<=0 as effectively-current, never proof of freshness.

Co-Authored-By: Claude Fable 5 <[email protected]>
Claude-Session: https://claude.ai/code/session_01NsKce8iZuSuRnu3gVMCBKB

2026-07-30 05:57:17 -05:00

fix(wake): #941 follow-up — validate WAKE_SNAPSHOT_TS_FUTURE_SLACK before arithmetic (poll-never-fails) #942