35 lines
2.6 KiB
Markdown
35 lines
2.6 KiB
Markdown
# Row266 review packet — Console rooms (#1771)
|
|
|
|
Owner Fethry14f80e3c; first reviewer Boyd48a3ae38, second Dewey84fb346c.
|
|
Base487500a16, pinned amended brief85e6fe2ecfc5. Sage owns gate and landing.
|
|
|
|
The owner Console has an explicit Open room action and a merged project timeline. Human broadcasts
|
|
show once with the broker's addressees; agent rows use the shared225 reply renderer including stored
|
|
check metadata, badges, changed-file labels and safe notices. Completion suggests quiet and active room
|
|
members and follows the broker's leading-tag grammar. The original body goes to room.send.
|
|
|
|
The seam has exactly three room calls, and no thread.messages fanout. Four room refusals map to409
|
|
with fixed lines. Read-only routes never open rooms. Writes retain existing authority/Origin fences,
|
|
strict arguments, receipt validation, draft preservation and no automatic retry after uncertainty.
|
|
|
|
manifest.r1.sha256 freezes exactly10 package paths: six production files and four NEW test files.
|
|
No pre-existing test is edited. Check with sha256sum -c from the repository root. The only brief
|
|
amendment is sage4156's narrow broker helper/check/last hydration for room.read; room.open/send and
|
|
other broker fields/refusals remain unchanged. Other changes are append-only session/build records
|
|
and this tracking packet. No queue JSON, role, policy, secret or generated editor asset changes.
|
|
|
|
Evidence and RED/GREEN history are in BUILD.md. Full suites/scripts are green; all16 isolated mutants are killed by assertions on source3095d6ea5. The initial
|
|
full bus999/1 is the pre-existing T9 timer race, reported before action; unchanged reruns authorized
|
|
by sage4158 all pass: credential6/0 three times, bus1000/0 once. Webui458/0, plugins120/0,
|
|
all12 scripts exit0. Queue wrapper skips canonical-only verify/render, and task retains the
|
|
row244 live-provider exclusions. No test-runner skips/cancellations in package suites. Full plugins120/0 rerun after strengthening
|
|
the new dispatch assertion. All16 one-anchor mutants restore and preserve candidate hashes; initial
|
|
M01 uncaught-refusal attempt is explicitly excluded. Final own-cwd node/Chromium sweep is empty. Review must consider every run, including the red.
|
|
|
|
Pin audit: pin-audit-before.txt and pin-audit-after.txt search source paths/basenames and64-hex old
|
|
and new digests across tests. No literal digest pin needs updating for any of the three named files.
|
|
|
|
Review focus: grouped paging cursor, no body-based client regrouping, quiet membership/completion,
|
|
raw body preservation, checked/unchecked renderer trust, grant/tester refusal, pending/uncertain writes,
|
|
late reads/sign-out and strictly scoped broker hydration.
|