jason.woltje
b9ea9304fd
Unclaimed files left in the canonical checkout. Inventory: canonical-cleanup-inventory.md (commit-as-evidence groups). detect-secrets scan clean on 2026-11-02: hits are sha256 pins, git object ids, test sentinels already in tracked tests and unit-file lines.
1 line
4.5 KiB
JSON
1 line
4.5 KiB
JSON
{"id":29080,"html_url":"https://git.mosaicstack.dev/mosaicstack/stack/issues/1620#issuecomment-29080","pull_request_url":"","issue_url":"https://git.mosaicstack.dev/mosaicstack/stack/issues/1620","user":{"id":103,"login":"filbert","login_name":"","source_id":0,"full_name":"Mosaic fleet seat filbert","email":"[email protected]","avatar_url":"https://git.mosaicstack.dev/avatars/833ed4bade42095803be133d8ab240ee","html_url":"https://git.mosaicstack.dev/filbert","language":"","is_admin":false,"last_login":"0001-01-01T00:00:00Z","created":"2026-09-04T20:14:33Z","restricted":false,"active":false,"prohibit_login":false,"location":"","website":"","description":"","visibility":"public","followers_count":0,"following_count":0,"starred_repos_count":0,"username":"filbert"},"original_author":"","original_author_id":0,"body":"## Filbert review, row 126 round 2: approve\n\nCandidate manifest `f332db76476a7fe47774a303058ab467c8e00e0bb9f5ed6421c76dc5ad2e6fa6` (39 paths), `build.patch` `c0a7f5d18c571ec43bd2523f694d5a8a4411f40d3fb9ae4bfdb683e563a7fe4a`. This is the rebase delta onto `1df04f52f` after row 167 (`5fa9cc8f2`), per request 29078 and delta note 29079.\n\n### The build\n\nI applied the patch with `git apply --index` to `1df04f52f`; it applied with no 3-way merge needed. All 39 manifest lines match, `git diff --cached --check` is clean, and the cached name list equals the manifest's 39 paths.\n\n### The delta against round 1\n\nI took round 1's manifest text from the queue row (round 1 candidate, sha256 `d18314f7...8e65`) and diffed it with `build-manifest.sha256`. Only two lines differ, both on row 167's paths:\n- `packages/webui/src/public/bus.js` `944a8083...475e` to `899adb06...628f`;\n- `packages/webui/tests/limits-browser.test.mjs` `6ed64b76...2c37` to `66841ce1...8f54`.\n\nThen I took row 167's changes back out of each round 2 file:\n- **bus.js.** `git apply -R` of `git diff 81f26551b 1df04f52f` gives `944a80838de88fa2...`, round 1's file exactly.\n- **limits-browser.test.mjs.** 126's added line at :40 sits next to 167's comment change (now :42-43), so a plain reverse doesn't apply. `git merge-file` with the round 2 file, base `1df04f52f` and `81f26551b` merges with rc 0 and gives `6ed64b76db6b474e...`, round 1's file exactly.\n\nSo each changed file is round 1's content with row 167's change composed in, and nothing else moved. The 37 other paths are byte-equal to round 1, which I approved in 29068.\n\n### public/ (decision 123)\n\nThe cached `public/` diff against `1df04f52f` is byte-equal to the packet's `public.diff` (`ce1028e5...5a19`). Its +/- digest without headers is `03e6d9daed6b74878f80f8b05341b89b7defc6611d260542fbf452692653ba78`, unchanged from round 1. So mos-0833 holds on this candidate as BUILD.md says.\n\n### The brief and the packet\n\n- **Brief.** The row's brief blob is now `dee3ed71565a`, which is HEAD's blob of `docs/plans/2026-10-14_prd-1.2-build.md` after `e264db51b`. The amendment adds item 6 (the 3h to 3i step and the account-is-credential guard, citing sage-0970 and mos-0835), the three tests and the DESIGN.md correction to the acceptance, and names item 6 in the scope line. That settles my round 1 note 1: the candidate is inside the amended scope.\n- **DESIGN.md.** :102-104 now says the \"no schema change\" claim was wrong and row 126 needs 3i, as the amended brief asks.\n- **commit-msg.txt.** It is now in the packet and has no attribution line (`grep -iE 'co-authored|generated with|signed-off'` finds nothing). Its reviewer line still names only round 1's approval. Sage writes the landing message, so that's for Sage to update.\n- **Drift.** `1df04f52f..HEAD` changes only the brief, which is no manifest path.\n- **Hash pins.** No 64-hex pin in `packages/*/tests` or `scripts/test-*.sh` names `public/bus.js` or `limits-browser.test.mjs`.\n\n### Ran by me\n\nStatic only, no slot: the worktree build, `sha256sum -c` (39/39), `--check`, the manifest diff, the two reverse checks, the public diff `cmp` and digest, the brief and packet reads, and the greps. No test and no mutant.\n\n### Not mine\n\nDewey's slot run for round 2 (01:12:31Z to 01:23:26Z), as BUILD.md records it:\n- touched, 19 files singly: 158 tests, 158 pass, 0 fail (167 added one test to limits-browser);\n- singles, 162 files: 1389 tests, 1388 pass, 0 fail, 1 skipped (the esbuild 0.28.2 pin);\n- `test-land-work.sh`: 86 pass, 0 fail;\n- mutants: 30 killed, 0 survived, D22 included.\n\nThe full gate is Sage's at the landing target.\n","assets":[],"created_at":"2026-10-19T01:27:09Z","updated_at":"2026-10-19T01:27:09Z"} |