Unclaimed files left in the canonical checkout. Inventory: canonical-cleanup-inventory.md (commit-as-evidence groups). detect-secrets scan clean on 2026-11-02: hits are sha256 pins, git object ids, test sentinels already in tracked tests and unit-file lines.
49 lines
2.6 KiB
Markdown
49 lines
2.6 KiB
Markdown
## Row 133 round 2 delta review (Filbert): approve
|
|
|
|
Candidate: manifest sha256 `1c0e6f8f260ae51b31c2235193c36ed1c005faefe317e1452a351a3bb5690ef0` (6 paths), base 89fd2d6fe (rows 49 and 123 in), packet agents/dewey/work/queue-133/r2/ in 346347c95.
|
|
|
|
Rebuild: a fresh worktree at d9bf6b6bc (current refactor) with the r2 build.patch applied. Every manifest hash matched and `git diff --check` was clean. The added lines have no dash, curly-quote or control characters. The packet manifest checks. No commit from 89fd2d6fe to d9bf6b6bc touches a manifest path.
|
|
|
|
### The delta is empty
|
|
|
|
- On my own `git archive` of 89fd2d6fe, r1's build.patch gives every r2 manifest digest.
|
|
- The `+` and `-` lines of the r1 and r2 build.patch files are identical. Only the index lines and hunk offsets differ, which is what build-patch-interdiff.diff shows.
|
|
- Only the README and broker.mjs digests changed from r1, because their bases moved.
|
|
|
|
My r1 approval (28589) therefore carries over to the change itself.
|
|
|
|
### Interaction with rows 49 and 123
|
|
|
|
I checked these in the rebased broker.mjs:
|
|
|
|
- **`#checkMessaging` callers.** There are four: `decision.raise` (898), `message.send` (1054), `review.request` (1159) and `review.verdict` (1202).
|
|
- **Message inserts.** There are three: the decision close (1011), `message.send` (1080) and `#reviewMessage` (1450). These are the same as r1.
|
|
- **Row 123's paths insert no message.** That covers `role.end`, `role.revoke` with a reason and `organization.set`.
|
|
- **Row 123's round 1 F1 fix is in the base.** `#checkAuthority` runs before the writer (743), and `#consumeAuthority` runs after it (757).
|
|
- **Roles.** roles/chief-of-staff.json gains `withinRole` actions and no `messaging` lists. roles/assistant.json is still the only shipped role with lists, so the validator's arbiter rule doesn't affect pm, cto or chief.
|
|
|
|
### What I ran and what I took from receipts
|
|
|
|
**I ran**, as single files with TMPDIR set and Docker disabled, all with 0 fail and 0 skipped:
|
|
|
|
| Test file | Result |
|
|
|---|---|
|
|
| bus decision-route | 5/5 |
|
|
| bus chief-of-staff | 13/13 |
|
|
| bus messaging | 12/12 |
|
|
| bus review | 8/8 |
|
|
| bus decision-close | 8/8 |
|
|
| bus decisions | 7/7 |
|
|
| bus human | 4/4 |
|
|
| bus broker | 16/16 |
|
|
| business assistant | 10/10 |
|
|
| business business | 15/15 |
|
|
| business role | 14/14 |
|
|
| business chief-of-staff | 10/10 |
|
|
|
|
**From Dewey's receipts, not rerun by me:**
|
|
- the targeted gate in gate-run.log, rc 0: business 94, bus 196, tasks 97, webui 112, cli 195;
|
|
- 2 of 2 controls passed and 5 of 5 mutants killed in mutants-run.log, with the source restored to the manifest.
|
|
|
|
I took no slot. Sage's landing gate is still part of the row's gate.
|