stack/docs/plans/reviews/2026-09-10_mosaic-i1-review-request.md

MOSAIC-I1-FILBERT-1 (#1499)

Independent implementation review. Author Darkwing; reviewer Filbert. Charter: docs/plans/2026-09-10_m20-increment1-charter.md (owner-approved via proceed 2026-09-10). Candidate: commit 557aba0f9e on refactor (not yet pushed).

Scope of the candidate: packages/mosaic (schemas, validation engine, registry loader, read-only validate/list CLI, fixtures, 15 tests); pi pin 0.85.1 (package.json + regenerated lockfile); 0.84.4->0.85.1 fixture updates in scripts/test-{darkwing-launch,auth,task}. Nothing else. scripts/auth.sh untouched; no materializer, no refresh execution, no credential path, no writes to ~/.pi or dataRoot anywhere in new code.

Verify against the charter's acceptance criteria:

1. Package suites pass covering the plan's registry-schema list (unknown keys, ID regex, path/name match, kind-specific requireds, reference integrity, duplicate IDs, missing provider/account, insecure-transport rule, credential-type support, fork-pin field).
2. validate exits 0 on the valid fixture tree, refuses invalid trees with precise errors, no stack spew, no secret echo; list prints secret-free projections only.
3. Pi pin exactly 0.85.1; lockfile in sync; existing suites: config/auth/conductor/release green; task suite carries exactly one pre-existing failure (no agent identity on headless run) that also fails at stashed baseline 54c12312 — confirm parity, do not count it against this candidate; one mock-adapter failure was observed once and did not reproduce on two reruns (recorded flaky-unreproduced).
4. Confirm no hidden mutation paths, no network in tests, no credential reads (fixture credential.json must never be read by the loader).

Method constraints: work in a disposable copy of the candidate tree (git archive/worktree of 557aba0f); no live pi commands against real auth, no package fetches beyond what you already have, no pushes, no shared-log edits. Rebuild-and-run evidence preferred where cheap; static reading suffices for scope confinement.

Write ONLY docs/plans/reviews/2026-09-10_mosaic-i1-verdict.md with APPROVED / REQUEST CHANGES plus findings, and reply to Darkwing/default. On APPROVED, Darkwing pushes and presents to Jason for acceptance per charter criterion 5. No increment 2 is authorized by this review.