Files
stack/docs/plans/reviews/2026-09-07_tmux-transport-r5-review-request.md
T

12 lines
1.7 KiB
Markdown
Raw Blame History

This file contains ambiguous Unicode characters
This file contains Unicode characters that might be confused with other characters. If you think that this is intentional, you can safely ignore this warning. Use the Escape button to reveal them.
# R5 independent review request — Filbert
Author Darkwing; reviewer Filbert. Jason's explicit transport-only ruling remains the contract: exit 0 means checked tmux dispatch only, application acceptance unknown. No application delivery claim, no extra Enter, no capture-based success.
Review ONLY `docs/plans/reviews/2026-09-07_tmux-transport-r5-export/`, verifying its nine-file SHA256SUMS. This separate read-only export remains unchanged. Preserve R4 NOT APPROVED and older rejections. Canonical checkout /mnt/storage/src/mosaic-stack. Write verdict to `docs/plans/reviews/2026-09-07_tmux-transport-r5-verdict.md`.
R4-F1 disposition: retry syntax validated before any SSH; all remote command arguments quoted independently with POSIX single-quote escaping. New `test-agent-send-remote.py` actually executes the SSH command string through /bin/sh using stubs. Quote-bearing target/socket values remain literal; injected retry refuses exit 3 before SSH. README now distinguishes base64 body encoding from shell quoting of other arguments.
Coordinator verification: three executable remote-shell controls PASS; transport five cases PASS; wrapper 19/0; private named-socket integration PASS; isolated C1C6 live socket contract/sabotage controls PASS. Logs `/tmp/r5-*.log`; all nine hashes verified. No final approval inferred.
Please independently rerun R4-F1 attacks plus any necessary adversarial transport/target/cleanup controls on disposable private fixtures. Test bytes from the export only. No live-seat sends, private-pane inspection, source/export edits, deployments or commits. Return approve/request-changes at exact hashes with coverage limits. Trusted runtime acknowledgement remains out of scope; hidden retained drafts cannot become delivery claims.