Jason-approved merge, rebased: git diff 07c12b51b..813671596 from
work/vikunja-19-295, its seven commits as one (9ede6935b through
813671596, which include task 296's searxng check). Business reviewer
verdict 51c71b46 approve on 813671596; Jason resolved merge decision
29ff6589 via the CLI.
Conflict resolution only. packages/harness/src/tools.mjs conflicted with
row 132 (0e947c216): both sides add a block after review_verdict. Kept
row 132's end_run and change_organization block, then 295's web_search and
web_fetch block, each with its own closing brace. Seven other paths that
refactor also changed merged without conflict. For each, the +/- lines on
the new base equal the source commit's. The other 20 paths are the
source blobs. Filbert reviews the rebased diff.
Co-Authored-By: Claude Opus 5.5 <[email protected]>
50 lines
3.1 KiB
JavaScript
50 lines
3.1 KiB
JavaScript
// REQ-PLUG-1: the kind registry and the organization file's `plugins` shape (row 131).
|
|
import test from "node:test";
|
|
import assert from "node:assert/strict";
|
|
import { KINDS, NAME, PluginError, checkPlugins } from "../src/kinds.mjs";
|
|
|
|
const code = expected => e => e instanceof PluginError && e.code === expected;
|
|
|
|
test("REQ-PLUG-1 REQ-LIMIT-4 the registry: usage-source and limit-check at interface version 1, each a list", () => {
|
|
assert.deepEqual(Object.keys(KINDS), ["usage-source", "limit-check", "search-source"]);
|
|
assert.deepEqual({ ...KINDS["usage-source"], exports: [...KINDS["usage-source"].exports] },
|
|
{ kind: "usage-source", interfaceVersion: 1, exports: ["readTurn"], switch: "list" });
|
|
assert.deepEqual({ ...KINDS["limit-check"], exports: [...KINDS["limit-check"].exports] },
|
|
{ kind: "limit-check", interfaceVersion: 1, exports: ["mayLaunch", "mustStop"], switch: "list" });
|
|
assert.deepEqual({ ...KINDS["search-source"], exports: [...KINDS["search-source"].exports] },
|
|
{ kind: "search-source", interfaceVersion: 1, exports: ["search"], switch: "one" });
|
|
assert.ok(Object.isFrozen(KINDS) && Object.isFrozen(KINDS["usage-source"]) && Object.isFrozen(KINDS["limit-check"].exports));
|
|
assert.equal(String(NAME), "/^[a-z][a-z0-9-]*$/");
|
|
});
|
|
|
|
test("REQ-PLUG-1 checkPlugins accepts one key per kind, each a list of names, empty included", () => {
|
|
for (const value of [{}, { "usage-source": [] }, { "usage-source": ["a", "b-2"], "limit-check": ["cap"] }]) {
|
|
assert.equal(checkPlugins(value, "plugins"), value);
|
|
}
|
|
});
|
|
|
|
test("REQ-PLUG-1 checkPlugins refuses bad shapes, unknown kinds, bad names and duplicates", () => {
|
|
for (const value of [null, [], "x", 3]) assert.throws(() => checkPlugins(value, "plugins"), code("bad-setting"));
|
|
assert.throws(() => checkPlugins({ "made-up": [] }, "plugins"), code("unknown-kind"));
|
|
assert.throws(() => checkPlugins({ toString: [] }, "plugins"), code("unknown-kind"));
|
|
assert.throws(() => checkPlugins({ "usage-source": "meter" }, "plugins"), code("bad-setting"));
|
|
for (const name of ["Meter", "1m", "m_x", "../x", "a/b", ".x", "", 7, null]) {
|
|
assert.throws(() => checkPlugins({ "usage-source": [name] }, "plugins"), code("bad-name"), String(name));
|
|
}
|
|
assert.throws(() => checkPlugins({ "limit-check": ["cap", "cap"] }, "plugins"), code("bad-setting"));
|
|
});
|
|
|
|
test("REQ-PLUG-1 a kind that switches on one module takes one name, not a list", () => {
|
|
const kinds = { single: { kind: "single", interfaceVersion: 1, exports: ["run"], switch: "one" } };
|
|
assert.ok(checkPlugins({ single: "only" }, "plugins", { kinds }));
|
|
assert.throws(() => checkPlugins({ single: ["only"] }, "plugins", { kinds }), code("bad-setting"));
|
|
assert.throws(() => checkPlugins({ single: "Only" }, "plugins", { kinds }), code("bad-name"));
|
|
});
|
|
|
|
test("REQ-PLUG-1 checkPlugins reports through the caller's fail callback", () => {
|
|
const seen = [];
|
|
const fail = (c, message) => { seen.push(c); throw new Error(message); };
|
|
assert.throws(() => checkPlugins({ "made-up": [] }, "x plugins", { fail }), /x plugins names unknown kind/);
|
|
assert.deepEqual(seen, ["unknown-kind"]);
|
|
});
|