a27f1fa7df
All checks were successful
ci/woodpecker/pr/ci Pipeline was successful
issue-comment.sh called the non-existent `tea issue comment` subcommand form; tea 0.11.1 silently no-ops and exits 0 instead of erroring, producing a false-success write. Switch to the top-level `tea comment <index> <body>` form and add fail-closed REST read-back verification so the wrapper no longer trusts tea's exit code alone. pr-review.sh's comment path was already fixed for this bug by #812/#835 (routes through a read-back-verified REST comment API instead of any tea comment subcommand); this change formalizes an explicit --login override flag there too and documents the after-detection last-wins --login ordering, consistent with issue-comment.sh. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
167 lines
6.4 KiB
Bash
Executable File
167 lines
6.4 KiB
Bash
Executable File
#!/bin/bash
|
|
# issue-comment.sh - Add a comment to an issue on GitHub or Gitea
|
|
# Usage: issue-comment.sh -i <issue_number> -c <comment> [--login <name>]
|
|
#
|
|
# tea v0.11.1 defines no `comment` subcommand under `tea issue` (or `tea pr`);
|
|
# the correct invocation is the TOP-LEVEL `tea comment <index> <body>` form.
|
|
# Calling the non-existent `tea issue comment ...` form does not error — tea
|
|
# silently falls through to a no-op and still exits 0, so a caller trusting
|
|
# the exit code alone believes a comment was posted when it was not (#865).
|
|
# Because that failure mode is silent, this script never trusts tea's exit
|
|
# code alone: after posting, it independently re-fetches the issue's comments
|
|
# via the Gitea REST API (curl — urllib is blocked by Cloudflare on this
|
|
# host) and fails closed if the posted body cannot be found.
|
|
#
|
|
# --login override: the default `--login` is resolved from the local `tea`
|
|
# login list for this repo's host (get_gitea_login). Pass --login <name> to
|
|
# override that default for this invocation only. The override is appended
|
|
# to the tea command line AFTER the detected default, because tea honors
|
|
# only the LAST `--login` flag on the command line — a flag placed before
|
|
# the default would be silently clobbered by it.
|
|
|
|
set -e
|
|
|
|
SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
|
|
source "$SCRIPT_DIR/detect-platform.sh"
|
|
|
|
# Parse arguments
|
|
ISSUE_NUMBER=""
|
|
COMMENT=""
|
|
LOGIN_OVERRIDE=""
|
|
|
|
while [[ $# -gt 0 ]]; do
|
|
case $1 in
|
|
-i|--issue)
|
|
ISSUE_NUMBER="$2"
|
|
shift 2
|
|
;;
|
|
-c|--comment)
|
|
COMMENT="$2"
|
|
shift 2
|
|
;;
|
|
-l|--login)
|
|
LOGIN_OVERRIDE="$2"
|
|
shift 2
|
|
;;
|
|
-h|--help)
|
|
echo "Usage: issue-comment.sh -i <issue_number> -c <comment> [--login <name>]"
|
|
echo ""
|
|
echo "Options:"
|
|
echo " -i, --issue Issue number (required)"
|
|
echo " -c, --comment Comment text (required)"
|
|
echo " -l, --login Override the detected Gitea tea login for this call"
|
|
echo " -h, --help Show this help"
|
|
exit 0
|
|
;;
|
|
*)
|
|
echo "Unknown option: $1"
|
|
exit 1
|
|
;;
|
|
esac
|
|
done
|
|
|
|
if [[ -z "$ISSUE_NUMBER" ]]; then
|
|
echo "Error: Issue number is required (-i)"
|
|
exit 1
|
|
fi
|
|
|
|
if [[ -z "$COMMENT" ]]; then
|
|
echo "Error: Comment is required (-c)"
|
|
exit 1
|
|
fi
|
|
|
|
detect_platform >/dev/null
|
|
|
|
# Independently re-fetch the issue's comments via the Gitea REST API and
|
|
# confirm one matches the body we just posted (see header comment: tea's
|
|
# exit code is not trustworthy evidence of a durable write on its own).
|
|
# Prints the matched comment ID to stdout on success.
|
|
gitea_verify_comment_posted() {
|
|
local issue_number="$1" comment_body="$2"
|
|
local host token configured_url repo api_base readback_response_file
|
|
|
|
host=$(get_remote_host)
|
|
token=$(get_gitea_token "$host") || {
|
|
echo "Error: Gitea token not found for comment read-back verification" >&2
|
|
return 1
|
|
}
|
|
configured_url=$(get_gitea_url_for_host "$host") || {
|
|
echo "Error: Configured Gitea URL not found for comment read-back verification" >&2
|
|
return 1
|
|
}
|
|
repo=$(get_gitea_repo_slug_for_url "$configured_url") || {
|
|
echo "Error: Could not resolve Gitea owner/repository relative to configured URL" >&2
|
|
return 1
|
|
}
|
|
api_base="${configured_url%/}/api/v1/repos/$repo"
|
|
|
|
readback_response_file=$(mktemp "${TMPDIR:-/tmp}/mosaic-issue-comment-readback.XXXXXX")
|
|
trap 'rm -f "$readback_response_file"' RETURN
|
|
|
|
if ! readback_status=$(curl -sS -o "$readback_response_file" -w '%{http_code}' \
|
|
-H "Authorization: token $token" \
|
|
"$api_base/issues/$issue_number/comments"); then
|
|
echo "Error: Gitea comment read-back transport failed" >&2
|
|
return 1
|
|
fi
|
|
if [[ "$readback_status" != "200" ]]; then
|
|
echo "Error: Gitea comment read-back failed with HTTP $readback_status" >&2
|
|
return 1
|
|
fi
|
|
|
|
EXPECTED_COMMENT_BODY="$comment_body" python3 - "$readback_response_file" <<'PY'
|
|
import json
|
|
import os
|
|
import sys
|
|
|
|
try:
|
|
with open(sys.argv[1], encoding="utf-8") as response:
|
|
comments = json.load(response)
|
|
if not isinstance(comments, list):
|
|
raise ValueError("response is not a comment list")
|
|
expected_body = os.environ["EXPECTED_COMMENT_BODY"]
|
|
matches = [c for c in comments if isinstance(c, dict) and c.get("body") == expected_body]
|
|
if not matches:
|
|
raise ValueError("no matching comment found on read-back")
|
|
best = max(matches, key=lambda c: c.get("id") or 0)
|
|
comment_id = best.get("id")
|
|
if not isinstance(comment_id, int) or comment_id <= 0:
|
|
raise ValueError("matching comment has no usable id")
|
|
except (OSError, json.JSONDecodeError, KeyError, TypeError, ValueError) as error:
|
|
print(f"Error: Gitea comment persistence verification failed: {error}", file=sys.stderr)
|
|
raise SystemExit(1)
|
|
print(comment_id)
|
|
PY
|
|
}
|
|
|
|
if [[ "$PLATFORM" == "github" ]]; then
|
|
gh issue comment "$ISSUE_NUMBER" --body "$COMMENT"
|
|
echo "Added comment to GitHub issue #$ISSUE_NUMBER"
|
|
elif [[ "$PLATFORM" == "gitea" ]]; then
|
|
# Build the invocation as an argv array (not unquoted $(get_gitea_repo_args)
|
|
# word-splitting) so the comment body — including Markdown backticks, $(...),
|
|
# and quotes — is passed verbatim and never re-split or shell-evaluated.
|
|
REPO_SLUG=$(get_repo_slug)
|
|
GITEA_LOGIN_NAME=$(get_gitea_login) || {
|
|
echo "Error: could not resolve a Gitea login for this repo; cannot comment on issue #$ISSUE_NUMBER." >&2
|
|
exit 1
|
|
}
|
|
TEA_ARGS=(comment "$ISSUE_NUMBER" "$COMMENT" --repo "$REPO_SLUG" --login "$GITEA_LOGIN_NAME")
|
|
# --login override goes LAST: tea honors only the final --login on its
|
|
# command line, so an override placed before the detected default above
|
|
# would be silently clobbered by it.
|
|
if [[ -n "$LOGIN_OVERRIDE" ]]; then
|
|
TEA_ARGS+=(--login "$LOGIN_OVERRIDE")
|
|
fi
|
|
tea "${TEA_ARGS[@]}"
|
|
|
|
comment_id=$(gitea_verify_comment_posted "$ISSUE_NUMBER" "$COMMENT") || {
|
|
echo "Error: could not verify comment landed on Gitea issue #$ISSUE_NUMBER via read-back; treating tea's exit code as untrustworthy (#865)." >&2
|
|
exit 1
|
|
}
|
|
echo "Added and verified comment on Gitea issue #$ISSUE_NUMBER (comment ID $comment_id)"
|
|
else
|
|
echo "Error: Unknown platform"
|
|
exit 1
|
|
fi
|