jarvis-enhance
a77afe6778
tmux resolves the two halves of a target with different, individually
dangerous defaults, and send-message.sh took both defaults:
* An unpinned name PREFIX-matches. With `foobar` alive and no `foo`,
`-t foo` resolves to `foobar` at rc=0 -- pasted, Enter-ed, verified
and reported OK against the wrong agent's pane.
* A bare `=name` is only half a pin. capture-pane REJECTS it ("can't
find pane") while list-panes silently PREFIX-MATCHES it, and the
validation at :76 uses list-panes -- so for any caller already
supplying `=name`, that rewrite was the only thing between them and
a wrong-session pass.
The direction is what makes this expensive. Paste (:93-94), Enter (:151)
and the verifying capture (:153) all read one EFFECTIVE_TARGET, so a
wrong-window send is confirmed by a wrong-window read: it manufactures a
false "delivered", not a loud failure. A false negative gets
investigated; a false positive gets believed.
Normalise to `=session:` -- exact session, active window. Explicit tmux
ids (%pane, @window, $session) pass through untouched.
BEHAVIOUR CHANGE for callers that already pass `=name`: they previously
landed on `:0.0` (window 0 unconditionally) and now land on the session's
ACTIVE window. This is the intended fix -- window 0 is not where a
multi-window agent is sitting -- but it does move a live target rather
than being a no-op normalisation.
Test: test-send-message-target.sh covers all four arms (absent name must
not prefix-match, delivery follows the active window, an explicit window
part is preserved, a unique prefix is still refused). Proven able to go
red: against the pre-fix script it FAILs at arm 1, and with arm 1 removed
it FAILs at arm 2. The multi-window fixture is load-bearing -- a
single-window session cannot tell `=s:` from `=s:0.0`, which is why this
survived.
It is registered as a signed enumeration exclusion rather than on a CI
surface: it drives a real tmux server and the CI image ships no tmux,
the same condition its two siblings are already excluded under. It
hard-fails when tmux is absent rather than skipping, so it cannot go
quietly green where it cannot run.
62 lines
6.0 KiB
Plaintext
62 lines
6.0 KiB
Plaintext
# test-enumeration-exclusions.txt — signed exclusions for check-test-enumeration.sh (#1017).
|
|
#
|
|
# Every entry is a recorded decision: a suite-shaped file that exists on disk,
|
|
# is NOT reachable from any CI surface, and carries the reason someone signed
|
|
# for that. The guard FAILS on an entry with no reason, a stale path, or a path
|
|
# the surfaces already enumerate. Burning an entry down = making it CI-reachable
|
|
# (package.json test:framework-shell or a ci.yml step) and deleting its line.
|
|
#
|
|
# Format: <repo-relative path> | <reason>
|
|
# All entries below were signed at #1017's filing base (main 826a8b3b, 2026-07-31)
|
|
# by pepper (sb-it-1-dt); measurements cited are one-run assertions from that seat.
|
|
|
|
# --- tools/git: the #1007 five — non-hermetic, resolve real credentials ---
|
|
packages/mosaic/framework/tools/git/test-pr-merge-gitea-empty-uid.sh | resolves real credentials (#1007 census); joins CI after the wrapper-half hermeticity fix (git -C scoping)
|
|
packages/mosaic/framework/tools/git/test-issue-create-interactive-auth.sh | resolves real credentials (#1007 census); joins CI after the wrapper-half hermeticity fix
|
|
packages/mosaic/framework/tools/git/test-pr-metadata-gitea.sh | resolves real credentials (#1007 census, fourth entry via family-grep); joins CI after the wrapper-half hermeticity fix
|
|
packages/mosaic/framework/tools/git/test-issue-comment-readback.sh | resolves real credentials (#1007 census, fifth entry); joins CI after the wrapper-half hermeticity fix
|
|
|
|
# --- tools/git: push guards — measured green locally, CI-image fitness unverified ---
|
|
packages/mosaic/framework/tools/git/test-push-guard.sh | measured green at 826a8b3b (46 passed / 0 failed, one run, 2026-07-31); CI-image fitness unverified; #1017 burndown
|
|
packages/mosaic/framework/tools/git/test-mutate-push-guard.sh | measured green at 826a8b3b (8/0, 13 mutants killed 0 survived, one run, 2026-07-31); requires setsid (util-linux), absent from the alpine base image; #1017 burndown
|
|
packages/mosaic/framework/tools/git/test-issue-create-body-safety.sh | hermeticity unaudited — the unprotected suite in #1007's protected/unprotected split; audit before CI; #1017 burndown
|
|
|
|
# --- tools/git: unmeasured ---
|
|
packages/mosaic/framework/tools/git/test-verify-clean-clone.sh | unmeasured in CI image; asserts git file-mode (100644/755) semantics that need verification on the CI filesystem first; #1017 burndown
|
|
packages/mosaic/framework/tools/git/test-help-exit-code.sh | unmeasured in CI image; stub-based (#701 regression harness), likely CI-fit; #1017 burndown
|
|
packages/mosaic/framework/tools/git/test-lane-brief-pr-linkage.sh | unmeasured in CI image; fixture-based (#546/#547 regression harness), likely CI-fit; #1017 burndown
|
|
|
|
# --- tools/tmux: require a live tmux server ---
|
|
packages/mosaic/framework/tools/tmux/test-send-message-socket.sh | requires a real tmux server on a throwaway socket; CI image ships no tmux; #1017 burndown (needs tmux in image or a signed permanent exclusion)
|
|
packages/mosaic/framework/tools/tmux/test-send-message-verdict.sh | requires real tmux-pane fixtures on a throwaway socket; CI image ships no tmux; #1017 burndown (same condition as its sibling)
|
|
# The entry below is NOT covered by the #1017 signature block above: it was
|
|
# signed by jarvis-enhance (dragon-lin, 2026-08-24) at a later base, for the
|
|
# test added alongside the send-message.sh exact-target fix.
|
|
packages/mosaic/framework/tools/tmux/test-send-message-target.sh | requires a real tmux server on a throwaway socket, and specifically a MULTI-WINDOW session (the bug it guards is invisible on a single-window fixture); CI image ships no tmux; same burndown condition as its two siblings above
|
|
|
|
# --- single-suite directories: unmeasured in CI ---
|
|
|
|
# --- naming-boundary files the strict test-*.sh prefix cannot even name ---
|
|
# (#1017: three independent censuses handled the microtest file three different
|
|
# ways — editorial drop, structural exclusion, accidental inclusion — with no
|
|
# recorded judgement. These lines ARE that judgement, signed.)
|
|
packages/mosaic/framework/tools/orchestrator/smoke-test.sh | behavior smoke checks for coord continue/run workflows, run manually by orchestrator seats; unmeasured in CI; #1017 burndown
|
|
packages/mosaic/framework/tools/wake/validate-973/microtest-wake-assert.sh | #973 instrument self-test, run as a precondition of the validate-973 evidence procedure rather than as a standing CI suite; #1017 burndown candidate
|
|
|
|
# --- tools/fleet: precondition is unsatisfiable in the CI image (#1271) ---
|
|
# Signed by fred (sb-it-1-dt, 2026-08-16) at origin/next 476db12.
|
|
# This suite asserts the launcher's behaviour when `mosaic` and `pi` are MISSING.
|
|
# It shims fakes into $FAKE_BIN, but the constructed PANE_PATH always ends in the
|
|
# real system path, so on a host that installs those binaries the missing-binary
|
|
# cases cannot be measured at all. The suite's own guard (line 103) says so and
|
|
# fails rather than reporting a pass it cannot back. That guard is correct.
|
|
# The error was wiring the suite into CI: #1017 (c56483eb) enumerated it and
|
|
# dropped this exclusion, and the CI image provides `pi` in the system path, so
|
|
# it has failed on every pipeline since. Measured 2026-08-16 across pipelines
|
|
# 2444 (#1256), 2438 (#1240) and 2441 (#1017-quality): exactly one FAIL line in
|
|
# each full log, identical, this assertion; control `zzz-not-present-zzz` -> 0.
|
|
# Burn-down and the full measurement are tracked in #1271; unwired by PR #1270.
|
|
# Because test:framework-shell is one && chain and this sat at position 44 of 48,
|
|
# the four suites after it had not run at all since the merge.
|
|
packages/mosaic/framework/tools/fleet/test-start-agent-session.sh | precondition unsatisfiable in the CI image: asserts missing-binary behaviour, but PANE_PATH always ends in the system path and the image provides `pi` there; guard at line 103 fails by design rather than passing unmeasured. Burn down by controlling the tail of PANE_PATH inside the test. NOT by removing `pi` from the image: the CI image installs @earendil-works/[email protected] deliberately (measured in pipeline 2444's test-step log), and other suites depend on that pin. Burn-down tracked in #1271
|