b0b2c20da0
F-01 (HIGH): issue-edit.sh and issue-assign.sh used string interpolation + eval to build CLI commands. Replace all eval sites with Bash arrays so user-supplied values (title, body, labels) are never shell-expanded. For the Gitea path, replace get_gitea_repo_args() (which emits %q-escaped strings designed for eval) with get_repo_slug() + get_gitea_login() so repo/login are passed as properly-quoted array elements. F-07 (MED): milestone-create.sh built the GitHub API JSON payload by string interpolation — a title containing " or $ broke the JSON. Rebuild with jq -n --arg so all values are safely serialised. Optional description key is omitted when empty, preserving existing behaviour. F-13 (LOW): pr-metadata.sh created a mktemp tmpfile inside curl_gitea_pull() but only removed it in success paths. Add trap 'rm -f "$body_file"' EXIT immediately after mktemp so early-exit paths (set -e, SIGINT) also clean up. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Kt2D8TsnDwhtzEAPijsNmR
131 lines
3.6 KiB
Bash
Executable File
131 lines
3.6 KiB
Bash
Executable File
#!/bin/bash
|
|
# milestone-create.sh - Create milestones on Gitea or GitHub
|
|
# Usage: milestone-create.sh -t "Title" [-d "Description"] [--due "YYYY-MM-DD"]
|
|
|
|
set -e
|
|
|
|
SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
|
|
source "$SCRIPT_DIR/detect-platform.sh"
|
|
|
|
# Default values
|
|
TITLE=""
|
|
DESCRIPTION=""
|
|
DUE_DATE=""
|
|
LIST_ONLY=false
|
|
|
|
usage() {
|
|
cat <<EOF
|
|
Usage: $(basename "$0") [OPTIONS]
|
|
|
|
Create or list milestones on the current repository (Gitea or GitHub).
|
|
|
|
Versioning Convention:
|
|
- Features get dedicated milestones
|
|
- Pre-MVP milestones MUST use 0.0.x and MUST start at 0.0.1
|
|
- 0.1.0 is reserved for MVP release
|
|
- After MVP, continue semantic progression (0.1.x, 0.2.x, ...)
|
|
|
|
Options:
|
|
-t, --title TITLE Milestone title/version (e.g., "0.0.1")
|
|
-d, --desc DESCRIPTION Milestone description
|
|
--due DATE Due date (YYYY-MM-DD format)
|
|
--list List existing milestones
|
|
-h, --help Show this help message
|
|
|
|
Examples:
|
|
$(basename "$0") --list
|
|
$(basename "$0") -t "0.0.1" -d "Pre-MVP Foundation Sprint"
|
|
$(basename "$0") -t "0.1.0" -d "MVP Release" --due "2025-03-01"
|
|
EOF
|
|
exit 1
|
|
}
|
|
|
|
# Parse arguments
|
|
while [[ $# -gt 0 ]]; do
|
|
case $1 in
|
|
-t|--title)
|
|
TITLE="$2"
|
|
shift 2
|
|
;;
|
|
-d|--desc)
|
|
DESCRIPTION="$2"
|
|
shift 2
|
|
;;
|
|
--due)
|
|
DUE_DATE="$2"
|
|
shift 2
|
|
;;
|
|
--list)
|
|
LIST_ONLY=true
|
|
shift
|
|
;;
|
|
-h|--help)
|
|
usage
|
|
;;
|
|
*)
|
|
echo "Unknown option: $1" >&2
|
|
usage
|
|
;;
|
|
esac
|
|
done
|
|
|
|
PLATFORM=$(detect_platform)
|
|
|
|
if [[ "$LIST_ONLY" == true ]]; then
|
|
case "$PLATFORM" in
|
|
github)
|
|
gh api repos/:owner/:repo/milestones --jq '.[] | "\(.number)\t\(.title)\t\(.state)\t\(.open_issues)/\(.closed_issues) issues"'
|
|
;;
|
|
gitea)
|
|
REPO_ARGS=$(get_gitea_repo_args) || {
|
|
echo "Error: Could not resolve Gitea repo/login for remote host" >&2
|
|
exit 1
|
|
}
|
|
tea milestones list $REPO_ARGS
|
|
;;
|
|
*)
|
|
echo "Error: Could not detect git platform" >&2
|
|
exit 1
|
|
;;
|
|
esac
|
|
exit 0
|
|
fi
|
|
|
|
if [[ -z "$TITLE" ]]; then
|
|
echo "Error: Title is required (-t) for creating milestones" >&2
|
|
usage
|
|
fi
|
|
|
|
case "$PLATFORM" in
|
|
github)
|
|
# GitHub uses the API for milestone creation
|
|
# Use jq to safely construct JSON so titles/descriptions containing
|
|
# quotes or special characters do not corrupt the payload (F-07).
|
|
JSON_PAYLOAD=$(jq -n \
|
|
--arg t "$TITLE" \
|
|
--arg d "$DESCRIPTION" \
|
|
--arg due "${DUE_DATE}" \
|
|
'{"title": $t}
|
|
+ (if $d != "" then {"description": $d} else {} end)
|
|
+ (if $due != "" then {"due_on": ($due + "T00:00:00Z")} else {} end)')
|
|
|
|
gh api repos/:owner/:repo/milestones --method POST --input - <<< "$JSON_PAYLOAD"
|
|
echo "Milestone '$TITLE' created successfully"
|
|
;;
|
|
gitea)
|
|
REPO_ARGS=$(get_gitea_repo_args) || {
|
|
echo "Error: Could not resolve Gitea repo/login for remote host" >&2
|
|
exit 1
|
|
}
|
|
CMD=(tea milestones create --title "$TITLE")
|
|
[[ -n "$DESCRIPTION" ]] && CMD+=(--description "$DESCRIPTION")
|
|
[[ -n "$DUE_DATE" ]] && CMD+=(--deadline "$DUE_DATE")
|
|
"${CMD[@]}" $REPO_ARGS
|
|
echo "Milestone '$TITLE' created successfully"
|
|
;;
|
|
*)
|
|
echo "Error: Could not detect git platform" >&2
|
|
exit 1
|
|
;;
|
|
esac
|