marcie
d326e6572a
ci/woodpecker/pr/ci Pipeline is pending
- Value guards now reject option-like values: --anything always, and single-dash flag shapes (-h, -i). Previously -b --help consumed --help as the body and performed the write (codex example: issue-close -i --help proceeding to 'Closed GitHub issue #--help'). Multi-char dash-leading text (-start of a list) stays a legal value. - Every remaining direct provider exec (gh/tea/CMD arrays across issue-create/edit/assign/list/view, milestone-*, pr-create/edit, pr-close, issue-close/reopen) wrapped with rc capture and normalized to exit 1 with a stderr message — provider exit 2 no longer collides with the reserved usage-error status. - All 16 usage-contract suites gained option-like and short-flag arms (16/16 green). Existing suites re-verified; test-pr-edit and test-issue-create-interactive-auth fail identically with these changes stashed (environment-coupled, not regressions; documented).
94 lines
3.3 KiB
Bash
Executable File
94 lines
3.3 KiB
Bash
Executable File
#!/bin/bash
|
|
# pr-close.sh - Close a pull request without merging on GitHub or Gitea
|
|
# Usage: pr-close.sh -n <pr_number> [-b <comment>]
|
|
# (-c/--comment is a backward-compatible alias for -b/--body; R1/R4 2026-08-28)
|
|
|
|
set -e
|
|
|
|
SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
|
|
source "$SCRIPT_DIR/detect-platform.sh"
|
|
|
|
# Parse arguments
|
|
PR_NUMBER=""
|
|
COMMENT=""
|
|
|
|
# Usage-error contract (R4, 2026-08-28): usage errors print to STDERR and exit 2,
|
|
# distinct from provider, credential, and verification failures (exit 1), so a
|
|
# caller or stop gate can tell an invocation defect from a delivery blocker.
|
|
usage_error() {
|
|
echo "Error: $*" >&2
|
|
echo "Usage: pr-close.sh -n <pr_number> [-b <comment>] (see --help)" >&2
|
|
exit 2
|
|
}
|
|
|
|
while [[ $# -gt 0 ]]; do
|
|
case $1 in
|
|
-n|--number)
|
|
[[ $# -ge 2 && "$2" != --* && ! "$2" =~ ^-[a-zA-Z]$ ]] || usage_error "option $1 requires a value (option-like values are rejected)"
|
|
PR_NUMBER="$2"
|
|
shift 2
|
|
;;
|
|
-b|--body|-c|--comment)
|
|
# R1 (2026-08-28): --body is the canonical flag; -c/--comment stays
|
|
# a backward-compatible alias.
|
|
[[ $# -ge 2 && "$2" != --* && ! "$2" =~ ^-[a-zA-Z]$ ]] || usage_error "option $1 requires a value (option-like values are rejected)"
|
|
COMMENT="$2"
|
|
shift 2
|
|
;;
|
|
-h|--help)
|
|
echo "Usage: pr-close.sh -n <pr_number> [-b <comment>]"
|
|
echo ""
|
|
echo "Options:"
|
|
echo " -n, --number PR number (required)"
|
|
echo " -b, --body Comment before closing (optional; canonical)"
|
|
echo " -c, --comment Alias for --body"
|
|
echo " -h, --help Show this help"
|
|
echo ""
|
|
echo "Exit codes: 0 success; 2 usage error (stderr); 1 provider/credential/verification failure."
|
|
exit 0
|
|
;;
|
|
*)
|
|
usage_error "unknown option: $1"
|
|
;;
|
|
esac
|
|
done
|
|
|
|
if [[ -z "$PR_NUMBER" ]]; then
|
|
usage_error "PR number is required (-n/--number)"
|
|
fi
|
|
|
|
detect_platform >/dev/null
|
|
|
|
if [[ "$PLATFORM" == "github" ]]; then
|
|
# R4: normalize provider failures to exit 1 (gh's own usage errors exit 2
|
|
# and would collide with the reserved usage-error status).
|
|
if [[ -n "$COMMENT" ]]; then
|
|
gh_rc=0
|
|
gh pr comment "$PR_NUMBER" --body "$COMMENT" || gh_rc=$?
|
|
if [[ "$gh_rc" -ne 0 ]]; then
|
|
echo "Error: GitHub PR comment before close failed (gh exit $gh_rc)" >&2
|
|
exit 1
|
|
fi
|
|
fi
|
|
gh_rc=0
|
|
gh pr close "$PR_NUMBER" || gh_rc=$?
|
|
if [[ "$gh_rc" -ne 0 ]]; then
|
|
echo "Error: GitHub PR close failed (gh exit $gh_rc)" >&2
|
|
exit 1
|
|
fi
|
|
echo "Closed GitHub PR #$PR_NUMBER"
|
|
elif [[ "$PLATFORM" == "gitea" ]]; then
|
|
if [[ -n "$COMMENT" ]]; then
|
|
prov_rc=0
|
|
tea pr comment "$PR_NUMBER" "$COMMENT" $(get_gitea_repo_args) || prov_rc=$?
|
|
[[ "$prov_rc" -eq 0 ]] || { echo "Error: provider command failed (exit ${prov_rc}; provider failure, not a usage error)" >&2; exit 1; }
|
|
fi
|
|
prov_rc=0
|
|
tea pr close "$PR_NUMBER" $(get_gitea_repo_args) || prov_rc=$?
|
|
[[ "$prov_rc" -eq 0 ]] || { echo "Error: provider command failed (exit ${prov_rc}; provider failure, not a usage error)" >&2; exit 1; }
|
|
echo "Closed Gitea PR #$PR_NUMBER"
|
|
else
|
|
echo "Error: Unknown platform"
|
|
exit 1
|
|
fi
|