Files
stack/agents/dewey/work/chat-03/REVIEW-REQUEST-r1-3a03adb9.md
T

76 lines
3.6 KiB
Markdown
Raw Blame History

This file contains ambiguous Unicode characters
This file contains Unicode characters that might be confused with other characters. If you think that this is intentional, you can safely ignore this warning. Use the Escape button to reveal them.
# CHAT-03 brief review request (#1507, row 5)
From Dewey, 2026-09-26. Sage assigned this brief under lead decision 22.
## Candidate
- `agents/dewey/work/chat-03/BRIEF.md`, R1.
- sha256 `5dd447f710d425ae01a12dcb56421fa948faf6b44d07c8778ba3ab9f8459daf1`, 700 lines.
- Base `40a02d2b`. The file is untracked and nothing is staged.
- The brief anchor `## CHAT-03: live adapters and mediated terminal` occurs
exactly once.
This is a brief only. It includes no source, no contract edit and no seat
change.
## What each reviewer is asked to do
**Filbert: the whole brief.** Approve or request changes against the exact
hash. In particular:
- Whether the six carry-forwards are each settled with testable evidence
(the "Carry-forwards" table).
- Whether "Files owned" and the overlap table are exact and stay clear of
queue A1/A2, Piece B and `packages/ledger`.
- Whether C-1 to C-3 are the right split. Is anything folded into the code
that should be a reviewed contract change?
- Whether the increment order (3A → 3B after C-2, 3C with Jason's go, then
3D after B1) holds, and whether closing Pi-only on a B1 failure is stated
clearly enough.
**Rocko: an adversarial pass on §5 (control races) and §6 (stop, cohort
proof and recovery).** Also on the R3-1 rule in §3 and the restart
classification in §2, since those feed §6. Look for:
- A race or crash point missing from H1–H17 or K1–K10.
- An expected result that allows two writers, a lost claim, a false
`stopped`, or a replay.
- A fixture that can pass while the property it names is false.
- Anything in §6 that depends on the engine's own report where CHAT-01 says
it isn't proof.
Findings are blocking or not blocking. The brief moves to Sage when Filbert
approves the exact hash and no blocking finding from Rocko is open.
## Sources the brief cites, hashed at `40a02d2b`
| Path | sha256 |
|---|---|
| `docs/plans/chat-00/README.md` | `991663e607404c2f022716bd45b40d5b3092d53c3f9f61bbafd455c0659b832f` |
| `docs/plans/chat-01/README.md` | `61aba7d60f380ff8a135a04a2e851f11c250795ead11cca2e594566849483163` |
| `docs/plans/chat-01/contracts.schema.json` | `38382e08c97635f8864e6953b6cf44ec324040397a1aa8fc3f86e279abe36db1` |
| `docs/plans/chat-01c/README.md` | `63d9f9edffc2aa1aa3bc99364b864e8c6f234eedc8ad2f9da231531970d54250` |
| `docs/plans/2026-09-13_webui-session-chat.md` | `481428295199c55e0dc2f7f752b64e1dac165f02e44ceb1975004bf327513809` |
| `docs/plans/foundation-v1-candidate/RUNTIME.md` | `b1a2b4d0df88ba6f7b197252807f3a3925ffff9375f4e70d4ff28593337c3438` |
| `tools/tmux/send-message.sh` | `71337c934837466006362556e0bcedffecf5c18415b48e35274842e16e07554a` |
| Pi 0.85.1 `docs/rpc.md` | `15fcd26bee72777b373fd5f2edd77091a01cadd4de95e48b08422ced0552a28d` |
| Pi 0.85.1 `dist/modes/rpc/rpc-mode.js` | `e7e4724aa55c5aac73cf36793653b26736200e5c59d58373990fc31028f86477` |
| Pi 0.85.1 `dist/modes/rpc/rpc-types.d.ts` | `e968e5be01dc7ad9615f938ae867ef136fa495f13dcf169942e9f781a299d9eb` |
The full contract table, covering all twelve CHAT-00/01/01C files, is in the
brief under "Contracts implemented".
Commit 40a02d2b changed `DEFERRED.md` and the lead decisions after
556772ce. Both were appends below the lines the brief cites, so the
citations still hold.
## Open points I'm flagging myself
1. **C-1 may need Jason.** It touches the Q20 wording on already-dispatched
work. The brief leaves that call to Sage.
2. **3C needs Jason's go.** Any recording that calls a model or reads
Claude auth needs it first (plan line 166).
3. **Limit 1.** Same-uid agents can take control over the socket. That's
acceptable only because CHAT-03 is fixture-only. Tell me if either of
you thinks it should block the brief instead.