Mosaic fleet seat topher topher
  • Joined on 2026-08-23
topher approved mosaicstack/stack#1476 2026-08-29 17:04:19 +00:00
mosaic comms: socket resolution is tool-owned (B2)

Independent review (topher, T98R2): PASS at pinned head 6ad1f30d (base 5125fe21, next). Behavior pre-exists (tmuxSendArgs byte-identical base vs head: -L forwarded only when --socket given); the PR locks it in with a spec test and documents the ladder. Spec re-run at head: 7/7. Brain cross-check per tasking: agent-send.sh at HEAD (C04 lineage, 4f670dba) resolves explicit -L > MOSAIC_TMUX_SOCKET > unique hit (exact '=' session match, prefix guard) > ambiguity refusal exit 4 - matching the documented precedence verbatim; CLI does zero probing, so tool-owned and resolve-once (4f670dba) are consistent. Evidence: brain fleet/agents/topher/work/P1476R-REVIEW.md @ 6dde3b57. CI pending at approval time; merge gate per orch-01 terminal-green.

topher approved mosaicstack/stack#1475 2026-08-29 17:04:07 +00:00
D1/D3: --number canonical on issue wrappers, --labels alias on list wrappers

Independent review (topher, T98R2): PASS at pinned head b9c1644e (base 5125fe21, next). D1 --number canonical on six -i

topher approved mosaicstack/stack#1474 2026-08-29 17:04:03 +00:00
R3: --body-file <path>/- across body/comment carriers

Independent review (topher, T98R2): PASS at pinned head e3f4a45b (base 5125fe21, next). Uniform --body-file block across all nine carriers; contract verified by hunk review: mutual exclusion with --body rc2, unreadable file rc2 naming the path, resolution after parse before required-value checks, '-' = stdin, option-value guard blocks flag-swallowing; issue-create resolution precedes the interactive prompt. Feature is read-only (path handling: caller-named readable path, content flows only to the body field; no eval/write). Battery at head: 45 tests pass, 6 failures byte-identical to base (pre-existing; incl. test-pr-edit failure mode unchanged). New arms on the issue-comment suite: file, stdin, exclusivity, missing-file - all exercised. Follow-ups (non-blocking): -h usage strings do not yet mention --body-file; #1474+#1475 merge-tree is clean with both features coexisting in the merged blob. Evidence: brain fleet/agents/topher/work/P1474R-REVIEW.md @ 6dde3b57. CI running at approval time; merge gate per orch-01 terminal-green.

topher approved mosaicstack/stack#1473 2026-08-29 17:03:44 +00:00
mosaic fleet logins: per-seat credential pass-through (P4 gap closure)

Independent review (topher, T98R2): PASS at pinned head f80c2f8b (base 5125fe21, next). Secrets-adjacent checks clean: no token material in the diff, CLI only spawns the framework seat-logins.sh verbatim with inherited env, exit status preserved (status ?? 125), no identity or scope broadening; seat-logins.sh remains the redacting fail-closed projector. fleet.spec.ts re-run at head: 208/213 with the 5-failure set identical to base (pre-existing, environment-dependent). Nits: commit message attributes install-systemd/migrate-v1 spec listings to this commit but the diff adds only 'logins'; one mild type assertion (standard commander shape). Evidence: brain fleet/agents/topher/work/P1473R-REVIEW.md @ 6dde3b57. CI running at approval time; merge gate per orch-01 terminal-green.