Files
stack/apps/coordinator
Jason Woltje 5d683d401e
Some checks failed
ci/woodpecker/push/woodpecker Pipeline failed
fix(#121): Remediate security issues from ORCH-121 review
Priority Fixes (Required Before Production):

H3: Add rate limiting to webhook endpoint
- Added slowapi library for FastAPI rate limiting
- Implemented per-IP rate limiting (100 req/min) on webhook endpoint
- Added global rate limiting support via slowapi

M4: Add subprocess timeouts to all gates
- Added timeout=300 (5 minutes) to all subprocess.run() calls in gates
- Implemented proper TimeoutExpired exception handling
- Removed dead CalledProcessError handlers (check=False makes them unreachable)

M2: Add input validation on QualityCheckRequest
- Validate files array size (max 1000 files)
- Validate file paths (no path traversal, no null bytes, no absolute paths)
- Validate diff summary size (max 10KB)
- Validate taskId and agentId format (non-empty)

Additional Fixes:

H1: Fix coverage.json path resolution
- Use absolute paths resolved from project root
- Validate path is within project boundaries (prevent path traversal)

Code Review Cleanup:
- Moved imports to module level in quality_orchestrator.py
- Refactored mock detection logic into separate helper methods
- Removed dead subprocess.CalledProcessError exception handlers from all gates

Testing:
- Added comprehensive tests for all security fixes
- All 339 coordinator tests pass
- All 447 orchestrator tests pass
- Followed TDD principles (RED-GREEN-REFACTOR)

Security Impact:
- Prevents webhook DoS attacks via rate limiting
- Prevents hung processes via subprocess timeouts
- Prevents path traversal attacks via input validation
- Prevents malformed input attacks via comprehensive validation

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
2026-02-04 11:50:05 -06:00
..

Mosaic Coordinator

FastAPI webhook receiver for Gitea issue events, enabling autonomous task coordination for AI agents.

Overview

The coordinator receives webhook events from Gitea when issues are assigned, unassigned, or closed. It verifies webhook authenticity via HMAC SHA256 signature and routes events to appropriate handlers.

Features

  • HMAC SHA256 signature verification
  • Event routing (assigned, unassigned, closed)
  • AI-powered issue metadata parsing (using Anthropic Sonnet)
  • Context estimation and agent assignment
  • Dependency tracking (blocks/blocked_by)
  • Comprehensive logging
  • Health check endpoint
  • Docker containerized
  • 95%+ test coverage

Development

Prerequisites

  • Python 3.11+
  • pip or uv package manager

Setup

# Install dependencies
pip install -e ".[dev]"

# Run tests
pytest

# Run with coverage
pytest --cov=src --cov-report=html

# Type checking
mypy src/

# Linting
ruff check src/

Running locally

# Copy environment template
cp .env.example .env

# Edit .env with your values
# GITEA_WEBHOOK_SECRET, GITEA_URL, ANTHROPIC_API_KEY

# Run server
uvicorn src.main:app --reload --port 8000

API Endpoints

POST /webhook/gitea

Receives Gitea webhook events.

Headers:

  • X-Gitea-Signature: HMAC SHA256 signature of request body

Response:

  • 200 OK: Event processed successfully
  • 401 Unauthorized: Invalid or missing signature
  • 422 Unprocessable Entity: Invalid payload

GET /health

Health check endpoint.

Response:

  • 200 OK: Service is healthy

Environment Variables

Variable Description Required Default
GITEA_WEBHOOK_SECRET Secret for HMAC signature verification Yes -
GITEA_URL Gitea instance URL Yes -
ANTHROPIC_API_KEY Anthropic API key for issue parsing Yes -
LOG_LEVEL Logging level (debug, info, warning, error) No info
HOST Server host No 0.0.0.0
PORT Server port No 8000

Docker

# Build
docker build -t mosaic-coordinator .

# Run
docker run -p 8000:8000 \
  -e GITEA_WEBHOOK_SECRET="your-secret" \
  -e GITEA_URL="https://git.mosaicstack.dev" \
  -e ANTHROPIC_API_KEY="your-anthropic-key" \
  mosaic-coordinator

Testing

# Run all tests
pytest

# Run with coverage (requires 85%+)
pytest --cov=src --cov-report=term-missing

# Run specific test file
pytest tests/test_security.py

# Run with verbose output
pytest -v

Architecture

apps/coordinator/
├── src/
│   ├── main.py             # FastAPI application
│   ├── webhook.py          # Webhook endpoint handlers
│   ├── parser.py           # Issue metadata parser (Anthropic)
│   ├── models.py           # Data models
│   ├── security.py         # HMAC signature verification
│   ├── config.py           # Configuration management
│   └── context_monitor.py  # Context usage monitoring
├── tests/
│   ├── test_security.py
│   ├── test_webhook.py
│   ├── test_parser.py
│   ├── test_context_monitor.py
│   └── conftest.py         # Pytest fixtures
├── pyproject.toml          # Project metadata & dependencies
├── .env.example            # Environment variable template
├── Dockerfile
└── README.md
  • #156 - Create coordinator bot user
  • #157 - Set up webhook receiver endpoint
  • #158 - Implement issue parser
  • #140 - Coordinator architecture