Compare commits
1
Commits
| Author | SHA1 | Date | |
|---|---|---|---|
|
|
99b8f6ea12 |
+1
-24
@@ -30,19 +30,6 @@ steps:
|
|||||||
# the baked pnpm store.
|
# the baked pnpm store.
|
||||||
- pnpm install --frozen-lockfile --prefer-offline
|
- pnpm install --frozen-lockfile --prefer-offline
|
||||||
|
|
||||||
# ---------------------------------------------------------------------------
|
|
||||||
# The steps below (sanitization, upgrade-guard, typecheck, lint, format,
|
|
||||||
# test) are the COMPLETE mandatory verification set. SDLC-D-034 mirrors them
|
|
||||||
# one-for-one in the canonical terminal verification command — root
|
|
||||||
# `pnpm verify:release` (scripts/verify-release.mjs) — which the publish
|
|
||||||
# pipeline (.woodpecker/publish.yml `verify` step) runs before ANY publish
|
|
||||||
# effect. These lines stay direct (not routed through the runner) because the
|
|
||||||
# #1017 test-enumeration guard audits framework tool paths through THIS
|
|
||||||
# surface; scripts/verify-release.test.mjs enforces that the runner's stage
|
|
||||||
# table keeps matching these commands exactly, so the two cannot drift.
|
|
||||||
# ---------------------------------------------------------------------------
|
|
||||||
|
|
||||||
# Canonical verify:release stage `sanitization`.
|
|
||||||
# Blocking gate: public framework package must contain no operator-specific
|
# Blocking gate: public framework package must contain no operator-specific
|
||||||
# personal data or private $HOME defaults. Runs early (no node_modules needed).
|
# personal data or private $HOME defaults. Runs early (no node_modules needed).
|
||||||
sanitization:
|
sanitization:
|
||||||
@@ -60,7 +47,6 @@ steps:
|
|||||||
# with everything it guards; this direct line keeps one instrument running.
|
# with everything it guards; this direct line keeps one instrument running.
|
||||||
- bash packages/mosaic/framework/tools/quality/scripts/check-test-enumeration.sh
|
- bash packages/mosaic/framework/tools/quality/scripts/check-test-enumeration.sh
|
||||||
|
|
||||||
# Canonical verify:release stage `upgrade-guard`.
|
|
||||||
# Blocking gate (#791): a framework upgrade must never write or delete an
|
# Blocking gate (#791): a framework upgrade must never write or delete an
|
||||||
# operator-owned path. The HARD GATE proves an unanticipated operator sentinel
|
# operator-owned path. The HARD GATE proves an unanticipated operator sentinel
|
||||||
# survives a keep-mode reseed byte-identical (with rsync present AND absent —
|
# survives a keep-mode reseed byte-identical (with rsync present AND absent —
|
||||||
@@ -82,8 +68,6 @@ steps:
|
|||||||
- bash packages/mosaic/framework/tools/quality/scripts/test-upgrade-durable-snapshot.sh
|
- bash packages/mosaic/framework/tools/quality/scripts/test-upgrade-durable-snapshot.sh
|
||||||
- bash packages/mosaic/framework/tools/quality/scripts/test-install-migration.sh
|
- bash packages/mosaic/framework/tools/quality/scripts/test-install-migration.sh
|
||||||
|
|
||||||
# Canonical verify:release stage `typecheck` — the same `pnpm typecheck`
|
|
||||||
# invocation (which runs the checkout preflight first, then turbo).
|
|
||||||
typecheck:
|
typecheck:
|
||||||
image: *node_image
|
image: *node_image
|
||||||
commands:
|
commands:
|
||||||
@@ -94,8 +78,7 @@ steps:
|
|||||||
- sanitization
|
- sanitization
|
||||||
- upgrade-guard
|
- upgrade-guard
|
||||||
|
|
||||||
# lint, format, and test are independent — run in parallel after typecheck.
|
# lint, format, and test are independent — run in parallel after typecheck
|
||||||
# Each runs exactly its canonical verify:release stage command.
|
|
||||||
lint:
|
lint:
|
||||||
image: *node_image
|
image: *node_image
|
||||||
commands:
|
commands:
|
||||||
@@ -112,12 +95,6 @@ steps:
|
|||||||
depends_on:
|
depends_on:
|
||||||
- typecheck
|
- typecheck
|
||||||
|
|
||||||
# Canonical verify:release stage `test` — the `pnpm test` line below is the
|
|
||||||
# shared command; everything else in this step is PIPELINE-LEVEL
|
|
||||||
# prerequisite the canonical command expects its caller to provide (SDLC-D-034):
|
|
||||||
# the ci-postgres service + pg_isready wait + db:migrate (postgres path),
|
|
||||||
# `apk add openssl`, and the pinned pi install. None of those can move into
|
|
||||||
# the runner (it must also work locally on the PGlite path with no database).
|
|
||||||
test:
|
test:
|
||||||
image: *node_image
|
image: *node_image
|
||||||
environment:
|
environment:
|
||||||
|
|||||||
@@ -1,19 +1,5 @@
|
|||||||
# Build, publish npm packages, and push Docker images
|
# Build, publish npm packages, and push Docker images
|
||||||
# Runs on main for stable publishes and on next for integration-line prereleases/images
|
# Runs on main for stable publishes and on next for integration-line prereleases/images
|
||||||
#
|
|
||||||
# SDLC-D-034 publish gate: every publish effect (publish-npm, publish-next-npm,
|
|
||||||
# and every image build/push step) depends DIRECTLY on the `verify` step below.
|
|
||||||
# `verify` (a) asserts the provider's commit identity matches the actual
|
|
||||||
# checkout (CI_COMMIT_SHA == git rev-parse HEAD, fail closed on mismatch or
|
|
||||||
# emptiness) and (b) runs the canonical terminal verification command
|
|
||||||
# (`pnpm verify:release`), which mirrors the PR CI pipeline's complete
|
|
||||||
# mandatory set (sanitization, upgrade-guard, preflight+typecheck, lint,
|
|
||||||
# format:check, test, build) — see scripts/verify-release.mjs. A missing,
|
|
||||||
# failed, skipped, cancelled, or inconclusive verification therefore skips the
|
|
||||||
# dependent publish effects (fail closed). Path-filtered short-circuits may
|
|
||||||
# skip publish EFFECTS (e.g. docs-only merges) but never bypass `verify` for a
|
|
||||||
# publish that does run: `verify` itself carries no path filter.
|
|
||||||
# scripts/verify-release.test.mjs enforces this DAG invariant at checkout time.
|
|
||||||
|
|
||||||
variables:
|
variables:
|
||||||
# Pre-baked CI base (see .woodpecker/ci-image.yml): node:24-alpine +
|
# Pre-baked CI base (see .woodpecker/ci-image.yml): node:24-alpine +
|
||||||
@@ -62,45 +48,6 @@ steps:
|
|||||||
# Resolve from the baked pnpm store instead of a cold network fetch.
|
# Resolve from the baked pnpm store instead of a cold network fetch.
|
||||||
- pnpm install --frozen-lockfile --prefer-offline
|
- pnpm install --frozen-lockfile --prefer-offline
|
||||||
|
|
||||||
# SDLC-D-034 exact-commit publish gate. No `when`/path filter on purpose: it
|
|
||||||
# runs for every event this pipeline serves so no publish effect can ever
|
|
||||||
# start without it. Fails closed on commit-identity mismatch (or either SHA
|
|
||||||
# being empty) and on any incomplete verification.
|
|
||||||
verify:
|
|
||||||
image: *node_image
|
|
||||||
commands:
|
|
||||||
- *enable_pnpm
|
|
||||||
# (a) Commit identity: the provider's claimed SHA must equal the actual
|
|
||||||
# checkout HEAD — verification of anything else must never authorize a
|
|
||||||
# publish of this commit.
|
|
||||||
- |
|
|
||||||
if [ -z "$CI_COMMIT_SHA" ]; then
|
|
||||||
echo "[verify] FATAL: CI_COMMIT_SHA is empty — cannot certify commit identity" >&2
|
|
||||||
exit 1
|
|
||||||
fi
|
|
||||||
CHECKOUT_SHA="$(git rev-parse HEAD 2>/dev/null || true)"
|
|
||||||
if [ -z "$CHECKOUT_SHA" ]; then
|
|
||||||
echo "[verify] FATAL: git rev-parse HEAD returned nothing — cannot certify commit identity" >&2
|
|
||||||
exit 1
|
|
||||||
fi
|
|
||||||
if [ "$CI_COMMIT_SHA" != "$CHECKOUT_SHA" ]; then
|
|
||||||
echo "[verify] FATAL: provider commit ($CI_COMMIT_SHA) != checkout HEAD ($CHECKOUT_SHA)" >&2
|
|
||||||
exit 1
|
|
||||||
fi
|
|
||||||
echo "[verify] commit identity confirmed: $CHECKOUT_SHA"
|
|
||||||
# (b) Canonical terminal verification. Caller-provided prerequisites the
|
|
||||||
# runner expects (see .woodpecker/ci.yml comments): bash/rsync for the
|
|
||||||
# guard stages, openssl + the pinned pi binary for the test stage. git is
|
|
||||||
# baked into ci-base but re-asserted here so the identity check above can
|
|
||||||
# never silently depend on a stale baked image. DATABASE_URL is
|
|
||||||
# deliberately NOT set: the canonical command must hold on the PGlite
|
|
||||||
# path too and never sets or requires a database itself.
|
|
||||||
- apk add --no-cache bash rsync openssl git
|
|
||||||
- npm install -g @earendil-works/[email protected]
|
|
||||||
- pnpm verify:release
|
|
||||||
depends_on:
|
|
||||||
- install
|
|
||||||
|
|
||||||
build:
|
build:
|
||||||
image: *node_image
|
image: *node_image
|
||||||
commands:
|
commands:
|
||||||
@@ -108,7 +55,6 @@ steps:
|
|||||||
- pnpm build
|
- pnpm build
|
||||||
depends_on:
|
depends_on:
|
||||||
- install
|
- install
|
||||||
- verify
|
|
||||||
|
|
||||||
publish-npm:
|
publish-npm:
|
||||||
image: *node_image
|
image: *node_image
|
||||||
@@ -168,7 +114,6 @@ steps:
|
|||||||
exit 1
|
exit 1
|
||||||
depends_on:
|
depends_on:
|
||||||
- build
|
- build
|
||||||
- verify
|
|
||||||
|
|
||||||
publish-next-npm:
|
publish-next-npm:
|
||||||
image: *node_image
|
image: *node_image
|
||||||
@@ -247,7 +192,6 @@ steps:
|
|||||||
echo "[publish-next] @mosaicstack/mosaic@next resolves to $RESOLVED_VERSION"
|
echo "[publish-next] @mosaicstack/mosaic@next resolves to $RESOLVED_VERSION"
|
||||||
depends_on:
|
depends_on:
|
||||||
- build
|
- build
|
||||||
- verify
|
|
||||||
|
|
||||||
# TODO: Uncomment when ready to publish to npmjs.org
|
# TODO: Uncomment when ready to publish to npmjs.org
|
||||||
# publish-npmjs:
|
# publish-npmjs:
|
||||||
@@ -261,7 +205,6 @@ steps:
|
|||||||
# - bash scripts/publish-npmjs.sh
|
# - bash scripts/publish-npmjs.sh
|
||||||
# depends_on:
|
# depends_on:
|
||||||
# - build
|
# - build
|
||||||
# - verify
|
|
||||||
# when:
|
# when:
|
||||||
# - event: [tag]
|
# - event: [tag]
|
||||||
|
|
||||||
@@ -299,7 +242,6 @@ steps:
|
|||||||
/kaniko/executor --context . --dockerfile docker/gateway.Dockerfile $DESTINATIONS
|
/kaniko/executor --context . --dockerfile docker/gateway.Dockerfile $DESTINATIONS
|
||||||
depends_on:
|
depends_on:
|
||||||
- build
|
- build
|
||||||
- verify
|
|
||||||
|
|
||||||
build-appservice:
|
build-appservice:
|
||||||
image: gcr.io/kaniko-project/executor:debug
|
image: gcr.io/kaniko-project/executor:debug
|
||||||
@@ -326,7 +268,6 @@ steps:
|
|||||||
/kaniko/executor --context . --dockerfile docker/appservice.Dockerfile $DESTINATIONS
|
/kaniko/executor --context . --dockerfile docker/appservice.Dockerfile $DESTINATIONS
|
||||||
depends_on:
|
depends_on:
|
||||||
- build
|
- build
|
||||||
- verify
|
|
||||||
|
|
||||||
build-web:
|
build-web:
|
||||||
image: gcr.io/kaniko-project/executor:debug
|
image: gcr.io/kaniko-project/executor:debug
|
||||||
@@ -353,4 +294,3 @@ steps:
|
|||||||
/kaniko/executor --context . --dockerfile docker/web.Dockerfile $DESTINATIONS
|
/kaniko/executor --context . --dockerfile docker/web.Dockerfile $DESTINATIONS
|
||||||
depends_on:
|
depends_on:
|
||||||
- build
|
- build
|
||||||
- verify
|
|
||||||
|
|||||||
@@ -34,6 +34,7 @@ export default tseslint.config(
|
|||||||
'packages/storage/vitest.config.ts',
|
'packages/storage/vitest.config.ts',
|
||||||
'packages/mosaic/vitest.config.ts',
|
'packages/mosaic/vitest.config.ts',
|
||||||
'packages/mosaic/__tests__/*.ts',
|
'packages/mosaic/__tests__/*.ts',
|
||||||
|
'packages/forge/__tests__/*.ts',
|
||||||
'tools/federation-harness/*.ts',
|
'tools/federation-harness/*.ts',
|
||||||
],
|
],
|
||||||
},
|
},
|
||||||
|
|||||||
@@ -9,7 +9,6 @@
|
|||||||
"preflight": "node scripts/preflight.mjs",
|
"preflight": "node scripts/preflight.mjs",
|
||||||
"clean:generated": "node scripts/clean-generated.mjs",
|
"clean:generated": "node scripts/clean-generated.mjs",
|
||||||
"typecheck": "pnpm preflight && turbo run typecheck",
|
"typecheck": "pnpm preflight && turbo run typecheck",
|
||||||
"verify:release": "node scripts/verify-release.mjs",
|
|
||||||
"test:checkout": "node --test scripts/*.test.mjs",
|
"test:checkout": "node --test scripts/*.test.mjs",
|
||||||
"test": "pnpm test:checkout && turbo run test && pnpm run test:installer",
|
"test": "pnpm test:checkout && turbo run test && pnpm run test:installer",
|
||||||
"test:installer": "bash tools/install-next-lane.test.sh",
|
"test:installer": "bash tools/install-next-lane.test.sh",
|
||||||
|
|||||||
@@ -539,3 +539,43 @@ Not every brief needs full Board of Directors review. The classification system
|
|||||||
### Backward compatibility
|
### Backward compatibility
|
||||||
|
|
||||||
Existing briefs without a `class` field are auto-classified. The default (no matching keywords) is `strategic`, so all existing runs get the full pipeline unless keywords trigger `technical`.
|
Existing briefs without a `class` field are auto-classified. The default (no matching keywords) is `strategic`, so all existing runs get the full pipeline unless keywords trigger `technical`.
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## Fail-Closed Execution & Explicit Simulation (SDLC-D-035)
|
||||||
|
|
||||||
|
**Added:** 2026-08-17
|
||||||
|
|
||||||
|
Forge fails closed when a required capability is missing. It never runs a
|
||||||
|
pipeline with a stub executor and reports success.
|
||||||
|
|
||||||
|
### Normal mode (default)
|
||||||
|
|
||||||
|
- No task executor wired → the CLI exits nonzero with the typed capability
|
||||||
|
error `FORGE_NO_EXECUTOR`. No run is created.
|
||||||
|
- A stage whose gate is approval-based (board approval, planning approvals,
|
||||||
|
remediation re-review, discovery/analysis attestations) records a typed
|
||||||
|
`waiting-for-authority` stage result and raises `FORGE_AUTHORITY_REQUIRED`.
|
||||||
|
It never passes vacuously.
|
||||||
|
- A stage whose gate requires an unwired provider (AI reviewer, CI pipeline)
|
||||||
|
records a typed `blocked` stage result and raises `FORGE_NO_REVIEWER` /
|
||||||
|
`FORGE_NO_CI_PIPELINE`. The synthetic echo-review approval in `06-review`
|
||||||
|
and all vacuous `true` gates were removed.
|
||||||
|
|
||||||
|
### Explicit simulation (`--simulate`)
|
||||||
|
|
||||||
|
Opts into stub/synthetic execution. Every stage result, every gate result, and
|
||||||
|
the run manifest carry the distinct typed status `simulated` (manifest also
|
||||||
|
records `mode: "simulated"`). `simulated` is a non-satisfying outcome:
|
||||||
|
`isSatisfyingOutcome()` and all completion/gate consumers treat only `passed`
|
||||||
|
as satisfying. The CLI exits 0 for a simulated run only because the caller
|
||||||
|
explicitly passed `--simulate`, and prints a loud SIMULATED banner.
|
||||||
|
|
||||||
|
### Typed outcome model
|
||||||
|
|
||||||
|
Every gate/task outcome is one of the closed set
|
||||||
|
`passed | failed | blocked | error | waiting-for-authority | simulated |
|
||||||
|
not-applicable`, with the reason recorded on the stage status and each gate
|
||||||
|
result in `manifest.json`. Missing implementations, missing gate evidence,
|
||||||
|
unknown stages, process errors, and timeouts map to fail-closed members —
|
||||||
|
never to `passed`.
|
||||||
|
|||||||
@@ -0,0 +1,319 @@
|
|||||||
|
import fs from 'node:fs';
|
||||||
|
import os from 'node:os';
|
||||||
|
import path from 'node:path';
|
||||||
|
import { describe, it, expect, beforeEach, afterEach } from 'vitest';
|
||||||
|
|
||||||
|
import { generateBoardTasks } from '../src/board-tasks.js';
|
||||||
|
import { STAGE_SPECS } from '../src/constants.js';
|
||||||
|
import { ForgeCapabilityError } from '../src/errors.js';
|
||||||
|
import {
|
||||||
|
evaluateStageGates,
|
||||||
|
gateLabel,
|
||||||
|
isCommandGate,
|
||||||
|
isSatisfyingOutcome,
|
||||||
|
} from '../src/outcomes.js';
|
||||||
|
import { loadManifest, runPipeline } from '../src/pipeline-runner.js';
|
||||||
|
import type { ForgeTask, ForgeTaskResult, TaskExecutor } from '../src/types.js';
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Mock real executor that returns typed results.
|
||||||
|
*
|
||||||
|
* Command gates are "verified" by the mock so normal-mode runs can pass
|
||||||
|
* mechanically gated stages; authority/provider gates are never reported
|
||||||
|
* because they have no mechanical implementation.
|
||||||
|
*/
|
||||||
|
function createTypedExecutor(options?: {
|
||||||
|
failStage?: string;
|
||||||
|
gateOutcomes?: Record<string, 'passed' | 'failed' | 'simulated' | 'error' | 'blocked'>;
|
||||||
|
}): TaskExecutor & { submittedTasks: ForgeTask[] } {
|
||||||
|
const submittedTasks: ForgeTask[] = [];
|
||||||
|
return {
|
||||||
|
submittedTasks,
|
||||||
|
async submitTask(task: ForgeTask) {
|
||||||
|
submittedTasks.push(task);
|
||||||
|
},
|
||||||
|
async waitForCompletion(taskId: string): Promise<ForgeTaskResult> {
|
||||||
|
const task = submittedTasks.find((t) => t.id === taskId);
|
||||||
|
const stageName = task?.metadata?.['stageName'] as string | undefined;
|
||||||
|
|
||||||
|
if (options?.failStage && stageName === options.failStage) {
|
||||||
|
return {
|
||||||
|
task_id: taskId,
|
||||||
|
outcome: 'failed',
|
||||||
|
reason: 'mock task failure',
|
||||||
|
completed_at: new Date().toISOString(),
|
||||||
|
exit_code: 1,
|
||||||
|
gate_results: [],
|
||||||
|
};
|
||||||
|
}
|
||||||
|
|
||||||
|
const gateResults = (task?.qualityGates ?? [])
|
||||||
|
.filter((gate) => isCommandGate(gate))
|
||||||
|
.map((gate) => {
|
||||||
|
const label = gateLabel(gate);
|
||||||
|
const outcome = options?.gateOutcomes?.[label] ?? 'passed';
|
||||||
|
return {
|
||||||
|
gate: label,
|
||||||
|
outcome,
|
||||||
|
reason: outcome === 'passed' ? 'mock verified' : `mock gate outcome: ${outcome}`,
|
||||||
|
};
|
||||||
|
});
|
||||||
|
|
||||||
|
return {
|
||||||
|
task_id: taskId,
|
||||||
|
outcome: 'passed',
|
||||||
|
reason: 'mock verified',
|
||||||
|
completed_at: new Date().toISOString(),
|
||||||
|
exit_code: 0,
|
||||||
|
gate_results: gateResults,
|
||||||
|
};
|
||||||
|
},
|
||||||
|
async getTaskStatus() {
|
||||||
|
return 'completed' as const;
|
||||||
|
},
|
||||||
|
};
|
||||||
|
}
|
||||||
|
|
||||||
|
describe('fail-closed: no executor wired', () => {
|
||||||
|
let tmpDir: string;
|
||||||
|
let briefPath: string;
|
||||||
|
|
||||||
|
beforeEach(() => {
|
||||||
|
tmpDir = fs.mkdtempSync(path.join(os.tmpdir(), 'forge-failclosed-'));
|
||||||
|
briefPath = path.join(tmpDir, 'brief.md');
|
||||||
|
fs.writeFileSync(briefPath, '# Fix bug\n\nA bugfix for lint cleanup.');
|
||||||
|
});
|
||||||
|
|
||||||
|
afterEach(() => {
|
||||||
|
fs.rmSync(tmpDir, { recursive: true, force: true });
|
||||||
|
});
|
||||||
|
|
||||||
|
it('throws a typed FORGE_NO_EXECUTOR capability error without --simulate', async () => {
|
||||||
|
await expect(
|
||||||
|
runPipeline(briefPath, tmpDir, {
|
||||||
|
// no executor, no simulate — must fail closed, never run with a stub
|
||||||
|
stages: ['00-intake'],
|
||||||
|
}),
|
||||||
|
).rejects.toMatchObject({
|
||||||
|
name: 'ForgeCapabilityError',
|
||||||
|
code: 'FORGE_NO_EXECUTOR',
|
||||||
|
capability: 'task-executor',
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|
||||||
|
it('does not create a run directory when failing closed on a missing executor', async () => {
|
||||||
|
try {
|
||||||
|
await runPipeline(briefPath, tmpDir, { stages: ['00-intake'] });
|
||||||
|
} catch {
|
||||||
|
// expected
|
||||||
|
}
|
||||||
|
expect(fs.existsSync(path.join(tmpDir, '.forge', 'runs'))).toBe(false);
|
||||||
|
});
|
||||||
|
|
||||||
|
it('completes with every result typed simulated when simulate is set', async () => {
|
||||||
|
const result = await runPipeline(briefPath, tmpDir, {
|
||||||
|
simulate: true,
|
||||||
|
stages: ['00-intake', '00b-discovery', '02-planning-1', '06-review'],
|
||||||
|
});
|
||||||
|
|
||||||
|
expect(result.manifest.mode).toBe('simulated');
|
||||||
|
expect(result.manifest.status).toBe('simulated');
|
||||||
|
|
||||||
|
for (const stage of result.stages) {
|
||||||
|
const stageStatus = result.manifest.stages[stage];
|
||||||
|
expect(stageStatus?.status, `stage ${stage}`).toBe('simulated');
|
||||||
|
expect(stageStatus?.status, `stage ${stage}`).not.toBe('passed');
|
||||||
|
expect(stageStatus?.reason, `stage ${stage}`).toBeTruthy();
|
||||||
|
for (const gateResult of stageStatus?.gateResults ?? []) {
|
||||||
|
expect(gateResult.outcome, `gate ${gateResult.gate} of ${stage}`).toBe('simulated');
|
||||||
|
expect(gateResult.outcome, `gate ${gateResult.gate} of ${stage}`).not.toBe('passed');
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// The persisted manifest agrees.
|
||||||
|
const persisted = loadManifest(result.runDir);
|
||||||
|
expect(persisted.mode).toBe('simulated');
|
||||||
|
expect(persisted.status).toBe('simulated');
|
||||||
|
expect(persisted.stages['02-planning-1']?.status).toBe('simulated');
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|
||||||
|
describe('fail-closed: typed outcome model', () => {
|
||||||
|
it('only passed satisfies the gate/dependency predicate', () => {
|
||||||
|
expect(isSatisfyingOutcome('passed')).toBe(true);
|
||||||
|
expect(isSatisfyingOutcome('failed')).toBe(false);
|
||||||
|
expect(isSatisfyingOutcome('blocked')).toBe(false);
|
||||||
|
expect(isSatisfyingOutcome('error')).toBe(false);
|
||||||
|
expect(isSatisfyingOutcome('waiting-for-authority')).toBe(false);
|
||||||
|
expect(isSatisfyingOutcome('simulated')).toBe(false);
|
||||||
|
expect(isSatisfyingOutcome('not-applicable')).toBe(false);
|
||||||
|
});
|
||||||
|
|
||||||
|
it('a simulated gate result cannot satisfy the stage gate evaluation', () => {
|
||||||
|
const evaluation = evaluateStageGates('05-coding', STAGE_SPECS['05-coding']!.qualityGates, {
|
||||||
|
task_id: 'FORGE-x-05',
|
||||||
|
outcome: 'passed',
|
||||||
|
reason: 'executor claims success',
|
||||||
|
completed_at: new Date().toISOString(),
|
||||||
|
exit_code: 0,
|
||||||
|
gate_results: [{ gate: 'pnpm lint', outcome: 'simulated', reason: 'simulated gate' }],
|
||||||
|
});
|
||||||
|
expect(isSatisfyingOutcome(evaluation.outcome)).toBe(false);
|
||||||
|
expect(evaluation.outcome).toBe('error');
|
||||||
|
});
|
||||||
|
|
||||||
|
it('a simulated task outcome cannot satisfy evaluation in normal mode', () => {
|
||||||
|
const evaluation = evaluateStageGates('00-intake', [], {
|
||||||
|
task_id: 'FORGE-x-00',
|
||||||
|
outcome: 'simulated',
|
||||||
|
reason: 'executor reported simulated',
|
||||||
|
completed_at: new Date().toISOString(),
|
||||||
|
exit_code: 0,
|
||||||
|
gate_results: [],
|
||||||
|
});
|
||||||
|
expect(isSatisfyingOutcome(evaluation.outcome)).toBe(false);
|
||||||
|
});
|
||||||
|
|
||||||
|
it('a missing gate result blocks the stage instead of passing vacuously', () => {
|
||||||
|
const evaluation = evaluateStageGates('05-coding', STAGE_SPECS['05-coding']!.qualityGates, {
|
||||||
|
task_id: 'FORGE-x-05',
|
||||||
|
outcome: 'passed',
|
||||||
|
reason: 'executor claims success',
|
||||||
|
completed_at: new Date().toISOString(),
|
||||||
|
exit_code: 0,
|
||||||
|
gate_results: [],
|
||||||
|
});
|
||||||
|
expect(evaluation.outcome).toBe('blocked');
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|
||||||
|
describe('fail-closed: authority and provider gates', () => {
|
||||||
|
let tmpDir: string;
|
||||||
|
let briefPath: string;
|
||||||
|
|
||||||
|
beforeEach(() => {
|
||||||
|
tmpDir = fs.mkdtempSync(path.join(os.tmpdir(), 'forge-authority-'));
|
||||||
|
briefPath = path.join(tmpDir, 'brief.md');
|
||||||
|
fs.writeFileSync(briefPath, '# Fix bug\n\nA bugfix for lint cleanup.');
|
||||||
|
});
|
||||||
|
|
||||||
|
afterEach(() => {
|
||||||
|
fs.rmSync(tmpDir, { recursive: true, force: true });
|
||||||
|
});
|
||||||
|
|
||||||
|
it.each(['02-planning-1', '03-planning-2', '04-planning-3', '07-remediate'])(
|
||||||
|
'planning/remediation stage %s yields waiting-for-authority (not passed) in normal mode',
|
||||||
|
async (stage) => {
|
||||||
|
const executor = createTypedExecutor();
|
||||||
|
let runDir: string | undefined;
|
||||||
|
|
||||||
|
try {
|
||||||
|
await runPipeline(briefPath, tmpDir, {
|
||||||
|
executor,
|
||||||
|
stages: [stage as string],
|
||||||
|
});
|
||||||
|
expect.unreachable('runPipeline should have failed closed');
|
||||||
|
} catch (err) {
|
||||||
|
expect(err).toBeInstanceOf(ForgeCapabilityError);
|
||||||
|
expect((err as ForgeCapabilityError).code).toBe('FORGE_AUTHORITY_REQUIRED');
|
||||||
|
runDir = path.join(tmpDir, '.forge', 'runs');
|
||||||
|
}
|
||||||
|
|
||||||
|
const runIds = fs.readdirSync(runDir!);
|
||||||
|
expect(runIds).toHaveLength(1);
|
||||||
|
const manifest = loadManifest(path.join(runDir!, runIds[0]!));
|
||||||
|
expect(manifest.stages[stage]?.status).toBe('waiting-for-authority');
|
||||||
|
expect(manifest.stages[stage]?.status).not.toBe('passed');
|
||||||
|
expect(manifest.status).toBe('waiting-for-authority');
|
||||||
|
},
|
||||||
|
);
|
||||||
|
|
||||||
|
it('review stage fails closed with a typed FORGE_NO_REVIEWER error in normal mode', async () => {
|
||||||
|
const executor = createTypedExecutor();
|
||||||
|
|
||||||
|
try {
|
||||||
|
await runPipeline(briefPath, tmpDir, {
|
||||||
|
executor,
|
||||||
|
stages: ['06-review'],
|
||||||
|
});
|
||||||
|
expect.unreachable('runPipeline should have failed closed');
|
||||||
|
} catch (err) {
|
||||||
|
expect(err).toBeInstanceOf(ForgeCapabilityError);
|
||||||
|
expect((err as ForgeCapabilityError).code).toBe('FORGE_NO_REVIEWER');
|
||||||
|
expect((err as ForgeCapabilityError).capability).toBe('reviewer');
|
||||||
|
}
|
||||||
|
|
||||||
|
const runsDir = path.join(tmpDir, '.forge', 'runs');
|
||||||
|
const runIds = fs.readdirSync(runsDir);
|
||||||
|
const manifest = loadManifest(path.join(runsDir, runIds[0]!));
|
||||||
|
expect(manifest.stages['06-review']?.status).toBe('blocked');
|
||||||
|
expect(manifest.stages['06-review']?.status).not.toBe('passed');
|
||||||
|
expect(manifest.status).toBe('failed');
|
||||||
|
});
|
||||||
|
|
||||||
|
it('review stage produces simulated results under --simulate', async () => {
|
||||||
|
const result = await runPipeline(briefPath, tmpDir, {
|
||||||
|
simulate: true,
|
||||||
|
stages: ['06-review'],
|
||||||
|
});
|
||||||
|
|
||||||
|
expect(result.manifest.mode).toBe('simulated');
|
||||||
|
expect(result.manifest.stages['06-review']?.status).toBe('simulated');
|
||||||
|
for (const gateResult of result.manifest.stages['06-review']?.gateResults ?? []) {
|
||||||
|
expect(gateResult.outcome).toBe('simulated');
|
||||||
|
}
|
||||||
|
});
|
||||||
|
|
||||||
|
it('deploy stage fails closed without a wired ci-pipeline provider in normal mode', async () => {
|
||||||
|
const executor = createTypedExecutor();
|
||||||
|
|
||||||
|
await expect(
|
||||||
|
runPipeline(briefPath, tmpDir, {
|
||||||
|
executor,
|
||||||
|
stages: ['09-deploy'],
|
||||||
|
}),
|
||||||
|
).rejects.toMatchObject({
|
||||||
|
name: 'ForgeCapabilityError',
|
||||||
|
code: 'FORGE_NO_CI_PIPELINE',
|
||||||
|
});
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|
||||||
|
describe('fail-closed: no vacuous gate commands remain', () => {
|
||||||
|
it('stage constants contain no echo/synthetic-approval, vacuous true, or empty gate commands', () => {
|
||||||
|
for (const [stageName, spec] of Object.entries(STAGE_SPECS)) {
|
||||||
|
for (const gate of spec.qualityGates) {
|
||||||
|
const serialized = JSON.stringify(gate);
|
||||||
|
// The echo-review synthetic approval must be gone.
|
||||||
|
expect(serialized, `stage ${stageName} gate ${serialized}`).not.toContain('echo');
|
||||||
|
expect(serialized, `stage ${stageName} gate ${serialized}`).not.toMatch(/"verdict"\s*:/);
|
||||||
|
expect(serialized, `stage ${stageName} gate ${serialized}`).not.toMatch(
|
||||||
|
/"summary"\s*:\s*"review-pass"/,
|
||||||
|
);
|
||||||
|
// No vacuous literal `true` gate.
|
||||||
|
expect(gate, `stage ${stageName}`).not.toBe('true');
|
||||||
|
// Command gates must carry a real, non-empty command.
|
||||||
|
if (isCommandGate(gate)) {
|
||||||
|
const command = typeof gate === 'string' ? gate : gate.command;
|
||||||
|
expect(command.trim().length, `stage ${stageName} gate ${serialized}`).toBeGreaterThan(0);
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
});
|
||||||
|
|
||||||
|
it('board tasks contain no vacuous true gates', () => {
|
||||||
|
const tmpDir = fs.mkdtempSync(path.join(os.tmpdir(), 'forge-board-gates-'));
|
||||||
|
try {
|
||||||
|
const tasks = generateBoardTasks('# Brief', [], tmpDir, 'BOARD-TEST');
|
||||||
|
for (const task of tasks) {
|
||||||
|
for (const gate of task.qualityGates) {
|
||||||
|
expect(gate, `task ${task.id}`).not.toBe('true');
|
||||||
|
const serialized = JSON.stringify(gate);
|
||||||
|
expect(serialized, `task ${task.id} gate ${serialized}`).not.toContain('echo');
|
||||||
|
}
|
||||||
|
}
|
||||||
|
} finally {
|
||||||
|
fs.rmSync(tmpDir, { recursive: true, force: true });
|
||||||
|
}
|
||||||
|
});
|
||||||
|
});
|
||||||
@@ -12,10 +12,10 @@ import {
|
|||||||
resumePipeline,
|
resumePipeline,
|
||||||
getPipelineStatus,
|
getPipelineStatus,
|
||||||
} from '../src/pipeline-runner.js';
|
} from '../src/pipeline-runner.js';
|
||||||
import type { ForgeTask, RunManifest, TaskExecutor } from '../src/types.js';
|
import type { ForgeTask, ForgeTaskResult, RunManifest, TaskExecutor } from '../src/types.js';
|
||||||
import type { TaskResult } from '@mosaicstack/macp';
|
import { gateLabel, isCommandGate } from '../src/outcomes.js';
|
||||||
|
|
||||||
/** Mock TaskExecutor that records submitted tasks and returns success. */
|
/** Mock TaskExecutor that records submitted tasks and returns typed results. */
|
||||||
function createMockExecutor(options?: {
|
function createMockExecutor(options?: {
|
||||||
failStage?: string;
|
failStage?: string;
|
||||||
}): TaskExecutor & { submittedTasks: ForgeTask[] } {
|
}): TaskExecutor & { submittedTasks: ForgeTask[] } {
|
||||||
@@ -25,7 +25,7 @@ function createMockExecutor(options?: {
|
|||||||
async submitTask(task: ForgeTask) {
|
async submitTask(task: ForgeTask) {
|
||||||
submittedTasks.push(task);
|
submittedTasks.push(task);
|
||||||
},
|
},
|
||||||
async waitForCompletion(taskId: string): Promise<TaskResult> {
|
async waitForCompletion(taskId: string): Promise<ForgeTaskResult> {
|
||||||
const failStage = options?.failStage;
|
const failStage = options?.failStage;
|
||||||
const task = submittedTasks.find((t) => t.id === taskId);
|
const task = submittedTasks.find((t) => t.id === taskId);
|
||||||
const stageName = task?.metadata?.['stageName'] as string | undefined;
|
const stageName = task?.metadata?.['stageName'] as string | undefined;
|
||||||
@@ -33,7 +33,8 @@ function createMockExecutor(options?: {
|
|||||||
if (failStage && stageName === failStage) {
|
if (failStage && stageName === failStage) {
|
||||||
return {
|
return {
|
||||||
task_id: taskId,
|
task_id: taskId,
|
||||||
status: 'failed',
|
outcome: 'failed',
|
||||||
|
reason: 'mock task failure',
|
||||||
completed_at: new Date().toISOString(),
|
completed_at: new Date().toISOString(),
|
||||||
exit_code: 1,
|
exit_code: 1,
|
||||||
gate_results: [],
|
gate_results: [],
|
||||||
@@ -41,10 +42,17 @@ function createMockExecutor(options?: {
|
|||||||
}
|
}
|
||||||
return {
|
return {
|
||||||
task_id: taskId,
|
task_id: taskId,
|
||||||
status: 'completed',
|
outcome: 'passed',
|
||||||
|
reason: 'mock verified',
|
||||||
completed_at: new Date().toISOString(),
|
completed_at: new Date().toISOString(),
|
||||||
exit_code: 0,
|
exit_code: 0,
|
||||||
gate_results: [],
|
gate_results: (task?.qualityGates ?? [])
|
||||||
|
.filter((gate) => isCommandGate(gate))
|
||||||
|
.map((gate) => ({
|
||||||
|
gate: gateLabel(gate),
|
||||||
|
outcome: 'passed' as const,
|
||||||
|
reason: 'mock verified',
|
||||||
|
})),
|
||||||
};
|
};
|
||||||
},
|
},
|
||||||
async getTaskStatus() {
|
async getTaskStatus() {
|
||||||
@@ -156,12 +164,13 @@ describe('runPipeline', () => {
|
|||||||
const executor = createMockExecutor();
|
const executor = createMockExecutor();
|
||||||
const result = await runPipeline(briefPath, tmpDir, {
|
const result = await runPipeline(briefPath, tmpDir, {
|
||||||
executor,
|
executor,
|
||||||
stages: ['00-intake', '00b-discovery'],
|
stages: ['00-intake', '05-coding'],
|
||||||
});
|
});
|
||||||
|
|
||||||
expect(result.runId).toMatch(/^\d{8}-\d{6}$/);
|
expect(result.runId).toMatch(/^\d{8}-\d{6}$/);
|
||||||
expect(result.stages).toEqual(['00-intake', '00b-discovery']);
|
expect(result.stages).toEqual(['00-intake', '05-coding']);
|
||||||
expect(result.manifest.status).toBe('completed');
|
expect(result.manifest.status).toBe('completed');
|
||||||
|
expect(result.manifest.mode).toBe('normal');
|
||||||
expect(executor.submittedTasks).toHaveLength(2);
|
expect(executor.submittedTasks).toHaveLength(2);
|
||||||
});
|
});
|
||||||
|
|
||||||
@@ -180,12 +189,17 @@ describe('runPipeline', () => {
|
|||||||
const executor = createMockExecutor();
|
const executor = createMockExecutor();
|
||||||
const result = await runPipeline(briefPath, tmpDir, {
|
const result = await runPipeline(briefPath, tmpDir, {
|
||||||
executor,
|
executor,
|
||||||
stages: ['00-intake', '00b-discovery'],
|
stages: ['00-intake', '05-coding'],
|
||||||
});
|
});
|
||||||
|
|
||||||
const manifest = loadManifest(result.runDir);
|
const manifest = loadManifest(result.runDir);
|
||||||
expect(manifest.stages['00-intake']?.status).toBe('passed');
|
expect(manifest.stages['00-intake']?.status).toBe('passed');
|
||||||
expect(manifest.stages['00b-discovery']?.status).toBe('passed');
|
expect(manifest.stages['05-coding']?.status).toBe('passed');
|
||||||
|
expect(manifest.stages['05-coding']?.gateResults?.map((g) => g.outcome)).toEqual([
|
||||||
|
'passed',
|
||||||
|
'passed',
|
||||||
|
'passed',
|
||||||
|
]);
|
||||||
});
|
});
|
||||||
|
|
||||||
it('respects CLI class override', async () => {
|
it('respects CLI class override', async () => {
|
||||||
@@ -215,7 +229,7 @@ describe('runPipeline', () => {
|
|||||||
const executor = createMockExecutor();
|
const executor = createMockExecutor();
|
||||||
await runPipeline(briefPath, tmpDir, {
|
await runPipeline(briefPath, tmpDir, {
|
||||||
executor,
|
executor,
|
||||||
stages: ['00-intake', '00b-discovery', '02-planning-1'],
|
stages: ['00-intake', '05-coding', '08-test'],
|
||||||
});
|
});
|
||||||
|
|
||||||
expect(executor.submittedTasks[0]!.dependsOn).toBeUndefined();
|
expect(executor.submittedTasks[0]!.dependsOn).toBeUndefined();
|
||||||
@@ -224,14 +238,14 @@ describe('runPipeline', () => {
|
|||||||
});
|
});
|
||||||
|
|
||||||
it('handles stage failure', async () => {
|
it('handles stage failure', async () => {
|
||||||
const executor = createMockExecutor({ failStage: '00b-discovery' });
|
const executor = createMockExecutor({ failStage: '05-coding' });
|
||||||
|
|
||||||
await expect(
|
await expect(
|
||||||
runPipeline(briefPath, tmpDir, {
|
runPipeline(briefPath, tmpDir, {
|
||||||
executor,
|
executor,
|
||||||
stages: ['00-intake', '00b-discovery'],
|
stages: ['00-intake', '05-coding'],
|
||||||
}),
|
}),
|
||||||
).rejects.toThrow('Stage 00b-discovery failed');
|
).rejects.toThrow('Stage 05-coding failed');
|
||||||
});
|
});
|
||||||
|
|
||||||
it('marks manifest as failed on stage failure', async () => {
|
it('marks manifest as failed on stage failure', async () => {
|
||||||
@@ -270,30 +284,143 @@ describe('resumePipeline', () => {
|
|||||||
fs.rmSync(tmpDir, { recursive: true, force: true });
|
fs.rmSync(tmpDir, { recursive: true, force: true });
|
||||||
});
|
});
|
||||||
|
|
||||||
it('resumes from first incomplete stage', async () => {
|
it('resumes from first incomplete stage and fails closed at the next provider gate', async () => {
|
||||||
// First run fails on discovery
|
// Simulate a run whose authority stages were approved out-of-band
|
||||||
const executor1 = createMockExecutor({ failStage: '00b-discovery' });
|
// (recorded as passed) and whose coding stage failed mechanically.
|
||||||
let runDir: string;
|
const runId = '20260101-000000';
|
||||||
|
const runDir = path.join(tmpDir, '.forge', 'runs', runId);
|
||||||
|
fs.mkdirSync(runDir, { recursive: true });
|
||||||
|
const passed = { status: 'passed' as const, startedAt: '2026-01-01T00:00:00Z' };
|
||||||
|
saveManifest(runDir, {
|
||||||
|
runId,
|
||||||
|
brief: briefPath,
|
||||||
|
codebase: tmpDir,
|
||||||
|
briefClass: 'hotfix',
|
||||||
|
classSource: 'frontmatter',
|
||||||
|
forceBoard: false,
|
||||||
|
mode: 'normal',
|
||||||
|
createdAt: '2026-01-01T00:00:00Z',
|
||||||
|
updatedAt: '2026-01-01T00:00:00Z',
|
||||||
|
currentStage: '05-coding',
|
||||||
|
status: 'failed',
|
||||||
|
stages: {
|
||||||
|
'00-intake': passed,
|
||||||
|
'00b-discovery': passed,
|
||||||
|
'02-planning-1': passed,
|
||||||
|
'03-planning-2': passed,
|
||||||
|
'04-planning-3': passed,
|
||||||
|
'05-coding': { status: 'failed', reason: 'gate failed' },
|
||||||
|
},
|
||||||
|
});
|
||||||
|
|
||||||
try {
|
// Resume re-runs 05-coding (the first non-passed stage), then fails
|
||||||
await runPipeline(briefPath, tmpDir, {
|
// closed at 06-review because no reviewer provider is wired.
|
||||||
executor: executor1,
|
const executor = createMockExecutor();
|
||||||
stages: ['00-intake', '00b-discovery', '02-planning-1'],
|
await expect(resumePipeline(runDir, executor)).rejects.toMatchObject({
|
||||||
});
|
name: 'ForgeCapabilityError',
|
||||||
} catch {
|
code: 'FORGE_NO_REVIEWER',
|
||||||
// expected
|
});
|
||||||
|
|
||||||
|
const manifest = loadManifest(runDir);
|
||||||
|
expect(manifest.stages['05-coding']?.status).toBe('passed');
|
||||||
|
expect(manifest.stages['06-review']?.status).toBe('blocked');
|
||||||
|
expect(manifest.status).toBe('failed');
|
||||||
|
});
|
||||||
|
|
||||||
|
it('resumes to completion as simulated under explicit simulate', async () => {
|
||||||
|
const runId = '20260101-000003';
|
||||||
|
const runDir = path.join(tmpDir, '.forge', 'runs', runId);
|
||||||
|
fs.mkdirSync(runDir, { recursive: true });
|
||||||
|
const passed = { status: 'passed' as const, startedAt: '2026-01-01T00:00:00Z' };
|
||||||
|
saveManifest(runDir, {
|
||||||
|
runId,
|
||||||
|
brief: briefPath,
|
||||||
|
codebase: tmpDir,
|
||||||
|
briefClass: 'hotfix',
|
||||||
|
classSource: 'frontmatter',
|
||||||
|
forceBoard: false,
|
||||||
|
mode: 'normal',
|
||||||
|
createdAt: '2026-01-01T00:00:00Z',
|
||||||
|
updatedAt: '2026-01-01T00:00:00Z',
|
||||||
|
currentStage: '05-coding',
|
||||||
|
status: 'failed',
|
||||||
|
stages: {
|
||||||
|
'00-intake': passed,
|
||||||
|
'00b-discovery': passed,
|
||||||
|
'02-planning-1': passed,
|
||||||
|
'03-planning-2': passed,
|
||||||
|
'04-planning-3': passed,
|
||||||
|
'05-coding': { status: 'failed', reason: 'gate failed' },
|
||||||
|
},
|
||||||
|
});
|
||||||
|
|
||||||
|
const result = await resumePipeline(runDir, undefined, { simulate: true });
|
||||||
|
|
||||||
|
expect(result.manifest.status).toBe('simulated');
|
||||||
|
expect(result.manifest.mode).toBe('simulated');
|
||||||
|
expect(result.stages[0]).toBe('05-coding');
|
||||||
|
for (const stage of result.stages) {
|
||||||
|
expect(result.manifest.stages[stage]?.status).toBe('simulated');
|
||||||
}
|
}
|
||||||
|
});
|
||||||
|
|
||||||
const runsDir = path.join(tmpDir, '.forge', 'runs');
|
it('fails closed on resume when the next stage needs authority sign-off', async () => {
|
||||||
runDir = path.join(runsDir, fs.readdirSync(runsDir)[0]!);
|
const runId = '20260101-000001';
|
||||||
|
const runDir = path.join(tmpDir, '.forge', 'runs', runId);
|
||||||
|
fs.mkdirSync(runDir, { recursive: true });
|
||||||
|
saveManifest(runDir, {
|
||||||
|
runId,
|
||||||
|
brief: briefPath,
|
||||||
|
codebase: tmpDir,
|
||||||
|
briefClass: 'hotfix',
|
||||||
|
classSource: 'frontmatter',
|
||||||
|
forceBoard: false,
|
||||||
|
mode: 'normal',
|
||||||
|
createdAt: '2026-01-01T00:00:00Z',
|
||||||
|
updatedAt: '2026-01-01T00:00:00Z',
|
||||||
|
currentStage: '00-intake',
|
||||||
|
status: 'in_progress',
|
||||||
|
stages: {
|
||||||
|
'00-intake': { status: 'passed' },
|
||||||
|
},
|
||||||
|
});
|
||||||
|
|
||||||
// Resume should pick up from 00b-discovery
|
const executor = createMockExecutor();
|
||||||
const executor2 = createMockExecutor();
|
await expect(resumePipeline(runDir, executor)).rejects.toMatchObject({
|
||||||
const result = await resumePipeline(runDir, executor2);
|
name: 'ForgeCapabilityError',
|
||||||
|
code: 'FORGE_AUTHORITY_REQUIRED',
|
||||||
|
});
|
||||||
|
|
||||||
expect(result.manifest.status).toBe('completed');
|
const manifest = loadManifest(runDir);
|
||||||
// Should have re-run from 00b-discovery onward
|
expect(manifest.stages['00b-discovery']?.status).toBe('waiting-for-authority');
|
||||||
expect(result.stages[0]).toBe('00b-discovery');
|
expect(manifest.status).toBe('waiting-for-authority');
|
||||||
|
});
|
||||||
|
|
||||||
|
it('fails closed on resume without an executor or --simulate', async () => {
|
||||||
|
const runId = '20260101-000002';
|
||||||
|
const runDir = path.join(tmpDir, '.forge', 'runs', runId);
|
||||||
|
fs.mkdirSync(runDir, { recursive: true });
|
||||||
|
saveManifest(runDir, {
|
||||||
|
runId,
|
||||||
|
brief: briefPath,
|
||||||
|
codebase: tmpDir,
|
||||||
|
briefClass: 'hotfix',
|
||||||
|
classSource: 'frontmatter',
|
||||||
|
forceBoard: false,
|
||||||
|
mode: 'normal',
|
||||||
|
createdAt: '2026-01-01T00:00:00Z',
|
||||||
|
updatedAt: '2026-01-01T00:00:00Z',
|
||||||
|
currentStage: '00-intake',
|
||||||
|
status: 'in_progress',
|
||||||
|
stages: {
|
||||||
|
'00-intake': { status: 'passed' },
|
||||||
|
},
|
||||||
|
});
|
||||||
|
|
||||||
|
await expect(resumePipeline(runDir)).rejects.toMatchObject({
|
||||||
|
name: 'ForgeCapabilityError',
|
||||||
|
code: 'FORGE_NO_EXECUTOR',
|
||||||
|
});
|
||||||
});
|
});
|
||||||
});
|
});
|
||||||
|
|
||||||
|
|||||||
@@ -95,7 +95,14 @@ export function generateBoardTasks(
|
|||||||
briefPath,
|
briefPath,
|
||||||
resultPath: resultRelPath,
|
resultPath: resultRelPath,
|
||||||
timeoutSeconds: 120,
|
timeoutSeconds: 120,
|
||||||
qualityGates: ['true'],
|
qualityGates: [
|
||||||
|
{
|
||||||
|
kind: 'authority',
|
||||||
|
capability: 'board-approval',
|
||||||
|
reason:
|
||||||
|
'persona evaluation is judged by board synthesis (authority review); no mechanical gate exists',
|
||||||
|
},
|
||||||
|
],
|
||||||
metadata: {
|
metadata: {
|
||||||
personaName: persona.name,
|
personaName: persona.name,
|
||||||
personaSlug: persona.slug,
|
personaSlug: persona.slug,
|
||||||
@@ -121,7 +128,13 @@ export function generateBoardTasks(
|
|||||||
timeoutSeconds: 120,
|
timeoutSeconds: 120,
|
||||||
dependsOn: personaTaskIds,
|
dependsOn: personaTaskIds,
|
||||||
dependsOnPolicy: 'all_terminal',
|
dependsOnPolicy: 'all_terminal',
|
||||||
qualityGates: ['true'],
|
qualityGates: [
|
||||||
|
{
|
||||||
|
kind: 'authority',
|
||||||
|
capability: 'board-approval',
|
||||||
|
reason: 'board synthesis is an authority decision; no mechanical gate exists',
|
||||||
|
},
|
||||||
|
],
|
||||||
metadata: {
|
metadata: {
|
||||||
resultOutputPath: synthesisResult,
|
resultOutputPath: synthesisResult,
|
||||||
inputResultPaths: personaResultPaths,
|
inputResultPaths: personaResultPaths,
|
||||||
|
|||||||
@@ -1,7 +1,11 @@
|
|||||||
|
import fs from 'node:fs';
|
||||||
|
import os from 'node:os';
|
||||||
|
import path from 'node:path';
|
||||||
import { Command } from 'commander';
|
import { Command } from 'commander';
|
||||||
import { describe, expect, it } from 'vitest';
|
import { describe, expect, it, vi, beforeEach, afterEach } from 'vitest';
|
||||||
|
|
||||||
import { registerForgeCommand } from './cli.js';
|
import { registerForgeCommand } from './cli.js';
|
||||||
|
import { loadManifest } from './pipeline-runner.js';
|
||||||
|
|
||||||
describe('registerForgeCommand', () => {
|
describe('registerForgeCommand', () => {
|
||||||
it('registers a "forge" command on the parent program', () => {
|
it('registers a "forge" command on the parent program', () => {
|
||||||
@@ -55,3 +59,94 @@ describe('registerForgeCommand', () => {
|
|||||||
}).not.toThrow();
|
}).not.toThrow();
|
||||||
});
|
});
|
||||||
});
|
});
|
||||||
|
|
||||||
|
describe('forge run fail-closed behavior (SDLC-D-035)', () => {
|
||||||
|
let tmpDir: string;
|
||||||
|
let briefPath: string;
|
||||||
|
let errSpy: ReturnType<typeof vi.spyOn>;
|
||||||
|
let logSpy: ReturnType<typeof vi.spyOn>;
|
||||||
|
let prevExitCode: string | number | null | undefined;
|
||||||
|
|
||||||
|
const parse = (args: string[]) => {
|
||||||
|
const program = new Command();
|
||||||
|
registerForgeCommand(program);
|
||||||
|
return program.parseAsync(['forge', ...args], { from: 'user' });
|
||||||
|
};
|
||||||
|
|
||||||
|
beforeEach(() => {
|
||||||
|
tmpDir = fs.mkdtempSync(path.join(os.tmpdir(), 'forge-cli-failclosed-'));
|
||||||
|
briefPath = path.join(tmpDir, 'brief.md');
|
||||||
|
fs.writeFileSync(briefPath, '# Fix bug\n\nA bugfix for lint cleanup.');
|
||||||
|
errSpy = vi.spyOn(console, 'error').mockImplementation(() => {});
|
||||||
|
logSpy = vi.spyOn(console, 'log').mockImplementation(() => {});
|
||||||
|
prevExitCode = process.exitCode;
|
||||||
|
});
|
||||||
|
|
||||||
|
afterEach(() => {
|
||||||
|
errSpy.mockRestore();
|
||||||
|
logSpy.mockRestore();
|
||||||
|
process.exitCode = prevExitCode;
|
||||||
|
fs.rmSync(tmpDir, { recursive: true, force: true });
|
||||||
|
});
|
||||||
|
|
||||||
|
it('exits nonzero with a typed FORGE_NO_EXECUTOR error when no executor is wired and --simulate is absent', async () => {
|
||||||
|
await parse(['run', '--brief', briefPath, '--codebase', tmpDir]);
|
||||||
|
|
||||||
|
expect(process.exitCode).toBe(1);
|
||||||
|
const errText = errSpy.mock.calls.map((c) => c.join(' ')).join('\n');
|
||||||
|
expect(errText).toContain('FORGE_NO_EXECUTOR');
|
||||||
|
// It must never run the pipeline with a stub and report success.
|
||||||
|
expect(fs.existsSync(path.join(tmpDir, '.forge', 'runs'))).toBe(false);
|
||||||
|
});
|
||||||
|
|
||||||
|
it('completes with typed simulated results and exit 0 under explicit --simulate', async () => {
|
||||||
|
await parse(['run', '--brief', briefPath, '--codebase', tmpDir, '--simulate']);
|
||||||
|
|
||||||
|
expect(process.exitCode).toBeUndefined();
|
||||||
|
|
||||||
|
// Loud simulated-mode summary.
|
||||||
|
const logText = logSpy.mock.calls.map((c) => c.join(' ')).join('\n');
|
||||||
|
expect(logText).toContain('SIMULATED');
|
||||||
|
|
||||||
|
// Manifest records the mode and simulated per-result statuses.
|
||||||
|
const runsDir = path.join(tmpDir, '.forge', 'runs');
|
||||||
|
const runIds = fs.readdirSync(runsDir);
|
||||||
|
expect(runIds).toHaveLength(1);
|
||||||
|
const manifest = loadManifest(path.join(runsDir, runIds[0]!));
|
||||||
|
expect(manifest.mode).toBe('simulated');
|
||||||
|
expect(manifest.status).toBe('simulated');
|
||||||
|
for (const stageStatus of Object.values(manifest.stages)) {
|
||||||
|
expect(stageStatus?.status).toBe('simulated');
|
||||||
|
for (const gateResult of stageStatus?.gateResults ?? []) {
|
||||||
|
expect(gateResult.outcome).toBe('simulated');
|
||||||
|
}
|
||||||
|
}
|
||||||
|
});
|
||||||
|
|
||||||
|
it('resume exits nonzero with a typed FORGE_NO_EXECUTOR error without --simulate', async () => {
|
||||||
|
const runDir = path.join(tmpDir, '.forge', 'runs', '20260101-000000');
|
||||||
|
fs.mkdirSync(runDir, { recursive: true });
|
||||||
|
fs.writeFileSync(
|
||||||
|
path.join(runDir, 'manifest.json'),
|
||||||
|
JSON.stringify({
|
||||||
|
runId: '20260101-000000',
|
||||||
|
brief: briefPath,
|
||||||
|
codebase: tmpDir,
|
||||||
|
briefClass: 'hotfix',
|
||||||
|
classSource: 'frontmatter',
|
||||||
|
forceBoard: false,
|
||||||
|
createdAt: '2026-01-01T00:00:00Z',
|
||||||
|
updatedAt: '2026-01-01T00:00:00Z',
|
||||||
|
currentStage: '00-intake',
|
||||||
|
status: 'in_progress',
|
||||||
|
stages: { '00-intake': { status: 'passed' } },
|
||||||
|
}),
|
||||||
|
);
|
||||||
|
|
||||||
|
await parse(['resume', '20260101-000000', '--project', tmpDir]);
|
||||||
|
|
||||||
|
expect(process.exitCode).toBe(1);
|
||||||
|
const errText = errSpy.mock.calls.map((c) => c.join(' ')).join('\n');
|
||||||
|
expect(errText).toContain('FORGE_NO_EXECUTOR');
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|||||||
+122
-48
@@ -5,37 +5,47 @@ import type { Command } from 'commander';
|
|||||||
|
|
||||||
import { classifyBrief } from './brief-classifier.js';
|
import { classifyBrief } from './brief-classifier.js';
|
||||||
import { STAGE_LABELS, STAGE_SEQUENCE } from './constants.js';
|
import { STAGE_LABELS, STAGE_SEQUENCE } from './constants.js';
|
||||||
|
import { ForgeCapabilityError } from './errors.js';
|
||||||
import { getEffectivePersonas, loadBoardPersonas } from './persona-loader.js';
|
import { getEffectivePersonas, loadBoardPersonas } from './persona-loader.js';
|
||||||
import { generateRunId, getPipelineStatus, loadManifest, runPipeline } from './pipeline-runner.js';
|
import { generateRunId, getPipelineStatus, loadManifest, runPipeline } from './pipeline-runner.js';
|
||||||
import type { PipelineOptions, RunManifest, TaskExecutor } from './types.js';
|
import { createSimulatedExecutor } from './simulated-executor.js';
|
||||||
|
import type { PipelineOptions, RunManifest, RunMode } from './types.js';
|
||||||
// ---------------------------------------------------------------------------
|
|
||||||
// Stub executor — used when no real executor is wired at CLI invocation time.
|
|
||||||
// ---------------------------------------------------------------------------
|
|
||||||
|
|
||||||
const stubExecutor: TaskExecutor = {
|
|
||||||
async submitTask(task) {
|
|
||||||
console.log(` [forge] stage submitted: ${task.id} (${task.title})`);
|
|
||||||
},
|
|
||||||
async waitForCompletion(taskId, _timeoutMs) {
|
|
||||||
console.log(` [forge] stage complete: ${taskId}`);
|
|
||||||
return {
|
|
||||||
task_id: taskId,
|
|
||||||
status: 'completed' as const,
|
|
||||||
completed_at: new Date().toISOString(),
|
|
||||||
exit_code: 0,
|
|
||||||
gate_results: [],
|
|
||||||
};
|
|
||||||
},
|
|
||||||
async getTaskStatus(_taskId) {
|
|
||||||
return 'completed' as const;
|
|
||||||
},
|
|
||||||
};
|
|
||||||
|
|
||||||
// ---------------------------------------------------------------------------
|
// ---------------------------------------------------------------------------
|
||||||
// Helpers
|
// Helpers
|
||||||
// ---------------------------------------------------------------------------
|
// ---------------------------------------------------------------------------
|
||||||
|
|
||||||
|
/** Resolve a run's effective mode, defaulting legacy manifests to normal. */
|
||||||
|
function runModeOf(manifest: RunManifest): RunMode {
|
||||||
|
return manifest.mode ?? 'normal';
|
||||||
|
}
|
||||||
|
|
||||||
|
/** Print a loud banner so a simulated run can never be misread as verified. */
|
||||||
|
function printSimulatedBanner(): void {
|
||||||
|
console.log('');
|
||||||
|
console.log('[forge] ===============================================================');
|
||||||
|
console.log('[forge] MODE: SIMULATED — no stage or gate was really executed.');
|
||||||
|
console.log('[forge] All results are synthetic and MUST NOT be read as verified');
|
||||||
|
console.log('[forge] success. Wire a real executor/providers and re-run to verify.');
|
||||||
|
console.log('[forge] ===============================================================');
|
||||||
|
}
|
||||||
|
|
||||||
|
/** Print a typed error line for fail-closed capability errors. */
|
||||||
|
function printCapabilityError(err: ForgeCapabilityError): void {
|
||||||
|
console.error(`[forge] error ${err.code}: ${err.message}`);
|
||||||
|
console.error(`[forge] missing capability: ${err.capability}`);
|
||||||
|
}
|
||||||
|
|
||||||
|
/** Handle a pipeline error uniformly: typed capability errors get their code. */
|
||||||
|
function handlePipelineError(err: unknown): void {
|
||||||
|
if (err instanceof ForgeCapabilityError) {
|
||||||
|
printCapabilityError(err);
|
||||||
|
} else {
|
||||||
|
console.error(`[forge] pipeline failed: ${err instanceof Error ? err.message : String(err)}`);
|
||||||
|
}
|
||||||
|
process.exitCode = 1;
|
||||||
|
}
|
||||||
|
|
||||||
function formatDuration(startedAt?: string, completedAt?: string): string {
|
function formatDuration(startedAt?: string, completedAt?: string): string {
|
||||||
if (!startedAt || !completedAt) return '-';
|
if (!startedAt || !completedAt) return '-';
|
||||||
const ms = new Date(completedAt).getTime() - new Date(startedAt).getTime();
|
const ms = new Date(completedAt).getTime() - new Date(startedAt).getTime();
|
||||||
@@ -44,19 +54,24 @@ function formatDuration(startedAt?: string, completedAt?: string): string {
|
|||||||
}
|
}
|
||||||
|
|
||||||
function printManifestTable(manifest: RunManifest): void {
|
function printManifestTable(manifest: RunManifest): void {
|
||||||
|
const mode = runModeOf(manifest);
|
||||||
console.log(`\nRun ID : ${manifest.runId}`);
|
console.log(`\nRun ID : ${manifest.runId}`);
|
||||||
console.log(`Status : ${manifest.status}`);
|
console.log(`Status : ${manifest.status}`);
|
||||||
|
console.log(`Mode : ${mode}`);
|
||||||
|
if (mode === 'simulated') {
|
||||||
|
console.log('WARNING: SIMULATED RUN — results are synthetic, not verified success.');
|
||||||
|
}
|
||||||
console.log(`Brief : ${manifest.brief}`);
|
console.log(`Brief : ${manifest.brief}`);
|
||||||
console.log(`Class : ${manifest.briefClass} (${manifest.classSource})`);
|
console.log(`Class : ${manifest.briefClass} (${manifest.classSource})`);
|
||||||
console.log(`Updated: ${manifest.updatedAt}`);
|
console.log(`Updated: ${manifest.updatedAt}`);
|
||||||
console.log('');
|
console.log('');
|
||||||
console.log('Stage'.padEnd(22) + 'Status'.padEnd(14) + 'Duration');
|
console.log('Stage'.padEnd(22) + 'Status'.padEnd(24) + 'Duration');
|
||||||
console.log('-'.repeat(50));
|
console.log('-'.repeat(60));
|
||||||
for (const stage of STAGE_SEQUENCE) {
|
for (const stage of STAGE_SEQUENCE) {
|
||||||
const s = manifest.stages[stage];
|
const s = manifest.stages[stage];
|
||||||
if (!s) continue;
|
if (!s) continue;
|
||||||
const label = (STAGE_LABELS[stage] ?? stage).padEnd(22);
|
const label = (STAGE_LABELS[stage] ?? stage).padEnd(22);
|
||||||
const status = s.status.padEnd(14);
|
const status = s.status.padEnd(24);
|
||||||
const dur = formatDuration(s.startedAt, s.completedAt);
|
const dur = formatDuration(s.startedAt, s.completedAt);
|
||||||
console.log(`${label}${status}${dur}`);
|
console.log(`${label}${status}${dur}`);
|
||||||
}
|
}
|
||||||
@@ -90,23 +105,58 @@ function listRecentRuns(projectRoot?: string): void {
|
|||||||
}
|
}
|
||||||
|
|
||||||
console.log('\nRecent runs:');
|
console.log('\nRecent runs:');
|
||||||
console.log('Run ID'.padEnd(22) + 'Status'.padEnd(14) + 'Brief');
|
console.log('Run ID'.padEnd(22) + 'Status'.padEnd(24) + 'Mode'.padEnd(12) + 'Brief');
|
||||||
console.log('-'.repeat(70));
|
console.log('-'.repeat(80));
|
||||||
|
|
||||||
for (const runId of entries) {
|
for (const runId of entries) {
|
||||||
const runDir = path.join(runsDir, runId);
|
const runDir = path.join(runsDir, runId);
|
||||||
try {
|
try {
|
||||||
const manifest = loadManifest(runDir);
|
const manifest = loadManifest(runDir);
|
||||||
const status = manifest.status.padEnd(14);
|
const status = manifest.status.padEnd(24);
|
||||||
|
const mode = runModeOf(manifest).padEnd(12);
|
||||||
const brief = path.basename(manifest.brief);
|
const brief = path.basename(manifest.brief);
|
||||||
console.log(`${runId.padEnd(22)}${status}${brief}`);
|
console.log(`${runId.padEnd(22)}${status}${mode}${brief}`);
|
||||||
} catch {
|
} catch {
|
||||||
console.log(`${runId.padEnd(22)}${'(unreadable)'.padEnd(14)}`);
|
console.log(`${runId.padEnd(22)}${'(unreadable)'.padEnd(24)}`);
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
console.log('');
|
console.log('');
|
||||||
}
|
}
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Apply the exit-code policy for a finished pipeline run (SDLC-D-035):
|
||||||
|
*
|
||||||
|
* - exit 0 only for a verified `completed` normal run, or for an overall
|
||||||
|
* `simulated` run when the caller explicitly passed --simulate;
|
||||||
|
* - anything else exits nonzero so it can never be read as success.
|
||||||
|
*/
|
||||||
|
function applyRunExitPolicy(result: { manifest: RunManifest; runDir: string }, simulate: boolean) {
|
||||||
|
const { manifest } = result;
|
||||||
|
|
||||||
|
if (runModeOf(manifest) === 'simulated') {
|
||||||
|
if (!simulate || manifest.status !== 'simulated') {
|
||||||
|
console.error(
|
||||||
|
'[forge] error FORGE_MODE_MISMATCH: run reports simulated results without an explicit, ' +
|
||||||
|
'consistent --simulate request; refusing to report success.',
|
||||||
|
);
|
||||||
|
process.exitCode = 1;
|
||||||
|
return;
|
||||||
|
}
|
||||||
|
printSimulatedBanner();
|
||||||
|
console.log(`[forge] run directory: ${result.runDir}`);
|
||||||
|
return; // exit 0 — the caller explicitly opted into simulation
|
||||||
|
}
|
||||||
|
|
||||||
|
if (manifest.status !== 'completed') {
|
||||||
|
console.error(`[forge] run did not complete: terminal status '${manifest.status}'`);
|
||||||
|
process.exitCode = 1;
|
||||||
|
return;
|
||||||
|
}
|
||||||
|
|
||||||
|
console.log(`[forge] pipeline complete (mode: normal): ${manifest.runId}`);
|
||||||
|
console.log(`[forge] run directory: ${result.runDir}`);
|
||||||
|
}
|
||||||
|
|
||||||
// ---------------------------------------------------------------------------
|
// ---------------------------------------------------------------------------
|
||||||
// Register function
|
// Register function
|
||||||
// ---------------------------------------------------------------------------
|
// ---------------------------------------------------------------------------
|
||||||
@@ -129,6 +179,11 @@ export function registerForgeCommand(parent: Command): void {
|
|||||||
.option('--config <path>', 'Path to forge config file (.forge/config.yaml)')
|
.option('--config <path>', 'Path to forge config file (.forge/config.yaml)')
|
||||||
.option('--codebase <path>', 'Codebase root to pass to the pipeline', process.cwd())
|
.option('--codebase <path>', 'Codebase root to pass to the pipeline', process.cwd())
|
||||||
.option('--dry-run', 'Print planned stages without executing', false)
|
.option('--dry-run', 'Print planned stages without executing', false)
|
||||||
|
.option(
|
||||||
|
'--simulate',
|
||||||
|
'Simulate execution without real providers (every result is typed simulated, never verified)',
|
||||||
|
false,
|
||||||
|
)
|
||||||
.action(
|
.action(
|
||||||
async (opts: {
|
async (opts: {
|
||||||
brief: string;
|
brief: string;
|
||||||
@@ -137,6 +192,7 @@ export function registerForgeCommand(parent: Command): void {
|
|||||||
config?: string;
|
config?: string;
|
||||||
codebase: string;
|
codebase: string;
|
||||||
dryRun: boolean;
|
dryRun: boolean;
|
||||||
|
simulate: boolean;
|
||||||
}) => {
|
}) => {
|
||||||
const briefPath = path.resolve(opts.brief);
|
const briefPath = path.resolve(opts.brief);
|
||||||
|
|
||||||
@@ -149,14 +205,22 @@ export function registerForgeCommand(parent: Command): void {
|
|||||||
const briefContent = fs.readFileSync(briefPath, 'utf-8');
|
const briefContent = fs.readFileSync(briefPath, 'utf-8');
|
||||||
const briefClass = classifyBrief(briefContent);
|
const briefClass = classifyBrief(briefContent);
|
||||||
const projectRoot = opts.codebase;
|
const projectRoot = opts.codebase;
|
||||||
|
// A real executor is never wired at CLI invocation time today, so the
|
||||||
|
// only executor we may construct is the explicitly-requested simulated
|
||||||
|
// one. Normal mode fails closed with FORGE_NO_EXECUTOR.
|
||||||
|
const executor = opts.simulate ? createSimulatedExecutor() : undefined;
|
||||||
|
|
||||||
if (opts.resume) {
|
if (opts.resume) {
|
||||||
const runId = opts.runId ?? generateRunId();
|
const runId = opts.runId ?? generateRunId();
|
||||||
const runDir = resolveRunDir(runId, projectRoot);
|
const runDir = resolveRunDir(runId, projectRoot);
|
||||||
console.log(`[forge] resuming run: ${runId}`);
|
console.log(`[forge] resuming run: ${runId}`);
|
||||||
const { resumePipeline } = await import('./pipeline-runner.js');
|
try {
|
||||||
const result = await resumePipeline(runDir, stubExecutor);
|
const { resumePipeline } = await import('./pipeline-runner.js');
|
||||||
console.log(`[forge] pipeline complete: ${result.runId}`);
|
const result = await resumePipeline(runDir, executor, { simulate: opts.simulate });
|
||||||
|
applyRunExitPolicy(result, opts.simulate);
|
||||||
|
} catch (err) {
|
||||||
|
handlePipelineError(err);
|
||||||
|
}
|
||||||
return;
|
return;
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -164,7 +228,8 @@ export function registerForgeCommand(parent: Command): void {
|
|||||||
briefClass,
|
briefClass,
|
||||||
codebase: projectRoot,
|
codebase: projectRoot,
|
||||||
dryRun: opts.dryRun,
|
dryRun: opts.dryRun,
|
||||||
executor: stubExecutor,
|
executor,
|
||||||
|
simulate: opts.simulate,
|
||||||
};
|
};
|
||||||
|
|
||||||
if (opts.dryRun) {
|
if (opts.dryRun) {
|
||||||
@@ -180,16 +245,15 @@ export function registerForgeCommand(parent: Command): void {
|
|||||||
|
|
||||||
console.log(`[forge] starting pipeline for brief: ${briefPath}`);
|
console.log(`[forge] starting pipeline for brief: ${briefPath}`);
|
||||||
console.log(`[forge] classified as: ${briefClass}`);
|
console.log(`[forge] classified as: ${briefClass}`);
|
||||||
|
if (opts.simulate) {
|
||||||
|
console.log('[forge] mode: SIMULATED (explicit --simulate)');
|
||||||
|
}
|
||||||
|
|
||||||
try {
|
try {
|
||||||
const result = await runPipeline(briefPath, projectRoot, pipelineOptions);
|
const result = await runPipeline(briefPath, projectRoot, pipelineOptions);
|
||||||
console.log(`[forge] pipeline complete: ${result.runId}`);
|
applyRunExitPolicy(result, opts.simulate);
|
||||||
console.log(`[forge] run directory: ${result.runDir}`);
|
|
||||||
} catch (err) {
|
} catch (err) {
|
||||||
console.error(
|
handlePipelineError(err);
|
||||||
`[forge] pipeline failed: ${err instanceof Error ? err.message : String(err)}`,
|
|
||||||
);
|
|
||||||
process.exitCode = 1;
|
|
||||||
}
|
}
|
||||||
},
|
},
|
||||||
);
|
);
|
||||||
@@ -224,7 +288,12 @@ export function registerForgeCommand(parent: Command): void {
|
|||||||
.command('resume <runId>')
|
.command('resume <runId>')
|
||||||
.description('Resume a stopped or failed pipeline run')
|
.description('Resume a stopped or failed pipeline run')
|
||||||
.option('--project <path>', 'Project root (defaults to cwd)', process.cwd())
|
.option('--project <path>', 'Project root (defaults to cwd)', process.cwd())
|
||||||
.action(async (runId: string, opts: { project: string }) => {
|
.option(
|
||||||
|
'--simulate',
|
||||||
|
'Simulate execution without real providers (every result is typed simulated, never verified)',
|
||||||
|
false,
|
||||||
|
)
|
||||||
|
.action(async (runId: string, opts: { project: string; simulate: boolean }) => {
|
||||||
const runDir = resolveRunDir(runId, opts.project);
|
const runDir = resolveRunDir(runId, opts.project);
|
||||||
|
|
||||||
if (!fs.existsSync(runDir)) {
|
if (!fs.existsSync(runDir)) {
|
||||||
@@ -234,15 +303,20 @@ export function registerForgeCommand(parent: Command): void {
|
|||||||
}
|
}
|
||||||
|
|
||||||
console.log(`[forge] resuming run: ${runId}`);
|
console.log(`[forge] resuming run: ${runId}`);
|
||||||
|
if (opts.simulate) {
|
||||||
|
console.log('[forge] mode: SIMULATED (explicit --simulate)');
|
||||||
|
}
|
||||||
|
|
||||||
|
// No real executor is wired at CLI invocation time; only the explicitly
|
||||||
|
// requested simulated executor may be constructed (fail closed otherwise).
|
||||||
|
const executor = opts.simulate ? createSimulatedExecutor() : undefined;
|
||||||
|
|
||||||
try {
|
try {
|
||||||
const { resumePipeline } = await import('./pipeline-runner.js');
|
const { resumePipeline } = await import('./pipeline-runner.js');
|
||||||
const result = await resumePipeline(runDir, stubExecutor);
|
const result = await resumePipeline(runDir, executor, { simulate: opts.simulate });
|
||||||
console.log(`[forge] pipeline complete: ${result.runId}`);
|
applyRunExitPolicy(result, opts.simulate);
|
||||||
console.log(`[forge] run directory: ${result.runDir}`);
|
|
||||||
} catch (err) {
|
} catch (err) {
|
||||||
console.error(`[forge] resume failed: ${err instanceof Error ? err.message : String(err)}`);
|
handlePipelineError(err);
|
||||||
process.exitCode = 1;
|
|
||||||
}
|
}
|
||||||
});
|
});
|
||||||
|
|
||||||
|
|||||||
@@ -9,7 +9,16 @@ export const PACKAGE_ROOT = path.resolve(path.dirname(fileURLToPath(import.meta.
|
|||||||
/** Pipeline asset directory (stages, agents, rails, gates, templates). */
|
/** Pipeline asset directory (stages, agents, rails, gates, templates). */
|
||||||
export const PIPELINE_DIR = path.join(PACKAGE_ROOT, 'pipeline');
|
export const PIPELINE_DIR = path.join(PACKAGE_ROOT, 'pipeline');
|
||||||
|
|
||||||
/** Stage specifications — defines every pipeline stage. */
|
/** Stage specifications — defines every pipeline stage.
|
||||||
|
*\n * Gate semantics (SDLC-D-035): every gate is one of
|
||||||
|
* - a real command string / GateEntry a mechanical runner can execute,
|
||||||
|
* - an `authority` gate (human/board sign-off; produces waiting-for-authority),
|
||||||
|
* - a `provider` gate (requires a wired provider such as a reviewer or CI pipeline).
|
||||||
|
*
|
||||||
|
* Vacuous gates (`true`, echo'd synthetic approvals, placeholder ci-pipeline
|
||||||
|
* commands) are forbidden: a stage whose gate has no real implementation
|
||||||
|
* fails closed instead of passing.
|
||||||
|
*/
|
||||||
export const STAGE_SPECS: Record<string, StageSpec> = {
|
export const STAGE_SPECS: Record<string, StageSpec> = {
|
||||||
'00-intake': {
|
'00-intake': {
|
||||||
number: '00',
|
number: '00',
|
||||||
@@ -27,7 +36,13 @@ export const STAGE_SPECS: Record<string, StageSpec> = {
|
|||||||
type: 'research',
|
type: 'research',
|
||||||
gate: 'discovery-complete',
|
gate: 'discovery-complete',
|
||||||
promptFile: '00b-discovery.md',
|
promptFile: '00b-discovery.md',
|
||||||
qualityGates: ['true'],
|
qualityGates: [
|
||||||
|
{
|
||||||
|
kind: 'authority',
|
||||||
|
capability: 'discovery-complete',
|
||||||
|
reason: 'discovery completion is attested by an authority; no mechanical check exists',
|
||||||
|
},
|
||||||
|
],
|
||||||
},
|
},
|
||||||
'01-board': {
|
'01-board': {
|
||||||
number: '01',
|
number: '01',
|
||||||
@@ -36,7 +51,13 @@ export const STAGE_SPECS: Record<string, StageSpec> = {
|
|||||||
type: 'review',
|
type: 'review',
|
||||||
gate: 'board-approval',
|
gate: 'board-approval',
|
||||||
promptFile: '01-board.md',
|
promptFile: '01-board.md',
|
||||||
qualityGates: [{ type: 'ci-pipeline', command: 'board-approval (via board-tasks)' }],
|
qualityGates: [
|
||||||
|
{
|
||||||
|
kind: 'authority',
|
||||||
|
capability: 'board-approval',
|
||||||
|
reason: 'board approval is a board/human decision; no mechanical gate exists',
|
||||||
|
},
|
||||||
|
],
|
||||||
},
|
},
|
||||||
'01b-brief-analyzer': {
|
'01b-brief-analyzer': {
|
||||||
number: '01b',
|
number: '01b',
|
||||||
@@ -45,7 +66,13 @@ export const STAGE_SPECS: Record<string, StageSpec> = {
|
|||||||
type: 'research',
|
type: 'research',
|
||||||
gate: 'brief-analysis-complete',
|
gate: 'brief-analysis-complete',
|
||||||
promptFile: '01-board.md',
|
promptFile: '01-board.md',
|
||||||
qualityGates: ['true'],
|
qualityGates: [
|
||||||
|
{
|
||||||
|
kind: 'authority',
|
||||||
|
capability: 'brief-analysis-complete',
|
||||||
|
reason: 'brief analysis completion is attested by an authority; no mechanical check exists',
|
||||||
|
},
|
||||||
|
],
|
||||||
},
|
},
|
||||||
'02-planning-1': {
|
'02-planning-1': {
|
||||||
number: '02',
|
number: '02',
|
||||||
@@ -54,7 +81,13 @@ export const STAGE_SPECS: Record<string, StageSpec> = {
|
|||||||
type: 'research',
|
type: 'research',
|
||||||
gate: 'architecture-approval',
|
gate: 'architecture-approval',
|
||||||
promptFile: '02-planning-1-architecture.md',
|
promptFile: '02-planning-1-architecture.md',
|
||||||
qualityGates: ['true'],
|
qualityGates: [
|
||||||
|
{
|
||||||
|
kind: 'authority',
|
||||||
|
capability: 'architecture-approval',
|
||||||
|
reason: 'ADR approval requires authority sign-off; no mechanical check exists',
|
||||||
|
},
|
||||||
|
],
|
||||||
},
|
},
|
||||||
'03-planning-2': {
|
'03-planning-2': {
|
||||||
number: '03',
|
number: '03',
|
||||||
@@ -63,7 +96,14 @@ export const STAGE_SPECS: Record<string, StageSpec> = {
|
|||||||
type: 'research',
|
type: 'research',
|
||||||
gate: 'implementation-approval',
|
gate: 'implementation-approval',
|
||||||
promptFile: '03-planning-2-implementation.md',
|
promptFile: '03-planning-2-implementation.md',
|
||||||
qualityGates: ['true'],
|
qualityGates: [
|
||||||
|
{
|
||||||
|
kind: 'authority',
|
||||||
|
capability: 'implementation-approval',
|
||||||
|
reason:
|
||||||
|
'implementation spec approval requires authority sign-off; no mechanical check exists',
|
||||||
|
},
|
||||||
|
],
|
||||||
},
|
},
|
||||||
'04-planning-3': {
|
'04-planning-3': {
|
||||||
number: '04',
|
number: '04',
|
||||||
@@ -72,7 +112,14 @@ export const STAGE_SPECS: Record<string, StageSpec> = {
|
|||||||
type: 'research',
|
type: 'research',
|
||||||
gate: 'decomposition-approval',
|
gate: 'decomposition-approval',
|
||||||
promptFile: '04-planning-3-decomposition.md',
|
promptFile: '04-planning-3-decomposition.md',
|
||||||
qualityGates: ['true'],
|
qualityGates: [
|
||||||
|
{
|
||||||
|
kind: 'authority',
|
||||||
|
capability: 'decomposition-approval',
|
||||||
|
reason:
|
||||||
|
'task decomposition approval requires authority sign-off; no mechanical check exists',
|
||||||
|
},
|
||||||
|
],
|
||||||
},
|
},
|
||||||
'05-coding': {
|
'05-coding': {
|
||||||
number: '05',
|
number: '05',
|
||||||
@@ -92,9 +139,10 @@ export const STAGE_SPECS: Record<string, StageSpec> = {
|
|||||||
promptFile: '06-review.md',
|
promptFile: '06-review.md',
|
||||||
qualityGates: [
|
qualityGates: [
|
||||||
{
|
{
|
||||||
type: 'ai-review',
|
kind: 'provider',
|
||||||
command:
|
capability: 'reviewer',
|
||||||
'echo \'{"summary":"review-pass","verdict":"approve","findings":[],"stats":{"blockers":0,"should_fix":0,"suggestions":0}}\'',
|
reason:
|
||||||
|
'review verdicts require a wired reviewer provider; synthetic approvals are not permitted',
|
||||||
},
|
},
|
||||||
],
|
],
|
||||||
},
|
},
|
||||||
@@ -105,7 +153,13 @@ export const STAGE_SPECS: Record<string, StageSpec> = {
|
|||||||
type: 'coding',
|
type: 'coding',
|
||||||
gate: 're-review',
|
gate: 're-review',
|
||||||
promptFile: '07-remediate.md',
|
promptFile: '07-remediate.md',
|
||||||
qualityGates: ['true'],
|
qualityGates: [
|
||||||
|
{
|
||||||
|
kind: 'authority',
|
||||||
|
capability: 're-review',
|
||||||
|
reason: 'remediation re-review is an approval-based gate; no mechanical check exists',
|
||||||
|
},
|
||||||
|
],
|
||||||
},
|
},
|
||||||
'08-test': {
|
'08-test': {
|
||||||
number: '08',
|
number: '08',
|
||||||
@@ -123,7 +177,13 @@ export const STAGE_SPECS: Record<string, StageSpec> = {
|
|||||||
type: 'deploy',
|
type: 'deploy',
|
||||||
gate: 'deploy-verification',
|
gate: 'deploy-verification',
|
||||||
promptFile: '09-deploy.md',
|
promptFile: '09-deploy.md',
|
||||||
qualityGates: [{ type: 'ci-pipeline', command: 'deploy-verification' }],
|
qualityGates: [
|
||||||
|
{
|
||||||
|
kind: 'provider',
|
||||||
|
capability: 'ci-pipeline',
|
||||||
|
reason: 'deploy verification requires a wired CI pipeline provider',
|
||||||
|
},
|
||||||
|
],
|
||||||
},
|
},
|
||||||
};
|
};
|
||||||
|
|
||||||
|
|||||||
@@ -0,0 +1,46 @@
|
|||||||
|
/**
|
||||||
|
* Typed fail-closed capability errors (SDLC-D-035).
|
||||||
|
*
|
||||||
|
* A Forge run must fail closed when a required capability (executor, reviewer
|
||||||
|
* provider, CI pipeline, authority sign-off) is missing. These typed errors
|
||||||
|
* name the missing capability so callers can distinguish "not wired" from
|
||||||
|
* ordinary execution failures.
|
||||||
|
*/
|
||||||
|
|
||||||
|
/** Closed set of typed Forge capability error codes. */
|
||||||
|
export const FORGE_ERROR_CODES = [
|
||||||
|
'FORGE_NO_EXECUTOR',
|
||||||
|
'FORGE_NO_REVIEWER',
|
||||||
|
'FORGE_NO_CI_PIPELINE',
|
||||||
|
'FORGE_NO_PROVIDER',
|
||||||
|
'FORGE_AUTHORITY_REQUIRED',
|
||||||
|
] as const;
|
||||||
|
|
||||||
|
export type ForgeErrorCode = (typeof FORGE_ERROR_CODES)[number];
|
||||||
|
|
||||||
|
/** Raised when a required capability is missing and the pipeline must fail closed. */
|
||||||
|
export class ForgeCapabilityError extends Error {
|
||||||
|
/** Typed error code from the closed FORGE_ERROR_CODES set. */
|
||||||
|
readonly code: ForgeErrorCode;
|
||||||
|
/** The missing capability, e.g. `task-executor`, `reviewer`, `board-approval`. */
|
||||||
|
readonly capability: string;
|
||||||
|
|
||||||
|
constructor(code: ForgeErrorCode, capability: string, message: string) {
|
||||||
|
super(message);
|
||||||
|
this.name = 'ForgeCapabilityError';
|
||||||
|
this.code = code;
|
||||||
|
this.capability = capability;
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
/** Map a provider gate capability to its typed error code. */
|
||||||
|
export function providerErrorCode(capability: string): ForgeErrorCode {
|
||||||
|
switch (capability) {
|
||||||
|
case 'reviewer':
|
||||||
|
return 'FORGE_NO_REVIEWER';
|
||||||
|
case 'ci-pipeline':
|
||||||
|
return 'FORGE_NO_CI_PIPELINE';
|
||||||
|
default:
|
||||||
|
return 'FORGE_NO_PROVIDER';
|
||||||
|
}
|
||||||
|
}
|
||||||
@@ -5,6 +5,13 @@ export type {
|
|||||||
StageSpec,
|
StageSpec,
|
||||||
BriefClass,
|
BriefClass,
|
||||||
ClassSource,
|
ClassSource,
|
||||||
|
ForgeOutcome,
|
||||||
|
AuthorityGate,
|
||||||
|
ProviderGate,
|
||||||
|
ForgeGate,
|
||||||
|
ForgeGateResult,
|
||||||
|
ForgeTaskResult,
|
||||||
|
RunMode,
|
||||||
StageStatus,
|
StageStatus,
|
||||||
RunManifest,
|
RunManifest,
|
||||||
ForgeTaskStatus,
|
ForgeTaskStatus,
|
||||||
@@ -81,5 +88,24 @@ export {
|
|||||||
getPipelineStatus,
|
getPipelineStatus,
|
||||||
} from './pipeline-runner.js';
|
} from './pipeline-runner.js';
|
||||||
|
|
||||||
|
// Fail-closed errors and typed outcome model (SDLC-D-035)
|
||||||
|
export { FORGE_ERROR_CODES, ForgeCapabilityError, providerErrorCode } from './errors.js';
|
||||||
|
export type { ForgeErrorCode } from './errors.js';
|
||||||
|
export {
|
||||||
|
isSatisfyingOutcome,
|
||||||
|
isCapabilityGate,
|
||||||
|
isCommandGate,
|
||||||
|
gateLabel,
|
||||||
|
uniformGateResults,
|
||||||
|
simulatedGateResults,
|
||||||
|
waitingGateResults,
|
||||||
|
blockedGateResults,
|
||||||
|
evaluateStageGates,
|
||||||
|
} from './outcomes.js';
|
||||||
|
export type { StageEvaluation } from './outcomes.js';
|
||||||
|
|
||||||
|
// Simulated executor (explicit --simulate only)
|
||||||
|
export { createSimulatedExecutor } from './simulated-executor.js';
|
||||||
|
|
||||||
// CLI
|
// CLI
|
||||||
export { registerForgeCommand } from './cli.js';
|
export { registerForgeCommand } from './cli.js';
|
||||||
|
|||||||
@@ -0,0 +1,147 @@
|
|||||||
|
import type { GateEntry } from '@mosaicstack/macp';
|
||||||
|
|
||||||
|
import type {
|
||||||
|
AuthorityGate,
|
||||||
|
ForgeGate,
|
||||||
|
ForgeGateResult,
|
||||||
|
ForgeOutcome,
|
||||||
|
ForgeTaskResult,
|
||||||
|
ProviderGate,
|
||||||
|
} from './types.js';
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Gate and dependency satisfaction predicate (SDLC-D-035).
|
||||||
|
*
|
||||||
|
* ONLY a verified `passed` outcome satisfies. Every other member of the closed
|
||||||
|
* outcome set — including `simulated` — is non-satisfying, so a simulated or
|
||||||
|
* authority-blocked result can never be read as success-by-verification.
|
||||||
|
*/
|
||||||
|
export function isSatisfyingOutcome(outcome: ForgeOutcome): boolean {
|
||||||
|
return outcome === 'passed';
|
||||||
|
}
|
||||||
|
|
||||||
|
/** Whether a gate is an authority or provider gate (capability-based, command-less). */
|
||||||
|
export function isCapabilityGate(gate: ForgeGate): gate is AuthorityGate | ProviderGate {
|
||||||
|
if (typeof gate !== 'object' || gate === null) return false;
|
||||||
|
const kind = (gate as Record<string, unknown>)['kind'];
|
||||||
|
return kind === 'authority' || kind === 'provider';
|
||||||
|
}
|
||||||
|
|
||||||
|
/** Whether a gate definition carries a real command a mechanical runner can execute. */
|
||||||
|
export function isCommandGate(gate: ForgeGate): gate is string | GateEntry {
|
||||||
|
if (typeof gate === 'string') {
|
||||||
|
return gate.trim().length > 0;
|
||||||
|
}
|
||||||
|
if (isCapabilityGate(gate)) {
|
||||||
|
// Authority and provider gates are satisfied by a capability, not a command.
|
||||||
|
return false;
|
||||||
|
}
|
||||||
|
return typeof gate.command === 'string' && gate.command.trim().length > 0;
|
||||||
|
}
|
||||||
|
|
||||||
|
/** Typed label identifying a gate in results and logs. */
|
||||||
|
export function gateLabel(gate: ForgeGate): string {
|
||||||
|
if (typeof gate === 'string') return gate;
|
||||||
|
if (isCapabilityGate(gate)) return `${gate.kind}:${gate.capability}`;
|
||||||
|
return gate.command || gate.type || 'unnamed-gate';
|
||||||
|
}
|
||||||
|
|
||||||
|
/** Reason string stamped on every simulated gate result. */
|
||||||
|
export const SIMULATED_GATE_REASON =
|
||||||
|
'simulated execution (--simulate): gate was not evaluated by a real implementation';
|
||||||
|
|
||||||
|
/** Build typed gate results with a uniform outcome for a stage's declared gates. */
|
||||||
|
export function uniformGateResults(
|
||||||
|
gates: ForgeGate[],
|
||||||
|
outcome: ForgeOutcome,
|
||||||
|
reason: string,
|
||||||
|
): ForgeGateResult[] {
|
||||||
|
return gates.map((gate) => ({ gate: gateLabel(gate), outcome, reason }));
|
||||||
|
}
|
||||||
|
|
||||||
|
/** Typed simulated gate results — used exclusively in `--simulate` runs. */
|
||||||
|
export function simulatedGateResults(gates: ForgeGate[]): ForgeGateResult[] {
|
||||||
|
return uniformGateResults(gates, 'simulated', SIMULATED_GATE_REASON);
|
||||||
|
}
|
||||||
|
|
||||||
|
/** Typed waiting-for-authority gate results for approval-based stages. */
|
||||||
|
export function waitingGateResults(gates: ForgeGate[], reason: string): ForgeGateResult[] {
|
||||||
|
return uniformGateResults(gates, 'waiting-for-authority', reason);
|
||||||
|
}
|
||||||
|
|
||||||
|
/** Typed blocked gate results for stages whose provider capability is not wired. */
|
||||||
|
export function blockedGateResults(gates: ForgeGate[], reason: string): ForgeGateResult[] {
|
||||||
|
return uniformGateResults(gates, 'blocked', reason);
|
||||||
|
}
|
||||||
|
|
||||||
|
/** Outcome of evaluating a completed stage in normal mode. */
|
||||||
|
export interface StageEvaluation {
|
||||||
|
outcome: ForgeOutcome;
|
||||||
|
reason: string;
|
||||||
|
gateResults: ForgeGateResult[];
|
||||||
|
}
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Evaluate a stage's declared gates against the executor's typed result.
|
||||||
|
*
|
||||||
|
* Fail-closed mapping:
|
||||||
|
* - a `simulated` task or gate outcome in normal mode maps to `error`
|
||||||
|
* - a missing gate result for a required command gate maps to `blocked`
|
||||||
|
* - a non-passing task outcome propagates as the stage outcome
|
||||||
|
* - only verified `passed` task and gate outcomes yield a `passed` stage
|
||||||
|
*/
|
||||||
|
export function evaluateStageGates(
|
||||||
|
stageName: string,
|
||||||
|
gates: ForgeGate[],
|
||||||
|
result: ForgeTaskResult,
|
||||||
|
): StageEvaluation {
|
||||||
|
const gateResults = result.gate_results ?? [];
|
||||||
|
|
||||||
|
if (result.outcome === 'simulated') {
|
||||||
|
return {
|
||||||
|
outcome: 'error',
|
||||||
|
reason: `executor reported a simulated outcome for stage '${stageName}' in normal mode — refusing to treat simulated results as verified`,
|
||||||
|
gateResults,
|
||||||
|
};
|
||||||
|
}
|
||||||
|
|
||||||
|
if (!isSatisfyingOutcome(result.outcome)) {
|
||||||
|
return {
|
||||||
|
outcome: result.outcome,
|
||||||
|
reason: `task outcome is '${result.outcome}': ${result.reason}`,
|
||||||
|
gateResults,
|
||||||
|
};
|
||||||
|
}
|
||||||
|
|
||||||
|
for (const gate of gates) {
|
||||||
|
// Authority and provider gates are pre-flighted before execution; they have
|
||||||
|
// no mechanical result to verify here.
|
||||||
|
if (!isCommandGate(gate)) continue;
|
||||||
|
|
||||||
|
const label = gateLabel(gate);
|
||||||
|
const gateResult = gateResults.find((r) => r.gate === label);
|
||||||
|
if (!gateResult) {
|
||||||
|
return {
|
||||||
|
outcome: 'blocked',
|
||||||
|
reason: `no gate result was reported for required gate '${label}' (stage '${stageName}')`,
|
||||||
|
gateResults,
|
||||||
|
};
|
||||||
|
}
|
||||||
|
if (!isSatisfyingOutcome(gateResult.outcome)) {
|
||||||
|
return {
|
||||||
|
outcome: gateResult.outcome === 'simulated' ? 'error' : gateResult.outcome,
|
||||||
|
reason: `gate '${label}' outcome is '${gateResult.outcome}': ${gateResult.reason}`,
|
||||||
|
gateResults,
|
||||||
|
};
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
return {
|
||||||
|
outcome: 'passed',
|
||||||
|
reason:
|
||||||
|
gates.length === 0
|
||||||
|
? "stage declares no gates; task outcome 'passed' accepted"
|
||||||
|
: 'all declared gates verified passed',
|
||||||
|
gateResults,
|
||||||
|
};
|
||||||
|
}
|
||||||
@@ -1,18 +1,33 @@
|
|||||||
import fs from 'node:fs';
|
import fs from 'node:fs';
|
||||||
import path from 'node:path';
|
import path from 'node:path';
|
||||||
|
|
||||||
import { STAGE_SEQUENCE } from './constants.js';
|
import { STAGE_SEQUENCE, STAGE_SPECS } from './constants.js';
|
||||||
import { determineBriefClass, stagesForClass } from './brief-classifier.js';
|
import { determineBriefClass, stagesForClass } from './brief-classifier.js';
|
||||||
|
import { ForgeCapabilityError, providerErrorCode } from './errors.js';
|
||||||
|
import {
|
||||||
|
blockedGateResults,
|
||||||
|
evaluateStageGates,
|
||||||
|
isCapabilityGate,
|
||||||
|
simulatedGateResults,
|
||||||
|
waitingGateResults,
|
||||||
|
} from './outcomes.js';
|
||||||
import { mapStageToTask } from './stage-adapter.js';
|
import { mapStageToTask } from './stage-adapter.js';
|
||||||
|
import { createSimulatedExecutor } from './simulated-executor.js';
|
||||||
import type {
|
import type {
|
||||||
ForgeTask,
|
ForgeTask,
|
||||||
|
ForgeTaskResult,
|
||||||
PipelineOptions,
|
PipelineOptions,
|
||||||
PipelineResult,
|
PipelineResult,
|
||||||
RunManifest,
|
RunManifest,
|
||||||
|
RunMode,
|
||||||
StageStatus,
|
StageStatus,
|
||||||
TaskExecutor,
|
TaskExecutor,
|
||||||
} from './types.js';
|
} from './types.js';
|
||||||
|
|
||||||
|
/** Reason stamped on stages that complete under explicit simulation. */
|
||||||
|
const SIMULATED_STAGE_REASON =
|
||||||
|
'simulated execution (--simulate): stage was not executed by a real executor';
|
||||||
|
|
||||||
/**
|
/**
|
||||||
* Generate a timestamp-based run ID.
|
* Generate a timestamp-based run ID.
|
||||||
*/
|
*/
|
||||||
@@ -47,6 +62,7 @@ function createManifest(opts: {
|
|||||||
briefClass: RunManifest['briefClass'];
|
briefClass: RunManifest['briefClass'];
|
||||||
classSource: RunManifest['classSource'];
|
classSource: RunManifest['classSource'];
|
||||||
forceBoard: boolean;
|
forceBoard: boolean;
|
||||||
|
mode: RunMode;
|
||||||
runDir: string;
|
runDir: string;
|
||||||
}): RunManifest {
|
}): RunManifest {
|
||||||
const ts = nowISO();
|
const ts = nowISO();
|
||||||
@@ -57,6 +73,7 @@ function createManifest(opts: {
|
|||||||
briefClass: opts.briefClass,
|
briefClass: opts.briefClass,
|
||||||
classSource: opts.classSource,
|
classSource: opts.classSource,
|
||||||
forceBoard: opts.forceBoard,
|
forceBoard: opts.forceBoard,
|
||||||
|
mode: opts.mode,
|
||||||
createdAt: ts,
|
createdAt: ts,
|
||||||
updatedAt: ts,
|
updatedAt: ts,
|
||||||
currentStage: '',
|
currentStage: '',
|
||||||
@@ -108,20 +125,199 @@ export function selectStages(stages?: string[], skipTo?: string): string[] {
|
|||||||
return selected.slice(skipIndex);
|
return selected.slice(skipIndex);
|
||||||
}
|
}
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Fail closed when the required executor capability is missing (SDLC-D-035).
|
||||||
|
*/
|
||||||
|
function requireExecutor(executor: TaskExecutor | undefined, simulate: boolean): TaskExecutor {
|
||||||
|
if (executor) return executor;
|
||||||
|
if (simulate) return createSimulatedExecutor({ log: false });
|
||||||
|
throw new ForgeCapabilityError(
|
||||||
|
'FORGE_NO_EXECUTOR',
|
||||||
|
'task-executor',
|
||||||
|
'no task executor is wired; refusing to run the pipeline with a stub executor (fail closed). ' +
|
||||||
|
'Pass --simulate to opt into explicitly simulated execution.',
|
||||||
|
);
|
||||||
|
}
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Pre-flight a stage's gates in normal mode (fail closed, SDLC-D-035).
|
||||||
|
*
|
||||||
|
* - authority gates: record a typed `waiting-for-authority` stage result and
|
||||||
|
* raise FORGE_AUTHORITY_REQUIRED — approval-based gates never pass vacuously.
|
||||||
|
* - provider gates: record a typed `blocked` stage result and raise the typed
|
||||||
|
* capability error for the missing provider.
|
||||||
|
*
|
||||||
|
* Returns the stage status to record when the pre-flight blocks, or undefined
|
||||||
|
* when the stage may proceed.
|
||||||
|
*/
|
||||||
|
function preflightStageGates(
|
||||||
|
stageName: string,
|
||||||
|
manifest: RunManifest,
|
||||||
|
): { status: StageStatus; error: ForgeCapabilityError } | undefined {
|
||||||
|
const spec = STAGE_SPECS[stageName];
|
||||||
|
if (!spec) throw new Error(`Unknown Forge stage: ${stageName}`);
|
||||||
|
|
||||||
|
for (const gate of spec.qualityGates) {
|
||||||
|
if (!isCapabilityGate(gate)) continue;
|
||||||
|
|
||||||
|
const startedAt = manifest.stages[stageName]?.startedAt;
|
||||||
|
const completedAt = nowISO();
|
||||||
|
|
||||||
|
if (gate.kind === 'authority') {
|
||||||
|
const reason = `gate '${gate.capability}' requires authority sign-off; no mechanical implementation exists (${gate.reason})`;
|
||||||
|
return {
|
||||||
|
status: {
|
||||||
|
status: 'waiting-for-authority',
|
||||||
|
reason,
|
||||||
|
startedAt,
|
||||||
|
completedAt,
|
||||||
|
gateResults: waitingGateResults(spec.qualityGates, reason),
|
||||||
|
},
|
||||||
|
error: new ForgeCapabilityError(
|
||||||
|
'FORGE_AUTHORITY_REQUIRED',
|
||||||
|
gate.capability,
|
||||||
|
`stage '${stageName}' is blocked on authority gate '${gate.capability}': ${gate.reason}. ` +
|
||||||
|
'The pipeline fails closed instead of passing vacuously. Record the approval out-of-band ' +
|
||||||
|
'or run with --simulate for explicitly simulated execution.',
|
||||||
|
),
|
||||||
|
};
|
||||||
|
}
|
||||||
|
|
||||||
|
const reason = `gate '${gate.capability}' requires provider '${gate.capability}' and none is wired (${gate.reason})`;
|
||||||
|
return {
|
||||||
|
status: {
|
||||||
|
status: 'blocked',
|
||||||
|
reason,
|
||||||
|
startedAt,
|
||||||
|
completedAt,
|
||||||
|
gateResults: blockedGateResults(spec.qualityGates, reason),
|
||||||
|
},
|
||||||
|
error: new ForgeCapabilityError(
|
||||||
|
providerErrorCode(gate.capability),
|
||||||
|
gate.capability,
|
||||||
|
`stage '${stageName}' requires provider '${gate.capability}' which is not wired: ${gate.reason}. ` +
|
||||||
|
'The pipeline fails closed instead of passing vacuously.',
|
||||||
|
),
|
||||||
|
};
|
||||||
|
}
|
||||||
|
|
||||||
|
return undefined;
|
||||||
|
}
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Execute the given stage tasks sequentially, updating the manifest.
|
||||||
|
*
|
||||||
|
* Normal mode requires a real executor and evaluates every declared command
|
||||||
|
* gate through the typed outcome model; any non-verified result fails closed.
|
||||||
|
* Simulate mode types every stage and gate result as `simulated`.
|
||||||
|
*/
|
||||||
|
async function executeStages(opts: {
|
||||||
|
manifest: RunManifest;
|
||||||
|
runDir: string;
|
||||||
|
tasks: ForgeTask[];
|
||||||
|
stageNames: string[];
|
||||||
|
executor: TaskExecutor;
|
||||||
|
simulate: boolean;
|
||||||
|
}): Promise<void> {
|
||||||
|
const { manifest, runDir, tasks, stageNames, executor, simulate } = opts;
|
||||||
|
|
||||||
|
for (let i = 0; i < tasks.length; i++) {
|
||||||
|
const task = tasks[i]!;
|
||||||
|
const stageName = stageNames[i]!;
|
||||||
|
const spec = STAGE_SPECS[stageName];
|
||||||
|
if (!spec) throw new Error(`Unknown Forge stage: ${stageName}`);
|
||||||
|
|
||||||
|
// Update manifest: stage in progress
|
||||||
|
manifest.currentStage = stageName;
|
||||||
|
manifest.stages[stageName] = {
|
||||||
|
status: 'in_progress',
|
||||||
|
startedAt: nowISO(),
|
||||||
|
};
|
||||||
|
saveManifest(runDir, manifest);
|
||||||
|
|
||||||
|
// Fail-closed pre-flight (normal mode only): authority/provider gates have
|
||||||
|
// no mechanical implementation and must never pass vacuously.
|
||||||
|
if (!simulate) {
|
||||||
|
const blocked = preflightStageGates(stageName, manifest);
|
||||||
|
if (blocked) {
|
||||||
|
manifest.stages[stageName] = blocked.status;
|
||||||
|
manifest.status =
|
||||||
|
blocked.status.status === 'waiting-for-authority' ? 'waiting-for-authority' : 'failed';
|
||||||
|
saveManifest(runDir, manifest);
|
||||||
|
throw blocked.error;
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
let result: ForgeTaskResult;
|
||||||
|
try {
|
||||||
|
await executor.submitTask(task);
|
||||||
|
result = await executor.waitForCompletion(task.id, task.timeoutSeconds * 1000);
|
||||||
|
} catch (error) {
|
||||||
|
// Process errors (including timeouts) map to the fail-closed `error` outcome.
|
||||||
|
const reason = error instanceof Error ? error.message : String(error);
|
||||||
|
manifest.stages[stageName] = {
|
||||||
|
status: 'error',
|
||||||
|
reason: `executor error: ${reason}`,
|
||||||
|
startedAt: manifest.stages[stageName]?.startedAt,
|
||||||
|
completedAt: nowISO(),
|
||||||
|
gateResults: [],
|
||||||
|
};
|
||||||
|
manifest.status = 'failed';
|
||||||
|
saveManifest(runDir, manifest);
|
||||||
|
throw error instanceof Error ? error : new Error(reason);
|
||||||
|
}
|
||||||
|
|
||||||
|
if (simulate) {
|
||||||
|
manifest.stages[stageName] = {
|
||||||
|
status: 'simulated',
|
||||||
|
reason: SIMULATED_STAGE_REASON,
|
||||||
|
startedAt: manifest.stages[stageName]?.startedAt,
|
||||||
|
completedAt: nowISO(),
|
||||||
|
gateResults: simulatedGateResults(spec.qualityGates),
|
||||||
|
};
|
||||||
|
saveManifest(runDir, manifest);
|
||||||
|
continue;
|
||||||
|
}
|
||||||
|
|
||||||
|
const evaluation = evaluateStageGates(stageName, spec.qualityGates, result);
|
||||||
|
manifest.stages[stageName] = {
|
||||||
|
status: evaluation.outcome,
|
||||||
|
reason: evaluation.reason,
|
||||||
|
startedAt: manifest.stages[stageName]?.startedAt,
|
||||||
|
completedAt: nowISO(),
|
||||||
|
gateResults: evaluation.gateResults,
|
||||||
|
};
|
||||||
|
|
||||||
|
if (evaluation.outcome !== 'passed') {
|
||||||
|
manifest.status =
|
||||||
|
evaluation.outcome === 'waiting-for-authority' ? 'waiting-for-authority' : 'failed';
|
||||||
|
saveManifest(runDir, manifest);
|
||||||
|
throw new Error(`Stage ${stageName} ${evaluation.outcome}: ${evaluation.reason}`);
|
||||||
|
}
|
||||||
|
|
||||||
|
saveManifest(runDir, manifest);
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
/**
|
/**
|
||||||
* Run the Forge pipeline.
|
* Run the Forge pipeline.
|
||||||
*
|
*
|
||||||
* 1. Classify the brief
|
* 1. Fail closed unless a real executor is wired or simulation is explicit
|
||||||
* 2. Generate a run ID and create run directory
|
* 2. Classify the brief
|
||||||
* 3. Map stages to tasks and submit to TaskExecutor
|
* 3. Generate a run ID and create run directory
|
||||||
* 4. Track manifest with stage statuses
|
* 4. Map stages to tasks and submit to TaskExecutor
|
||||||
* 5. Return pipeline result
|
* 5. Track manifest with typed stage outcomes
|
||||||
|
* 6. Return pipeline result
|
||||||
*/
|
*/
|
||||||
export async function runPipeline(
|
export async function runPipeline(
|
||||||
briefPath: string,
|
briefPath: string,
|
||||||
projectRoot: string,
|
projectRoot: string,
|
||||||
options: PipelineOptions,
|
options: PipelineOptions,
|
||||||
): Promise<PipelineResult> {
|
): Promise<PipelineResult> {
|
||||||
|
const simulate = options.simulate ?? false;
|
||||||
|
const executor = requireExecutor(options.executor, simulate);
|
||||||
|
const mode: RunMode = simulate ? 'simulated' : 'normal';
|
||||||
|
|
||||||
const resolvedRoot = path.resolve(projectRoot);
|
const resolvedRoot = path.resolve(projectRoot);
|
||||||
const resolvedBrief = path.resolve(briefPath);
|
const resolvedBrief = path.resolve(briefPath);
|
||||||
const briefContent = fs.readFileSync(resolvedBrief, 'utf-8');
|
const briefContent = fs.readFileSync(resolvedBrief, 'utf-8');
|
||||||
@@ -146,6 +342,7 @@ export async function runPipeline(
|
|||||||
briefClass,
|
briefClass,
|
||||||
classSource,
|
classSource,
|
||||||
forceBoard: options.forceBoard ?? false,
|
forceBoard: options.forceBoard ?? false,
|
||||||
|
mode,
|
||||||
runDir,
|
runDir,
|
||||||
});
|
});
|
||||||
|
|
||||||
@@ -172,54 +369,10 @@ export async function runPipeline(
|
|||||||
}
|
}
|
||||||
|
|
||||||
// Execute stages
|
// Execute stages
|
||||||
const { executor } = options;
|
await executeStages({ manifest, runDir, tasks, stageNames: selectedStages, executor, simulate });
|
||||||
for (let i = 0; i < tasks.length; i++) {
|
|
||||||
const task = tasks[i]!;
|
|
||||||
const stageName = selectedStages[i]!;
|
|
||||||
|
|
||||||
// Update manifest: stage in progress
|
// All stages reached a terminal state for this mode
|
||||||
manifest.currentStage = stageName;
|
manifest.status = simulate ? 'simulated' : 'completed';
|
||||||
manifest.stages[stageName] = {
|
|
||||||
status: 'in_progress',
|
|
||||||
startedAt: nowISO(),
|
|
||||||
};
|
|
||||||
saveManifest(runDir, manifest);
|
|
||||||
|
|
||||||
try {
|
|
||||||
await executor.submitTask(task);
|
|
||||||
const result = await executor.waitForCompletion(task.id, task.timeoutSeconds * 1000);
|
|
||||||
|
|
||||||
// Update manifest: stage completed or failed
|
|
||||||
const stageStatus: StageStatus = {
|
|
||||||
status: result.status === 'completed' ? 'passed' : 'failed',
|
|
||||||
startedAt: manifest.stages[stageName]!.startedAt,
|
|
||||||
completedAt: nowISO(),
|
|
||||||
};
|
|
||||||
manifest.stages[stageName] = stageStatus;
|
|
||||||
|
|
||||||
if (result.status !== 'completed') {
|
|
||||||
manifest.status = 'failed';
|
|
||||||
saveManifest(runDir, manifest);
|
|
||||||
throw new Error(`Stage ${stageName} failed with status: ${result.status}`);
|
|
||||||
}
|
|
||||||
|
|
||||||
saveManifest(runDir, manifest);
|
|
||||||
} catch (error) {
|
|
||||||
if (!manifest.stages[stageName]?.completedAt) {
|
|
||||||
manifest.stages[stageName] = {
|
|
||||||
status: 'failed',
|
|
||||||
startedAt: manifest.stages[stageName]?.startedAt,
|
|
||||||
completedAt: nowISO(),
|
|
||||||
};
|
|
||||||
}
|
|
||||||
manifest.status = 'failed';
|
|
||||||
saveManifest(runDir, manifest);
|
|
||||||
throw error;
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
// All stages passed
|
|
||||||
manifest.status = 'completed';
|
|
||||||
saveManifest(runDir, manifest);
|
saveManifest(runDir, manifest);
|
||||||
|
|
||||||
return {
|
return {
|
||||||
@@ -234,22 +387,30 @@ export async function runPipeline(
|
|||||||
}
|
}
|
||||||
|
|
||||||
/**
|
/**
|
||||||
* Resume a pipeline from the last incomplete stage.
|
* Resume a pipeline from the last non-passed stage.
|
||||||
*/
|
*/
|
||||||
export async function resumePipeline(
|
export async function resumePipeline(
|
||||||
runDir: string,
|
runDir: string,
|
||||||
executor: TaskExecutor,
|
executor?: TaskExecutor,
|
||||||
|
options?: { simulate?: boolean },
|
||||||
): Promise<PipelineResult> {
|
): Promise<PipelineResult> {
|
||||||
|
const simulate = options?.simulate ?? false;
|
||||||
|
const wiredExecutor = requireExecutor(executor, simulate);
|
||||||
|
const mode: RunMode = simulate ? 'simulated' : 'normal';
|
||||||
|
|
||||||
const manifest = loadManifest(runDir);
|
const manifest = loadManifest(runDir);
|
||||||
const resolvedRoot = path.dirname(path.dirname(path.dirname(runDir))); // .forge/runs/{id} → project root
|
const resolvedRoot = path.dirname(path.dirname(path.dirname(runDir))); // .forge/runs/{id} → project root
|
||||||
|
|
||||||
const briefContent = fs.readFileSync(manifest.brief, 'utf-8');
|
const briefContent = fs.readFileSync(manifest.brief, 'utf-8');
|
||||||
const allStages = stagesForClass(manifest.briefClass, manifest.forceBoard);
|
const allStages = stagesForClass(manifest.briefClass, manifest.forceBoard);
|
||||||
|
|
||||||
// Find first non-passed stage
|
manifest.mode = mode;
|
||||||
|
|
||||||
|
// Find first non-satisfying stage (only a verified `passed` counts as done;
|
||||||
|
// simulated and waiting-for-authority stages are re-run).
|
||||||
const resumeFrom = allStages.find((s) => manifest.stages[s]?.status !== 'passed');
|
const resumeFrom = allStages.find((s) => manifest.stages[s]?.status !== 'passed');
|
||||||
if (!resumeFrom) {
|
if (!resumeFrom) {
|
||||||
manifest.status = 'completed';
|
manifest.status = mode === 'simulated' ? 'simulated' : 'completed';
|
||||||
saveManifest(runDir, manifest);
|
saveManifest(runDir, manifest);
|
||||||
return {
|
return {
|
||||||
runId: manifest.runId,
|
runId: manifest.runId,
|
||||||
@@ -284,49 +445,16 @@ export async function resumePipeline(
|
|||||||
tasks.push(task);
|
tasks.push(task);
|
||||||
}
|
}
|
||||||
|
|
||||||
for (let i = 0; i < tasks.length; i++) {
|
await executeStages({
|
||||||
const task = tasks[i]!;
|
manifest,
|
||||||
const stageName = remainingStages[i]!;
|
runDir,
|
||||||
|
tasks,
|
||||||
|
stageNames: remainingStages,
|
||||||
|
executor: wiredExecutor,
|
||||||
|
simulate,
|
||||||
|
});
|
||||||
|
|
||||||
manifest.currentStage = stageName;
|
manifest.status = simulate ? 'simulated' : 'completed';
|
||||||
manifest.stages[stageName] = {
|
|
||||||
status: 'in_progress',
|
|
||||||
startedAt: nowISO(),
|
|
||||||
};
|
|
||||||
saveManifest(runDir, manifest);
|
|
||||||
|
|
||||||
try {
|
|
||||||
await executor.submitTask(task);
|
|
||||||
const result = await executor.waitForCompletion(task.id, task.timeoutSeconds * 1000);
|
|
||||||
|
|
||||||
manifest.stages[stageName] = {
|
|
||||||
status: result.status === 'completed' ? 'passed' : 'failed',
|
|
||||||
startedAt: manifest.stages[stageName]!.startedAt,
|
|
||||||
completedAt: nowISO(),
|
|
||||||
};
|
|
||||||
|
|
||||||
if (result.status !== 'completed') {
|
|
||||||
manifest.status = 'failed';
|
|
||||||
saveManifest(runDir, manifest);
|
|
||||||
throw new Error(`Stage ${stageName} failed with status: ${result.status}`);
|
|
||||||
}
|
|
||||||
|
|
||||||
saveManifest(runDir, manifest);
|
|
||||||
} catch (error) {
|
|
||||||
if (!manifest.stages[stageName]?.completedAt) {
|
|
||||||
manifest.stages[stageName] = {
|
|
||||||
status: 'failed',
|
|
||||||
startedAt: manifest.stages[stageName]?.startedAt,
|
|
||||||
completedAt: nowISO(),
|
|
||||||
};
|
|
||||||
}
|
|
||||||
manifest.status = 'failed';
|
|
||||||
saveManifest(runDir, manifest);
|
|
||||||
throw error;
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
manifest.status = 'completed';
|
|
||||||
saveManifest(runDir, manifest);
|
saveManifest(runDir, manifest);
|
||||||
|
|
||||||
return {
|
return {
|
||||||
|
|||||||
@@ -0,0 +1,32 @@
|
|||||||
|
import type { ForgeTask, ForgeTaskResult, TaskExecutor } from './types.js';
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Simulated executor — used ONLY when the caller explicitly passes --simulate.
|
||||||
|
*
|
||||||
|
* It submits no real work and returns typed `simulated` results so a simulated
|
||||||
|
* run can never be confused with a verified one. In normal mode (no --simulate)
|
||||||
|
* the CLI refuses to run at all with FORGE_NO_EXECUTOR instead of wiring this
|
||||||
|
* stub (fail closed, SDLC-D-035).
|
||||||
|
*/
|
||||||
|
export function createSimulatedExecutor(options?: { log?: boolean }): TaskExecutor {
|
||||||
|
const log = options?.log ?? true;
|
||||||
|
return {
|
||||||
|
async submitTask(task: ForgeTask) {
|
||||||
|
if (log) console.log(` [forge:simulated] stage submitted: ${task.id} (${task.title})`);
|
||||||
|
},
|
||||||
|
async waitForCompletion(taskId: string): Promise<ForgeTaskResult> {
|
||||||
|
if (log) console.log(` [forge:simulated] stage complete: ${taskId}`);
|
||||||
|
return {
|
||||||
|
task_id: taskId,
|
||||||
|
outcome: 'simulated',
|
||||||
|
reason: 'no executor wired; simulated execution requested via --simulate',
|
||||||
|
completed_at: new Date().toISOString(),
|
||||||
|
exit_code: 0,
|
||||||
|
gate_results: [],
|
||||||
|
};
|
||||||
|
},
|
||||||
|
async getTaskStatus() {
|
||||||
|
return 'completed' as const;
|
||||||
|
},
|
||||||
|
};
|
||||||
|
}
|
||||||
@@ -1,4 +1,4 @@
|
|||||||
import type { GateEntry, TaskResult } from '@mosaicstack/macp';
|
import type { GateEntry } from '@mosaicstack/macp';
|
||||||
|
|
||||||
/** Stage dispatch mode. */
|
/** Stage dispatch mode. */
|
||||||
export type StageDispatch = 'exec' | 'yolo' | 'pi';
|
export type StageDispatch = 'exec' | 'yolo' | 'pi';
|
||||||
@@ -6,6 +6,58 @@ export type StageDispatch = 'exec' | 'yolo' | 'pi';
|
|||||||
/** Stage type — determines agent selection and gate requirements. */
|
/** Stage type — determines agent selection and gate requirements. */
|
||||||
export type StageType = 'research' | 'review' | 'coding' | 'deploy';
|
export type StageType = 'research' | 'review' | 'coding' | 'deploy';
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Typed outcome for every gate and stage evaluation — closed set (SDLC-D-035).
|
||||||
|
*
|
||||||
|
* Only `passed` means "verified by a real implementation". `simulated` is
|
||||||
|
* produced exclusively in explicit `--simulate` runs and is never satisfying.
|
||||||
|
*/
|
||||||
|
export type ForgeOutcome =
|
||||||
|
| 'passed'
|
||||||
|
| 'failed'
|
||||||
|
| 'blocked'
|
||||||
|
| 'error'
|
||||||
|
| 'waiting-for-authority'
|
||||||
|
| 'simulated'
|
||||||
|
| 'not-applicable';
|
||||||
|
|
||||||
|
/** A gate that requires authority (human/board) sign-off; no mechanical command can satisfy it. */
|
||||||
|
export interface AuthorityGate {
|
||||||
|
kind: 'authority';
|
||||||
|
capability: string;
|
||||||
|
reason: string;
|
||||||
|
}
|
||||||
|
|
||||||
|
/** A gate that requires a wired provider (e.g. an AI reviewer, CI pipeline) to evaluate. */
|
||||||
|
export interface ProviderGate {
|
||||||
|
kind: 'provider';
|
||||||
|
capability: string;
|
||||||
|
reason: string;
|
||||||
|
}
|
||||||
|
|
||||||
|
/** Forge quality gate: a real command, an authority sign-off, or a provider-backed check. */
|
||||||
|
export type ForgeGate = string | GateEntry | AuthorityGate | ProviderGate;
|
||||||
|
|
||||||
|
/** Typed result of evaluating a single quality gate. */
|
||||||
|
export interface ForgeGateResult {
|
||||||
|
gate: string;
|
||||||
|
outcome: ForgeOutcome;
|
||||||
|
reason: string;
|
||||||
|
exitCode?: number;
|
||||||
|
output?: string;
|
||||||
|
timedOut?: boolean;
|
||||||
|
}
|
||||||
|
|
||||||
|
/** Typed result of a task/stage execution returned by a TaskExecutor. */
|
||||||
|
export interface ForgeTaskResult {
|
||||||
|
task_id: string;
|
||||||
|
outcome: ForgeOutcome;
|
||||||
|
reason: string;
|
||||||
|
completed_at: string;
|
||||||
|
exit_code: number;
|
||||||
|
gate_results: ForgeGateResult[];
|
||||||
|
}
|
||||||
|
|
||||||
/** Stage specification — defines a single pipeline stage. */
|
/** Stage specification — defines a single pipeline stage. */
|
||||||
export interface StageSpec {
|
export interface StageSpec {
|
||||||
number: string;
|
number: string;
|
||||||
@@ -14,7 +66,7 @@ export interface StageSpec {
|
|||||||
type: StageType;
|
type: StageType;
|
||||||
gate: string;
|
gate: string;
|
||||||
promptFile: string;
|
promptFile: string;
|
||||||
qualityGates: (string | GateEntry)[];
|
qualityGates: ForgeGate[];
|
||||||
}
|
}
|
||||||
|
|
||||||
/** Brief classification. */
|
/** Brief classification. */
|
||||||
@@ -25,11 +77,18 @@ export type ClassSource = 'cli' | 'frontmatter' | 'auto';
|
|||||||
|
|
||||||
/** Per-stage status within a run manifest. */
|
/** Per-stage status within a run manifest. */
|
||||||
export interface StageStatus {
|
export interface StageStatus {
|
||||||
status: 'pending' | 'in_progress' | 'passed' | 'failed';
|
status: 'pending' | 'in_progress' | ForgeOutcome;
|
||||||
|
/** Why the stage reached its current (terminal) outcome, when applicable. */
|
||||||
|
reason?: string;
|
||||||
startedAt?: string;
|
startedAt?: string;
|
||||||
completedAt?: string;
|
completedAt?: string;
|
||||||
|
/** Typed per-gate results recorded alongside the stage outcome. */
|
||||||
|
gateResults?: ForgeGateResult[];
|
||||||
}
|
}
|
||||||
|
|
||||||
|
/** Execution mode of a run. */
|
||||||
|
export type RunMode = 'normal' | 'simulated';
|
||||||
|
|
||||||
/** Run manifest — persisted to disk as manifest.json. */
|
/** Run manifest — persisted to disk as manifest.json. */
|
||||||
export interface RunManifest {
|
export interface RunManifest {
|
||||||
runId: string;
|
runId: string;
|
||||||
@@ -38,10 +97,23 @@ export interface RunManifest {
|
|||||||
briefClass: BriefClass;
|
briefClass: BriefClass;
|
||||||
classSource: ClassSource;
|
classSource: ClassSource;
|
||||||
forceBoard: boolean;
|
forceBoard: boolean;
|
||||||
|
/**
|
||||||
|
* Execution mode. `simulated` runs stub execution; their results are typed
|
||||||
|
* `simulated` and must never be read as verified success. Optional because
|
||||||
|
* manifests written before this field existed default to `normal`.
|
||||||
|
*/
|
||||||
|
mode?: RunMode;
|
||||||
createdAt: string;
|
createdAt: string;
|
||||||
updatedAt: string;
|
updatedAt: string;
|
||||||
currentStage: string;
|
currentStage: string;
|
||||||
status: 'in_progress' | 'completed' | 'failed' | 'interrupted' | 'rejected';
|
status:
|
||||||
|
| 'in_progress'
|
||||||
|
| 'completed'
|
||||||
|
| 'failed'
|
||||||
|
| 'interrupted'
|
||||||
|
| 'rejected'
|
||||||
|
| 'simulated'
|
||||||
|
| 'waiting-for-authority';
|
||||||
stages: Record<string, StageStatus>;
|
stages: Record<string, StageStatus>;
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -65,7 +137,7 @@ export interface ForgeTask {
|
|||||||
briefPath: string;
|
briefPath: string;
|
||||||
resultPath: string;
|
resultPath: string;
|
||||||
timeoutSeconds: number;
|
timeoutSeconds: number;
|
||||||
qualityGates: (string | GateEntry)[];
|
qualityGates: ForgeGate[];
|
||||||
worktree?: string;
|
worktree?: string;
|
||||||
command?: string;
|
command?: string;
|
||||||
dependsOn?: string[];
|
dependsOn?: string[];
|
||||||
@@ -76,7 +148,7 @@ export interface ForgeTask {
|
|||||||
/** Abstract task executor — decouples from packages/coord. */
|
/** Abstract task executor — decouples from packages/coord. */
|
||||||
export interface TaskExecutor {
|
export interface TaskExecutor {
|
||||||
submitTask(task: ForgeTask): Promise<void>;
|
submitTask(task: ForgeTask): Promise<void>;
|
||||||
waitForCompletion(taskId: string, timeoutMs: number): Promise<TaskResult>;
|
waitForCompletion(taskId: string, timeoutMs: number): Promise<ForgeTaskResult>;
|
||||||
getTaskStatus(taskId: string): Promise<ForgeTaskStatus>;
|
getTaskStatus(taskId: string): Promise<ForgeTaskStatus>;
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -122,7 +194,16 @@ export interface PipelineOptions {
|
|||||||
stages?: string[];
|
stages?: string[];
|
||||||
skipTo?: string;
|
skipTo?: string;
|
||||||
dryRun?: boolean;
|
dryRun?: boolean;
|
||||||
executor: TaskExecutor;
|
/**
|
||||||
|
* Real task executor. Required in normal mode: the pipeline fails closed
|
||||||
|
* with FORGE_NO_EXECUTOR when it is absent.
|
||||||
|
*/
|
||||||
|
executor?: TaskExecutor;
|
||||||
|
/**
|
||||||
|
* Explicit opt-in to simulated execution. Every stage and gate result is
|
||||||
|
* typed `simulated` and is never satisfying.
|
||||||
|
*/
|
||||||
|
simulate?: boolean;
|
||||||
}
|
}
|
||||||
|
|
||||||
/** Pipeline run result. */
|
/** Pipeline run result. */
|
||||||
|
|||||||
@@ -1,166 +0,0 @@
|
|||||||
#!/usr/bin/env node
|
|
||||||
// verify-release.mjs — the ONE canonical terminal verification command
|
|
||||||
// (SDLC-D-034, `pnpm verify:release`).
|
|
||||||
//
|
|
||||||
// Publication (.woodpecker/publish.yml `verify` step) is bound to terminal
|
|
||||||
// verification of the exact commit through this command, which is composed
|
|
||||||
// from the SAME commands the PR CI pipeline (.woodpecker/ci.yml) runs — CI and
|
|
||||||
// publish share one semantic checklist:
|
|
||||||
//
|
|
||||||
// stage | mirrors ci.yml step | commands
|
|
||||||
// --------------|---------------------|------------------------------------------
|
|
||||||
// sanitization | sanitization | verify-sanitized.sh, check-resident-
|
|
||||||
// | | budget.sh (--self-test + run),
|
|
||||||
// | | check-test-enumeration.sh
|
|
||||||
// upgrade-guard | upgrade-guard | test-upgrade-manifest-guard.sh,
|
|
||||||
// | | test-upgrade-rollback.sh,
|
|
||||||
// | | test-upgrade-durable-snapshot.sh,
|
|
||||||
// | | test-install-migration.sh
|
|
||||||
// typecheck | typecheck | pnpm typecheck (runs the checkout
|
|
||||||
// | | preflight, then turbo typecheck)
|
|
||||||
// lint | lint | pnpm lint
|
|
||||||
// format | format | pnpm format:check
|
|
||||||
// test | test | pnpm test
|
|
||||||
// build | publish.yml build | pnpm build
|
|
||||||
//
|
|
||||||
// Caller-provided prerequisites (kept at the pipeline level — see the comments
|
|
||||||
// in .woodpecker/ci.yml): `bash` + `rsync` for the guard stages, `openssl` and
|
|
||||||
// the pinned @earendil-works/pi-coding-agent for the test stage, and — on the
|
|
||||||
// postgres path only — the ci-postgres service plus
|
|
||||||
// `pnpm --filter @mosaicstack/db run db:migrate` before the test stage.
|
|
||||||
//
|
|
||||||
// This command works with DATABASE_URL set (CI postgres path) or unset (local
|
|
||||||
// PGlite path); it never sets, exports, or requires a database itself.
|
|
||||||
//
|
|
||||||
// scripts/verify-release.test.mjs enforces that this stage table keeps
|
|
||||||
// matching .woodpecker/ci.yml step-for-step, so the two surfaces cannot drift
|
|
||||||
// apart silently.
|
|
||||||
|
|
||||||
import { spawnSync } from 'node:child_process';
|
|
||||||
import path from 'node:path';
|
|
||||||
import { fileURLToPath } from 'node:url';
|
|
||||||
|
|
||||||
export const STAGES = [
|
|
||||||
{
|
|
||||||
name: 'sanitization',
|
|
||||||
// Mirror of the .woodpecker/ci.yml `sanitization` step (minus its
|
|
||||||
// `apk add` environment prep). Kept as direct command strings here: the
|
|
||||||
// #1017 test-enumeration guard audits these paths through the ci.yml
|
|
||||||
// surface, so indirection from ci.yml into this file is not possible.
|
|
||||||
commands: [
|
|
||||||
'bash packages/mosaic/framework/tools/quality/scripts/verify-sanitized.sh',
|
|
||||||
'bash packages/mosaic/framework/tools/quality/scripts/check-resident-budget.sh --self-test',
|
|
||||||
'bash packages/mosaic/framework/tools/quality/scripts/check-resident-budget.sh',
|
|
||||||
'bash packages/mosaic/framework/tools/quality/scripts/check-test-enumeration.sh',
|
|
||||||
],
|
|
||||||
},
|
|
||||||
{
|
|
||||||
name: 'upgrade-guard',
|
|
||||||
// Mirror of the .woodpecker/ci.yml `upgrade-guard` step (minus its
|
|
||||||
// `apk add` environment prep).
|
|
||||||
commands: [
|
|
||||||
'bash packages/mosaic/framework/tools/quality/scripts/test-upgrade-manifest-guard.sh',
|
|
||||||
'bash packages/mosaic/framework/tools/quality/scripts/test-upgrade-rollback.sh',
|
|
||||||
'bash packages/mosaic/framework/tools/quality/scripts/test-upgrade-durable-snapshot.sh',
|
|
||||||
'bash packages/mosaic/framework/tools/quality/scripts/test-install-migration.sh',
|
|
||||||
],
|
|
||||||
},
|
|
||||||
{
|
|
||||||
// `pnpm typecheck` is `pnpm preflight && turbo run typecheck`, so the
|
|
||||||
// checkout preflight (scripts/preflight.mjs) is part of this stage exactly
|
|
||||||
// as it is part of the ci.yml `typecheck` step.
|
|
||||||
name: 'typecheck',
|
|
||||||
commands: ['pnpm typecheck'],
|
|
||||||
},
|
|
||||||
{
|
|
||||||
name: 'lint',
|
|
||||||
commands: ['pnpm lint'],
|
|
||||||
},
|
|
||||||
{
|
|
||||||
name: 'format',
|
|
||||||
commands: ['pnpm format:check'],
|
|
||||||
},
|
|
||||||
{
|
|
||||||
// Requires `openssl` and the pinned `pi` binary on the pipeline path; see
|
|
||||||
// the caller-provided prerequisites above.
|
|
||||||
name: 'test',
|
|
||||||
commands: ['pnpm test'],
|
|
||||||
},
|
|
||||||
{
|
|
||||||
name: 'build',
|
|
||||||
commands: ['pnpm build'],
|
|
||||||
},
|
|
||||||
];
|
|
||||||
|
|
||||||
export function stageByName(name) {
|
|
||||||
return STAGES.find((stage) => stage.name === name);
|
|
||||||
}
|
|
||||||
|
|
||||||
function missingBinaries(bins) {
|
|
||||||
return bins.filter(
|
|
||||||
(bin) => spawnSync('sh', ['-c', `command -v ${bin} >/dev/null 2>&1`]).status !== 0,
|
|
||||||
);
|
|
||||||
}
|
|
||||||
|
|
||||||
function runCommand(command) {
|
|
||||||
const result = spawnSync(command, { shell: true, stdio: 'inherit' });
|
|
||||||
if (result.error) {
|
|
||||||
console.error(`[verify:release] failed to launch '${command}': ${result.error.message}`);
|
|
||||||
return false;
|
|
||||||
}
|
|
||||||
if (result.status !== 0) {
|
|
||||||
const reason = result.signal ? `terminated by ${result.signal}` : `exited ${result.status}`;
|
|
||||||
console.error(`[verify:release] command '${command}' ${reason}`);
|
|
||||||
return false;
|
|
||||||
}
|
|
||||||
return true;
|
|
||||||
}
|
|
||||||
|
|
||||||
// Runs the complete mandatory verification set (or, with --stage <name>, the
|
|
||||||
// single named stage — used for wiring/smoke-testing, not for gating: only a
|
|
||||||
// run of every stage is a terminal verification). Fails fast: the first
|
|
||||||
// failing command aborts with a non-zero exit code. Returns the exit code.
|
|
||||||
export function verifyRelease({ stages = STAGES } = {}) {
|
|
||||||
const missing = missingBinaries(['bash', 'rsync']);
|
|
||||||
if (missing.length > 0) {
|
|
||||||
console.error(
|
|
||||||
`[verify:release] FATAL: required binaries missing from PATH: ${missing.join(', ')}. ` +
|
|
||||||
'The caller provides them (ci-base bakes bash; pipelines apk add rsync).',
|
|
||||||
);
|
|
||||||
return 1;
|
|
||||||
}
|
|
||||||
for (const stage of stages) {
|
|
||||||
console.log(`\n[verify:release] === stage: ${stage.name} ===`);
|
|
||||||
for (const command of stage.commands) {
|
|
||||||
console.log(`[verify:release] $ ${command}`);
|
|
||||||
if (!runCommand(command)) {
|
|
||||||
console.error(
|
|
||||||
`[verify:release] FATAL: stage '${stage.name}' failed — verification inconclusive`,
|
|
||||||
);
|
|
||||||
return 1;
|
|
||||||
}
|
|
||||||
}
|
|
||||||
}
|
|
||||||
console.log(`\n[verify:release] all ${stages.length} stage(s) passed`);
|
|
||||||
return 0;
|
|
||||||
}
|
|
||||||
|
|
||||||
function main(argv) {
|
|
||||||
const stageFlagIndex = argv.indexOf('--stage');
|
|
||||||
if (stageFlagIndex !== -1) {
|
|
||||||
const name = argv[stageFlagIndex + 1];
|
|
||||||
const stage = stageByName(name);
|
|
||||||
if (!stage) {
|
|
||||||
console.error(
|
|
||||||
`[verify:release] unknown stage '${name ?? ''}' — expected one of: ${STAGES.map((entry) => entry.name).join(', ')}`,
|
|
||||||
);
|
|
||||||
process.exit(2);
|
|
||||||
}
|
|
||||||
process.exit(verifyRelease({ stages: [stage] }));
|
|
||||||
}
|
|
||||||
process.exit(verifyRelease());
|
|
||||||
}
|
|
||||||
|
|
||||||
if (process.argv[1] && path.resolve(process.argv[1]) === fileURLToPath(import.meta.url)) {
|
|
||||||
main(process.argv.slice(2));
|
|
||||||
}
|
|
||||||
@@ -1,277 +0,0 @@
|
|||||||
import assert from 'node:assert/strict';
|
|
||||||
import { readFile } from 'node:fs/promises';
|
|
||||||
import { createRequire } from 'node:module';
|
|
||||||
import path from 'node:path';
|
|
||||||
import test from 'node:test';
|
|
||||||
|
|
||||||
import { STAGES } from './verify-release.mjs';
|
|
||||||
|
|
||||||
// SDLC-D-034 checkout invariant: publication in .woodpecker/publish.yml is
|
|
||||||
// bound to exact-commit terminal verification. This suite parses the real
|
|
||||||
// pipeline files and fails red when the gate is bypassed, weakened, or drifts
|
|
||||||
// out of sync with the canonical `pnpm verify:release` command.
|
|
||||||
|
|
||||||
// Reuse the monorepo's existing YAML parser (@mosaicstack/mosaic's direct
|
|
||||||
// dependency) instead of adding a root dependency or vendoring a parser.
|
|
||||||
const mosaicRequire = createRequire(
|
|
||||||
path.resolve(process.cwd(), 'packages', 'mosaic', 'package.json'),
|
|
||||||
);
|
|
||||||
const { parse: parseYaml } = mosaicRequire('yaml');
|
|
||||||
|
|
||||||
const publishYmlPath = path.join(process.cwd(), '.woodpecker', 'publish.yml');
|
|
||||||
const ciYmlPath = path.join(process.cwd(), '.woodpecker', 'ci.yml');
|
|
||||||
|
|
||||||
async function readPublishPipeline() {
|
|
||||||
return parseYaml(await readFile(publishYmlPath, 'utf8'));
|
|
||||||
}
|
|
||||||
|
|
||||||
// A step has an external publication effect when its name starts with
|
|
||||||
// `publish` or when any command pushes an image to a registry.
|
|
||||||
function pushesImage(step) {
|
|
||||||
return (step.commands ?? []).some((command) =>
|
|
||||||
/(^|\s)(\/kaniko\/executor|docker push)\b|--destination/.test(command),
|
|
||||||
);
|
|
||||||
}
|
|
||||||
|
|
||||||
function publishEffectSteps(pipeline) {
|
|
||||||
return Object.entries(pipeline.steps ?? {})
|
|
||||||
.filter(([name, step]) => name.startsWith('publish') || pushesImage(step))
|
|
||||||
.map(([name]) => name);
|
|
||||||
}
|
|
||||||
|
|
||||||
// Transitive closure of a step's depends_on graph.
|
|
||||||
function dependencyClosure(pipeline, stepName, seen = new Set()) {
|
|
||||||
const dependencies = pipeline.steps?.[stepName]?.depends_on ?? [];
|
|
||||||
for (const dependency of dependencies) {
|
|
||||||
if (seen.has(dependency)) continue;
|
|
||||||
seen.add(dependency);
|
|
||||||
dependencyClosure(pipeline, dependency, seen);
|
|
||||||
}
|
|
||||||
return seen;
|
|
||||||
}
|
|
||||||
|
|
||||||
function verifyCommands(pipeline) {
|
|
||||||
const verify = pipeline.steps?.verify;
|
|
||||||
assert.ok(verify, 'publish pipeline must define a `verify` step');
|
|
||||||
assert.ok(Array.isArray(verify.commands), '`verify` step must have commands');
|
|
||||||
return verify.commands;
|
|
||||||
}
|
|
||||||
|
|
||||||
function assertCommitIdentityAssertion(commands) {
|
|
||||||
const text = commands.join('\n');
|
|
||||||
assert.match(
|
|
||||||
text,
|
|
||||||
/CI_COMMIT_SHA/,
|
|
||||||
'`verify` must compare the provider commit identity (CI_COMMIT_SHA)',
|
|
||||||
);
|
|
||||||
assert.match(text, /git rev-parse HEAD/, '`verify` must compare against git rev-parse HEAD');
|
|
||||||
assert.match(
|
|
||||||
text,
|
|
||||||
/exit 1/,
|
|
||||||
'`verify` must fail closed (exit 1) on identity mismatch or emptiness',
|
|
||||||
);
|
|
||||||
}
|
|
||||||
|
|
||||||
function assertCanonicalCommand(commands) {
|
|
||||||
assert.ok(
|
|
||||||
commands.some((command) => /^pnpm verify:release\b/.test(command.trim())),
|
|
||||||
'`verify` must run the canonical terminal verification command `pnpm verify:release`',
|
|
||||||
);
|
|
||||||
}
|
|
||||||
|
|
||||||
function assertPublishGate(pipeline) {
|
|
||||||
assert.ok(pipeline.steps, 'publish pipeline must define steps');
|
|
||||||
|
|
||||||
const commands = verifyCommands(pipeline);
|
|
||||||
assertCommitIdentityAssertion(commands);
|
|
||||||
assertCanonicalCommand(commands);
|
|
||||||
|
|
||||||
const effects = publishEffectSteps(pipeline);
|
|
||||||
assert.ok(effects.length > 0, 'publish pipeline must contain publish effect steps to guard');
|
|
||||||
|
|
||||||
for (const stepName of effects) {
|
|
||||||
const step = pipeline.steps[stepName];
|
|
||||||
assert.ok(
|
|
||||||
Array.isArray(step.depends_on) && step.depends_on.includes('verify'),
|
|
||||||
`publish effect '${stepName}' must depend DIRECTLY on the verify step (SDLC-D-034: transitively through build is not enough)`,
|
|
||||||
);
|
|
||||||
assert.ok(
|
|
||||||
dependencyClosure(pipeline, stepName).has('verify'),
|
|
||||||
`publish effect '${stepName}' must depend on a chain that includes verify`,
|
|
||||||
);
|
|
||||||
}
|
|
||||||
return effects;
|
|
||||||
}
|
|
||||||
|
|
||||||
test('the publish pipeline gates every publish effect behind exact-commit verification', async () => {
|
|
||||||
const pipeline = await readPublishPipeline();
|
|
||||||
const effects = assertPublishGate(pipeline);
|
|
||||||
assert.deepEqual(effects.sort(), [
|
|
||||||
'build-appservice',
|
|
||||||
'build-gateway',
|
|
||||||
'build-web',
|
|
||||||
'publish-next-npm',
|
|
||||||
'publish-npm',
|
|
||||||
]);
|
|
||||||
});
|
|
||||||
|
|
||||||
test('the verify step carries no path/event short-circuit of its own', async () => {
|
|
||||||
const pipeline = await readPublishPipeline();
|
|
||||||
// A `when` filter on `verify` would let a publish effect fire on an event
|
|
||||||
// class that skipped verification — the gate must be unconditional.
|
|
||||||
assert.equal(pipeline.steps.verify.when, undefined);
|
|
||||||
});
|
|
||||||
|
|
||||||
test('a publish step that bypasses verify fails the gate checker', () => {
|
|
||||||
// Negative fixture: a plausible publish pipeline where `publish-npm` hangs
|
|
||||||
// off `build` only and `build` never chains to `verify` — the exact bypass
|
|
||||||
// class SDLC-D-034 closes. The checker must go red on it.
|
|
||||||
const bypassingPipeline = `
|
|
||||||
steps:
|
|
||||||
install:
|
|
||||||
image: node:24-alpine
|
|
||||||
commands:
|
|
||||||
- pnpm install --frozen-lockfile
|
|
||||||
verify:
|
|
||||||
image: node:24-alpine
|
|
||||||
commands:
|
|
||||||
- |
|
|
||||||
if [ -z "$CI_COMMIT_SHA" ] || [ "$CI_COMMIT_SHA" != "$(git rev-parse HEAD)" ]; then
|
|
||||||
echo "identity mismatch" >&2
|
|
||||||
exit 1
|
|
||||||
fi
|
|
||||||
- pnpm verify:release
|
|
||||||
depends_on:
|
|
||||||
- install
|
|
||||||
build:
|
|
||||||
image: node:24-alpine
|
|
||||||
commands:
|
|
||||||
- pnpm build
|
|
||||||
depends_on:
|
|
||||||
- install
|
|
||||||
publish-npm:
|
|
||||||
image: node:24-alpine
|
|
||||||
commands:
|
|
||||||
- pnpm publish
|
|
||||||
depends_on:
|
|
||||||
- build
|
|
||||||
`;
|
|
||||||
assert.throws(
|
|
||||||
() => assertPublishGate(parseYaml(bypassingPipeline)),
|
|
||||||
/publish-npm.*DIRECTLY.*verify/s,
|
|
||||||
);
|
|
||||||
});
|
|
||||||
|
|
||||||
test('a publish step chained to verify only transitively fails the gate checker', () => {
|
|
||||||
// Negative fixture: `build` depends on verify but `publish-npm` does not
|
|
||||||
// carry the direct edge — weaker than SDLC-D-034 requires of the real DAG.
|
|
||||||
const transitiveOnlyPipeline = `
|
|
||||||
steps:
|
|
||||||
install:
|
|
||||||
image: node:24-alpine
|
|
||||||
commands:
|
|
||||||
- pnpm install --frozen-lockfile
|
|
||||||
verify:
|
|
||||||
image: node:24-alpine
|
|
||||||
commands:
|
|
||||||
- |
|
|
||||||
if [ -z "$CI_COMMIT_SHA" ] || [ "$CI_COMMIT_SHA" != "$(git rev-parse HEAD)" ]; then
|
|
||||||
echo "identity mismatch" >&2
|
|
||||||
exit 1
|
|
||||||
fi
|
|
||||||
- pnpm verify:release
|
|
||||||
depends_on:
|
|
||||||
- install
|
|
||||||
build:
|
|
||||||
image: node:24-alpine
|
|
||||||
commands:
|
|
||||||
- pnpm build
|
|
||||||
depends_on:
|
|
||||||
- install
|
|
||||||
- verify
|
|
||||||
publish-npm:
|
|
||||||
image: node:24-alpine
|
|
||||||
commands:
|
|
||||||
- pnpm publish
|
|
||||||
depends_on:
|
|
||||||
- build
|
|
||||||
`;
|
|
||||||
assert.throws(
|
|
||||||
() => assertPublishGate(parseYaml(transitiveOnlyPipeline)),
|
|
||||||
/publish-npm.*DIRECTLY.*verify/s,
|
|
||||||
);
|
|
||||||
});
|
|
||||||
|
|
||||||
test('a verify step without the commit-identity assertion fails the gate checker', () => {
|
|
||||||
const noIdentityPipeline = `
|
|
||||||
steps:
|
|
||||||
verify:
|
|
||||||
image: node:24-alpine
|
|
||||||
commands:
|
|
||||||
- pnpm verify:release
|
|
||||||
publish-npm:
|
|
||||||
image: node:24-alpine
|
|
||||||
commands:
|
|
||||||
- pnpm publish
|
|
||||||
depends_on:
|
|
||||||
- verify
|
|
||||||
`;
|
|
||||||
assert.throws(() => assertPublishGate(parseYaml(noIdentityPipeline)), /CI_COMMIT_SHA/);
|
|
||||||
});
|
|
||||||
|
|
||||||
test('the canonical verify:release stages mirror the PR CI pipeline one-for-one', async () => {
|
|
||||||
const ci = parseYaml(await readFile(ciYmlPath, 'utf8'));
|
|
||||||
const canonical = Object.fromEntries(STAGES.map((stage) => [stage.name, stage.commands]));
|
|
||||||
|
|
||||||
// The complete mandatory set, in gate order.
|
|
||||||
assert.deepEqual(
|
|
||||||
STAGES.map((stage) => stage.name),
|
|
||||||
['sanitization', 'upgrade-guard', 'typecheck', 'lint', 'format', 'test', 'build'],
|
|
||||||
);
|
|
||||||
|
|
||||||
// Guard stages: ci.yml commands minus its `apk add` environment prep must be
|
|
||||||
// exactly the canonical stage commands (order included).
|
|
||||||
for (const stageName of ['sanitization', 'upgrade-guard']) {
|
|
||||||
assert.deepEqual(
|
|
||||||
ci.steps[stageName].commands.filter((command) => !command.startsWith('apk add')),
|
|
||||||
canonical[stageName],
|
|
||||||
`canonical '${stageName}' stage must match the ci.yml step`,
|
|
||||||
);
|
|
||||||
}
|
|
||||||
|
|
||||||
// pnpm stages: ci.yml commands minus `corepack enable` must be exactly the
|
|
||||||
// canonical stage commands.
|
|
||||||
for (const stepName of ['typecheck', 'lint', 'format']) {
|
|
||||||
assert.deepEqual(
|
|
||||||
ci.steps[stepName].commands.filter((command) => command !== 'corepack enable'),
|
|
||||||
canonical[stepName],
|
|
||||||
`canonical '${stepName}' stage must match the ci.yml step`,
|
|
||||||
);
|
|
||||||
}
|
|
||||||
|
|
||||||
// The test stage is shared, but ci.yml wraps it in pipeline-level
|
|
||||||
// prerequisites the canonical command expects its caller to provide
|
|
||||||
// (SDLC-D-034): the postgres service + readiness wait + db:migrate, openssl,
|
|
||||||
// and the pinned pi runtime. None of those may be dropped silently.
|
|
||||||
for (const command of canonical.test) {
|
|
||||||
assert.ok(
|
|
||||||
ci.steps.test.commands.includes(command),
|
|
||||||
`ci.yml test step must run the canonical test stage command '${command}'`,
|
|
||||||
);
|
|
||||||
}
|
|
||||||
for (const fragment of [
|
|
||||||
'pg_isready -h ci-postgres',
|
|
||||||
'pnpm --filter @mosaicstack/db run db:migrate',
|
|
||||||
'npm install -g @earendil-works/[email protected]',
|
|
||||||
]) {
|
|
||||||
assert.ok(
|
|
||||||
ci.steps.test.commands.some((command) => command.includes(fragment)),
|
|
||||||
`ci.yml test step must keep its pipeline-level prerequisite '${fragment}'`,
|
|
||||||
);
|
|
||||||
}
|
|
||||||
});
|
|
||||||
|
|
||||||
test('the root package.json exposes verify:release as the canonical command', async () => {
|
|
||||||
const packageJson = JSON.parse(await readFile(path.join(process.cwd(), 'package.json'), 'utf8'));
|
|
||||||
assert.match(packageJson.scripts['verify:release'], /scripts\/verify-release\.mjs/);
|
|
||||||
});
|
|
||||||
Reference in New Issue
Block a user