Compare commits
| Author | SHA1 | Date | |
|---|---|---|---|
|
|
4917df1f07 | ||
|
|
8199261caa | ||
|
|
57a2f2b40e | ||
|
|
93c1de51e1 |
+1
-3
@@ -116,7 +116,7 @@ gateway-backed agent catalog.
|
|||||||
### Normative requirements
|
### Normative requirements
|
||||||
|
|
||||||
| ID | Requirement |
|
| ID | Requirement |
|
||||||
| ------------ | ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- |
|
| ------------ | ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- |
|
||||||
| `FCM-REQ-01` | The roster SHALL be the sole writable desired-state source for local fleet membership, launch policy, and persisted lifecycle target. Generated environment files, systemd enablement, tmux sessions, and heartbeat state SHALL be non-authoritative projections. |
|
| `FCM-REQ-01` | The roster SHALL be the sole writable desired-state source for local fleet membership, launch policy, and persisted lifecycle target. Generated environment files, systemd enablement, tmux sessions, and heartbeat state SHALL be non-authoritative projections. |
|
||||||
| `FCM-REQ-02` | The implementation SHALL provide one executable structural contract for YAML/JSON input and one shared semantic validator. Roster load, profile validation, provision, migration, and apply SHALL reuse the existing baseline-plus-`roles.local` profile/persona resolver; a parallel role resolver is forbidden. |
|
| `FCM-REQ-02` | The implementation SHALL provide one executable structural contract for YAML/JSON input and one shared semantic validator. Roster load, profile validation, provision, migration, and apply SHALL reuse the existing baseline-plus-`roles.local` profile/persona resolver; a parallel role resolver is forbidden. |
|
||||||
| `FCM-REQ-03` | The local fleet CLI SHALL expose documented programmatic validate, show, plan, apply/reconcile, create, inspect, update, delete, start, stop, restart, status, verify, and doctor operations with stable JSON and exit-code behavior. Existing `fleet add/remove` compatibility aliases may remain during the stated deprecation window. |
|
| `FCM-REQ-03` | The local fleet CLI SHALL expose documented programmatic validate, show, plan, apply/reconcile, create, inspect, update, delete, start, stop, restart, status, verify, and doctor operations with stable JSON and exit-code behavior. Existing `fleet add/remove` compatibility aliases may remain during the stated deprecation window. |
|
||||||
@@ -127,7 +127,6 @@ gateway-backed agent catalog.
|
|||||||
| `FCM-REQ-08` | v1 migration SHALL be field-complete, reversible, and explicit about aliases, unresolved classes, lifecycle inference, generated-file regeneration, local override quarantine, schema-only remote/connector fields, and rollback. Every shipped example, profile, and service preset SHALL be migrated and executable, retained as an explicitly versioned v1 fixture, or retired with a replacement and deprecation note. |
|
| `FCM-REQ-08` | v1 migration SHALL be field-complete, reversible, and explicit about aliases, unresolved classes, lifecycle inference, generated-file regeneration, local override quarantine, schema-only remote/connector fields, and rollback. Every shipped example, profile, and service preset SHALL be migrated and executable, retained as an explicitly versioned v1 fixture, or retired with a replacement and deprecation note. |
|
||||||
| `FCM-REQ-09` | M1–M5 SHALL remain local tmux/systemd control-plane work. Remote/SSH reconciliation, connector mutation, secret references, arbitrary command/channel overrides, gateway/API convergence, and UI configuration storage are excluded and require a separate PRD/threat model. |
|
| `FCM-REQ-09` | M1–M5 SHALL remain local tmux/systemd control-plane work. Remote/SSH reconciliation, connector mutation, secret references, arbitrary command/channel overrides, gateway/API convergence, and UI configuration storage are excluded and require a separate PRD/threat model. |
|
||||||
| `FCM-REQ-10` | Documentation and examples are delivery gates. The M0 checklist at [docs/fleet/FLEET-CONFIG-DOCS-IA-CHECKLIST.md](./fleet/FLEET-CONFIG-DOCS-IA-CHECKLIST.md) and the baseline disposition inventory at [docs/fleet/LEGACY-EXAMPLE-PROFILE-DISPOSITION-INVENTORY.md](./fleet/LEGACY-EXAMPLE-PROFILE-DISPOSITION-INVENTORY.md) SHALL be maintained as acceptance evidence. |
|
| `FCM-REQ-10` | Documentation and examples are delivery gates. The M0 checklist at [docs/fleet/FLEET-CONFIG-DOCS-IA-CHECKLIST.md](./fleet/FLEET-CONFIG-DOCS-IA-CHECKLIST.md) and the baseline disposition inventory at [docs/fleet/LEGACY-EXAMPLE-PROFILE-DISPOSITION-INVENTORY.md](./fleet/LEGACY-EXAMPLE-PROFILE-DISPOSITION-INVENTORY.md) SHALL be maintained as acceptance evidence. |
|
||||||
| `FCM-REQ-11` | Fleet provisioning SHALL validate the fleet CLI and distinct runtimes requested by the roster against the exact PATH construction used by the runtime pane, through one shared implementation rather than the operator PATH or a parallel PATH model. Name resolution alone is insufficient: a resolved script's shebang interpreter SHALL also be reachable, and Node SHALL execute a side-effect-free version probe when it is that interpreter. `fleet install` and `install-systemd` SHALL fail before installation effects when a required executable is absent or unreachable. `fleet doctor` SHALL emit the same named checks as non-green evidence. Every runtime failure SHALL name the runtime, all requesting roster rows, the pane PATH searched, and an exact install command. |
|
|
||||||
|
|
||||||
### Acceptance criteria
|
### Acceptance criteria
|
||||||
|
|
||||||
@@ -139,7 +138,6 @@ gateway-backed agent catalog.
|
|||||||
6. `AC-FCM-06`: A v1 roster migration previews field-by-field disposition, preserves observed stopped/running state, inventories rather than reconciles remote/schema-only entries, supports a canary and rollback, and classifies every shipped example, profile, and service preset according to the M0 inventory.
|
6. `AC-FCM-06`: A v1 roster migration previews field-by-field disposition, preserves observed stopped/running state, inventories rather than reconciles remote/schema-only entries, supports a canary and rollback, and classifies every shipped example, profile, and service preset according to the M0 inventory.
|
||||||
7. `AC-FCM-07`: Required role authority is validated: validator certificate is consumed but does not merge, merge-gate is the sole merge authority, team-leader leases do not change roster/credentials/authority, and interaction/Tess cannot claim orchestration or merge powers.
|
7. `AC-FCM-07`: Required role authority is validated: validator certificate is consumed but does not merge, merge-gate is the sole merge authority, team-leader leases do not change roster/credentials/authority, and interaction/Tess cannot claim orchestration or merge powers.
|
||||||
8. `AC-FCM-08`: Documentation, examples, migration, troubleshooting, operational recovery, package/update asset drift, schema/example/profile validation, independent code/security review, validator certificate, and terminal-green CI are complete before #758 closes.
|
8. `AC-FCM-08`: Documentation, examples, migration, troubleshooting, operational recovery, package/update asset drift, schema/example/profile validation, independent code/security review, validator certificate, and terminal-green CI are complete before #758 closes.
|
||||||
9. `AC-FCM-09`: Red-first isolated tests create (a) a roster whose runtime exists on the operator PATH but is absent from the constructed pane PATH and (b) a greenfield pane where `mosaic` and a runtime resolve as Node-shebang scripts while Node is absent. They prove `fleet install` fails before effects, the launcher creates no doomed session, and `fleet doctor` reports named non-green checks. Diagnostics include the executable or runtime, all requesting rows, searched pane PATH, shebang dependency when present, and exact runtime install command; repeated rows are checked once per distinct runtime/effective pane path. Tests use temporary `--mosaic-home` state and fixture binaries, never host runtime mutation.
|
|
||||||
|
|
||||||
### M0 implementation gate
|
### M0 implementation gate
|
||||||
|
|
||||||
|
|||||||
@@ -59,28 +59,6 @@ valid allowed local data can move to `.env.local`; invalid legacy input is priva
|
|||||||
Diagnostics expose only rule code, key name, and a SHA-256 content hash. They do not reveal command
|
Diagnostics expose only rule code, key name, and a SHA-256 content hash. They do not reveal command
|
||||||
text, credentials, or other values.
|
text, credentials, or other values.
|
||||||
|
|
||||||
## Pane executable preflight
|
|
||||||
|
|
||||||
The fleet install, install-systemd, and doctor commands plus the session launcher use
|
|
||||||
**pane-runtime-path.sh** as the single pane-PATH implementation. Install inspects every distinct
|
|
||||||
roster runtime and effective MOSAIC_RUNTIME_BIN pair before creating holder identity, tool,
|
|
||||||
projection, or unit files. Doctor reports the same checks as JSON.
|
|
||||||
|
|
||||||
A resolved command is not automatically executable. The helper reads a script shebang, unwraps the
|
|
||||||
common “/usr/bin/env node” and “/usr/bin/env -S node …” forms, then resolves the declared command
|
|
||||||
against the pane PATH. When Node is the declared interpreter, the helper runs the side-effect-free
|
|
||||||
“node --version” probe. It does not run “mosaic --version”, whose startup update check can write cache
|
|
||||||
state. Native binaries have no PATH-resolved shebang dependency and retain their normal executable
|
|
||||||
check. Failures name the executable or runtime, requesting roster rows, searched pane PATH,
|
|
||||||
dependency, and runtime install command.
|
|
||||||
|
|
||||||
Supported runtime install commands are:
|
|
||||||
|
|
||||||
- **Claude:** curl -fsSL https://claude.ai/install.sh | bash
|
|
||||||
- **Codex:** npm install -g @openai/codex
|
|
||||||
- **OpenCode:** npm install -g opencode-ai
|
|
||||||
- **Pi:** npm install -g @earendil-works/pi-coding-agent
|
|
||||||
|
|
||||||
## Launch and stop behavior
|
## Launch and stop behavior
|
||||||
|
|
||||||
The launcher obtains the agent's socket only from the validated generated projection. It creates or
|
The launcher obtains the agent's socket only from the validated generated projection. It creates or
|
||||||
|
|||||||
@@ -1,71 +0,0 @@
|
|||||||
# #1256 — Fleet runtime preflight
|
|
||||||
|
|
||||||
**Agent:** tiny
|
|
||||||
|
|
||||||
**Branch:** `fix/1256-fleet-runtime-preflight` from `origin/next@476db12b92971634b67fd2057b7577ee5894e449`
|
|
||||||
|
|
||||||
**Issue:** `mosaicstack/stack#1256` blocker 1
|
|
||||||
|
|
||||||
**Adjacent PR:** `#1258` (`fix/1256-fleet-pane-path-node`) owns the bootstrapped-Node candidate and must remain a separate change
|
|
||||||
|
|
||||||
**Budget:** 30K-token soft cap; one bounded implementation lane
|
|
||||||
|
|
||||||
## Objective
|
|
||||||
|
|
||||||
Make fleet provisioning fail before installation effects when the roster names a runtime binary absent from the exact PATH the tmux pane will receive. Make `mosaic fleet doctor` report the same named runtime check. Diagnostics must name the runtime, every requesting roster row, the pane PATH searched, and an exact install command.
|
|
||||||
|
|
||||||
For Pi the exact command is:
|
|
||||||
|
|
||||||
```text
|
|
||||||
npm install -g @earendil-works/pi-coding-agent
|
|
||||||
```
|
|
||||||
|
|
||||||
## Constraints
|
|
||||||
|
|
||||||
- TDD: add the failing behavior test and capture RED before implementation.
|
|
||||||
- Runtime resolution uses the launcher's pane-PATH construction; a second PATH model is forbidden.
|
|
||||||
- Operator PATH is non-authoritative and must not cause a false pass.
|
|
||||||
- Tests use an isolated `--mosaic-home`/temporary HOME and never mutate host runtime binaries.
|
|
||||||
- No install, removal, or binary-resolution changes on sb-it-1-dt.
|
|
||||||
- PR targets `next` and requires a reviewer other than fred.
|
|
||||||
- Commit identity is `tiny <[email protected]>`.
|
|
||||||
- #1258's Node candidate is a dependency/adjacent change, never reimplemented here.
|
|
||||||
|
|
||||||
## Planned seam
|
|
||||||
|
|
||||||
1. Factor the shell pane-path builder/resolver into one sourceable and executable fleet helper.
|
|
||||||
2. Have `start-agent-session.sh` source that helper, preserving one definition of the pane PATH.
|
|
||||||
3. Have the TypeScript fleet command invoke the same helper under the unit-equivalent clean launcher environment.
|
|
||||||
4. Group roster rows by distinct runtime and effective pane PATH, then report requesting row names.
|
|
||||||
5. Run the preflight before `installFleet` performs any write.
|
|
||||||
6. Add the named result to roster-v2 `fleet doctor` JSON and set a failing exit when a runtime is absent.
|
|
||||||
7. Install/copy the helper alongside `start-agent-session.sh` and update framework manifest/docs as required.
|
|
||||||
|
|
||||||
This seam overlaps #1258 only at the location of the existing shell function. Development may use #1258 as a local dependency, but the final PR diff must exclude #1258's separately owned Node change after that PR lands or after an agreed rebase order.
|
|
||||||
|
|
||||||
## Acceptance evidence
|
|
||||||
|
|
||||||
| Requirement | Evidence |
|
|
||||||
|---|---|
|
|
||||||
| Missing Pi blocks install before effects | isolated CLI test: nonzero + no installed files/runner effects |
|
|
||||||
| Operator PATH cannot create false green | test puts Pi only on operator PATH and omits it from constructed pane PATH |
|
|
||||||
| Exact pane PATH reused | launcher and CLI call one shared shell helper; contract test exercises both |
|
|
||||||
| Actionable diagnosis | runtime + roster rows + searched PATH + exact install command assertions |
|
|
||||||
| Distinct runtimes | repeated rows produce one check with all row names |
|
|
||||||
| Doctor reports named check | JSON assertion + nonzero exit for missing runtime |
|
|
||||||
| Present runtime passes | isolated pane-path fixture with executable binary |
|
|
||||||
| No host mutation | tests use temporary HOME/Mosaic home and fixture binaries only |
|
|
||||||
| Baseline safety | focused tests, package typecheck/lint/format, full relevant suite, CI |
|
|
||||||
|
|
||||||
## Progress log
|
|
||||||
|
|
||||||
- 2026-08-16: Dispatch received from fred; issue #1256 and PR #1258 measured.
|
|
||||||
- 2026-08-16: Fresh clone created under `~/agent-work/tiny-fleet-runtime-preflight`; local Git identity pinned to tiny so retired global `mos-dt-0` identity cannot win.
|
|
||||||
- 2026-08-16: Design inspection found the pane PATH exists only inside `start-agent-session.sh`; the right seam is a shared shell helper rather than a parallel TypeScript reconstruction.
|
|
||||||
- 2026-08-16: RED measured on `origin/next@476db12b`: focused `fleet-roster-v2-dispatch.spec.ts` ran 11 tests; the new case failed because install returned success, wrote units for two agents, and emitted no `runtime=pi` diagnosis while Pi existed only on operator PATH.
|
|
||||||
- 2026-08-16: Factored pane home/PATH/resolution into sourceable and executable `pane-runtime-path.sh`; install invokes it before the first effect, doctor emits the same named checks, and the launcher sources it.
|
|
||||||
- 2026-08-16: Fred/rhodey review exposed the #1241 name-resolution blind spot: `mosaic` can resolve while its `#!/usr/bin/env node` interpreter cannot. Measurement confirmed every supported current Mosaic package shape is a Node-shebang script, but executing `mosaic --version` is not observational because CLI startup runs the cache-writing/network update checker before Commander handles the flag.
|
|
||||||
- 2026-08-16: Final executable check reads and unwraps direct and `/usr/bin/env` shebangs (including `env -S`), resolves the declared dependency against pane PATH, and runs only side-effect-free `node --version` when Node is declared. Native binaries do not inherit a permanent Node requirement. Install, doctor, and launcher share this implementation.
|
|
||||||
- 2026-08-16: Isolated greenfield fixture places resolved Mosaic and Pi Node-shebang scripts in pane-visible npm-global bin while using an empty system suffix; both checks become `unexecutable` with `dependency=node`, and install leaves holder/tools/units absent. No host binary or HOME is changed.
|
|
||||||
- 2026-08-16: GREEN evidence before #1258 rebase: focused install/doctor/preflight suites pass; `fleet.spec.ts` 209/209; full Vitest 87 files / 1,557 tests; launcher shell suite, typecheck, lint, build, and focused format check pass. Full framework-shell reaches an unrelated host-measurement drift in unchanged `invariant_r_unittest.py` (expected Pi 0.84.1, host resolves 0.84.2); no invariant was changed in this lane.
|
|
||||||
- 2026-08-16: Merge-order gate remains: `origin/next` is still `476db12b`; #1258 is unmerged at `6dc35e5`. Rebase after it lands, relocate its Node candidate into the helper with explicit provenance, rerun gates, then open the PR to `next` for an independent non-fred review.
|
|
||||||
@@ -34,6 +34,7 @@ export default tseslint.config(
|
|||||||
'packages/storage/vitest.config.ts',
|
'packages/storage/vitest.config.ts',
|
||||||
'packages/mosaic/vitest.config.ts',
|
'packages/mosaic/vitest.config.ts',
|
||||||
'packages/mosaic/__tests__/*.ts',
|
'packages/mosaic/__tests__/*.ts',
|
||||||
|
'packages/forge/__tests__/*.ts',
|
||||||
'tools/federation-harness/*.ts',
|
'tools/federation-harness/*.ts',
|
||||||
],
|
],
|
||||||
},
|
},
|
||||||
|
|||||||
@@ -539,3 +539,43 @@ Not every brief needs full Board of Directors review. The classification system
|
|||||||
### Backward compatibility
|
### Backward compatibility
|
||||||
|
|
||||||
Existing briefs without a `class` field are auto-classified. The default (no matching keywords) is `strategic`, so all existing runs get the full pipeline unless keywords trigger `technical`.
|
Existing briefs without a `class` field are auto-classified. The default (no matching keywords) is `strategic`, so all existing runs get the full pipeline unless keywords trigger `technical`.
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## Fail-Closed Execution & Explicit Simulation (SDLC-D-035)
|
||||||
|
|
||||||
|
**Added:** 2026-08-17
|
||||||
|
|
||||||
|
Forge fails closed when a required capability is missing. It never runs a
|
||||||
|
pipeline with a stub executor and reports success.
|
||||||
|
|
||||||
|
### Normal mode (default)
|
||||||
|
|
||||||
|
- No task executor wired → the CLI exits nonzero with the typed capability
|
||||||
|
error `FORGE_NO_EXECUTOR`. No run is created.
|
||||||
|
- A stage whose gate is approval-based (board approval, planning approvals,
|
||||||
|
remediation re-review, discovery/analysis attestations) records a typed
|
||||||
|
`waiting-for-authority` stage result and raises `FORGE_AUTHORITY_REQUIRED`.
|
||||||
|
It never passes vacuously.
|
||||||
|
- A stage whose gate requires an unwired provider (AI reviewer, CI pipeline)
|
||||||
|
records a typed `blocked` stage result and raises `FORGE_NO_REVIEWER` /
|
||||||
|
`FORGE_NO_CI_PIPELINE`. The synthetic echo-review approval in `06-review`
|
||||||
|
and all vacuous `true` gates were removed.
|
||||||
|
|
||||||
|
### Explicit simulation (`--simulate`)
|
||||||
|
|
||||||
|
Opts into stub/synthetic execution. Every stage result, every gate result, and
|
||||||
|
the run manifest carry the distinct typed status `simulated` (manifest also
|
||||||
|
records `mode: "simulated"`). `simulated` is a non-satisfying outcome:
|
||||||
|
`isSatisfyingOutcome()` and all completion/gate consumers treat only `passed`
|
||||||
|
as satisfying. The CLI exits 0 for a simulated run only because the caller
|
||||||
|
explicitly passed `--simulate`, and prints a loud SIMULATED banner.
|
||||||
|
|
||||||
|
### Typed outcome model
|
||||||
|
|
||||||
|
Every gate/task outcome is one of the closed set
|
||||||
|
`passed | failed | blocked | error | waiting-for-authority | simulated |
|
||||||
|
not-applicable`, with the reason recorded on the stage status and each gate
|
||||||
|
result in `manifest.json`. Missing implementations, missing gate evidence,
|
||||||
|
unknown stages, process errors, and timeouts map to fail-closed members —
|
||||||
|
never to `passed`.
|
||||||
|
|||||||
@@ -0,0 +1,319 @@
|
|||||||
|
import fs from 'node:fs';
|
||||||
|
import os from 'node:os';
|
||||||
|
import path from 'node:path';
|
||||||
|
import { describe, it, expect, beforeEach, afterEach } from 'vitest';
|
||||||
|
|
||||||
|
import { generateBoardTasks } from '../src/board-tasks.js';
|
||||||
|
import { STAGE_SPECS } from '../src/constants.js';
|
||||||
|
import { ForgeCapabilityError } from '../src/errors.js';
|
||||||
|
import {
|
||||||
|
evaluateStageGates,
|
||||||
|
gateLabel,
|
||||||
|
isCommandGate,
|
||||||
|
isSatisfyingOutcome,
|
||||||
|
} from '../src/outcomes.js';
|
||||||
|
import { loadManifest, runPipeline } from '../src/pipeline-runner.js';
|
||||||
|
import type { ForgeTask, ForgeTaskResult, TaskExecutor } from '../src/types.js';
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Mock real executor that returns typed results.
|
||||||
|
*
|
||||||
|
* Command gates are "verified" by the mock so normal-mode runs can pass
|
||||||
|
* mechanically gated stages; authority/provider gates are never reported
|
||||||
|
* because they have no mechanical implementation.
|
||||||
|
*/
|
||||||
|
function createTypedExecutor(options?: {
|
||||||
|
failStage?: string;
|
||||||
|
gateOutcomes?: Record<string, 'passed' | 'failed' | 'simulated' | 'error' | 'blocked'>;
|
||||||
|
}): TaskExecutor & { submittedTasks: ForgeTask[] } {
|
||||||
|
const submittedTasks: ForgeTask[] = [];
|
||||||
|
return {
|
||||||
|
submittedTasks,
|
||||||
|
async submitTask(task: ForgeTask) {
|
||||||
|
submittedTasks.push(task);
|
||||||
|
},
|
||||||
|
async waitForCompletion(taskId: string): Promise<ForgeTaskResult> {
|
||||||
|
const task = submittedTasks.find((t) => t.id === taskId);
|
||||||
|
const stageName = task?.metadata?.['stageName'] as string | undefined;
|
||||||
|
|
||||||
|
if (options?.failStage && stageName === options.failStage) {
|
||||||
|
return {
|
||||||
|
task_id: taskId,
|
||||||
|
outcome: 'failed',
|
||||||
|
reason: 'mock task failure',
|
||||||
|
completed_at: new Date().toISOString(),
|
||||||
|
exit_code: 1,
|
||||||
|
gate_results: [],
|
||||||
|
};
|
||||||
|
}
|
||||||
|
|
||||||
|
const gateResults = (task?.qualityGates ?? [])
|
||||||
|
.filter((gate) => isCommandGate(gate))
|
||||||
|
.map((gate) => {
|
||||||
|
const label = gateLabel(gate);
|
||||||
|
const outcome = options?.gateOutcomes?.[label] ?? 'passed';
|
||||||
|
return {
|
||||||
|
gate: label,
|
||||||
|
outcome,
|
||||||
|
reason: outcome === 'passed' ? 'mock verified' : `mock gate outcome: ${outcome}`,
|
||||||
|
};
|
||||||
|
});
|
||||||
|
|
||||||
|
return {
|
||||||
|
task_id: taskId,
|
||||||
|
outcome: 'passed',
|
||||||
|
reason: 'mock verified',
|
||||||
|
completed_at: new Date().toISOString(),
|
||||||
|
exit_code: 0,
|
||||||
|
gate_results: gateResults,
|
||||||
|
};
|
||||||
|
},
|
||||||
|
async getTaskStatus() {
|
||||||
|
return 'completed' as const;
|
||||||
|
},
|
||||||
|
};
|
||||||
|
}
|
||||||
|
|
||||||
|
describe('fail-closed: no executor wired', () => {
|
||||||
|
let tmpDir: string;
|
||||||
|
let briefPath: string;
|
||||||
|
|
||||||
|
beforeEach(() => {
|
||||||
|
tmpDir = fs.mkdtempSync(path.join(os.tmpdir(), 'forge-failclosed-'));
|
||||||
|
briefPath = path.join(tmpDir, 'brief.md');
|
||||||
|
fs.writeFileSync(briefPath, '# Fix bug\n\nA bugfix for lint cleanup.');
|
||||||
|
});
|
||||||
|
|
||||||
|
afterEach(() => {
|
||||||
|
fs.rmSync(tmpDir, { recursive: true, force: true });
|
||||||
|
});
|
||||||
|
|
||||||
|
it('throws a typed FORGE_NO_EXECUTOR capability error without --simulate', async () => {
|
||||||
|
await expect(
|
||||||
|
runPipeline(briefPath, tmpDir, {
|
||||||
|
// no executor, no simulate — must fail closed, never run with a stub
|
||||||
|
stages: ['00-intake'],
|
||||||
|
}),
|
||||||
|
).rejects.toMatchObject({
|
||||||
|
name: 'ForgeCapabilityError',
|
||||||
|
code: 'FORGE_NO_EXECUTOR',
|
||||||
|
capability: 'task-executor',
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|
||||||
|
it('does not create a run directory when failing closed on a missing executor', async () => {
|
||||||
|
try {
|
||||||
|
await runPipeline(briefPath, tmpDir, { stages: ['00-intake'] });
|
||||||
|
} catch {
|
||||||
|
// expected
|
||||||
|
}
|
||||||
|
expect(fs.existsSync(path.join(tmpDir, '.forge', 'runs'))).toBe(false);
|
||||||
|
});
|
||||||
|
|
||||||
|
it('completes with every result typed simulated when simulate is set', async () => {
|
||||||
|
const result = await runPipeline(briefPath, tmpDir, {
|
||||||
|
simulate: true,
|
||||||
|
stages: ['00-intake', '00b-discovery', '02-planning-1', '06-review'],
|
||||||
|
});
|
||||||
|
|
||||||
|
expect(result.manifest.mode).toBe('simulated');
|
||||||
|
expect(result.manifest.status).toBe('simulated');
|
||||||
|
|
||||||
|
for (const stage of result.stages) {
|
||||||
|
const stageStatus = result.manifest.stages[stage];
|
||||||
|
expect(stageStatus?.status, `stage ${stage}`).toBe('simulated');
|
||||||
|
expect(stageStatus?.status, `stage ${stage}`).not.toBe('passed');
|
||||||
|
expect(stageStatus?.reason, `stage ${stage}`).toBeTruthy();
|
||||||
|
for (const gateResult of stageStatus?.gateResults ?? []) {
|
||||||
|
expect(gateResult.outcome, `gate ${gateResult.gate} of ${stage}`).toBe('simulated');
|
||||||
|
expect(gateResult.outcome, `gate ${gateResult.gate} of ${stage}`).not.toBe('passed');
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// The persisted manifest agrees.
|
||||||
|
const persisted = loadManifest(result.runDir);
|
||||||
|
expect(persisted.mode).toBe('simulated');
|
||||||
|
expect(persisted.status).toBe('simulated');
|
||||||
|
expect(persisted.stages['02-planning-1']?.status).toBe('simulated');
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|
||||||
|
describe('fail-closed: typed outcome model', () => {
|
||||||
|
it('only passed satisfies the gate/dependency predicate', () => {
|
||||||
|
expect(isSatisfyingOutcome('passed')).toBe(true);
|
||||||
|
expect(isSatisfyingOutcome('failed')).toBe(false);
|
||||||
|
expect(isSatisfyingOutcome('blocked')).toBe(false);
|
||||||
|
expect(isSatisfyingOutcome('error')).toBe(false);
|
||||||
|
expect(isSatisfyingOutcome('waiting-for-authority')).toBe(false);
|
||||||
|
expect(isSatisfyingOutcome('simulated')).toBe(false);
|
||||||
|
expect(isSatisfyingOutcome('not-applicable')).toBe(false);
|
||||||
|
});
|
||||||
|
|
||||||
|
it('a simulated gate result cannot satisfy the stage gate evaluation', () => {
|
||||||
|
const evaluation = evaluateStageGates('05-coding', STAGE_SPECS['05-coding']!.qualityGates, {
|
||||||
|
task_id: 'FORGE-x-05',
|
||||||
|
outcome: 'passed',
|
||||||
|
reason: 'executor claims success',
|
||||||
|
completed_at: new Date().toISOString(),
|
||||||
|
exit_code: 0,
|
||||||
|
gate_results: [{ gate: 'pnpm lint', outcome: 'simulated', reason: 'simulated gate' }],
|
||||||
|
});
|
||||||
|
expect(isSatisfyingOutcome(evaluation.outcome)).toBe(false);
|
||||||
|
expect(evaluation.outcome).toBe('error');
|
||||||
|
});
|
||||||
|
|
||||||
|
it('a simulated task outcome cannot satisfy evaluation in normal mode', () => {
|
||||||
|
const evaluation = evaluateStageGates('00-intake', [], {
|
||||||
|
task_id: 'FORGE-x-00',
|
||||||
|
outcome: 'simulated',
|
||||||
|
reason: 'executor reported simulated',
|
||||||
|
completed_at: new Date().toISOString(),
|
||||||
|
exit_code: 0,
|
||||||
|
gate_results: [],
|
||||||
|
});
|
||||||
|
expect(isSatisfyingOutcome(evaluation.outcome)).toBe(false);
|
||||||
|
});
|
||||||
|
|
||||||
|
it('a missing gate result blocks the stage instead of passing vacuously', () => {
|
||||||
|
const evaluation = evaluateStageGates('05-coding', STAGE_SPECS['05-coding']!.qualityGates, {
|
||||||
|
task_id: 'FORGE-x-05',
|
||||||
|
outcome: 'passed',
|
||||||
|
reason: 'executor claims success',
|
||||||
|
completed_at: new Date().toISOString(),
|
||||||
|
exit_code: 0,
|
||||||
|
gate_results: [],
|
||||||
|
});
|
||||||
|
expect(evaluation.outcome).toBe('blocked');
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|
||||||
|
describe('fail-closed: authority and provider gates', () => {
|
||||||
|
let tmpDir: string;
|
||||||
|
let briefPath: string;
|
||||||
|
|
||||||
|
beforeEach(() => {
|
||||||
|
tmpDir = fs.mkdtempSync(path.join(os.tmpdir(), 'forge-authority-'));
|
||||||
|
briefPath = path.join(tmpDir, 'brief.md');
|
||||||
|
fs.writeFileSync(briefPath, '# Fix bug\n\nA bugfix for lint cleanup.');
|
||||||
|
});
|
||||||
|
|
||||||
|
afterEach(() => {
|
||||||
|
fs.rmSync(tmpDir, { recursive: true, force: true });
|
||||||
|
});
|
||||||
|
|
||||||
|
it.each(['02-planning-1', '03-planning-2', '04-planning-3', '07-remediate'])(
|
||||||
|
'planning/remediation stage %s yields waiting-for-authority (not passed) in normal mode',
|
||||||
|
async (stage) => {
|
||||||
|
const executor = createTypedExecutor();
|
||||||
|
let runDir: string | undefined;
|
||||||
|
|
||||||
|
try {
|
||||||
|
await runPipeline(briefPath, tmpDir, {
|
||||||
|
executor,
|
||||||
|
stages: [stage as string],
|
||||||
|
});
|
||||||
|
expect.unreachable('runPipeline should have failed closed');
|
||||||
|
} catch (err) {
|
||||||
|
expect(err).toBeInstanceOf(ForgeCapabilityError);
|
||||||
|
expect((err as ForgeCapabilityError).code).toBe('FORGE_AUTHORITY_REQUIRED');
|
||||||
|
runDir = path.join(tmpDir, '.forge', 'runs');
|
||||||
|
}
|
||||||
|
|
||||||
|
const runIds = fs.readdirSync(runDir!);
|
||||||
|
expect(runIds).toHaveLength(1);
|
||||||
|
const manifest = loadManifest(path.join(runDir!, runIds[0]!));
|
||||||
|
expect(manifest.stages[stage]?.status).toBe('waiting-for-authority');
|
||||||
|
expect(manifest.stages[stage]?.status).not.toBe('passed');
|
||||||
|
expect(manifest.status).toBe('waiting-for-authority');
|
||||||
|
},
|
||||||
|
);
|
||||||
|
|
||||||
|
it('review stage fails closed with a typed FORGE_NO_REVIEWER error in normal mode', async () => {
|
||||||
|
const executor = createTypedExecutor();
|
||||||
|
|
||||||
|
try {
|
||||||
|
await runPipeline(briefPath, tmpDir, {
|
||||||
|
executor,
|
||||||
|
stages: ['06-review'],
|
||||||
|
});
|
||||||
|
expect.unreachable('runPipeline should have failed closed');
|
||||||
|
} catch (err) {
|
||||||
|
expect(err).toBeInstanceOf(ForgeCapabilityError);
|
||||||
|
expect((err as ForgeCapabilityError).code).toBe('FORGE_NO_REVIEWER');
|
||||||
|
expect((err as ForgeCapabilityError).capability).toBe('reviewer');
|
||||||
|
}
|
||||||
|
|
||||||
|
const runsDir = path.join(tmpDir, '.forge', 'runs');
|
||||||
|
const runIds = fs.readdirSync(runsDir);
|
||||||
|
const manifest = loadManifest(path.join(runsDir, runIds[0]!));
|
||||||
|
expect(manifest.stages['06-review']?.status).toBe('blocked');
|
||||||
|
expect(manifest.stages['06-review']?.status).not.toBe('passed');
|
||||||
|
expect(manifest.status).toBe('failed');
|
||||||
|
});
|
||||||
|
|
||||||
|
it('review stage produces simulated results under --simulate', async () => {
|
||||||
|
const result = await runPipeline(briefPath, tmpDir, {
|
||||||
|
simulate: true,
|
||||||
|
stages: ['06-review'],
|
||||||
|
});
|
||||||
|
|
||||||
|
expect(result.manifest.mode).toBe('simulated');
|
||||||
|
expect(result.manifest.stages['06-review']?.status).toBe('simulated');
|
||||||
|
for (const gateResult of result.manifest.stages['06-review']?.gateResults ?? []) {
|
||||||
|
expect(gateResult.outcome).toBe('simulated');
|
||||||
|
}
|
||||||
|
});
|
||||||
|
|
||||||
|
it('deploy stage fails closed without a wired ci-pipeline provider in normal mode', async () => {
|
||||||
|
const executor = createTypedExecutor();
|
||||||
|
|
||||||
|
await expect(
|
||||||
|
runPipeline(briefPath, tmpDir, {
|
||||||
|
executor,
|
||||||
|
stages: ['09-deploy'],
|
||||||
|
}),
|
||||||
|
).rejects.toMatchObject({
|
||||||
|
name: 'ForgeCapabilityError',
|
||||||
|
code: 'FORGE_NO_CI_PIPELINE',
|
||||||
|
});
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|
||||||
|
describe('fail-closed: no vacuous gate commands remain', () => {
|
||||||
|
it('stage constants contain no echo/synthetic-approval, vacuous true, or empty gate commands', () => {
|
||||||
|
for (const [stageName, spec] of Object.entries(STAGE_SPECS)) {
|
||||||
|
for (const gate of spec.qualityGates) {
|
||||||
|
const serialized = JSON.stringify(gate);
|
||||||
|
// The echo-review synthetic approval must be gone.
|
||||||
|
expect(serialized, `stage ${stageName} gate ${serialized}`).not.toContain('echo');
|
||||||
|
expect(serialized, `stage ${stageName} gate ${serialized}`).not.toMatch(/"verdict"\s*:/);
|
||||||
|
expect(serialized, `stage ${stageName} gate ${serialized}`).not.toMatch(
|
||||||
|
/"summary"\s*:\s*"review-pass"/,
|
||||||
|
);
|
||||||
|
// No vacuous literal `true` gate.
|
||||||
|
expect(gate, `stage ${stageName}`).not.toBe('true');
|
||||||
|
// Command gates must carry a real, non-empty command.
|
||||||
|
if (isCommandGate(gate)) {
|
||||||
|
const command = typeof gate === 'string' ? gate : gate.command;
|
||||||
|
expect(command.trim().length, `stage ${stageName} gate ${serialized}`).toBeGreaterThan(0);
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
});
|
||||||
|
|
||||||
|
it('board tasks contain no vacuous true gates', () => {
|
||||||
|
const tmpDir = fs.mkdtempSync(path.join(os.tmpdir(), 'forge-board-gates-'));
|
||||||
|
try {
|
||||||
|
const tasks = generateBoardTasks('# Brief', [], tmpDir, 'BOARD-TEST');
|
||||||
|
for (const task of tasks) {
|
||||||
|
for (const gate of task.qualityGates) {
|
||||||
|
expect(gate, `task ${task.id}`).not.toBe('true');
|
||||||
|
const serialized = JSON.stringify(gate);
|
||||||
|
expect(serialized, `task ${task.id} gate ${serialized}`).not.toContain('echo');
|
||||||
|
}
|
||||||
|
}
|
||||||
|
} finally {
|
||||||
|
fs.rmSync(tmpDir, { recursive: true, force: true });
|
||||||
|
}
|
||||||
|
});
|
||||||
|
});
|
||||||
@@ -12,10 +12,10 @@ import {
|
|||||||
resumePipeline,
|
resumePipeline,
|
||||||
getPipelineStatus,
|
getPipelineStatus,
|
||||||
} from '../src/pipeline-runner.js';
|
} from '../src/pipeline-runner.js';
|
||||||
import type { ForgeTask, RunManifest, TaskExecutor } from '../src/types.js';
|
import type { ForgeTask, ForgeTaskResult, RunManifest, TaskExecutor } from '../src/types.js';
|
||||||
import type { TaskResult } from '@mosaicstack/macp';
|
import { gateLabel, isCommandGate } from '../src/outcomes.js';
|
||||||
|
|
||||||
/** Mock TaskExecutor that records submitted tasks and returns success. */
|
/** Mock TaskExecutor that records submitted tasks and returns typed results. */
|
||||||
function createMockExecutor(options?: {
|
function createMockExecutor(options?: {
|
||||||
failStage?: string;
|
failStage?: string;
|
||||||
}): TaskExecutor & { submittedTasks: ForgeTask[] } {
|
}): TaskExecutor & { submittedTasks: ForgeTask[] } {
|
||||||
@@ -25,7 +25,7 @@ function createMockExecutor(options?: {
|
|||||||
async submitTask(task: ForgeTask) {
|
async submitTask(task: ForgeTask) {
|
||||||
submittedTasks.push(task);
|
submittedTasks.push(task);
|
||||||
},
|
},
|
||||||
async waitForCompletion(taskId: string): Promise<TaskResult> {
|
async waitForCompletion(taskId: string): Promise<ForgeTaskResult> {
|
||||||
const failStage = options?.failStage;
|
const failStage = options?.failStage;
|
||||||
const task = submittedTasks.find((t) => t.id === taskId);
|
const task = submittedTasks.find((t) => t.id === taskId);
|
||||||
const stageName = task?.metadata?.['stageName'] as string | undefined;
|
const stageName = task?.metadata?.['stageName'] as string | undefined;
|
||||||
@@ -33,7 +33,8 @@ function createMockExecutor(options?: {
|
|||||||
if (failStage && stageName === failStage) {
|
if (failStage && stageName === failStage) {
|
||||||
return {
|
return {
|
||||||
task_id: taskId,
|
task_id: taskId,
|
||||||
status: 'failed',
|
outcome: 'failed',
|
||||||
|
reason: 'mock task failure',
|
||||||
completed_at: new Date().toISOString(),
|
completed_at: new Date().toISOString(),
|
||||||
exit_code: 1,
|
exit_code: 1,
|
||||||
gate_results: [],
|
gate_results: [],
|
||||||
@@ -41,10 +42,17 @@ function createMockExecutor(options?: {
|
|||||||
}
|
}
|
||||||
return {
|
return {
|
||||||
task_id: taskId,
|
task_id: taskId,
|
||||||
status: 'completed',
|
outcome: 'passed',
|
||||||
|
reason: 'mock verified',
|
||||||
completed_at: new Date().toISOString(),
|
completed_at: new Date().toISOString(),
|
||||||
exit_code: 0,
|
exit_code: 0,
|
||||||
gate_results: [],
|
gate_results: (task?.qualityGates ?? [])
|
||||||
|
.filter((gate) => isCommandGate(gate))
|
||||||
|
.map((gate) => ({
|
||||||
|
gate: gateLabel(gate),
|
||||||
|
outcome: 'passed' as const,
|
||||||
|
reason: 'mock verified',
|
||||||
|
})),
|
||||||
};
|
};
|
||||||
},
|
},
|
||||||
async getTaskStatus() {
|
async getTaskStatus() {
|
||||||
@@ -156,12 +164,13 @@ describe('runPipeline', () => {
|
|||||||
const executor = createMockExecutor();
|
const executor = createMockExecutor();
|
||||||
const result = await runPipeline(briefPath, tmpDir, {
|
const result = await runPipeline(briefPath, tmpDir, {
|
||||||
executor,
|
executor,
|
||||||
stages: ['00-intake', '00b-discovery'],
|
stages: ['00-intake', '05-coding'],
|
||||||
});
|
});
|
||||||
|
|
||||||
expect(result.runId).toMatch(/^\d{8}-\d{6}$/);
|
expect(result.runId).toMatch(/^\d{8}-\d{6}$/);
|
||||||
expect(result.stages).toEqual(['00-intake', '00b-discovery']);
|
expect(result.stages).toEqual(['00-intake', '05-coding']);
|
||||||
expect(result.manifest.status).toBe('completed');
|
expect(result.manifest.status).toBe('completed');
|
||||||
|
expect(result.manifest.mode).toBe('normal');
|
||||||
expect(executor.submittedTasks).toHaveLength(2);
|
expect(executor.submittedTasks).toHaveLength(2);
|
||||||
});
|
});
|
||||||
|
|
||||||
@@ -180,12 +189,17 @@ describe('runPipeline', () => {
|
|||||||
const executor = createMockExecutor();
|
const executor = createMockExecutor();
|
||||||
const result = await runPipeline(briefPath, tmpDir, {
|
const result = await runPipeline(briefPath, tmpDir, {
|
||||||
executor,
|
executor,
|
||||||
stages: ['00-intake', '00b-discovery'],
|
stages: ['00-intake', '05-coding'],
|
||||||
});
|
});
|
||||||
|
|
||||||
const manifest = loadManifest(result.runDir);
|
const manifest = loadManifest(result.runDir);
|
||||||
expect(manifest.stages['00-intake']?.status).toBe('passed');
|
expect(manifest.stages['00-intake']?.status).toBe('passed');
|
||||||
expect(manifest.stages['00b-discovery']?.status).toBe('passed');
|
expect(manifest.stages['05-coding']?.status).toBe('passed');
|
||||||
|
expect(manifest.stages['05-coding']?.gateResults?.map((g) => g.outcome)).toEqual([
|
||||||
|
'passed',
|
||||||
|
'passed',
|
||||||
|
'passed',
|
||||||
|
]);
|
||||||
});
|
});
|
||||||
|
|
||||||
it('respects CLI class override', async () => {
|
it('respects CLI class override', async () => {
|
||||||
@@ -215,7 +229,7 @@ describe('runPipeline', () => {
|
|||||||
const executor = createMockExecutor();
|
const executor = createMockExecutor();
|
||||||
await runPipeline(briefPath, tmpDir, {
|
await runPipeline(briefPath, tmpDir, {
|
||||||
executor,
|
executor,
|
||||||
stages: ['00-intake', '00b-discovery', '02-planning-1'],
|
stages: ['00-intake', '05-coding', '08-test'],
|
||||||
});
|
});
|
||||||
|
|
||||||
expect(executor.submittedTasks[0]!.dependsOn).toBeUndefined();
|
expect(executor.submittedTasks[0]!.dependsOn).toBeUndefined();
|
||||||
@@ -224,14 +238,14 @@ describe('runPipeline', () => {
|
|||||||
});
|
});
|
||||||
|
|
||||||
it('handles stage failure', async () => {
|
it('handles stage failure', async () => {
|
||||||
const executor = createMockExecutor({ failStage: '00b-discovery' });
|
const executor = createMockExecutor({ failStage: '05-coding' });
|
||||||
|
|
||||||
await expect(
|
await expect(
|
||||||
runPipeline(briefPath, tmpDir, {
|
runPipeline(briefPath, tmpDir, {
|
||||||
executor,
|
executor,
|
||||||
stages: ['00-intake', '00b-discovery'],
|
stages: ['00-intake', '05-coding'],
|
||||||
}),
|
}),
|
||||||
).rejects.toThrow('Stage 00b-discovery failed');
|
).rejects.toThrow('Stage 05-coding failed');
|
||||||
});
|
});
|
||||||
|
|
||||||
it('marks manifest as failed on stage failure', async () => {
|
it('marks manifest as failed on stage failure', async () => {
|
||||||
@@ -270,30 +284,143 @@ describe('resumePipeline', () => {
|
|||||||
fs.rmSync(tmpDir, { recursive: true, force: true });
|
fs.rmSync(tmpDir, { recursive: true, force: true });
|
||||||
});
|
});
|
||||||
|
|
||||||
it('resumes from first incomplete stage', async () => {
|
it('resumes from first incomplete stage and fails closed at the next provider gate', async () => {
|
||||||
// First run fails on discovery
|
// Simulate a run whose authority stages were approved out-of-band
|
||||||
const executor1 = createMockExecutor({ failStage: '00b-discovery' });
|
// (recorded as passed) and whose coding stage failed mechanically.
|
||||||
let runDir: string;
|
const runId = '20260101-000000';
|
||||||
|
const runDir = path.join(tmpDir, '.forge', 'runs', runId);
|
||||||
try {
|
fs.mkdirSync(runDir, { recursive: true });
|
||||||
await runPipeline(briefPath, tmpDir, {
|
const passed = { status: 'passed' as const, startedAt: '2026-01-01T00:00:00Z' };
|
||||||
executor: executor1,
|
saveManifest(runDir, {
|
||||||
stages: ['00-intake', '00b-discovery', '02-planning-1'],
|
runId,
|
||||||
|
brief: briefPath,
|
||||||
|
codebase: tmpDir,
|
||||||
|
briefClass: 'hotfix',
|
||||||
|
classSource: 'frontmatter',
|
||||||
|
forceBoard: false,
|
||||||
|
mode: 'normal',
|
||||||
|
createdAt: '2026-01-01T00:00:00Z',
|
||||||
|
updatedAt: '2026-01-01T00:00:00Z',
|
||||||
|
currentStage: '05-coding',
|
||||||
|
status: 'failed',
|
||||||
|
stages: {
|
||||||
|
'00-intake': passed,
|
||||||
|
'00b-discovery': passed,
|
||||||
|
'02-planning-1': passed,
|
||||||
|
'03-planning-2': passed,
|
||||||
|
'04-planning-3': passed,
|
||||||
|
'05-coding': { status: 'failed', reason: 'gate failed' },
|
||||||
|
},
|
||||||
});
|
});
|
||||||
} catch {
|
|
||||||
// expected
|
// Resume re-runs 05-coding (the first non-passed stage), then fails
|
||||||
|
// closed at 06-review because no reviewer provider is wired.
|
||||||
|
const executor = createMockExecutor();
|
||||||
|
await expect(resumePipeline(runDir, executor)).rejects.toMatchObject({
|
||||||
|
name: 'ForgeCapabilityError',
|
||||||
|
code: 'FORGE_NO_REVIEWER',
|
||||||
|
});
|
||||||
|
|
||||||
|
const manifest = loadManifest(runDir);
|
||||||
|
expect(manifest.stages['05-coding']?.status).toBe('passed');
|
||||||
|
expect(manifest.stages['06-review']?.status).toBe('blocked');
|
||||||
|
expect(manifest.status).toBe('failed');
|
||||||
|
});
|
||||||
|
|
||||||
|
it('resumes to completion as simulated under explicit simulate', async () => {
|
||||||
|
const runId = '20260101-000003';
|
||||||
|
const runDir = path.join(tmpDir, '.forge', 'runs', runId);
|
||||||
|
fs.mkdirSync(runDir, { recursive: true });
|
||||||
|
const passed = { status: 'passed' as const, startedAt: '2026-01-01T00:00:00Z' };
|
||||||
|
saveManifest(runDir, {
|
||||||
|
runId,
|
||||||
|
brief: briefPath,
|
||||||
|
codebase: tmpDir,
|
||||||
|
briefClass: 'hotfix',
|
||||||
|
classSource: 'frontmatter',
|
||||||
|
forceBoard: false,
|
||||||
|
mode: 'normal',
|
||||||
|
createdAt: '2026-01-01T00:00:00Z',
|
||||||
|
updatedAt: '2026-01-01T00:00:00Z',
|
||||||
|
currentStage: '05-coding',
|
||||||
|
status: 'failed',
|
||||||
|
stages: {
|
||||||
|
'00-intake': passed,
|
||||||
|
'00b-discovery': passed,
|
||||||
|
'02-planning-1': passed,
|
||||||
|
'03-planning-2': passed,
|
||||||
|
'04-planning-3': passed,
|
||||||
|
'05-coding': { status: 'failed', reason: 'gate failed' },
|
||||||
|
},
|
||||||
|
});
|
||||||
|
|
||||||
|
const result = await resumePipeline(runDir, undefined, { simulate: true });
|
||||||
|
|
||||||
|
expect(result.manifest.status).toBe('simulated');
|
||||||
|
expect(result.manifest.mode).toBe('simulated');
|
||||||
|
expect(result.stages[0]).toBe('05-coding');
|
||||||
|
for (const stage of result.stages) {
|
||||||
|
expect(result.manifest.stages[stage]?.status).toBe('simulated');
|
||||||
}
|
}
|
||||||
|
});
|
||||||
|
|
||||||
const runsDir = path.join(tmpDir, '.forge', 'runs');
|
it('fails closed on resume when the next stage needs authority sign-off', async () => {
|
||||||
runDir = path.join(runsDir, fs.readdirSync(runsDir)[0]!);
|
const runId = '20260101-000001';
|
||||||
|
const runDir = path.join(tmpDir, '.forge', 'runs', runId);
|
||||||
|
fs.mkdirSync(runDir, { recursive: true });
|
||||||
|
saveManifest(runDir, {
|
||||||
|
runId,
|
||||||
|
brief: briefPath,
|
||||||
|
codebase: tmpDir,
|
||||||
|
briefClass: 'hotfix',
|
||||||
|
classSource: 'frontmatter',
|
||||||
|
forceBoard: false,
|
||||||
|
mode: 'normal',
|
||||||
|
createdAt: '2026-01-01T00:00:00Z',
|
||||||
|
updatedAt: '2026-01-01T00:00:00Z',
|
||||||
|
currentStage: '00-intake',
|
||||||
|
status: 'in_progress',
|
||||||
|
stages: {
|
||||||
|
'00-intake': { status: 'passed' },
|
||||||
|
},
|
||||||
|
});
|
||||||
|
|
||||||
// Resume should pick up from 00b-discovery
|
const executor = createMockExecutor();
|
||||||
const executor2 = createMockExecutor();
|
await expect(resumePipeline(runDir, executor)).rejects.toMatchObject({
|
||||||
const result = await resumePipeline(runDir, executor2);
|
name: 'ForgeCapabilityError',
|
||||||
|
code: 'FORGE_AUTHORITY_REQUIRED',
|
||||||
|
});
|
||||||
|
|
||||||
expect(result.manifest.status).toBe('completed');
|
const manifest = loadManifest(runDir);
|
||||||
// Should have re-run from 00b-discovery onward
|
expect(manifest.stages['00b-discovery']?.status).toBe('waiting-for-authority');
|
||||||
expect(result.stages[0]).toBe('00b-discovery');
|
expect(manifest.status).toBe('waiting-for-authority');
|
||||||
|
});
|
||||||
|
|
||||||
|
it('fails closed on resume without an executor or --simulate', async () => {
|
||||||
|
const runId = '20260101-000002';
|
||||||
|
const runDir = path.join(tmpDir, '.forge', 'runs', runId);
|
||||||
|
fs.mkdirSync(runDir, { recursive: true });
|
||||||
|
saveManifest(runDir, {
|
||||||
|
runId,
|
||||||
|
brief: briefPath,
|
||||||
|
codebase: tmpDir,
|
||||||
|
briefClass: 'hotfix',
|
||||||
|
classSource: 'frontmatter',
|
||||||
|
forceBoard: false,
|
||||||
|
mode: 'normal',
|
||||||
|
createdAt: '2026-01-01T00:00:00Z',
|
||||||
|
updatedAt: '2026-01-01T00:00:00Z',
|
||||||
|
currentStage: '00-intake',
|
||||||
|
status: 'in_progress',
|
||||||
|
stages: {
|
||||||
|
'00-intake': { status: 'passed' },
|
||||||
|
},
|
||||||
|
});
|
||||||
|
|
||||||
|
await expect(resumePipeline(runDir)).rejects.toMatchObject({
|
||||||
|
name: 'ForgeCapabilityError',
|
||||||
|
code: 'FORGE_NO_EXECUTOR',
|
||||||
|
});
|
||||||
});
|
});
|
||||||
});
|
});
|
||||||
|
|
||||||
|
|||||||
@@ -95,7 +95,14 @@ export function generateBoardTasks(
|
|||||||
briefPath,
|
briefPath,
|
||||||
resultPath: resultRelPath,
|
resultPath: resultRelPath,
|
||||||
timeoutSeconds: 120,
|
timeoutSeconds: 120,
|
||||||
qualityGates: ['true'],
|
qualityGates: [
|
||||||
|
{
|
||||||
|
kind: 'authority',
|
||||||
|
capability: 'board-approval',
|
||||||
|
reason:
|
||||||
|
'persona evaluation is judged by board synthesis (authority review); no mechanical gate exists',
|
||||||
|
},
|
||||||
|
],
|
||||||
metadata: {
|
metadata: {
|
||||||
personaName: persona.name,
|
personaName: persona.name,
|
||||||
personaSlug: persona.slug,
|
personaSlug: persona.slug,
|
||||||
@@ -121,7 +128,13 @@ export function generateBoardTasks(
|
|||||||
timeoutSeconds: 120,
|
timeoutSeconds: 120,
|
||||||
dependsOn: personaTaskIds,
|
dependsOn: personaTaskIds,
|
||||||
dependsOnPolicy: 'all_terminal',
|
dependsOnPolicy: 'all_terminal',
|
||||||
qualityGates: ['true'],
|
qualityGates: [
|
||||||
|
{
|
||||||
|
kind: 'authority',
|
||||||
|
capability: 'board-approval',
|
||||||
|
reason: 'board synthesis is an authority decision; no mechanical gate exists',
|
||||||
|
},
|
||||||
|
],
|
||||||
metadata: {
|
metadata: {
|
||||||
resultOutputPath: synthesisResult,
|
resultOutputPath: synthesisResult,
|
||||||
inputResultPaths: personaResultPaths,
|
inputResultPaths: personaResultPaths,
|
||||||
|
|||||||
@@ -1,7 +1,11 @@
|
|||||||
|
import fs from 'node:fs';
|
||||||
|
import os from 'node:os';
|
||||||
|
import path from 'node:path';
|
||||||
import { Command } from 'commander';
|
import { Command } from 'commander';
|
||||||
import { describe, expect, it } from 'vitest';
|
import { describe, expect, it, vi, beforeEach, afterEach } from 'vitest';
|
||||||
|
|
||||||
import { registerForgeCommand } from './cli.js';
|
import { registerForgeCommand } from './cli.js';
|
||||||
|
import { loadManifest } from './pipeline-runner.js';
|
||||||
|
|
||||||
describe('registerForgeCommand', () => {
|
describe('registerForgeCommand', () => {
|
||||||
it('registers a "forge" command on the parent program', () => {
|
it('registers a "forge" command on the parent program', () => {
|
||||||
@@ -55,3 +59,94 @@ describe('registerForgeCommand', () => {
|
|||||||
}).not.toThrow();
|
}).not.toThrow();
|
||||||
});
|
});
|
||||||
});
|
});
|
||||||
|
|
||||||
|
describe('forge run fail-closed behavior (SDLC-D-035)', () => {
|
||||||
|
let tmpDir: string;
|
||||||
|
let briefPath: string;
|
||||||
|
let errSpy: ReturnType<typeof vi.spyOn>;
|
||||||
|
let logSpy: ReturnType<typeof vi.spyOn>;
|
||||||
|
let prevExitCode: string | number | null | undefined;
|
||||||
|
|
||||||
|
const parse = (args: string[]) => {
|
||||||
|
const program = new Command();
|
||||||
|
registerForgeCommand(program);
|
||||||
|
return program.parseAsync(['forge', ...args], { from: 'user' });
|
||||||
|
};
|
||||||
|
|
||||||
|
beforeEach(() => {
|
||||||
|
tmpDir = fs.mkdtempSync(path.join(os.tmpdir(), 'forge-cli-failclosed-'));
|
||||||
|
briefPath = path.join(tmpDir, 'brief.md');
|
||||||
|
fs.writeFileSync(briefPath, '# Fix bug\n\nA bugfix for lint cleanup.');
|
||||||
|
errSpy = vi.spyOn(console, 'error').mockImplementation(() => {});
|
||||||
|
logSpy = vi.spyOn(console, 'log').mockImplementation(() => {});
|
||||||
|
prevExitCode = process.exitCode;
|
||||||
|
});
|
||||||
|
|
||||||
|
afterEach(() => {
|
||||||
|
errSpy.mockRestore();
|
||||||
|
logSpy.mockRestore();
|
||||||
|
process.exitCode = prevExitCode;
|
||||||
|
fs.rmSync(tmpDir, { recursive: true, force: true });
|
||||||
|
});
|
||||||
|
|
||||||
|
it('exits nonzero with a typed FORGE_NO_EXECUTOR error when no executor is wired and --simulate is absent', async () => {
|
||||||
|
await parse(['run', '--brief', briefPath, '--codebase', tmpDir]);
|
||||||
|
|
||||||
|
expect(process.exitCode).toBe(1);
|
||||||
|
const errText = errSpy.mock.calls.map((c) => c.join(' ')).join('\n');
|
||||||
|
expect(errText).toContain('FORGE_NO_EXECUTOR');
|
||||||
|
// It must never run the pipeline with a stub and report success.
|
||||||
|
expect(fs.existsSync(path.join(tmpDir, '.forge', 'runs'))).toBe(false);
|
||||||
|
});
|
||||||
|
|
||||||
|
it('completes with typed simulated results and exit 0 under explicit --simulate', async () => {
|
||||||
|
await parse(['run', '--brief', briefPath, '--codebase', tmpDir, '--simulate']);
|
||||||
|
|
||||||
|
expect(process.exitCode).toBeUndefined();
|
||||||
|
|
||||||
|
// Loud simulated-mode summary.
|
||||||
|
const logText = logSpy.mock.calls.map((c) => c.join(' ')).join('\n');
|
||||||
|
expect(logText).toContain('SIMULATED');
|
||||||
|
|
||||||
|
// Manifest records the mode and simulated per-result statuses.
|
||||||
|
const runsDir = path.join(tmpDir, '.forge', 'runs');
|
||||||
|
const runIds = fs.readdirSync(runsDir);
|
||||||
|
expect(runIds).toHaveLength(1);
|
||||||
|
const manifest = loadManifest(path.join(runsDir, runIds[0]!));
|
||||||
|
expect(manifest.mode).toBe('simulated');
|
||||||
|
expect(manifest.status).toBe('simulated');
|
||||||
|
for (const stageStatus of Object.values(manifest.stages)) {
|
||||||
|
expect(stageStatus?.status).toBe('simulated');
|
||||||
|
for (const gateResult of stageStatus?.gateResults ?? []) {
|
||||||
|
expect(gateResult.outcome).toBe('simulated');
|
||||||
|
}
|
||||||
|
}
|
||||||
|
});
|
||||||
|
|
||||||
|
it('resume exits nonzero with a typed FORGE_NO_EXECUTOR error without --simulate', async () => {
|
||||||
|
const runDir = path.join(tmpDir, '.forge', 'runs', '20260101-000000');
|
||||||
|
fs.mkdirSync(runDir, { recursive: true });
|
||||||
|
fs.writeFileSync(
|
||||||
|
path.join(runDir, 'manifest.json'),
|
||||||
|
JSON.stringify({
|
||||||
|
runId: '20260101-000000',
|
||||||
|
brief: briefPath,
|
||||||
|
codebase: tmpDir,
|
||||||
|
briefClass: 'hotfix',
|
||||||
|
classSource: 'frontmatter',
|
||||||
|
forceBoard: false,
|
||||||
|
createdAt: '2026-01-01T00:00:00Z',
|
||||||
|
updatedAt: '2026-01-01T00:00:00Z',
|
||||||
|
currentStage: '00-intake',
|
||||||
|
status: 'in_progress',
|
||||||
|
stages: { '00-intake': { status: 'passed' } },
|
||||||
|
}),
|
||||||
|
);
|
||||||
|
|
||||||
|
await parse(['resume', '20260101-000000', '--project', tmpDir]);
|
||||||
|
|
||||||
|
expect(process.exitCode).toBe(1);
|
||||||
|
const errText = errSpy.mock.calls.map((c) => c.join(' ')).join('\n');
|
||||||
|
expect(errText).toContain('FORGE_NO_EXECUTOR');
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|||||||
+121
-47
@@ -5,37 +5,47 @@ import type { Command } from 'commander';
|
|||||||
|
|
||||||
import { classifyBrief } from './brief-classifier.js';
|
import { classifyBrief } from './brief-classifier.js';
|
||||||
import { STAGE_LABELS, STAGE_SEQUENCE } from './constants.js';
|
import { STAGE_LABELS, STAGE_SEQUENCE } from './constants.js';
|
||||||
|
import { ForgeCapabilityError } from './errors.js';
|
||||||
import { getEffectivePersonas, loadBoardPersonas } from './persona-loader.js';
|
import { getEffectivePersonas, loadBoardPersonas } from './persona-loader.js';
|
||||||
import { generateRunId, getPipelineStatus, loadManifest, runPipeline } from './pipeline-runner.js';
|
import { generateRunId, getPipelineStatus, loadManifest, runPipeline } from './pipeline-runner.js';
|
||||||
import type { PipelineOptions, RunManifest, TaskExecutor } from './types.js';
|
import { createSimulatedExecutor } from './simulated-executor.js';
|
||||||
|
import type { PipelineOptions, RunManifest, RunMode } from './types.js';
|
||||||
// ---------------------------------------------------------------------------
|
|
||||||
// Stub executor — used when no real executor is wired at CLI invocation time.
|
|
||||||
// ---------------------------------------------------------------------------
|
|
||||||
|
|
||||||
const stubExecutor: TaskExecutor = {
|
|
||||||
async submitTask(task) {
|
|
||||||
console.log(` [forge] stage submitted: ${task.id} (${task.title})`);
|
|
||||||
},
|
|
||||||
async waitForCompletion(taskId, _timeoutMs) {
|
|
||||||
console.log(` [forge] stage complete: ${taskId}`);
|
|
||||||
return {
|
|
||||||
task_id: taskId,
|
|
||||||
status: 'completed' as const,
|
|
||||||
completed_at: new Date().toISOString(),
|
|
||||||
exit_code: 0,
|
|
||||||
gate_results: [],
|
|
||||||
};
|
|
||||||
},
|
|
||||||
async getTaskStatus(_taskId) {
|
|
||||||
return 'completed' as const;
|
|
||||||
},
|
|
||||||
};
|
|
||||||
|
|
||||||
// ---------------------------------------------------------------------------
|
// ---------------------------------------------------------------------------
|
||||||
// Helpers
|
// Helpers
|
||||||
// ---------------------------------------------------------------------------
|
// ---------------------------------------------------------------------------
|
||||||
|
|
||||||
|
/** Resolve a run's effective mode, defaulting legacy manifests to normal. */
|
||||||
|
function runModeOf(manifest: RunManifest): RunMode {
|
||||||
|
return manifest.mode ?? 'normal';
|
||||||
|
}
|
||||||
|
|
||||||
|
/** Print a loud banner so a simulated run can never be misread as verified. */
|
||||||
|
function printSimulatedBanner(): void {
|
||||||
|
console.log('');
|
||||||
|
console.log('[forge] ===============================================================');
|
||||||
|
console.log('[forge] MODE: SIMULATED — no stage or gate was really executed.');
|
||||||
|
console.log('[forge] All results are synthetic and MUST NOT be read as verified');
|
||||||
|
console.log('[forge] success. Wire a real executor/providers and re-run to verify.');
|
||||||
|
console.log('[forge] ===============================================================');
|
||||||
|
}
|
||||||
|
|
||||||
|
/** Print a typed error line for fail-closed capability errors. */
|
||||||
|
function printCapabilityError(err: ForgeCapabilityError): void {
|
||||||
|
console.error(`[forge] error ${err.code}: ${err.message}`);
|
||||||
|
console.error(`[forge] missing capability: ${err.capability}`);
|
||||||
|
}
|
||||||
|
|
||||||
|
/** Handle a pipeline error uniformly: typed capability errors get their code. */
|
||||||
|
function handlePipelineError(err: unknown): void {
|
||||||
|
if (err instanceof ForgeCapabilityError) {
|
||||||
|
printCapabilityError(err);
|
||||||
|
} else {
|
||||||
|
console.error(`[forge] pipeline failed: ${err instanceof Error ? err.message : String(err)}`);
|
||||||
|
}
|
||||||
|
process.exitCode = 1;
|
||||||
|
}
|
||||||
|
|
||||||
function formatDuration(startedAt?: string, completedAt?: string): string {
|
function formatDuration(startedAt?: string, completedAt?: string): string {
|
||||||
if (!startedAt || !completedAt) return '-';
|
if (!startedAt || !completedAt) return '-';
|
||||||
const ms = new Date(completedAt).getTime() - new Date(startedAt).getTime();
|
const ms = new Date(completedAt).getTime() - new Date(startedAt).getTime();
|
||||||
@@ -44,19 +54,24 @@ function formatDuration(startedAt?: string, completedAt?: string): string {
|
|||||||
}
|
}
|
||||||
|
|
||||||
function printManifestTable(manifest: RunManifest): void {
|
function printManifestTable(manifest: RunManifest): void {
|
||||||
|
const mode = runModeOf(manifest);
|
||||||
console.log(`\nRun ID : ${manifest.runId}`);
|
console.log(`\nRun ID : ${manifest.runId}`);
|
||||||
console.log(`Status : ${manifest.status}`);
|
console.log(`Status : ${manifest.status}`);
|
||||||
|
console.log(`Mode : ${mode}`);
|
||||||
|
if (mode === 'simulated') {
|
||||||
|
console.log('WARNING: SIMULATED RUN — results are synthetic, not verified success.');
|
||||||
|
}
|
||||||
console.log(`Brief : ${manifest.brief}`);
|
console.log(`Brief : ${manifest.brief}`);
|
||||||
console.log(`Class : ${manifest.briefClass} (${manifest.classSource})`);
|
console.log(`Class : ${manifest.briefClass} (${manifest.classSource})`);
|
||||||
console.log(`Updated: ${manifest.updatedAt}`);
|
console.log(`Updated: ${manifest.updatedAt}`);
|
||||||
console.log('');
|
console.log('');
|
||||||
console.log('Stage'.padEnd(22) + 'Status'.padEnd(14) + 'Duration');
|
console.log('Stage'.padEnd(22) + 'Status'.padEnd(24) + 'Duration');
|
||||||
console.log('-'.repeat(50));
|
console.log('-'.repeat(60));
|
||||||
for (const stage of STAGE_SEQUENCE) {
|
for (const stage of STAGE_SEQUENCE) {
|
||||||
const s = manifest.stages[stage];
|
const s = manifest.stages[stage];
|
||||||
if (!s) continue;
|
if (!s) continue;
|
||||||
const label = (STAGE_LABELS[stage] ?? stage).padEnd(22);
|
const label = (STAGE_LABELS[stage] ?? stage).padEnd(22);
|
||||||
const status = s.status.padEnd(14);
|
const status = s.status.padEnd(24);
|
||||||
const dur = formatDuration(s.startedAt, s.completedAt);
|
const dur = formatDuration(s.startedAt, s.completedAt);
|
||||||
console.log(`${label}${status}${dur}`);
|
console.log(`${label}${status}${dur}`);
|
||||||
}
|
}
|
||||||
@@ -90,23 +105,58 @@ function listRecentRuns(projectRoot?: string): void {
|
|||||||
}
|
}
|
||||||
|
|
||||||
console.log('\nRecent runs:');
|
console.log('\nRecent runs:');
|
||||||
console.log('Run ID'.padEnd(22) + 'Status'.padEnd(14) + 'Brief');
|
console.log('Run ID'.padEnd(22) + 'Status'.padEnd(24) + 'Mode'.padEnd(12) + 'Brief');
|
||||||
console.log('-'.repeat(70));
|
console.log('-'.repeat(80));
|
||||||
|
|
||||||
for (const runId of entries) {
|
for (const runId of entries) {
|
||||||
const runDir = path.join(runsDir, runId);
|
const runDir = path.join(runsDir, runId);
|
||||||
try {
|
try {
|
||||||
const manifest = loadManifest(runDir);
|
const manifest = loadManifest(runDir);
|
||||||
const status = manifest.status.padEnd(14);
|
const status = manifest.status.padEnd(24);
|
||||||
|
const mode = runModeOf(manifest).padEnd(12);
|
||||||
const brief = path.basename(manifest.brief);
|
const brief = path.basename(manifest.brief);
|
||||||
console.log(`${runId.padEnd(22)}${status}${brief}`);
|
console.log(`${runId.padEnd(22)}${status}${mode}${brief}`);
|
||||||
} catch {
|
} catch {
|
||||||
console.log(`${runId.padEnd(22)}${'(unreadable)'.padEnd(14)}`);
|
console.log(`${runId.padEnd(22)}${'(unreadable)'.padEnd(24)}`);
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
console.log('');
|
console.log('');
|
||||||
}
|
}
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Apply the exit-code policy for a finished pipeline run (SDLC-D-035):
|
||||||
|
*
|
||||||
|
* - exit 0 only for a verified `completed` normal run, or for an overall
|
||||||
|
* `simulated` run when the caller explicitly passed --simulate;
|
||||||
|
* - anything else exits nonzero so it can never be read as success.
|
||||||
|
*/
|
||||||
|
function applyRunExitPolicy(result: { manifest: RunManifest; runDir: string }, simulate: boolean) {
|
||||||
|
const { manifest } = result;
|
||||||
|
|
||||||
|
if (runModeOf(manifest) === 'simulated') {
|
||||||
|
if (!simulate || manifest.status !== 'simulated') {
|
||||||
|
console.error(
|
||||||
|
'[forge] error FORGE_MODE_MISMATCH: run reports simulated results without an explicit, ' +
|
||||||
|
'consistent --simulate request; refusing to report success.',
|
||||||
|
);
|
||||||
|
process.exitCode = 1;
|
||||||
|
return;
|
||||||
|
}
|
||||||
|
printSimulatedBanner();
|
||||||
|
console.log(`[forge] run directory: ${result.runDir}`);
|
||||||
|
return; // exit 0 — the caller explicitly opted into simulation
|
||||||
|
}
|
||||||
|
|
||||||
|
if (manifest.status !== 'completed') {
|
||||||
|
console.error(`[forge] run did not complete: terminal status '${manifest.status}'`);
|
||||||
|
process.exitCode = 1;
|
||||||
|
return;
|
||||||
|
}
|
||||||
|
|
||||||
|
console.log(`[forge] pipeline complete (mode: normal): ${manifest.runId}`);
|
||||||
|
console.log(`[forge] run directory: ${result.runDir}`);
|
||||||
|
}
|
||||||
|
|
||||||
// ---------------------------------------------------------------------------
|
// ---------------------------------------------------------------------------
|
||||||
// Register function
|
// Register function
|
||||||
// ---------------------------------------------------------------------------
|
// ---------------------------------------------------------------------------
|
||||||
@@ -129,6 +179,11 @@ export function registerForgeCommand(parent: Command): void {
|
|||||||
.option('--config <path>', 'Path to forge config file (.forge/config.yaml)')
|
.option('--config <path>', 'Path to forge config file (.forge/config.yaml)')
|
||||||
.option('--codebase <path>', 'Codebase root to pass to the pipeline', process.cwd())
|
.option('--codebase <path>', 'Codebase root to pass to the pipeline', process.cwd())
|
||||||
.option('--dry-run', 'Print planned stages without executing', false)
|
.option('--dry-run', 'Print planned stages without executing', false)
|
||||||
|
.option(
|
||||||
|
'--simulate',
|
||||||
|
'Simulate execution without real providers (every result is typed simulated, never verified)',
|
||||||
|
false,
|
||||||
|
)
|
||||||
.action(
|
.action(
|
||||||
async (opts: {
|
async (opts: {
|
||||||
brief: string;
|
brief: string;
|
||||||
@@ -137,6 +192,7 @@ export function registerForgeCommand(parent: Command): void {
|
|||||||
config?: string;
|
config?: string;
|
||||||
codebase: string;
|
codebase: string;
|
||||||
dryRun: boolean;
|
dryRun: boolean;
|
||||||
|
simulate: boolean;
|
||||||
}) => {
|
}) => {
|
||||||
const briefPath = path.resolve(opts.brief);
|
const briefPath = path.resolve(opts.brief);
|
||||||
|
|
||||||
@@ -149,14 +205,22 @@ export function registerForgeCommand(parent: Command): void {
|
|||||||
const briefContent = fs.readFileSync(briefPath, 'utf-8');
|
const briefContent = fs.readFileSync(briefPath, 'utf-8');
|
||||||
const briefClass = classifyBrief(briefContent);
|
const briefClass = classifyBrief(briefContent);
|
||||||
const projectRoot = opts.codebase;
|
const projectRoot = opts.codebase;
|
||||||
|
// A real executor is never wired at CLI invocation time today, so the
|
||||||
|
// only executor we may construct is the explicitly-requested simulated
|
||||||
|
// one. Normal mode fails closed with FORGE_NO_EXECUTOR.
|
||||||
|
const executor = opts.simulate ? createSimulatedExecutor() : undefined;
|
||||||
|
|
||||||
if (opts.resume) {
|
if (opts.resume) {
|
||||||
const runId = opts.runId ?? generateRunId();
|
const runId = opts.runId ?? generateRunId();
|
||||||
const runDir = resolveRunDir(runId, projectRoot);
|
const runDir = resolveRunDir(runId, projectRoot);
|
||||||
console.log(`[forge] resuming run: ${runId}`);
|
console.log(`[forge] resuming run: ${runId}`);
|
||||||
|
try {
|
||||||
const { resumePipeline } = await import('./pipeline-runner.js');
|
const { resumePipeline } = await import('./pipeline-runner.js');
|
||||||
const result = await resumePipeline(runDir, stubExecutor);
|
const result = await resumePipeline(runDir, executor, { simulate: opts.simulate });
|
||||||
console.log(`[forge] pipeline complete: ${result.runId}`);
|
applyRunExitPolicy(result, opts.simulate);
|
||||||
|
} catch (err) {
|
||||||
|
handlePipelineError(err);
|
||||||
|
}
|
||||||
return;
|
return;
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -164,7 +228,8 @@ export function registerForgeCommand(parent: Command): void {
|
|||||||
briefClass,
|
briefClass,
|
||||||
codebase: projectRoot,
|
codebase: projectRoot,
|
||||||
dryRun: opts.dryRun,
|
dryRun: opts.dryRun,
|
||||||
executor: stubExecutor,
|
executor,
|
||||||
|
simulate: opts.simulate,
|
||||||
};
|
};
|
||||||
|
|
||||||
if (opts.dryRun) {
|
if (opts.dryRun) {
|
||||||
@@ -180,16 +245,15 @@ export function registerForgeCommand(parent: Command): void {
|
|||||||
|
|
||||||
console.log(`[forge] starting pipeline for brief: ${briefPath}`);
|
console.log(`[forge] starting pipeline for brief: ${briefPath}`);
|
||||||
console.log(`[forge] classified as: ${briefClass}`);
|
console.log(`[forge] classified as: ${briefClass}`);
|
||||||
|
if (opts.simulate) {
|
||||||
|
console.log('[forge] mode: SIMULATED (explicit --simulate)');
|
||||||
|
}
|
||||||
|
|
||||||
try {
|
try {
|
||||||
const result = await runPipeline(briefPath, projectRoot, pipelineOptions);
|
const result = await runPipeline(briefPath, projectRoot, pipelineOptions);
|
||||||
console.log(`[forge] pipeline complete: ${result.runId}`);
|
applyRunExitPolicy(result, opts.simulate);
|
||||||
console.log(`[forge] run directory: ${result.runDir}`);
|
|
||||||
} catch (err) {
|
} catch (err) {
|
||||||
console.error(
|
handlePipelineError(err);
|
||||||
`[forge] pipeline failed: ${err instanceof Error ? err.message : String(err)}`,
|
|
||||||
);
|
|
||||||
process.exitCode = 1;
|
|
||||||
}
|
}
|
||||||
},
|
},
|
||||||
);
|
);
|
||||||
@@ -224,7 +288,12 @@ export function registerForgeCommand(parent: Command): void {
|
|||||||
.command('resume <runId>')
|
.command('resume <runId>')
|
||||||
.description('Resume a stopped or failed pipeline run')
|
.description('Resume a stopped or failed pipeline run')
|
||||||
.option('--project <path>', 'Project root (defaults to cwd)', process.cwd())
|
.option('--project <path>', 'Project root (defaults to cwd)', process.cwd())
|
||||||
.action(async (runId: string, opts: { project: string }) => {
|
.option(
|
||||||
|
'--simulate',
|
||||||
|
'Simulate execution without real providers (every result is typed simulated, never verified)',
|
||||||
|
false,
|
||||||
|
)
|
||||||
|
.action(async (runId: string, opts: { project: string; simulate: boolean }) => {
|
||||||
const runDir = resolveRunDir(runId, opts.project);
|
const runDir = resolveRunDir(runId, opts.project);
|
||||||
|
|
||||||
if (!fs.existsSync(runDir)) {
|
if (!fs.existsSync(runDir)) {
|
||||||
@@ -234,15 +303,20 @@ export function registerForgeCommand(parent: Command): void {
|
|||||||
}
|
}
|
||||||
|
|
||||||
console.log(`[forge] resuming run: ${runId}`);
|
console.log(`[forge] resuming run: ${runId}`);
|
||||||
|
if (opts.simulate) {
|
||||||
|
console.log('[forge] mode: SIMULATED (explicit --simulate)');
|
||||||
|
}
|
||||||
|
|
||||||
|
// No real executor is wired at CLI invocation time; only the explicitly
|
||||||
|
// requested simulated executor may be constructed (fail closed otherwise).
|
||||||
|
const executor = opts.simulate ? createSimulatedExecutor() : undefined;
|
||||||
|
|
||||||
try {
|
try {
|
||||||
const { resumePipeline } = await import('./pipeline-runner.js');
|
const { resumePipeline } = await import('./pipeline-runner.js');
|
||||||
const result = await resumePipeline(runDir, stubExecutor);
|
const result = await resumePipeline(runDir, executor, { simulate: opts.simulate });
|
||||||
console.log(`[forge] pipeline complete: ${result.runId}`);
|
applyRunExitPolicy(result, opts.simulate);
|
||||||
console.log(`[forge] run directory: ${result.runDir}`);
|
|
||||||
} catch (err) {
|
} catch (err) {
|
||||||
console.error(`[forge] resume failed: ${err instanceof Error ? err.message : String(err)}`);
|
handlePipelineError(err);
|
||||||
process.exitCode = 1;
|
|
||||||
}
|
}
|
||||||
});
|
});
|
||||||
|
|
||||||
|
|||||||
@@ -9,7 +9,16 @@ export const PACKAGE_ROOT = path.resolve(path.dirname(fileURLToPath(import.meta.
|
|||||||
/** Pipeline asset directory (stages, agents, rails, gates, templates). */
|
/** Pipeline asset directory (stages, agents, rails, gates, templates). */
|
||||||
export const PIPELINE_DIR = path.join(PACKAGE_ROOT, 'pipeline');
|
export const PIPELINE_DIR = path.join(PACKAGE_ROOT, 'pipeline');
|
||||||
|
|
||||||
/** Stage specifications — defines every pipeline stage. */
|
/** Stage specifications — defines every pipeline stage.
|
||||||
|
*\n * Gate semantics (SDLC-D-035): every gate is one of
|
||||||
|
* - a real command string / GateEntry a mechanical runner can execute,
|
||||||
|
* - an `authority` gate (human/board sign-off; produces waiting-for-authority),
|
||||||
|
* - a `provider` gate (requires a wired provider such as a reviewer or CI pipeline).
|
||||||
|
*
|
||||||
|
* Vacuous gates (`true`, echo'd synthetic approvals, placeholder ci-pipeline
|
||||||
|
* commands) are forbidden: a stage whose gate has no real implementation
|
||||||
|
* fails closed instead of passing.
|
||||||
|
*/
|
||||||
export const STAGE_SPECS: Record<string, StageSpec> = {
|
export const STAGE_SPECS: Record<string, StageSpec> = {
|
||||||
'00-intake': {
|
'00-intake': {
|
||||||
number: '00',
|
number: '00',
|
||||||
@@ -27,7 +36,13 @@ export const STAGE_SPECS: Record<string, StageSpec> = {
|
|||||||
type: 'research',
|
type: 'research',
|
||||||
gate: 'discovery-complete',
|
gate: 'discovery-complete',
|
||||||
promptFile: '00b-discovery.md',
|
promptFile: '00b-discovery.md',
|
||||||
qualityGates: ['true'],
|
qualityGates: [
|
||||||
|
{
|
||||||
|
kind: 'authority',
|
||||||
|
capability: 'discovery-complete',
|
||||||
|
reason: 'discovery completion is attested by an authority; no mechanical check exists',
|
||||||
|
},
|
||||||
|
],
|
||||||
},
|
},
|
||||||
'01-board': {
|
'01-board': {
|
||||||
number: '01',
|
number: '01',
|
||||||
@@ -36,7 +51,13 @@ export const STAGE_SPECS: Record<string, StageSpec> = {
|
|||||||
type: 'review',
|
type: 'review',
|
||||||
gate: 'board-approval',
|
gate: 'board-approval',
|
||||||
promptFile: '01-board.md',
|
promptFile: '01-board.md',
|
||||||
qualityGates: [{ type: 'ci-pipeline', command: 'board-approval (via board-tasks)' }],
|
qualityGates: [
|
||||||
|
{
|
||||||
|
kind: 'authority',
|
||||||
|
capability: 'board-approval',
|
||||||
|
reason: 'board approval is a board/human decision; no mechanical gate exists',
|
||||||
|
},
|
||||||
|
],
|
||||||
},
|
},
|
||||||
'01b-brief-analyzer': {
|
'01b-brief-analyzer': {
|
||||||
number: '01b',
|
number: '01b',
|
||||||
@@ -45,7 +66,13 @@ export const STAGE_SPECS: Record<string, StageSpec> = {
|
|||||||
type: 'research',
|
type: 'research',
|
||||||
gate: 'brief-analysis-complete',
|
gate: 'brief-analysis-complete',
|
||||||
promptFile: '01-board.md',
|
promptFile: '01-board.md',
|
||||||
qualityGates: ['true'],
|
qualityGates: [
|
||||||
|
{
|
||||||
|
kind: 'authority',
|
||||||
|
capability: 'brief-analysis-complete',
|
||||||
|
reason: 'brief analysis completion is attested by an authority; no mechanical check exists',
|
||||||
|
},
|
||||||
|
],
|
||||||
},
|
},
|
||||||
'02-planning-1': {
|
'02-planning-1': {
|
||||||
number: '02',
|
number: '02',
|
||||||
@@ -54,7 +81,13 @@ export const STAGE_SPECS: Record<string, StageSpec> = {
|
|||||||
type: 'research',
|
type: 'research',
|
||||||
gate: 'architecture-approval',
|
gate: 'architecture-approval',
|
||||||
promptFile: '02-planning-1-architecture.md',
|
promptFile: '02-planning-1-architecture.md',
|
||||||
qualityGates: ['true'],
|
qualityGates: [
|
||||||
|
{
|
||||||
|
kind: 'authority',
|
||||||
|
capability: 'architecture-approval',
|
||||||
|
reason: 'ADR approval requires authority sign-off; no mechanical check exists',
|
||||||
|
},
|
||||||
|
],
|
||||||
},
|
},
|
||||||
'03-planning-2': {
|
'03-planning-2': {
|
||||||
number: '03',
|
number: '03',
|
||||||
@@ -63,7 +96,14 @@ export const STAGE_SPECS: Record<string, StageSpec> = {
|
|||||||
type: 'research',
|
type: 'research',
|
||||||
gate: 'implementation-approval',
|
gate: 'implementation-approval',
|
||||||
promptFile: '03-planning-2-implementation.md',
|
promptFile: '03-planning-2-implementation.md',
|
||||||
qualityGates: ['true'],
|
qualityGates: [
|
||||||
|
{
|
||||||
|
kind: 'authority',
|
||||||
|
capability: 'implementation-approval',
|
||||||
|
reason:
|
||||||
|
'implementation spec approval requires authority sign-off; no mechanical check exists',
|
||||||
|
},
|
||||||
|
],
|
||||||
},
|
},
|
||||||
'04-planning-3': {
|
'04-planning-3': {
|
||||||
number: '04',
|
number: '04',
|
||||||
@@ -72,7 +112,14 @@ export const STAGE_SPECS: Record<string, StageSpec> = {
|
|||||||
type: 'research',
|
type: 'research',
|
||||||
gate: 'decomposition-approval',
|
gate: 'decomposition-approval',
|
||||||
promptFile: '04-planning-3-decomposition.md',
|
promptFile: '04-planning-3-decomposition.md',
|
||||||
qualityGates: ['true'],
|
qualityGates: [
|
||||||
|
{
|
||||||
|
kind: 'authority',
|
||||||
|
capability: 'decomposition-approval',
|
||||||
|
reason:
|
||||||
|
'task decomposition approval requires authority sign-off; no mechanical check exists',
|
||||||
|
},
|
||||||
|
],
|
||||||
},
|
},
|
||||||
'05-coding': {
|
'05-coding': {
|
||||||
number: '05',
|
number: '05',
|
||||||
@@ -92,9 +139,10 @@ export const STAGE_SPECS: Record<string, StageSpec> = {
|
|||||||
promptFile: '06-review.md',
|
promptFile: '06-review.md',
|
||||||
qualityGates: [
|
qualityGates: [
|
||||||
{
|
{
|
||||||
type: 'ai-review',
|
kind: 'provider',
|
||||||
command:
|
capability: 'reviewer',
|
||||||
'echo \'{"summary":"review-pass","verdict":"approve","findings":[],"stats":{"blockers":0,"should_fix":0,"suggestions":0}}\'',
|
reason:
|
||||||
|
'review verdicts require a wired reviewer provider; synthetic approvals are not permitted',
|
||||||
},
|
},
|
||||||
],
|
],
|
||||||
},
|
},
|
||||||
@@ -105,7 +153,13 @@ export const STAGE_SPECS: Record<string, StageSpec> = {
|
|||||||
type: 'coding',
|
type: 'coding',
|
||||||
gate: 're-review',
|
gate: 're-review',
|
||||||
promptFile: '07-remediate.md',
|
promptFile: '07-remediate.md',
|
||||||
qualityGates: ['true'],
|
qualityGates: [
|
||||||
|
{
|
||||||
|
kind: 'authority',
|
||||||
|
capability: 're-review',
|
||||||
|
reason: 'remediation re-review is an approval-based gate; no mechanical check exists',
|
||||||
|
},
|
||||||
|
],
|
||||||
},
|
},
|
||||||
'08-test': {
|
'08-test': {
|
||||||
number: '08',
|
number: '08',
|
||||||
@@ -123,7 +177,13 @@ export const STAGE_SPECS: Record<string, StageSpec> = {
|
|||||||
type: 'deploy',
|
type: 'deploy',
|
||||||
gate: 'deploy-verification',
|
gate: 'deploy-verification',
|
||||||
promptFile: '09-deploy.md',
|
promptFile: '09-deploy.md',
|
||||||
qualityGates: [{ type: 'ci-pipeline', command: 'deploy-verification' }],
|
qualityGates: [
|
||||||
|
{
|
||||||
|
kind: 'provider',
|
||||||
|
capability: 'ci-pipeline',
|
||||||
|
reason: 'deploy verification requires a wired CI pipeline provider',
|
||||||
|
},
|
||||||
|
],
|
||||||
},
|
},
|
||||||
};
|
};
|
||||||
|
|
||||||
|
|||||||
@@ -0,0 +1,46 @@
|
|||||||
|
/**
|
||||||
|
* Typed fail-closed capability errors (SDLC-D-035).
|
||||||
|
*
|
||||||
|
* A Forge run must fail closed when a required capability (executor, reviewer
|
||||||
|
* provider, CI pipeline, authority sign-off) is missing. These typed errors
|
||||||
|
* name the missing capability so callers can distinguish "not wired" from
|
||||||
|
* ordinary execution failures.
|
||||||
|
*/
|
||||||
|
|
||||||
|
/** Closed set of typed Forge capability error codes. */
|
||||||
|
export const FORGE_ERROR_CODES = [
|
||||||
|
'FORGE_NO_EXECUTOR',
|
||||||
|
'FORGE_NO_REVIEWER',
|
||||||
|
'FORGE_NO_CI_PIPELINE',
|
||||||
|
'FORGE_NO_PROVIDER',
|
||||||
|
'FORGE_AUTHORITY_REQUIRED',
|
||||||
|
] as const;
|
||||||
|
|
||||||
|
export type ForgeErrorCode = (typeof FORGE_ERROR_CODES)[number];
|
||||||
|
|
||||||
|
/** Raised when a required capability is missing and the pipeline must fail closed. */
|
||||||
|
export class ForgeCapabilityError extends Error {
|
||||||
|
/** Typed error code from the closed FORGE_ERROR_CODES set. */
|
||||||
|
readonly code: ForgeErrorCode;
|
||||||
|
/** The missing capability, e.g. `task-executor`, `reviewer`, `board-approval`. */
|
||||||
|
readonly capability: string;
|
||||||
|
|
||||||
|
constructor(code: ForgeErrorCode, capability: string, message: string) {
|
||||||
|
super(message);
|
||||||
|
this.name = 'ForgeCapabilityError';
|
||||||
|
this.code = code;
|
||||||
|
this.capability = capability;
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
/** Map a provider gate capability to its typed error code. */
|
||||||
|
export function providerErrorCode(capability: string): ForgeErrorCode {
|
||||||
|
switch (capability) {
|
||||||
|
case 'reviewer':
|
||||||
|
return 'FORGE_NO_REVIEWER';
|
||||||
|
case 'ci-pipeline':
|
||||||
|
return 'FORGE_NO_CI_PIPELINE';
|
||||||
|
default:
|
||||||
|
return 'FORGE_NO_PROVIDER';
|
||||||
|
}
|
||||||
|
}
|
||||||
@@ -5,6 +5,13 @@ export type {
|
|||||||
StageSpec,
|
StageSpec,
|
||||||
BriefClass,
|
BriefClass,
|
||||||
ClassSource,
|
ClassSource,
|
||||||
|
ForgeOutcome,
|
||||||
|
AuthorityGate,
|
||||||
|
ProviderGate,
|
||||||
|
ForgeGate,
|
||||||
|
ForgeGateResult,
|
||||||
|
ForgeTaskResult,
|
||||||
|
RunMode,
|
||||||
StageStatus,
|
StageStatus,
|
||||||
RunManifest,
|
RunManifest,
|
||||||
ForgeTaskStatus,
|
ForgeTaskStatus,
|
||||||
@@ -81,5 +88,24 @@ export {
|
|||||||
getPipelineStatus,
|
getPipelineStatus,
|
||||||
} from './pipeline-runner.js';
|
} from './pipeline-runner.js';
|
||||||
|
|
||||||
|
// Fail-closed errors and typed outcome model (SDLC-D-035)
|
||||||
|
export { FORGE_ERROR_CODES, ForgeCapabilityError, providerErrorCode } from './errors.js';
|
||||||
|
export type { ForgeErrorCode } from './errors.js';
|
||||||
|
export {
|
||||||
|
isSatisfyingOutcome,
|
||||||
|
isCapabilityGate,
|
||||||
|
isCommandGate,
|
||||||
|
gateLabel,
|
||||||
|
uniformGateResults,
|
||||||
|
simulatedGateResults,
|
||||||
|
waitingGateResults,
|
||||||
|
blockedGateResults,
|
||||||
|
evaluateStageGates,
|
||||||
|
} from './outcomes.js';
|
||||||
|
export type { StageEvaluation } from './outcomes.js';
|
||||||
|
|
||||||
|
// Simulated executor (explicit --simulate only)
|
||||||
|
export { createSimulatedExecutor } from './simulated-executor.js';
|
||||||
|
|
||||||
// CLI
|
// CLI
|
||||||
export { registerForgeCommand } from './cli.js';
|
export { registerForgeCommand } from './cli.js';
|
||||||
|
|||||||
@@ -0,0 +1,147 @@
|
|||||||
|
import type { GateEntry } from '@mosaicstack/macp';
|
||||||
|
|
||||||
|
import type {
|
||||||
|
AuthorityGate,
|
||||||
|
ForgeGate,
|
||||||
|
ForgeGateResult,
|
||||||
|
ForgeOutcome,
|
||||||
|
ForgeTaskResult,
|
||||||
|
ProviderGate,
|
||||||
|
} from './types.js';
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Gate and dependency satisfaction predicate (SDLC-D-035).
|
||||||
|
*
|
||||||
|
* ONLY a verified `passed` outcome satisfies. Every other member of the closed
|
||||||
|
* outcome set — including `simulated` — is non-satisfying, so a simulated or
|
||||||
|
* authority-blocked result can never be read as success-by-verification.
|
||||||
|
*/
|
||||||
|
export function isSatisfyingOutcome(outcome: ForgeOutcome): boolean {
|
||||||
|
return outcome === 'passed';
|
||||||
|
}
|
||||||
|
|
||||||
|
/** Whether a gate is an authority or provider gate (capability-based, command-less). */
|
||||||
|
export function isCapabilityGate(gate: ForgeGate): gate is AuthorityGate | ProviderGate {
|
||||||
|
if (typeof gate !== 'object' || gate === null) return false;
|
||||||
|
const kind = (gate as Record<string, unknown>)['kind'];
|
||||||
|
return kind === 'authority' || kind === 'provider';
|
||||||
|
}
|
||||||
|
|
||||||
|
/** Whether a gate definition carries a real command a mechanical runner can execute. */
|
||||||
|
export function isCommandGate(gate: ForgeGate): gate is string | GateEntry {
|
||||||
|
if (typeof gate === 'string') {
|
||||||
|
return gate.trim().length > 0;
|
||||||
|
}
|
||||||
|
if (isCapabilityGate(gate)) {
|
||||||
|
// Authority and provider gates are satisfied by a capability, not a command.
|
||||||
|
return false;
|
||||||
|
}
|
||||||
|
return typeof gate.command === 'string' && gate.command.trim().length > 0;
|
||||||
|
}
|
||||||
|
|
||||||
|
/** Typed label identifying a gate in results and logs. */
|
||||||
|
export function gateLabel(gate: ForgeGate): string {
|
||||||
|
if (typeof gate === 'string') return gate;
|
||||||
|
if (isCapabilityGate(gate)) return `${gate.kind}:${gate.capability}`;
|
||||||
|
return gate.command || gate.type || 'unnamed-gate';
|
||||||
|
}
|
||||||
|
|
||||||
|
/** Reason string stamped on every simulated gate result. */
|
||||||
|
export const SIMULATED_GATE_REASON =
|
||||||
|
'simulated execution (--simulate): gate was not evaluated by a real implementation';
|
||||||
|
|
||||||
|
/** Build typed gate results with a uniform outcome for a stage's declared gates. */
|
||||||
|
export function uniformGateResults(
|
||||||
|
gates: ForgeGate[],
|
||||||
|
outcome: ForgeOutcome,
|
||||||
|
reason: string,
|
||||||
|
): ForgeGateResult[] {
|
||||||
|
return gates.map((gate) => ({ gate: gateLabel(gate), outcome, reason }));
|
||||||
|
}
|
||||||
|
|
||||||
|
/** Typed simulated gate results — used exclusively in `--simulate` runs. */
|
||||||
|
export function simulatedGateResults(gates: ForgeGate[]): ForgeGateResult[] {
|
||||||
|
return uniformGateResults(gates, 'simulated', SIMULATED_GATE_REASON);
|
||||||
|
}
|
||||||
|
|
||||||
|
/** Typed waiting-for-authority gate results for approval-based stages. */
|
||||||
|
export function waitingGateResults(gates: ForgeGate[], reason: string): ForgeGateResult[] {
|
||||||
|
return uniformGateResults(gates, 'waiting-for-authority', reason);
|
||||||
|
}
|
||||||
|
|
||||||
|
/** Typed blocked gate results for stages whose provider capability is not wired. */
|
||||||
|
export function blockedGateResults(gates: ForgeGate[], reason: string): ForgeGateResult[] {
|
||||||
|
return uniformGateResults(gates, 'blocked', reason);
|
||||||
|
}
|
||||||
|
|
||||||
|
/** Outcome of evaluating a completed stage in normal mode. */
|
||||||
|
export interface StageEvaluation {
|
||||||
|
outcome: ForgeOutcome;
|
||||||
|
reason: string;
|
||||||
|
gateResults: ForgeGateResult[];
|
||||||
|
}
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Evaluate a stage's declared gates against the executor's typed result.
|
||||||
|
*
|
||||||
|
* Fail-closed mapping:
|
||||||
|
* - a `simulated` task or gate outcome in normal mode maps to `error`
|
||||||
|
* - a missing gate result for a required command gate maps to `blocked`
|
||||||
|
* - a non-passing task outcome propagates as the stage outcome
|
||||||
|
* - only verified `passed` task and gate outcomes yield a `passed` stage
|
||||||
|
*/
|
||||||
|
export function evaluateStageGates(
|
||||||
|
stageName: string,
|
||||||
|
gates: ForgeGate[],
|
||||||
|
result: ForgeTaskResult,
|
||||||
|
): StageEvaluation {
|
||||||
|
const gateResults = result.gate_results ?? [];
|
||||||
|
|
||||||
|
if (result.outcome === 'simulated') {
|
||||||
|
return {
|
||||||
|
outcome: 'error',
|
||||||
|
reason: `executor reported a simulated outcome for stage '${stageName}' in normal mode — refusing to treat simulated results as verified`,
|
||||||
|
gateResults,
|
||||||
|
};
|
||||||
|
}
|
||||||
|
|
||||||
|
if (!isSatisfyingOutcome(result.outcome)) {
|
||||||
|
return {
|
||||||
|
outcome: result.outcome,
|
||||||
|
reason: `task outcome is '${result.outcome}': ${result.reason}`,
|
||||||
|
gateResults,
|
||||||
|
};
|
||||||
|
}
|
||||||
|
|
||||||
|
for (const gate of gates) {
|
||||||
|
// Authority and provider gates are pre-flighted before execution; they have
|
||||||
|
// no mechanical result to verify here.
|
||||||
|
if (!isCommandGate(gate)) continue;
|
||||||
|
|
||||||
|
const label = gateLabel(gate);
|
||||||
|
const gateResult = gateResults.find((r) => r.gate === label);
|
||||||
|
if (!gateResult) {
|
||||||
|
return {
|
||||||
|
outcome: 'blocked',
|
||||||
|
reason: `no gate result was reported for required gate '${label}' (stage '${stageName}')`,
|
||||||
|
gateResults,
|
||||||
|
};
|
||||||
|
}
|
||||||
|
if (!isSatisfyingOutcome(gateResult.outcome)) {
|
||||||
|
return {
|
||||||
|
outcome: gateResult.outcome === 'simulated' ? 'error' : gateResult.outcome,
|
||||||
|
reason: `gate '${label}' outcome is '${gateResult.outcome}': ${gateResult.reason}`,
|
||||||
|
gateResults,
|
||||||
|
};
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
return {
|
||||||
|
outcome: 'passed',
|
||||||
|
reason:
|
||||||
|
gates.length === 0
|
||||||
|
? "stage declares no gates; task outcome 'passed' accepted"
|
||||||
|
: 'all declared gates verified passed',
|
||||||
|
gateResults,
|
||||||
|
};
|
||||||
|
}
|
||||||
@@ -1,18 +1,33 @@
|
|||||||
import fs from 'node:fs';
|
import fs from 'node:fs';
|
||||||
import path from 'node:path';
|
import path from 'node:path';
|
||||||
|
|
||||||
import { STAGE_SEQUENCE } from './constants.js';
|
import { STAGE_SEQUENCE, STAGE_SPECS } from './constants.js';
|
||||||
import { determineBriefClass, stagesForClass } from './brief-classifier.js';
|
import { determineBriefClass, stagesForClass } from './brief-classifier.js';
|
||||||
|
import { ForgeCapabilityError, providerErrorCode } from './errors.js';
|
||||||
|
import {
|
||||||
|
blockedGateResults,
|
||||||
|
evaluateStageGates,
|
||||||
|
isCapabilityGate,
|
||||||
|
simulatedGateResults,
|
||||||
|
waitingGateResults,
|
||||||
|
} from './outcomes.js';
|
||||||
import { mapStageToTask } from './stage-adapter.js';
|
import { mapStageToTask } from './stage-adapter.js';
|
||||||
|
import { createSimulatedExecutor } from './simulated-executor.js';
|
||||||
import type {
|
import type {
|
||||||
ForgeTask,
|
ForgeTask,
|
||||||
|
ForgeTaskResult,
|
||||||
PipelineOptions,
|
PipelineOptions,
|
||||||
PipelineResult,
|
PipelineResult,
|
||||||
RunManifest,
|
RunManifest,
|
||||||
|
RunMode,
|
||||||
StageStatus,
|
StageStatus,
|
||||||
TaskExecutor,
|
TaskExecutor,
|
||||||
} from './types.js';
|
} from './types.js';
|
||||||
|
|
||||||
|
/** Reason stamped on stages that complete under explicit simulation. */
|
||||||
|
const SIMULATED_STAGE_REASON =
|
||||||
|
'simulated execution (--simulate): stage was not executed by a real executor';
|
||||||
|
|
||||||
/**
|
/**
|
||||||
* Generate a timestamp-based run ID.
|
* Generate a timestamp-based run ID.
|
||||||
*/
|
*/
|
||||||
@@ -47,6 +62,7 @@ function createManifest(opts: {
|
|||||||
briefClass: RunManifest['briefClass'];
|
briefClass: RunManifest['briefClass'];
|
||||||
classSource: RunManifest['classSource'];
|
classSource: RunManifest['classSource'];
|
||||||
forceBoard: boolean;
|
forceBoard: boolean;
|
||||||
|
mode: RunMode;
|
||||||
runDir: string;
|
runDir: string;
|
||||||
}): RunManifest {
|
}): RunManifest {
|
||||||
const ts = nowISO();
|
const ts = nowISO();
|
||||||
@@ -57,6 +73,7 @@ function createManifest(opts: {
|
|||||||
briefClass: opts.briefClass,
|
briefClass: opts.briefClass,
|
||||||
classSource: opts.classSource,
|
classSource: opts.classSource,
|
||||||
forceBoard: opts.forceBoard,
|
forceBoard: opts.forceBoard,
|
||||||
|
mode: opts.mode,
|
||||||
createdAt: ts,
|
createdAt: ts,
|
||||||
updatedAt: ts,
|
updatedAt: ts,
|
||||||
currentStage: '',
|
currentStage: '',
|
||||||
@@ -108,20 +125,199 @@ export function selectStages(stages?: string[], skipTo?: string): string[] {
|
|||||||
return selected.slice(skipIndex);
|
return selected.slice(skipIndex);
|
||||||
}
|
}
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Fail closed when the required executor capability is missing (SDLC-D-035).
|
||||||
|
*/
|
||||||
|
function requireExecutor(executor: TaskExecutor | undefined, simulate: boolean): TaskExecutor {
|
||||||
|
if (executor) return executor;
|
||||||
|
if (simulate) return createSimulatedExecutor({ log: false });
|
||||||
|
throw new ForgeCapabilityError(
|
||||||
|
'FORGE_NO_EXECUTOR',
|
||||||
|
'task-executor',
|
||||||
|
'no task executor is wired; refusing to run the pipeline with a stub executor (fail closed). ' +
|
||||||
|
'Pass --simulate to opt into explicitly simulated execution.',
|
||||||
|
);
|
||||||
|
}
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Pre-flight a stage's gates in normal mode (fail closed, SDLC-D-035).
|
||||||
|
*
|
||||||
|
* - authority gates: record a typed `waiting-for-authority` stage result and
|
||||||
|
* raise FORGE_AUTHORITY_REQUIRED — approval-based gates never pass vacuously.
|
||||||
|
* - provider gates: record a typed `blocked` stage result and raise the typed
|
||||||
|
* capability error for the missing provider.
|
||||||
|
*
|
||||||
|
* Returns the stage status to record when the pre-flight blocks, or undefined
|
||||||
|
* when the stage may proceed.
|
||||||
|
*/
|
||||||
|
function preflightStageGates(
|
||||||
|
stageName: string,
|
||||||
|
manifest: RunManifest,
|
||||||
|
): { status: StageStatus; error: ForgeCapabilityError } | undefined {
|
||||||
|
const spec = STAGE_SPECS[stageName];
|
||||||
|
if (!spec) throw new Error(`Unknown Forge stage: ${stageName}`);
|
||||||
|
|
||||||
|
for (const gate of spec.qualityGates) {
|
||||||
|
if (!isCapabilityGate(gate)) continue;
|
||||||
|
|
||||||
|
const startedAt = manifest.stages[stageName]?.startedAt;
|
||||||
|
const completedAt = nowISO();
|
||||||
|
|
||||||
|
if (gate.kind === 'authority') {
|
||||||
|
const reason = `gate '${gate.capability}' requires authority sign-off; no mechanical implementation exists (${gate.reason})`;
|
||||||
|
return {
|
||||||
|
status: {
|
||||||
|
status: 'waiting-for-authority',
|
||||||
|
reason,
|
||||||
|
startedAt,
|
||||||
|
completedAt,
|
||||||
|
gateResults: waitingGateResults(spec.qualityGates, reason),
|
||||||
|
},
|
||||||
|
error: new ForgeCapabilityError(
|
||||||
|
'FORGE_AUTHORITY_REQUIRED',
|
||||||
|
gate.capability,
|
||||||
|
`stage '${stageName}' is blocked on authority gate '${gate.capability}': ${gate.reason}. ` +
|
||||||
|
'The pipeline fails closed instead of passing vacuously. Record the approval out-of-band ' +
|
||||||
|
'or run with --simulate for explicitly simulated execution.',
|
||||||
|
),
|
||||||
|
};
|
||||||
|
}
|
||||||
|
|
||||||
|
const reason = `gate '${gate.capability}' requires provider '${gate.capability}' and none is wired (${gate.reason})`;
|
||||||
|
return {
|
||||||
|
status: {
|
||||||
|
status: 'blocked',
|
||||||
|
reason,
|
||||||
|
startedAt,
|
||||||
|
completedAt,
|
||||||
|
gateResults: blockedGateResults(spec.qualityGates, reason),
|
||||||
|
},
|
||||||
|
error: new ForgeCapabilityError(
|
||||||
|
providerErrorCode(gate.capability),
|
||||||
|
gate.capability,
|
||||||
|
`stage '${stageName}' requires provider '${gate.capability}' which is not wired: ${gate.reason}. ` +
|
||||||
|
'The pipeline fails closed instead of passing vacuously.',
|
||||||
|
),
|
||||||
|
};
|
||||||
|
}
|
||||||
|
|
||||||
|
return undefined;
|
||||||
|
}
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Execute the given stage tasks sequentially, updating the manifest.
|
||||||
|
*
|
||||||
|
* Normal mode requires a real executor and evaluates every declared command
|
||||||
|
* gate through the typed outcome model; any non-verified result fails closed.
|
||||||
|
* Simulate mode types every stage and gate result as `simulated`.
|
||||||
|
*/
|
||||||
|
async function executeStages(opts: {
|
||||||
|
manifest: RunManifest;
|
||||||
|
runDir: string;
|
||||||
|
tasks: ForgeTask[];
|
||||||
|
stageNames: string[];
|
||||||
|
executor: TaskExecutor;
|
||||||
|
simulate: boolean;
|
||||||
|
}): Promise<void> {
|
||||||
|
const { manifest, runDir, tasks, stageNames, executor, simulate } = opts;
|
||||||
|
|
||||||
|
for (let i = 0; i < tasks.length; i++) {
|
||||||
|
const task = tasks[i]!;
|
||||||
|
const stageName = stageNames[i]!;
|
||||||
|
const spec = STAGE_SPECS[stageName];
|
||||||
|
if (!spec) throw new Error(`Unknown Forge stage: ${stageName}`);
|
||||||
|
|
||||||
|
// Update manifest: stage in progress
|
||||||
|
manifest.currentStage = stageName;
|
||||||
|
manifest.stages[stageName] = {
|
||||||
|
status: 'in_progress',
|
||||||
|
startedAt: nowISO(),
|
||||||
|
};
|
||||||
|
saveManifest(runDir, manifest);
|
||||||
|
|
||||||
|
// Fail-closed pre-flight (normal mode only): authority/provider gates have
|
||||||
|
// no mechanical implementation and must never pass vacuously.
|
||||||
|
if (!simulate) {
|
||||||
|
const blocked = preflightStageGates(stageName, manifest);
|
||||||
|
if (blocked) {
|
||||||
|
manifest.stages[stageName] = blocked.status;
|
||||||
|
manifest.status =
|
||||||
|
blocked.status.status === 'waiting-for-authority' ? 'waiting-for-authority' : 'failed';
|
||||||
|
saveManifest(runDir, manifest);
|
||||||
|
throw blocked.error;
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
let result: ForgeTaskResult;
|
||||||
|
try {
|
||||||
|
await executor.submitTask(task);
|
||||||
|
result = await executor.waitForCompletion(task.id, task.timeoutSeconds * 1000);
|
||||||
|
} catch (error) {
|
||||||
|
// Process errors (including timeouts) map to the fail-closed `error` outcome.
|
||||||
|
const reason = error instanceof Error ? error.message : String(error);
|
||||||
|
manifest.stages[stageName] = {
|
||||||
|
status: 'error',
|
||||||
|
reason: `executor error: ${reason}`,
|
||||||
|
startedAt: manifest.stages[stageName]?.startedAt,
|
||||||
|
completedAt: nowISO(),
|
||||||
|
gateResults: [],
|
||||||
|
};
|
||||||
|
manifest.status = 'failed';
|
||||||
|
saveManifest(runDir, manifest);
|
||||||
|
throw error instanceof Error ? error : new Error(reason);
|
||||||
|
}
|
||||||
|
|
||||||
|
if (simulate) {
|
||||||
|
manifest.stages[stageName] = {
|
||||||
|
status: 'simulated',
|
||||||
|
reason: SIMULATED_STAGE_REASON,
|
||||||
|
startedAt: manifest.stages[stageName]?.startedAt,
|
||||||
|
completedAt: nowISO(),
|
||||||
|
gateResults: simulatedGateResults(spec.qualityGates),
|
||||||
|
};
|
||||||
|
saveManifest(runDir, manifest);
|
||||||
|
continue;
|
||||||
|
}
|
||||||
|
|
||||||
|
const evaluation = evaluateStageGates(stageName, spec.qualityGates, result);
|
||||||
|
manifest.stages[stageName] = {
|
||||||
|
status: evaluation.outcome,
|
||||||
|
reason: evaluation.reason,
|
||||||
|
startedAt: manifest.stages[stageName]?.startedAt,
|
||||||
|
completedAt: nowISO(),
|
||||||
|
gateResults: evaluation.gateResults,
|
||||||
|
};
|
||||||
|
|
||||||
|
if (evaluation.outcome !== 'passed') {
|
||||||
|
manifest.status =
|
||||||
|
evaluation.outcome === 'waiting-for-authority' ? 'waiting-for-authority' : 'failed';
|
||||||
|
saveManifest(runDir, manifest);
|
||||||
|
throw new Error(`Stage ${stageName} ${evaluation.outcome}: ${evaluation.reason}`);
|
||||||
|
}
|
||||||
|
|
||||||
|
saveManifest(runDir, manifest);
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
/**
|
/**
|
||||||
* Run the Forge pipeline.
|
* Run the Forge pipeline.
|
||||||
*
|
*
|
||||||
* 1. Classify the brief
|
* 1. Fail closed unless a real executor is wired or simulation is explicit
|
||||||
* 2. Generate a run ID and create run directory
|
* 2. Classify the brief
|
||||||
* 3. Map stages to tasks and submit to TaskExecutor
|
* 3. Generate a run ID and create run directory
|
||||||
* 4. Track manifest with stage statuses
|
* 4. Map stages to tasks and submit to TaskExecutor
|
||||||
* 5. Return pipeline result
|
* 5. Track manifest with typed stage outcomes
|
||||||
|
* 6. Return pipeline result
|
||||||
*/
|
*/
|
||||||
export async function runPipeline(
|
export async function runPipeline(
|
||||||
briefPath: string,
|
briefPath: string,
|
||||||
projectRoot: string,
|
projectRoot: string,
|
||||||
options: PipelineOptions,
|
options: PipelineOptions,
|
||||||
): Promise<PipelineResult> {
|
): Promise<PipelineResult> {
|
||||||
|
const simulate = options.simulate ?? false;
|
||||||
|
const executor = requireExecutor(options.executor, simulate);
|
||||||
|
const mode: RunMode = simulate ? 'simulated' : 'normal';
|
||||||
|
|
||||||
const resolvedRoot = path.resolve(projectRoot);
|
const resolvedRoot = path.resolve(projectRoot);
|
||||||
const resolvedBrief = path.resolve(briefPath);
|
const resolvedBrief = path.resolve(briefPath);
|
||||||
const briefContent = fs.readFileSync(resolvedBrief, 'utf-8');
|
const briefContent = fs.readFileSync(resolvedBrief, 'utf-8');
|
||||||
@@ -146,6 +342,7 @@ export async function runPipeline(
|
|||||||
briefClass,
|
briefClass,
|
||||||
classSource,
|
classSource,
|
||||||
forceBoard: options.forceBoard ?? false,
|
forceBoard: options.forceBoard ?? false,
|
||||||
|
mode,
|
||||||
runDir,
|
runDir,
|
||||||
});
|
});
|
||||||
|
|
||||||
@@ -172,54 +369,10 @@ export async function runPipeline(
|
|||||||
}
|
}
|
||||||
|
|
||||||
// Execute stages
|
// Execute stages
|
||||||
const { executor } = options;
|
await executeStages({ manifest, runDir, tasks, stageNames: selectedStages, executor, simulate });
|
||||||
for (let i = 0; i < tasks.length; i++) {
|
|
||||||
const task = tasks[i]!;
|
|
||||||
const stageName = selectedStages[i]!;
|
|
||||||
|
|
||||||
// Update manifest: stage in progress
|
// All stages reached a terminal state for this mode
|
||||||
manifest.currentStage = stageName;
|
manifest.status = simulate ? 'simulated' : 'completed';
|
||||||
manifest.stages[stageName] = {
|
|
||||||
status: 'in_progress',
|
|
||||||
startedAt: nowISO(),
|
|
||||||
};
|
|
||||||
saveManifest(runDir, manifest);
|
|
||||||
|
|
||||||
try {
|
|
||||||
await executor.submitTask(task);
|
|
||||||
const result = await executor.waitForCompletion(task.id, task.timeoutSeconds * 1000);
|
|
||||||
|
|
||||||
// Update manifest: stage completed or failed
|
|
||||||
const stageStatus: StageStatus = {
|
|
||||||
status: result.status === 'completed' ? 'passed' : 'failed',
|
|
||||||
startedAt: manifest.stages[stageName]!.startedAt,
|
|
||||||
completedAt: nowISO(),
|
|
||||||
};
|
|
||||||
manifest.stages[stageName] = stageStatus;
|
|
||||||
|
|
||||||
if (result.status !== 'completed') {
|
|
||||||
manifest.status = 'failed';
|
|
||||||
saveManifest(runDir, manifest);
|
|
||||||
throw new Error(`Stage ${stageName} failed with status: ${result.status}`);
|
|
||||||
}
|
|
||||||
|
|
||||||
saveManifest(runDir, manifest);
|
|
||||||
} catch (error) {
|
|
||||||
if (!manifest.stages[stageName]?.completedAt) {
|
|
||||||
manifest.stages[stageName] = {
|
|
||||||
status: 'failed',
|
|
||||||
startedAt: manifest.stages[stageName]?.startedAt,
|
|
||||||
completedAt: nowISO(),
|
|
||||||
};
|
|
||||||
}
|
|
||||||
manifest.status = 'failed';
|
|
||||||
saveManifest(runDir, manifest);
|
|
||||||
throw error;
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
// All stages passed
|
|
||||||
manifest.status = 'completed';
|
|
||||||
saveManifest(runDir, manifest);
|
saveManifest(runDir, manifest);
|
||||||
|
|
||||||
return {
|
return {
|
||||||
@@ -234,22 +387,30 @@ export async function runPipeline(
|
|||||||
}
|
}
|
||||||
|
|
||||||
/**
|
/**
|
||||||
* Resume a pipeline from the last incomplete stage.
|
* Resume a pipeline from the last non-passed stage.
|
||||||
*/
|
*/
|
||||||
export async function resumePipeline(
|
export async function resumePipeline(
|
||||||
runDir: string,
|
runDir: string,
|
||||||
executor: TaskExecutor,
|
executor?: TaskExecutor,
|
||||||
|
options?: { simulate?: boolean },
|
||||||
): Promise<PipelineResult> {
|
): Promise<PipelineResult> {
|
||||||
|
const simulate = options?.simulate ?? false;
|
||||||
|
const wiredExecutor = requireExecutor(executor, simulate);
|
||||||
|
const mode: RunMode = simulate ? 'simulated' : 'normal';
|
||||||
|
|
||||||
const manifest = loadManifest(runDir);
|
const manifest = loadManifest(runDir);
|
||||||
const resolvedRoot = path.dirname(path.dirname(path.dirname(runDir))); // .forge/runs/{id} → project root
|
const resolvedRoot = path.dirname(path.dirname(path.dirname(runDir))); // .forge/runs/{id} → project root
|
||||||
|
|
||||||
const briefContent = fs.readFileSync(manifest.brief, 'utf-8');
|
const briefContent = fs.readFileSync(manifest.brief, 'utf-8');
|
||||||
const allStages = stagesForClass(manifest.briefClass, manifest.forceBoard);
|
const allStages = stagesForClass(manifest.briefClass, manifest.forceBoard);
|
||||||
|
|
||||||
// Find first non-passed stage
|
manifest.mode = mode;
|
||||||
|
|
||||||
|
// Find first non-satisfying stage (only a verified `passed` counts as done;
|
||||||
|
// simulated and waiting-for-authority stages are re-run).
|
||||||
const resumeFrom = allStages.find((s) => manifest.stages[s]?.status !== 'passed');
|
const resumeFrom = allStages.find((s) => manifest.stages[s]?.status !== 'passed');
|
||||||
if (!resumeFrom) {
|
if (!resumeFrom) {
|
||||||
manifest.status = 'completed';
|
manifest.status = mode === 'simulated' ? 'simulated' : 'completed';
|
||||||
saveManifest(runDir, manifest);
|
saveManifest(runDir, manifest);
|
||||||
return {
|
return {
|
||||||
runId: manifest.runId,
|
runId: manifest.runId,
|
||||||
@@ -284,49 +445,16 @@ export async function resumePipeline(
|
|||||||
tasks.push(task);
|
tasks.push(task);
|
||||||
}
|
}
|
||||||
|
|
||||||
for (let i = 0; i < tasks.length; i++) {
|
await executeStages({
|
||||||
const task = tasks[i]!;
|
manifest,
|
||||||
const stageName = remainingStages[i]!;
|
runDir,
|
||||||
|
tasks,
|
||||||
|
stageNames: remainingStages,
|
||||||
|
executor: wiredExecutor,
|
||||||
|
simulate,
|
||||||
|
});
|
||||||
|
|
||||||
manifest.currentStage = stageName;
|
manifest.status = simulate ? 'simulated' : 'completed';
|
||||||
manifest.stages[stageName] = {
|
|
||||||
status: 'in_progress',
|
|
||||||
startedAt: nowISO(),
|
|
||||||
};
|
|
||||||
saveManifest(runDir, manifest);
|
|
||||||
|
|
||||||
try {
|
|
||||||
await executor.submitTask(task);
|
|
||||||
const result = await executor.waitForCompletion(task.id, task.timeoutSeconds * 1000);
|
|
||||||
|
|
||||||
manifest.stages[stageName] = {
|
|
||||||
status: result.status === 'completed' ? 'passed' : 'failed',
|
|
||||||
startedAt: manifest.stages[stageName]!.startedAt,
|
|
||||||
completedAt: nowISO(),
|
|
||||||
};
|
|
||||||
|
|
||||||
if (result.status !== 'completed') {
|
|
||||||
manifest.status = 'failed';
|
|
||||||
saveManifest(runDir, manifest);
|
|
||||||
throw new Error(`Stage ${stageName} failed with status: ${result.status}`);
|
|
||||||
}
|
|
||||||
|
|
||||||
saveManifest(runDir, manifest);
|
|
||||||
} catch (error) {
|
|
||||||
if (!manifest.stages[stageName]?.completedAt) {
|
|
||||||
manifest.stages[stageName] = {
|
|
||||||
status: 'failed',
|
|
||||||
startedAt: manifest.stages[stageName]?.startedAt,
|
|
||||||
completedAt: nowISO(),
|
|
||||||
};
|
|
||||||
}
|
|
||||||
manifest.status = 'failed';
|
|
||||||
saveManifest(runDir, manifest);
|
|
||||||
throw error;
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
manifest.status = 'completed';
|
|
||||||
saveManifest(runDir, manifest);
|
saveManifest(runDir, manifest);
|
||||||
|
|
||||||
return {
|
return {
|
||||||
|
|||||||
@@ -0,0 +1,32 @@
|
|||||||
|
import type { ForgeTask, ForgeTaskResult, TaskExecutor } from './types.js';
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Simulated executor — used ONLY when the caller explicitly passes --simulate.
|
||||||
|
*
|
||||||
|
* It submits no real work and returns typed `simulated` results so a simulated
|
||||||
|
* run can never be confused with a verified one. In normal mode (no --simulate)
|
||||||
|
* the CLI refuses to run at all with FORGE_NO_EXECUTOR instead of wiring this
|
||||||
|
* stub (fail closed, SDLC-D-035).
|
||||||
|
*/
|
||||||
|
export function createSimulatedExecutor(options?: { log?: boolean }): TaskExecutor {
|
||||||
|
const log = options?.log ?? true;
|
||||||
|
return {
|
||||||
|
async submitTask(task: ForgeTask) {
|
||||||
|
if (log) console.log(` [forge:simulated] stage submitted: ${task.id} (${task.title})`);
|
||||||
|
},
|
||||||
|
async waitForCompletion(taskId: string): Promise<ForgeTaskResult> {
|
||||||
|
if (log) console.log(` [forge:simulated] stage complete: ${taskId}`);
|
||||||
|
return {
|
||||||
|
task_id: taskId,
|
||||||
|
outcome: 'simulated',
|
||||||
|
reason: 'no executor wired; simulated execution requested via --simulate',
|
||||||
|
completed_at: new Date().toISOString(),
|
||||||
|
exit_code: 0,
|
||||||
|
gate_results: [],
|
||||||
|
};
|
||||||
|
},
|
||||||
|
async getTaskStatus() {
|
||||||
|
return 'completed' as const;
|
||||||
|
},
|
||||||
|
};
|
||||||
|
}
|
||||||
@@ -1,4 +1,4 @@
|
|||||||
import type { GateEntry, TaskResult } from '@mosaicstack/macp';
|
import type { GateEntry } from '@mosaicstack/macp';
|
||||||
|
|
||||||
/** Stage dispatch mode. */
|
/** Stage dispatch mode. */
|
||||||
export type StageDispatch = 'exec' | 'yolo' | 'pi';
|
export type StageDispatch = 'exec' | 'yolo' | 'pi';
|
||||||
@@ -6,6 +6,58 @@ export type StageDispatch = 'exec' | 'yolo' | 'pi';
|
|||||||
/** Stage type — determines agent selection and gate requirements. */
|
/** Stage type — determines agent selection and gate requirements. */
|
||||||
export type StageType = 'research' | 'review' | 'coding' | 'deploy';
|
export type StageType = 'research' | 'review' | 'coding' | 'deploy';
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Typed outcome for every gate and stage evaluation — closed set (SDLC-D-035).
|
||||||
|
*
|
||||||
|
* Only `passed` means "verified by a real implementation". `simulated` is
|
||||||
|
* produced exclusively in explicit `--simulate` runs and is never satisfying.
|
||||||
|
*/
|
||||||
|
export type ForgeOutcome =
|
||||||
|
| 'passed'
|
||||||
|
| 'failed'
|
||||||
|
| 'blocked'
|
||||||
|
| 'error'
|
||||||
|
| 'waiting-for-authority'
|
||||||
|
| 'simulated'
|
||||||
|
| 'not-applicable';
|
||||||
|
|
||||||
|
/** A gate that requires authority (human/board) sign-off; no mechanical command can satisfy it. */
|
||||||
|
export interface AuthorityGate {
|
||||||
|
kind: 'authority';
|
||||||
|
capability: string;
|
||||||
|
reason: string;
|
||||||
|
}
|
||||||
|
|
||||||
|
/** A gate that requires a wired provider (e.g. an AI reviewer, CI pipeline) to evaluate. */
|
||||||
|
export interface ProviderGate {
|
||||||
|
kind: 'provider';
|
||||||
|
capability: string;
|
||||||
|
reason: string;
|
||||||
|
}
|
||||||
|
|
||||||
|
/** Forge quality gate: a real command, an authority sign-off, or a provider-backed check. */
|
||||||
|
export type ForgeGate = string | GateEntry | AuthorityGate | ProviderGate;
|
||||||
|
|
||||||
|
/** Typed result of evaluating a single quality gate. */
|
||||||
|
export interface ForgeGateResult {
|
||||||
|
gate: string;
|
||||||
|
outcome: ForgeOutcome;
|
||||||
|
reason: string;
|
||||||
|
exitCode?: number;
|
||||||
|
output?: string;
|
||||||
|
timedOut?: boolean;
|
||||||
|
}
|
||||||
|
|
||||||
|
/** Typed result of a task/stage execution returned by a TaskExecutor. */
|
||||||
|
export interface ForgeTaskResult {
|
||||||
|
task_id: string;
|
||||||
|
outcome: ForgeOutcome;
|
||||||
|
reason: string;
|
||||||
|
completed_at: string;
|
||||||
|
exit_code: number;
|
||||||
|
gate_results: ForgeGateResult[];
|
||||||
|
}
|
||||||
|
|
||||||
/** Stage specification — defines a single pipeline stage. */
|
/** Stage specification — defines a single pipeline stage. */
|
||||||
export interface StageSpec {
|
export interface StageSpec {
|
||||||
number: string;
|
number: string;
|
||||||
@@ -14,7 +66,7 @@ export interface StageSpec {
|
|||||||
type: StageType;
|
type: StageType;
|
||||||
gate: string;
|
gate: string;
|
||||||
promptFile: string;
|
promptFile: string;
|
||||||
qualityGates: (string | GateEntry)[];
|
qualityGates: ForgeGate[];
|
||||||
}
|
}
|
||||||
|
|
||||||
/** Brief classification. */
|
/** Brief classification. */
|
||||||
@@ -25,11 +77,18 @@ export type ClassSource = 'cli' | 'frontmatter' | 'auto';
|
|||||||
|
|
||||||
/** Per-stage status within a run manifest. */
|
/** Per-stage status within a run manifest. */
|
||||||
export interface StageStatus {
|
export interface StageStatus {
|
||||||
status: 'pending' | 'in_progress' | 'passed' | 'failed';
|
status: 'pending' | 'in_progress' | ForgeOutcome;
|
||||||
|
/** Why the stage reached its current (terminal) outcome, when applicable. */
|
||||||
|
reason?: string;
|
||||||
startedAt?: string;
|
startedAt?: string;
|
||||||
completedAt?: string;
|
completedAt?: string;
|
||||||
|
/** Typed per-gate results recorded alongside the stage outcome. */
|
||||||
|
gateResults?: ForgeGateResult[];
|
||||||
}
|
}
|
||||||
|
|
||||||
|
/** Execution mode of a run. */
|
||||||
|
export type RunMode = 'normal' | 'simulated';
|
||||||
|
|
||||||
/** Run manifest — persisted to disk as manifest.json. */
|
/** Run manifest — persisted to disk as manifest.json. */
|
||||||
export interface RunManifest {
|
export interface RunManifest {
|
||||||
runId: string;
|
runId: string;
|
||||||
@@ -38,10 +97,23 @@ export interface RunManifest {
|
|||||||
briefClass: BriefClass;
|
briefClass: BriefClass;
|
||||||
classSource: ClassSource;
|
classSource: ClassSource;
|
||||||
forceBoard: boolean;
|
forceBoard: boolean;
|
||||||
|
/**
|
||||||
|
* Execution mode. `simulated` runs stub execution; their results are typed
|
||||||
|
* `simulated` and must never be read as verified success. Optional because
|
||||||
|
* manifests written before this field existed default to `normal`.
|
||||||
|
*/
|
||||||
|
mode?: RunMode;
|
||||||
createdAt: string;
|
createdAt: string;
|
||||||
updatedAt: string;
|
updatedAt: string;
|
||||||
currentStage: string;
|
currentStage: string;
|
||||||
status: 'in_progress' | 'completed' | 'failed' | 'interrupted' | 'rejected';
|
status:
|
||||||
|
| 'in_progress'
|
||||||
|
| 'completed'
|
||||||
|
| 'failed'
|
||||||
|
| 'interrupted'
|
||||||
|
| 'rejected'
|
||||||
|
| 'simulated'
|
||||||
|
| 'waiting-for-authority';
|
||||||
stages: Record<string, StageStatus>;
|
stages: Record<string, StageStatus>;
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -65,7 +137,7 @@ export interface ForgeTask {
|
|||||||
briefPath: string;
|
briefPath: string;
|
||||||
resultPath: string;
|
resultPath: string;
|
||||||
timeoutSeconds: number;
|
timeoutSeconds: number;
|
||||||
qualityGates: (string | GateEntry)[];
|
qualityGates: ForgeGate[];
|
||||||
worktree?: string;
|
worktree?: string;
|
||||||
command?: string;
|
command?: string;
|
||||||
dependsOn?: string[];
|
dependsOn?: string[];
|
||||||
@@ -76,7 +148,7 @@ export interface ForgeTask {
|
|||||||
/** Abstract task executor — decouples from packages/coord. */
|
/** Abstract task executor — decouples from packages/coord. */
|
||||||
export interface TaskExecutor {
|
export interface TaskExecutor {
|
||||||
submitTask(task: ForgeTask): Promise<void>;
|
submitTask(task: ForgeTask): Promise<void>;
|
||||||
waitForCompletion(taskId: string, timeoutMs: number): Promise<TaskResult>;
|
waitForCompletion(taskId: string, timeoutMs: number): Promise<ForgeTaskResult>;
|
||||||
getTaskStatus(taskId: string): Promise<ForgeTaskStatus>;
|
getTaskStatus(taskId: string): Promise<ForgeTaskStatus>;
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -122,7 +194,16 @@ export interface PipelineOptions {
|
|||||||
stages?: string[];
|
stages?: string[];
|
||||||
skipTo?: string;
|
skipTo?: string;
|
||||||
dryRun?: boolean;
|
dryRun?: boolean;
|
||||||
executor: TaskExecutor;
|
/**
|
||||||
|
* Real task executor. Required in normal mode: the pipeline fails closed
|
||||||
|
* with FORGE_NO_EXECUTOR when it is absent.
|
||||||
|
*/
|
||||||
|
executor?: TaskExecutor;
|
||||||
|
/**
|
||||||
|
* Explicit opt-in to simulated execution. Every stage and gate result is
|
||||||
|
* typed `simulated` and is never satisfying.
|
||||||
|
*/
|
||||||
|
simulate?: boolean;
|
||||||
}
|
}
|
||||||
|
|
||||||
/** Pipeline run result. */
|
/** Pipeline run result. */
|
||||||
|
|||||||
@@ -51,12 +51,8 @@ See `docs/fleet/reference/generated-env-boundary.md` for the full contract.
|
|||||||
## Manual canary sequence
|
## Manual canary sequence
|
||||||
|
|
||||||
Use the roster and the supported installer; do not pre-create the agent environment directory or
|
Use the roster and the supported installer; do not pre-create the agent environment directory or
|
||||||
edit a generated projection. Before it writes any holder identity, tool, projection, or unit file,
|
edit a generated projection. `mosaic fleet install` validates the roster, installs the units and
|
||||||
`mosaic fleet install` validates the fleet CLI and every distinct roster runtime through the exact
|
helpers, and writes private roster-derived projections before any service is started.
|
||||||
pane PATH. The shared helper also unwraps `/usr/bin/env` shebangs, so a resolved Node script with no
|
|
||||||
pane-visible Node fails before effects. `mosaic fleet doctor` reports the same named executable
|
|
||||||
checks without mutation. After that preflight, install places the units and helpers and writes private
|
|
||||||
roster-derived projections before any service starts.
|
|
||||||
|
|
||||||
```bash
|
```bash
|
||||||
# Create a site-owned canary roster. Inspect an existing roster before using --force.
|
# Create a site-owned canary roster. Inspect an existing roster before using --force.
|
||||||
|
|||||||
@@ -1,199 +0,0 @@
|
|||||||
#!/usr/bin/env bash
|
|
||||||
# Canonical fleet-pane PATH construction and executable reachability checks.
|
|
||||||
#
|
|
||||||
# This file is both sourceable by start-agent-session.sh and executable by the
|
|
||||||
# fleet CLI preflight. Keep the pane PATH in one implementation: provisioning
|
|
||||||
# checks and the eventual pane must answer the same question.
|
|
||||||
|
|
||||||
mosaic_fleet_pane_home() {
|
|
||||||
local mosaic_home="$1"
|
|
||||||
local fallback_home="$2"
|
|
||||||
case "$mosaic_home" in
|
|
||||||
*/.config/mosaic) printf '%s' "${mosaic_home%/.config/mosaic}" ;;
|
|
||||||
*) printf '%s' "$fallback_home" ;;
|
|
||||||
esac
|
|
||||||
}
|
|
||||||
|
|
||||||
mosaic_fleet_build_runtime_bin_prefix() {
|
|
||||||
local pane_home="$1"
|
|
||||||
local runtime_bin="${2:-}"
|
|
||||||
local candidates=()
|
|
||||||
if [ -n "$runtime_bin" ]; then candidates+=("$runtime_bin"); fi
|
|
||||||
if command -v npm >/dev/null 2>&1; then
|
|
||||||
local npm_prefix
|
|
||||||
npm_prefix=$(npm config get prefix 2>/dev/null) || true
|
|
||||||
if [ -n "$npm_prefix" ]; then candidates+=("${npm_prefix}/bin"); fi
|
|
||||||
fi
|
|
||||||
candidates+=("$pane_home/.npm-global/bin" "$pane_home/.local/bin")
|
|
||||||
|
|
||||||
local prefix="" dir
|
|
||||||
for dir in "${candidates[@]}"; do
|
|
||||||
[ -d "$dir" ] || continue
|
|
||||||
case ":${prefix}:" in *":${dir}:"*) ;; *) prefix="${prefix:+$prefix:}$dir" ;; esac
|
|
||||||
done
|
|
||||||
printf '%s' "$prefix"
|
|
||||||
}
|
|
||||||
|
|
||||||
mosaic_fleet_build_pane_path() {
|
|
||||||
local pane_home="$1"
|
|
||||||
local runtime_bin="${2:-}"
|
|
||||||
local system_path="${3:-/usr/local/bin:/usr/bin:/bin}"
|
|
||||||
local prefix
|
|
||||||
prefix=$(mosaic_fleet_build_runtime_bin_prefix "$pane_home" "$runtime_bin")
|
|
||||||
printf '%s' "${prefix:+${prefix}:}${system_path}"
|
|
||||||
}
|
|
||||||
|
|
||||||
mosaic_fleet_resolve_in_pane_path() {
|
|
||||||
local pane_path="$1"
|
|
||||||
local binary="$2"
|
|
||||||
PATH="$pane_path" command -v -- "$binary" 2>/dev/null
|
|
||||||
}
|
|
||||||
|
|
||||||
# Sets executable evidence in MOSAIC_FLEET_EXECUTABLE_* and returns nonzero when
|
|
||||||
# a resolved script's shebang interpreter cannot run in the pane. Native/ELF
|
|
||||||
# binaries have no PATH-resolved interpreter dependency and pass the executable
|
|
||||||
# bit check. Node receives an additional side-effect-free `node --version`
|
|
||||||
# execution check; invoking `mosaic --version` itself is intentionally avoided
|
|
||||||
# because Mosaic performs a cache-writing/network update check at CLI startup.
|
|
||||||
mosaic_fleet_check_resolved_executable() {
|
|
||||||
local pane_path="$1"
|
|
||||||
local resolved="$2"
|
|
||||||
MOSAIC_FLEET_EXECUTABLE_DEPENDENCY=""
|
|
||||||
MOSAIC_FLEET_EXECUTABLE_PROBE=""
|
|
||||||
MOSAIC_FLEET_EXECUTABLE_EXIT=""
|
|
||||||
MOSAIC_FLEET_EXECUTABLE_OUTPUT=""
|
|
||||||
|
|
||||||
[ -x "$resolved" ] || {
|
|
||||||
MOSAIC_FLEET_EXECUTABLE_OUTPUT="resolved path is not executable"
|
|
||||||
return 70
|
|
||||||
}
|
|
||||||
|
|
||||||
local magic=""
|
|
||||||
IFS= read -r -n 2 magic < "$resolved" || true
|
|
||||||
[ "$magic" = '#!' ] || return 0
|
|
||||||
|
|
||||||
local shebang
|
|
||||||
IFS= read -r shebang < "$resolved" || true
|
|
||||||
shebang=${shebang%$'\r'}
|
|
||||||
shebang=${shebang#\#!}
|
|
||||||
local parts=()
|
|
||||||
read -r -a parts <<< "$shebang"
|
|
||||||
local interpreter="${parts[0]:-}"
|
|
||||||
[[ "$interpreter" = /* ]] && [ -x "$interpreter" ] || {
|
|
||||||
MOSAIC_FLEET_EXECUTABLE_DEPENDENCY="$interpreter"
|
|
||||||
MOSAIC_FLEET_EXECUTABLE_OUTPUT="shebang interpreter is absent or not executable"
|
|
||||||
return 70
|
|
||||||
}
|
|
||||||
|
|
||||||
local dependency="$interpreter"
|
|
||||||
local dependency_path="$interpreter"
|
|
||||||
if [ "${interpreter##*/}" = env ]; then
|
|
||||||
local index=1
|
|
||||||
if [ "${parts[$index]:-}" = -S ]; then index=$((index + 1)); fi
|
|
||||||
dependency="${parts[$index]:-}"
|
|
||||||
if [ -z "$dependency" ] || [[ "$dependency" = -* ]]; then
|
|
||||||
MOSAIC_FLEET_EXECUTABLE_DEPENDENCY="$dependency"
|
|
||||||
MOSAIC_FLEET_EXECUTABLE_OUTPUT="unsupported env shebang"
|
|
||||||
return 70
|
|
||||||
fi
|
|
||||||
fi
|
|
||||||
|
|
||||||
MOSAIC_FLEET_EXECUTABLE_DEPENDENCY="$dependency"
|
|
||||||
if [ "${dependency##*/}" = node ]; then
|
|
||||||
MOSAIC_FLEET_EXECUTABLE_PROBE="node --version"
|
|
||||||
fi
|
|
||||||
if [ "${interpreter##*/}" = env ]; then
|
|
||||||
if ! dependency_path=$(mosaic_fleet_resolve_in_pane_path "$pane_path" "$dependency"); then
|
|
||||||
MOSAIC_FLEET_EXECUTABLE_OUTPUT="shebang command is not on the pane PATH"
|
|
||||||
return 70
|
|
||||||
fi
|
|
||||||
fi
|
|
||||||
|
|
||||||
if [ "${dependency##*/}" = node ]; then
|
|
||||||
if MOSAIC_FLEET_EXECUTABLE_OUTPUT=$(PATH="$pane_path" "$dependency_path" --version 2>&1); then
|
|
||||||
MOSAIC_FLEET_EXECUTABLE_EXIT=0
|
|
||||||
else
|
|
||||||
MOSAIC_FLEET_EXECUTABLE_EXIT=$?
|
|
||||||
return 70
|
|
||||||
fi
|
|
||||||
fi
|
|
||||||
return 0
|
|
||||||
}
|
|
||||||
|
|
||||||
mosaic_fleet_runtime_path_main() {
|
|
||||||
local mosaic_home=""
|
|
||||||
local runtime_bin=""
|
|
||||||
local system_path="/usr/local/bin:/usr/bin:/bin"
|
|
||||||
local binary=""
|
|
||||||
local check_executable=0
|
|
||||||
|
|
||||||
while [ "$#" -gt 0 ]; do
|
|
||||||
case "$1" in
|
|
||||||
--mosaic-home)
|
|
||||||
[ "$#" -ge 2 ] || return 64
|
|
||||||
mosaic_home="$2"
|
|
||||||
shift 2
|
|
||||||
;;
|
|
||||||
--runtime-bin)
|
|
||||||
[ "$#" -ge 2 ] || return 64
|
|
||||||
runtime_bin="$2"
|
|
||||||
shift 2
|
|
||||||
;;
|
|
||||||
--binary)
|
|
||||||
[ "$#" -ge 2 ] || return 64
|
|
||||||
binary="$2"
|
|
||||||
shift 2
|
|
||||||
;;
|
|
||||||
--check-executable)
|
|
||||||
check_executable=1
|
|
||||||
shift
|
|
||||||
;;
|
|
||||||
# Test seam for measuring a greenfield host with no system Node. The
|
|
||||||
# launcher and production CLI omit it and retain the fixed system suffix.
|
|
||||||
--system-path)
|
|
||||||
[ "$#" -ge 2 ] || return 64
|
|
||||||
system_path="$2"
|
|
||||||
shift 2
|
|
||||||
;;
|
|
||||||
*) return 64 ;;
|
|
||||||
esac
|
|
||||||
done
|
|
||||||
|
|
||||||
[ -n "$mosaic_home" ] && [ -n "$binary" ] || return 64
|
|
||||||
local pane_home pane_path resolved
|
|
||||||
pane_home=$(mosaic_fleet_pane_home "$mosaic_home" "${HOME:-}")
|
|
||||||
# npm config is HOME-sensitive. Pin it to the derived pane home before asking
|
|
||||||
# for its prefix so an operator's unrelated npmrc cannot influence preflight.
|
|
||||||
HOME=$pane_home
|
|
||||||
export HOME
|
|
||||||
pane_path=$(mosaic_fleet_build_pane_path "$pane_home" "$runtime_bin" "$system_path")
|
|
||||||
if ! resolved=$(mosaic_fleet_resolve_in_pane_path "$pane_path" "$binary"); then
|
|
||||||
printf 'pane_path\0%s\0status\0missing\0binary_path\0\0dependency\0\0probe_command\0\0probe_exit\0\0probe_output\0\0' \
|
|
||||||
"$pane_path"
|
|
||||||
return 69
|
|
||||||
fi
|
|
||||||
|
|
||||||
if [ "$check_executable" -eq 1 ]; then
|
|
||||||
if mosaic_fleet_check_resolved_executable "$pane_path" "$resolved"; then
|
|
||||||
printf 'pane_path\0%s\0status\0present\0binary_path\0%s\0dependency\0%s\0probe_command\0%s\0probe_exit\0%s\0probe_output\0%s\0' \
|
|
||||||
"$pane_path" "$resolved" "$MOSAIC_FLEET_EXECUTABLE_DEPENDENCY" \
|
|
||||||
"$MOSAIC_FLEET_EXECUTABLE_PROBE" "$MOSAIC_FLEET_EXECUTABLE_EXIT" \
|
|
||||||
"$MOSAIC_FLEET_EXECUTABLE_OUTPUT"
|
|
||||||
return 0
|
|
||||||
fi
|
|
||||||
printf 'pane_path\0%s\0status\0unexecutable\0binary_path\0%s\0dependency\0%s\0probe_command\0%s\0probe_exit\0%s\0probe_output\0%s\0' \
|
|
||||||
"$pane_path" "$resolved" "$MOSAIC_FLEET_EXECUTABLE_DEPENDENCY" \
|
|
||||||
"$MOSAIC_FLEET_EXECUTABLE_PROBE" "$MOSAIC_FLEET_EXECUTABLE_EXIT" \
|
|
||||||
"$MOSAIC_FLEET_EXECUTABLE_OUTPUT"
|
|
||||||
return 70
|
|
||||||
fi
|
|
||||||
|
|
||||||
printf 'pane_path\0%s\0status\0present\0binary_path\0%s\0dependency\0\0probe_command\0\0probe_exit\0\0probe_output\0\0' \
|
|
||||||
"$pane_path" "$resolved"
|
|
||||||
return 0
|
|
||||||
}
|
|
||||||
|
|
||||||
if [[ "${BASH_SOURCE[0]}" == "$0" ]]; then
|
|
||||||
set -euo pipefail
|
|
||||||
mosaic_fleet_runtime_path_main "$@"
|
|
||||||
fi
|
|
||||||
@@ -258,22 +258,46 @@ if _tmux has-session -t "=${AGENT_NAME}:0.0" 2>/dev/null; then
|
|||||||
fi
|
fi
|
||||||
|
|
||||||
# Systemd passes HOME as %h, and the installed service fixes MOSAIC_HOME under
|
# Systemd passes HOME as %h, and the installed service fixes MOSAIC_HOME under
|
||||||
# that home. The provisioning preflight executes this same helper under the
|
# that home. Derive the pane home from the canonical path when available so an
|
||||||
# unit's clean launcher environment, so operator PATH cannot produce a false
|
# inherited pane/session HOME cannot become runtime authority.
|
||||||
# green result for a binary the pane will never see.
|
PANE_HOME=$HOME
|
||||||
SCRIPT_DIR=$(cd -- "$(dirname -- "${BASH_SOURCE[0]}")" && pwd)
|
case "$MOSAIC_HOME" in
|
||||||
# shellcheck source=pane-runtime-path.sh
|
*/.config/mosaic) PANE_HOME=${MOSAIC_HOME%/.config/mosaic} ;;
|
||||||
. "$SCRIPT_DIR/pane-runtime-path.sh"
|
esac
|
||||||
PANE_HOME=$(mosaic_fleet_pane_home "$MOSAIC_HOME" "$HOME")
|
|
||||||
PANE_PATH=$(mosaic_fleet_build_pane_path "$PANE_HOME" "$MOSAIC_RUNTIME_BIN")
|
|
||||||
|
|
||||||
# #1241/#1256. The pane runs `mosaic yolo <runtime>` under PANE_PATH with a
|
_build_runtime_bin_prefix() {
|
||||||
# cleared environment. Resolve both names and validate any shebang interpreter
|
local candidates=()
|
||||||
# here, before an effect, where the failure remains attributable. Name
|
if [ -n "$MOSAIC_RUNTIME_BIN" ]; then candidates+=("$MOSAIC_RUNTIME_BIN"); fi
|
||||||
# resolution alone is insufficient: an `#!/usr/bin/env node` script resolves
|
if command -v npm >/dev/null 2>&1; then
|
||||||
# even when the pane cannot execute it because Node is absent.
|
local npm_prefix
|
||||||
|
npm_prefix=$(npm config get prefix 2>/dev/null) || true
|
||||||
|
if [ -n "$npm_prefix" ]; then candidates+=("${npm_prefix}/bin"); fi
|
||||||
|
fi
|
||||||
|
candidates+=("$PANE_HOME/.npm-global/bin" "$PANE_HOME/.local/bin")
|
||||||
|
|
||||||
|
local prefix="" dir
|
||||||
|
for dir in "${candidates[@]}"; do
|
||||||
|
[ -d "$dir" ] || continue
|
||||||
|
case ":${prefix}:" in *":${dir}:"*) ;; *) prefix="${prefix:+$prefix:}$dir" ;; esac
|
||||||
|
done
|
||||||
|
printf '%s' "$prefix"
|
||||||
|
}
|
||||||
|
|
||||||
|
MOSAIC_RUNTIME_BIN_PREFIX=$(_build_runtime_bin_prefix)
|
||||||
|
PANE_PATH=${MOSAIC_RUNTIME_BIN_PREFIX:+${MOSAIC_RUNTIME_BIN_PREFIX}:}/usr/local/bin:/usr/bin:/bin
|
||||||
|
|
||||||
|
# #1241. The pane runs `mosaic yolo <runtime>` under PANE_PATH with a cleared
|
||||||
|
# environment. A binary missing from *that* path is a pane that dies in under a
|
||||||
|
# second, inside a session nobody is attached to, with its diagnostic scrolled
|
||||||
|
# into a pane tmux then destroys. Resolve both here, before any effect, where
|
||||||
|
# the failure is still attributable to the thing that caused it.
|
||||||
|
#
|
||||||
|
# `mosaic yolo <runtime>` runs checkRuntime(runtime) and the binary it looks for
|
||||||
|
# is named exactly like the runtime, so resolving the runtime name is the same
|
||||||
|
# question the pane will ask a moment later — asked while an operator can still
|
||||||
|
# see the answer.
|
||||||
_resolve_in_pane_path() {
|
_resolve_in_pane_path() {
|
||||||
mosaic_fleet_resolve_in_pane_path "$PANE_PATH" "$1"
|
PATH="$PANE_PATH" command -v -- "$1" 2>/dev/null
|
||||||
}
|
}
|
||||||
|
|
||||||
# Exit 69 (EX_UNAVAILABLE): the seat cannot be provided. Distinguished from the
|
# Exit 69 (EX_UNAVAILABLE): the seat cannot be provided. Distinguished from the
|
||||||
@@ -288,15 +312,8 @@ fail_launch() {
|
|||||||
}
|
}
|
||||||
|
|
||||||
for required_binary in mosaic "$MOSAIC_AGENT_RUNTIME"; do
|
for required_binary in mosaic "$MOSAIC_AGENT_RUNTIME"; do
|
||||||
resolved_binary=$(_resolve_in_pane_path "$required_binary") ||
|
_resolve_in_pane_path "$required_binary" >/dev/null ||
|
||||||
fail_launch missing-binary "'${required_binary}' is not on the pane PATH (${PANE_PATH})"
|
fail_launch missing-binary "'${required_binary}' is not on the pane PATH (${PANE_PATH})"
|
||||||
if mosaic_fleet_check_resolved_executable "$PANE_PATH" "$resolved_binary"; then
|
|
||||||
continue
|
|
||||||
else
|
|
||||||
executable_exit=$?
|
|
||||||
fi
|
|
||||||
fail_launch unexecutable-binary \
|
|
||||||
"'${required_binary}' resolves to '${resolved_binary}' but dependency '${MOSAIC_FLEET_EXECUTABLE_DEPENDENCY:-unknown}' is not executable on the pane PATH (${PANE_PATH}); check_exit=${executable_exit} detail=${MOSAIC_FLEET_EXECUTABLE_OUTPUT:-unavailable}"
|
|
||||||
done
|
done
|
||||||
|
|
||||||
_ensure_claude_workdir_trusted() {
|
_ensure_claude_workdir_trusted() {
|
||||||
|
|||||||
@@ -484,27 +484,6 @@ assert_missing_pane_binary_rejected() {
|
|||||||
assert_missing_pane_binary_rejected mosaic
|
assert_missing_pane_binary_rejected mosaic
|
||||||
assert_missing_pane_binary_rejected pi
|
assert_missing_pane_binary_rejected pi
|
||||||
|
|
||||||
# #1256. Name resolution is not executable reachability. A script can resolve
|
|
||||||
# while its /usr/bin/env shebang command is absent from PANE_PATH; reject that
|
|
||||||
# before tmux creates the doomed session.
|
|
||||||
: > "$TMUX_CALLS"
|
|
||||||
HOME_UNEXECUTABLE="$ROOT/unexecutable-shebang"
|
|
||||||
write_generated "$HOME_UNEXECUTABLE" "coder-unexecutable"
|
|
||||||
rm -f "$HOME_UNEXECUTABLE/.npm-global/bin/mosaic"
|
|
||||||
printf '#!/usr/bin/env mosaic-test-absent-interpreter\n' > \
|
|
||||||
"$HOME_UNEXECUTABLE/.npm-global/bin/mosaic"
|
|
||||||
chmod +x "$HOME_UNEXECUTABLE/.npm-global/bin/mosaic"
|
|
||||||
if output=$(MOSAIC_TEST_PANE_PID=$$ run_start "$HOME_UNEXECUTABLE" coder-unexecutable 2>&1); then
|
|
||||||
fail "launcher accepted a resolved mosaic script with an absent shebang command"
|
|
||||||
fi
|
|
||||||
echo "$output" | grep -qF 'code=unexecutable-binary' || \
|
|
||||||
fail "unexecutable shebang diagnostic missing: $output"
|
|
||||||
echo "$output" | grep -qF 'mosaic-test-absent-interpreter' || \
|
|
||||||
fail "unexecutable shebang diagnostic did not name the missing dependency"
|
|
||||||
if tr '\0' '\n' < "$TMUX_CALLS" | grep -qF new-session; then
|
|
||||||
fail "launcher created a session after its shebang dependency check failed"
|
|
||||||
fi
|
|
||||||
|
|
||||||
# #1241. tmux destroys a session when its pane command exits, so no pane PID a
|
# #1241. tmux destroys a session when its pane command exits, so no pane PID a
|
||||||
# second after new-session means the runtime died on startup. This used to be a
|
# second after new-session means the runtime died on startup. This used to be a
|
||||||
# WARNING about the heartbeat sidecar followed by exit 0 — three layers above it
|
# WARNING about the heartbeat sidecar followed by exit 0 — three layers above it
|
||||||
|
|||||||
@@ -39,3 +39,20 @@ packages/mosaic/framework/tools/tmux/test-send-message-verdict.sh | requires rea
|
|||||||
# recorded judgement. These lines ARE that judgement, signed.)
|
# recorded judgement. These lines ARE that judgement, signed.)
|
||||||
packages/mosaic/framework/tools/orchestrator/smoke-test.sh | behavior smoke checks for coord continue/run workflows, run manually by orchestrator seats; unmeasured in CI; #1017 burndown
|
packages/mosaic/framework/tools/orchestrator/smoke-test.sh | behavior smoke checks for coord continue/run workflows, run manually by orchestrator seats; unmeasured in CI; #1017 burndown
|
||||||
packages/mosaic/framework/tools/wake/validate-973/microtest-wake-assert.sh | #973 instrument self-test, run as a precondition of the validate-973 evidence procedure rather than as a standing CI suite; #1017 burndown candidate
|
packages/mosaic/framework/tools/wake/validate-973/microtest-wake-assert.sh | #973 instrument self-test, run as a precondition of the validate-973 evidence procedure rather than as a standing CI suite; #1017 burndown candidate
|
||||||
|
|
||||||
|
# --- tools/fleet: precondition is unsatisfiable in the CI image (#1271) ---
|
||||||
|
# Signed by fred (sb-it-1-dt, 2026-08-16) at origin/next 476db12.
|
||||||
|
# This suite asserts the launcher's behaviour when `mosaic` and `pi` are MISSING.
|
||||||
|
# It shims fakes into $FAKE_BIN, but the constructed PANE_PATH always ends in the
|
||||||
|
# real system path, so on a host that installs those binaries the missing-binary
|
||||||
|
# cases cannot be measured at all. The suite's own guard (line 103) says so and
|
||||||
|
# fails rather than reporting a pass it cannot back. That guard is correct.
|
||||||
|
# The error was wiring the suite into CI: #1017 (c56483eb) enumerated it and
|
||||||
|
# dropped this exclusion, and the CI image provides `pi` in the system path, so
|
||||||
|
# it has failed on every pipeline since. Measured 2026-08-16 across pipelines
|
||||||
|
# 2444 (#1256), 2438 (#1240) and 2441 (#1017-quality): exactly one FAIL line in
|
||||||
|
# each full log, identical, this assertion; control `zzz-not-present-zzz` -> 0.
|
||||||
|
# Burn-down and the full measurement are tracked in #1271; unwired by PR #1270.
|
||||||
|
# Because test:framework-shell is one && chain and this sat at position 44 of 48,
|
||||||
|
# the four suites after it had not run at all since the merge.
|
||||||
|
packages/mosaic/framework/tools/fleet/test-start-agent-session.sh | precondition unsatisfiable in the CI image: asserts missing-binary behaviour, but PANE_PATH always ends in the system path and the image provides `pi` there; guard at line 103 fails by design rather than passing unmeasured. Burn down by controlling the tail of PANE_PATH inside the test. NOT by removing `pi` from the image: the CI image installs @earendil-works/[email protected] deliberately (measured in pipeline 2444's test-step log), and other suites depend on that pin. Burn-down tracked in #1271
|
||||||
|
|||||||
@@ -25,7 +25,7 @@
|
|||||||
"lint": "eslint src",
|
"lint": "eslint src",
|
||||||
"typecheck": "tsc --noEmit",
|
"typecheck": "tsc --noEmit",
|
||||||
"test": "vitest run --passWithNoTests && pnpm run test:framework-shell",
|
"test": "vitest run --passWithNoTests && pnpm run test:framework-shell",
|
||||||
"test:framework-shell": "bash framework/tools/quality/scripts/check-test-enumeration.sh && bash framework/tools/quality/scripts/test-check-test-enumeration.sh && python3 src/lease-broker/daemon_deadline_unittest.py && python3 src/lease-broker/normative_fragments_unittest.py && python3 src/lease-broker/promotion_binding_unittest.py && python3 src/lease-broker/promotion_trigger_unittest.py && python3 src/lease-broker/receipt_challenge_unittest.py && python3 src/lease-broker/context_recovery_unittest.py && python3 src/lease-broker/recovery_runtime_unittest.py && python3 src/lease-broker/recovery_b1_adversarial_unittest.py && python3 src/lease-broker/receipt_observer_client_unittest.py && python3 src/lease-broker/invariant_r_unittest.py && python3 src/lease-broker/framework_skill_portability_unittest.py && python3 src/mutator-gate/runtime_tools_unittest.py && python3 src/mutator-gate/runtime_launch_guard_unittest.py && python3 src/mutator-gate/version_coupling_unittest.py && python3 framework/tools/lease-broker/check-runtime-launches.py --root ../.. && bash framework/tools/codex/test-pr-diff-context.sh && bash framework/tools/qa/test-deps-preflight.sh && bash framework/tools/git/test-pr-review-gitea-comment.sh && bash framework/tools/git/test-pr-review-repo-host-override.sh && bash framework/tools/git/test-ci-queue-wait-branch-absent.sh && bash framework/tools/git/test-ci-queue-wait-tristate.sh && bash framework/tools/git/test-ci-queue-wait-github-checks.sh && bash framework/tools/git/test-pr-merge-queue-branch.sh && bash framework/tools/git/test-pr-merge-head-pin.sh && bash framework/tools/git/test-pr-merge-message-field.sh && bash framework/tools/git/test-git-credential-mosaic.sh && bash framework/tools/git/test-gitea-token-identity.sh && bash framework/tools/woodpecker/test-terminal-green-contract.sh && bash framework/tools/_scripts/test-install-ordering-guard.sh && bash framework/tools/_scripts/test-mosaic-init-rce.sh && bash framework/tools/tmux/agent-send.test.sh && bash framework/tools/wake/test-wake-store-ack.sh && bash framework/tools/wake/test-wake-store-enqueue-race.sh && bash framework/tools/wake/test-wake-digest-hmac.sh && bash framework/tools/wake/test-wake-digest-quarantine.sh && bash framework/tools/wake/test-wake-detector.sh && bash framework/tools/wake/test-wake-fn-oracle.sh && bash framework/tools/wake/test-wake-reconcile.sh && bash framework/tools/wake/test-wake-beacon.sh && bash framework/tools/wake/test-wake-preimage.sh && bash framework/tools/wake/test-wake-install.sh && bash framework/tools/fleet/test-start-agent-session.sh && bash framework/tools/glpi/test-list-http-status.sh && bash framework/tools/orchestrator/test-board-roll.sh && bash framework/tools/woodpecker/test-ci-wait-exit-matrix.sh && bash framework/tools/_scripts/test-fleet-transport-check.sh"
|
"test:framework-shell": "bash framework/tools/quality/scripts/check-test-enumeration.sh && bash framework/tools/quality/scripts/test-check-test-enumeration.sh && python3 src/lease-broker/daemon_deadline_unittest.py && python3 src/lease-broker/normative_fragments_unittest.py && python3 src/lease-broker/promotion_binding_unittest.py && python3 src/lease-broker/promotion_trigger_unittest.py && python3 src/lease-broker/receipt_challenge_unittest.py && python3 src/lease-broker/context_recovery_unittest.py && python3 src/lease-broker/recovery_runtime_unittest.py && python3 src/lease-broker/recovery_b1_adversarial_unittest.py && python3 src/lease-broker/receipt_observer_client_unittest.py && python3 src/lease-broker/invariant_r_unittest.py && python3 src/lease-broker/framework_skill_portability_unittest.py && python3 src/mutator-gate/runtime_tools_unittest.py && python3 src/mutator-gate/runtime_launch_guard_unittest.py && python3 src/mutator-gate/version_coupling_unittest.py && python3 framework/tools/lease-broker/check-runtime-launches.py --root ../.. && bash framework/tools/codex/test-pr-diff-context.sh && bash framework/tools/qa/test-deps-preflight.sh && bash framework/tools/git/test-pr-review-gitea-comment.sh && bash framework/tools/git/test-pr-review-repo-host-override.sh && bash framework/tools/git/test-ci-queue-wait-branch-absent.sh && bash framework/tools/git/test-ci-queue-wait-tristate.sh && bash framework/tools/git/test-ci-queue-wait-github-checks.sh && bash framework/tools/git/test-pr-merge-queue-branch.sh && bash framework/tools/git/test-pr-merge-head-pin.sh && bash framework/tools/git/test-pr-merge-message-field.sh && bash framework/tools/git/test-git-credential-mosaic.sh && bash framework/tools/git/test-gitea-token-identity.sh && bash framework/tools/woodpecker/test-terminal-green-contract.sh && bash framework/tools/_scripts/test-install-ordering-guard.sh && bash framework/tools/_scripts/test-mosaic-init-rce.sh && bash framework/tools/tmux/agent-send.test.sh && bash framework/tools/wake/test-wake-store-ack.sh && bash framework/tools/wake/test-wake-store-enqueue-race.sh && bash framework/tools/wake/test-wake-digest-hmac.sh && bash framework/tools/wake/test-wake-digest-quarantine.sh && bash framework/tools/wake/test-wake-detector.sh && bash framework/tools/wake/test-wake-fn-oracle.sh && bash framework/tools/wake/test-wake-reconcile.sh && bash framework/tools/wake/test-wake-beacon.sh && bash framework/tools/wake/test-wake-preimage.sh && bash framework/tools/wake/test-wake-install.sh && bash framework/tools/glpi/test-list-http-status.sh && bash framework/tools/orchestrator/test-board-roll.sh && bash framework/tools/woodpecker/test-ci-wait-exit-matrix.sh && bash framework/tools/_scripts/test-fleet-transport-check.sh"
|
||||||
},
|
},
|
||||||
"dependencies": {
|
"dependencies": {
|
||||||
"@mosaicstack/brain": "workspace:*",
|
"@mosaicstack/brain": "workspace:*",
|
||||||
|
|||||||
@@ -1,13 +1,9 @@
|
|||||||
import { chmod, mkdir, mkdtemp, rm, writeFile } from 'node:fs/promises';
|
import { chmod, mkdir, mkdtemp, rm, writeFile } from 'node:fs/promises';
|
||||||
import { tmpdir } from 'node:os';
|
import { tmpdir } from 'node:os';
|
||||||
import { join, resolve } from 'node:path';
|
import { join } from 'node:path';
|
||||||
import { Command } from 'commander';
|
import { Command } from 'commander';
|
||||||
import { afterEach, describe, expect, it, vi } from 'vitest';
|
import { afterEach, describe, expect, it, vi } from 'vitest';
|
||||||
import { type FleetReconcileDeps } from '../fleet/fleet-reconciler.js';
|
import { type FleetReconcileDeps } from '../fleet/fleet-reconciler.js';
|
||||||
import {
|
|
||||||
type FleetRuntimeProbeResult,
|
|
||||||
type FleetRuntimeProbeRunner,
|
|
||||||
} from '../fleet/fleet-runtime-preflight.js';
|
|
||||||
import { registerFleetCommand, type CommandResult, type FleetCommandDeps } from './fleet.js';
|
import { registerFleetCommand, type CommandResult, type FleetCommandDeps } from './fleet.js';
|
||||||
|
|
||||||
const roster = `
|
const roster = `
|
||||||
@@ -69,15 +65,12 @@ function program(
|
|||||||
mosaicHome: string,
|
mosaicHome: string,
|
||||||
runner: FleetCommandDeps['runner'],
|
runner: FleetCommandDeps['runner'],
|
||||||
reconcileOverrides: Partial<FleetReconcileDeps> = {},
|
reconcileOverrides: Partial<FleetReconcileDeps> = {},
|
||||||
runtimeProbeRunner: FleetRuntimeProbeRunner = runtimeProbe('present'),
|
|
||||||
): Command {
|
): Command {
|
||||||
const result = new Command();
|
const result = new Command();
|
||||||
result.exitOverride();
|
result.exitOverride();
|
||||||
registerFleetCommand(result, {
|
registerFleetCommand(result, {
|
||||||
mosaicHome,
|
mosaicHome,
|
||||||
runner,
|
runner,
|
||||||
frameworkRoot: resolve(process.cwd(), 'framework'),
|
|
||||||
runtimeProbeRunner,
|
|
||||||
reconcileDeps: {
|
reconcileDeps: {
|
||||||
homeDirectory: '/home/mosaic',
|
homeDirectory: '/home/mosaic',
|
||||||
readHolderIdentity: async () => '11111111-1111-4111-8111-111111111111',
|
readHolderIdentity: async () => '11111111-1111-4111-8111-111111111111',
|
||||||
@@ -90,24 +83,6 @@ function program(
|
|||||||
return result;
|
return result;
|
||||||
}
|
}
|
||||||
|
|
||||||
function runtimeProbe(status: 'present' | 'missing'): FleetRuntimeProbeRunner {
|
|
||||||
return async (_command, args): Promise<FleetRuntimeProbeResult> => {
|
|
||||||
const binaryFlag = args.indexOf('--binary');
|
|
||||||
const binary = binaryFlag >= 0 ? args[binaryFlag + 1] : undefined;
|
|
||||||
const effectiveStatus = binary === 'mosaic' ? 'present' : status;
|
|
||||||
return {
|
|
||||||
stdout:
|
|
||||||
`pane_path\u0000/fixture/runtime-bin:/usr/bin:/bin\u0000status\u0000${effectiveStatus}\u0000` +
|
|
||||||
`binary_path\u0000${effectiveStatus === 'present' ? `/fixture/runtime-bin/${binary ?? 'unknown'}` : ''}\u0000` +
|
|
||||||
`dependency\u0000${effectiveStatus === 'present' ? 'node' : ''}\u0000` +
|
|
||||||
`probe_command\u0000${effectiveStatus === 'present' ? 'node --version' : ''}\u0000` +
|
|
||||||
`probe_exit\u0000${effectiveStatus === 'present' ? '0' : ''}\u0000probe_output\u0000\u0000`,
|
|
||||||
stderr: '',
|
|
||||||
exitCode: effectiveStatus === 'present' ? 0 : 69,
|
|
||||||
};
|
|
||||||
};
|
|
||||||
}
|
|
||||||
|
|
||||||
function capture(): string[] {
|
function capture(): string[] {
|
||||||
const lines: string[] = [];
|
const lines: string[] = [];
|
||||||
vi.spyOn(console, 'log').mockImplementation((value: string): void => {
|
vi.spyOn(console, 'log').mockImplementation((value: string): void => {
|
||||||
@@ -177,64 +152,13 @@ describe('mosaic fleet reconciler commands', (): void => {
|
|||||||
|
|
||||||
expect(lines.map((line: string): unknown => JSON.parse(line))).toMatchObject([
|
expect(lines.map((line: string): unknown => JSON.parse(line))).toMatchObject([
|
||||||
{ applied: false, lifecycle: 'not-applied' },
|
{ applied: false, lifecycle: 'not-applied' },
|
||||||
{
|
{ applied: false, lifecycle: 'not-applied' },
|
||||||
applied: false,
|
|
||||||
lifecycle: 'not-applied',
|
|
||||||
checks: {
|
|
||||||
fleetCliExecutable: [
|
|
||||||
{
|
|
||||||
check: 'fleet-cli-executable',
|
|
||||||
status: 'ok',
|
|
||||||
requestedBy: ['coder0'],
|
|
||||||
dependency: 'node',
|
|
||||||
probeCommand: 'node --version',
|
|
||||||
},
|
|
||||||
],
|
|
||||||
fleetRuntimeAvailability: [
|
|
||||||
{
|
|
||||||
check: 'fleet-runtime-available',
|
|
||||||
runtime: 'pi',
|
|
||||||
status: 'ok',
|
|
||||||
requestedBy: ['coder0'],
|
|
||||||
},
|
|
||||||
],
|
|
||||||
},
|
|
||||||
},
|
|
||||||
]);
|
]);
|
||||||
expect(
|
expect(
|
||||||
calls.every((call: string[]): boolean => call[0] !== 'systemctl' || call[2] === 'show'),
|
calls.every((call: string[]): boolean => call[0] !== 'systemctl' || call[2] === 'show'),
|
||||||
).toBe(true);
|
).toBe(true);
|
||||||
});
|
});
|
||||||
|
|
||||||
it('reports a missing roster runtime as a named non-green doctor check', async (): Promise<void> => {
|
|
||||||
const home = await fleetHome();
|
|
||||||
const lines = capture();
|
|
||||||
|
|
||||||
await program(home, ownedRunner([]), {}, runtimeProbe('missing')).parseAsync([
|
|
||||||
'node',
|
|
||||||
'mosaic',
|
|
||||||
'fleet',
|
|
||||||
'doctor',
|
|
||||||
]);
|
|
||||||
|
|
||||||
expect(JSON.parse(lines.pop() ?? '')).toMatchObject({
|
|
||||||
applied: false,
|
|
||||||
checks: {
|
|
||||||
fleetRuntimeAvailability: [
|
|
||||||
{
|
|
||||||
check: 'fleet-runtime-available',
|
|
||||||
runtime: 'pi',
|
|
||||||
status: 'missing',
|
|
||||||
requestedBy: ['coder0'],
|
|
||||||
panePath: '/fixture/runtime-bin:/usr/bin:/bin',
|
|
||||||
installCommand: 'npm install -g @earendil-works/pi-coding-agent',
|
|
||||||
},
|
|
||||||
],
|
|
||||||
},
|
|
||||||
});
|
|
||||||
expect(process.exitCode).toBe(1);
|
|
||||||
});
|
|
||||||
|
|
||||||
it.each(['start', 'stop', 'restart'] as const)(
|
it.each(['start', 'stop', 'restart'] as const)(
|
||||||
'uses exact roster-owned systemd targeting for %s',
|
'uses exact roster-owned systemd targeting for %s',
|
||||||
async (operation: 'start' | 'stop' | 'restart'): Promise<void> => {
|
async (operation: 'start' | 'stop' | 'restart'): Promise<void> => {
|
||||||
|
|||||||
@@ -8,18 +8,10 @@ import {
|
|||||||
type FleetReconcileCommand,
|
type FleetReconcileCommand,
|
||||||
type FleetReconcileDeps,
|
type FleetReconcileDeps,
|
||||||
} from '../fleet/fleet-reconciler.js';
|
} from '../fleet/fleet-reconciler.js';
|
||||||
import {
|
|
||||||
inspectFleetRuntimeAvailability,
|
|
||||||
type FleetRuntimeInspection,
|
|
||||||
type FleetRuntimePreflightCheck,
|
|
||||||
type FleetRuntimeProbeRunner,
|
|
||||||
} from '../fleet/fleet-runtime-preflight.js';
|
|
||||||
import { parseRosterV2 } from '../fleet/roster-v2.js';
|
import { parseRosterV2 } from '../fleet/roster-v2.js';
|
||||||
|
|
||||||
export interface FleetReconcilerCommandDeps {
|
export interface FleetReconcilerCommandDeps {
|
||||||
readonly runner: CommandRunner;
|
readonly runner: CommandRunner;
|
||||||
readonly runtimeProbeRunner?: FleetRuntimeProbeRunner;
|
|
||||||
readonly frameworkRoot?: string;
|
|
||||||
readonly mosaicHome?: string;
|
readonly mosaicHome?: string;
|
||||||
readonly reconcileDeps?: Omit<FleetReconcileDeps, 'runner' | 'mosaicHome'>;
|
readonly reconcileDeps?: Omit<FleetReconcileDeps, 'runner' | 'mosaicHome'>;
|
||||||
}
|
}
|
||||||
@@ -79,10 +71,6 @@ export async function executeReconcilerCommand(
|
|||||||
const mosaicHome = resolveMosaicHome(fleetCommand, deps);
|
const mosaicHome = resolveMosaicHome(fleetCommand, deps);
|
||||||
const rosterPath = resolveRosterPath(fleetCommand, mosaicHome);
|
const rosterPath = resolveRosterPath(fleetCommand, mosaicHome);
|
||||||
const roster = parseRosterV2(await readFile(rosterPath, 'utf8'), 'yaml');
|
const roster = parseRosterV2(await readFile(rosterPath, 'utf8'), 'yaml');
|
||||||
const runtimeInspection =
|
|
||||||
operation === 'doctor'
|
|
||||||
? await inspectRuntimeAvailability(roster.agents, mosaicHome, deps)
|
|
||||||
: undefined;
|
|
||||||
const mutating = operation === 'apply' || operation === 'reconcile' || isLifecycle(operation);
|
const mutating = operation === 'apply' || operation === 'reconcile' || isLifecycle(operation);
|
||||||
const expectedGeneration = mutating
|
const expectedGeneration = mutating
|
||||||
? parseExpectedGeneration(opts.expectedGeneration)
|
? parseExpectedGeneration(opts.expectedGeneration)
|
||||||
@@ -102,31 +90,8 @@ export async function executeReconcilerCommand(
|
|||||||
...(deps.reconcileDeps ?? {}),
|
...(deps.reconcileDeps ?? {}),
|
||||||
},
|
},
|
||||||
});
|
});
|
||||||
printJson(operation === 'doctor' ? { ...result, checks: runtimeInspection } : result);
|
printJson(result);
|
||||||
const executableFailure =
|
process.exitCode = result.recovery === undefined && result.cleanup === undefined ? 0 : 1;
|
||||||
runtimeInspection !== undefined &&
|
|
||||||
[...runtimeInspection.fleetCliExecutable, ...runtimeInspection.fleetRuntimeAvailability].some(
|
|
||||||
(check: FleetRuntimePreflightCheck): boolean => check.status !== 'ok',
|
|
||||||
);
|
|
||||||
process.exitCode =
|
|
||||||
result.recovery === undefined && result.cleanup === undefined && !executableFailure ? 0 : 1;
|
|
||||||
}
|
|
||||||
|
|
||||||
async function inspectRuntimeAvailability(
|
|
||||||
agents: readonly { readonly name: string; readonly runtime: string }[],
|
|
||||||
mosaicHome: string,
|
|
||||||
deps: FleetReconcilerCommandDeps,
|
|
||||||
): Promise<FleetRuntimeInspection> {
|
|
||||||
if (deps.frameworkRoot === undefined || deps.runtimeProbeRunner === undefined) {
|
|
||||||
throw new Error('Fleet doctor runtime preflight dependencies are unavailable.');
|
|
||||||
}
|
|
||||||
return inspectFleetRuntimeAvailability({
|
|
||||||
mosaicHome,
|
|
||||||
agentEnvDir: join(mosaicHome, 'fleet', 'agents'),
|
|
||||||
helperPath: join(deps.frameworkRoot, 'tools', 'fleet', 'pane-runtime-path.sh'),
|
|
||||||
agents,
|
|
||||||
runner: deps.runtimeProbeRunner,
|
|
||||||
});
|
|
||||||
}
|
}
|
||||||
|
|
||||||
function isLifecycle(operation: FleetReconcileCommand): boolean {
|
function isLifecycle(operation: FleetReconcileCommand): boolean {
|
||||||
|
|||||||
@@ -4,7 +4,6 @@ import { tmpdir } from 'node:os';
|
|||||||
import { join, resolve } from 'node:path';
|
import { join, resolve } from 'node:path';
|
||||||
import { Command } from 'commander';
|
import { Command } from 'commander';
|
||||||
import { afterEach, describe, expect, it, vi } from 'vitest';
|
import { afterEach, describe, expect, it, vi } from 'vitest';
|
||||||
import type { FleetRuntimeProbeRunner } from '../fleet/fleet-runtime-preflight.js';
|
|
||||||
import { registerFleetCommand, type CommandResult, type CommandRunner } from './fleet.js';
|
import { registerFleetCommand, type CommandResult, type CommandRunner } from './fleet.js';
|
||||||
|
|
||||||
/**
|
/**
|
||||||
@@ -70,7 +69,6 @@ agents:
|
|||||||
let tempHome: string | undefined;
|
let tempHome: string | undefined;
|
||||||
const savedHome = process.env.HOME;
|
const savedHome = process.env.HOME;
|
||||||
const savedMosaicHome = process.env.MOSAIC_HOME;
|
const savedMosaicHome = process.env.MOSAIC_HOME;
|
||||||
const savedPath = process.env.PATH;
|
|
||||||
|
|
||||||
afterEach(async (): Promise<void> => {
|
afterEach(async (): Promise<void> => {
|
||||||
vi.restoreAllMocks();
|
vi.restoreAllMocks();
|
||||||
@@ -79,8 +77,6 @@ afterEach(async (): Promise<void> => {
|
|||||||
else process.env.HOME = savedHome;
|
else process.env.HOME = savedHome;
|
||||||
if (savedMosaicHome === undefined) delete process.env.MOSAIC_HOME;
|
if (savedMosaicHome === undefined) delete process.env.MOSAIC_HOME;
|
||||||
else process.env.MOSAIC_HOME = savedMosaicHome;
|
else process.env.MOSAIC_HOME = savedMosaicHome;
|
||||||
if (savedPath === undefined) delete process.env.PATH;
|
|
||||||
else process.env.PATH = savedPath;
|
|
||||||
if (tempHome) await rm(tempHome, { recursive: true, force: true });
|
if (tempHome) await rm(tempHome, { recursive: true, force: true });
|
||||||
tempHome = undefined;
|
tempHome = undefined;
|
||||||
});
|
});
|
||||||
@@ -89,7 +85,7 @@ afterEach(async (): Promise<void> => {
|
|||||||
* A HOME with a roster-v2 fleet and nothing else — the greenfield shape, before
|
* A HOME with a roster-v2 fleet and nothing else — the greenfield shape, before
|
||||||
* anything has been installed, applied or started.
|
* anything has been installed, applied or started.
|
||||||
*/
|
*/
|
||||||
async function v2Home(options: { withPaneRuntime?: boolean } = {}): Promise<string> {
|
async function v2Home(): Promise<string> {
|
||||||
tempHome = await mkdtemp(join(tmpdir(), 'mosaic-fleet-v2-dispatch-'));
|
tempHome = await mkdtemp(join(tmpdir(), 'mosaic-fleet-v2-dispatch-'));
|
||||||
process.env.HOME = tempHome;
|
process.env.HOME = tempHome;
|
||||||
delete process.env.MOSAIC_HOME;
|
delete process.env.MOSAIC_HOME;
|
||||||
@@ -101,12 +97,6 @@ async function v2Home(options: { withPaneRuntime?: boolean } = {}): Promise<stri
|
|||||||
await writeFile(join(mosaicHome, 'fleet', 'roles', 'code.md'), '`class: code`\n\n# code\n', {
|
await writeFile(join(mosaicHome, 'fleet', 'roles', 'code.md'), '`class: code`\n\n# code\n', {
|
||||||
mode: 0o600,
|
mode: 0o600,
|
||||||
});
|
});
|
||||||
const runtimeDir = join(tempHome, '.npm-global', 'bin');
|
|
||||||
await mkdir(runtimeDir, { recursive: true });
|
|
||||||
await writeFile(join(runtimeDir, 'mosaic'), '#!/bin/sh\nexit 0\n', { mode: 0o755 });
|
|
||||||
if (options.withPaneRuntime !== false) {
|
|
||||||
await writeFile(join(runtimeDir, 'pi'), '#!/bin/sh\nexit 0\n', { mode: 0o755 });
|
|
||||||
}
|
|
||||||
return mosaicHome;
|
return mosaicHome;
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -123,17 +113,10 @@ const greenfieldRunner: CommandRunner = async (command): Promise<CommandResult>
|
|||||||
return { stdout: '', stderr: '', exitCode: 1 };
|
return { stdout: '', stderr: '', exitCode: 1 };
|
||||||
};
|
};
|
||||||
|
|
||||||
function program(
|
function program(runner: CommandRunner = greenfieldRunner): Command {
|
||||||
runner: CommandRunner = greenfieldRunner,
|
|
||||||
runtimeProbeRunner?: FleetRuntimeProbeRunner,
|
|
||||||
): Command {
|
|
||||||
const result = new Command();
|
const result = new Command();
|
||||||
result.exitOverride();
|
result.exitOverride();
|
||||||
registerFleetCommand(result, {
|
registerFleetCommand(result, { runner, frameworkRoot: resolve(process.cwd(), 'framework') });
|
||||||
runner,
|
|
||||||
frameworkRoot: resolve(process.cwd(), 'framework'),
|
|
||||||
...(runtimeProbeRunner === undefined ? {} : { runtimeProbeRunner }),
|
|
||||||
});
|
|
||||||
return result;
|
return result;
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -183,93 +166,6 @@ describe('mosaic fleet ps — roster v2', (): void => {
|
|||||||
});
|
});
|
||||||
|
|
||||||
describe('mosaic fleet install — roster v2', (): void => {
|
describe('mosaic fleet install — roster v2', (): void => {
|
||||||
it('rejects a roster runtime missing from the pane PATH before installing any files', async (): Promise<void> => {
|
|
||||||
const mosaicHome = await v2Home({ withPaneRuntime: false });
|
|
||||||
const operatorBin = join(tempHome!, 'operator-bin');
|
|
||||||
await mkdir(operatorBin, { recursive: true });
|
|
||||||
await writeFile(join(operatorBin, 'pi'), '#!/bin/sh\nexit 0\n', { mode: 0o755 });
|
|
||||||
process.env.PATH = `${operatorBin}:${savedPath ?? '/usr/bin:/bin'}`;
|
|
||||||
|
|
||||||
let message = '';
|
|
||||||
try {
|
|
||||||
await program().parseAsync([
|
|
||||||
'node',
|
|
||||||
'mosaic',
|
|
||||||
'fleet',
|
|
||||||
'--mosaic-home',
|
|
||||||
mosaicHome,
|
|
||||||
'install',
|
|
||||||
'--no-enable',
|
|
||||||
]);
|
|
||||||
} catch (error: unknown) {
|
|
||||||
message = error instanceof Error ? error.message : String(error);
|
|
||||||
}
|
|
||||||
|
|
||||||
expect(message).toContain('runtime=pi');
|
|
||||||
expect(message).toContain('requested_by=coder0,coder1');
|
|
||||||
expect(message).toContain('pane_path=');
|
|
||||||
expect(message).toContain('npm install -g @earendil-works/pi-coding-agent');
|
|
||||||
expect(message).not.toContain(operatorBin);
|
|
||||||
expect(
|
|
||||||
await exists(join(tempHome!, '.config', 'systemd', 'user', '[email protected]')),
|
|
||||||
).toBe(false);
|
|
||||||
expect(await exists(join(mosaicHome, 'fleet', 'holder.id'))).toBe(false);
|
|
||||||
expect(await exists(join(mosaicHome, 'tools'))).toBe(false);
|
|
||||||
});
|
|
||||||
|
|
||||||
it('rejects resolved Node-shebang commands when Node is absent from the pane PATH', async (): Promise<void> => {
|
|
||||||
const mosaicHome = await v2Home();
|
|
||||||
const runtimeDir = join(tempHome!, '.npm-global', 'bin');
|
|
||||||
const nodeScript = '#!/usr/bin/env node\nconsole.log("should-not-run");\n';
|
|
||||||
await writeFile(join(runtimeDir, 'mosaic'), nodeScript, { mode: 0o755 });
|
|
||||||
await writeFile(join(runtimeDir, 'pi'), nodeScript, { mode: 0o755 });
|
|
||||||
await writeFile(join(tempHome!, '.npmrc'), `prefix=${join(tempHome!, 'absent-prefix')}\n`);
|
|
||||||
const isolatedSystemPath = join(tempHome!, 'system-bin');
|
|
||||||
await mkdir(isolatedSystemPath, { recursive: true });
|
|
||||||
const isolatedProbeRunner: FleetRuntimeProbeRunner = async (
|
|
||||||
command,
|
|
||||||
args,
|
|
||||||
): Promise<CommandResult> =>
|
|
||||||
new Promise((settle) => {
|
|
||||||
const child = execFile(
|
|
||||||
command,
|
|
||||||
[...args, '--system-path', isolatedSystemPath],
|
|
||||||
{ encoding: 'utf8' },
|
|
||||||
(error, stdout, stderr) => {
|
|
||||||
settle({
|
|
||||||
stdout,
|
|
||||||
stderr,
|
|
||||||
exitCode: child.exitCode ?? (error === null ? 0 : 1),
|
|
||||||
});
|
|
||||||
},
|
|
||||||
);
|
|
||||||
});
|
|
||||||
|
|
||||||
let message = '';
|
|
||||||
try {
|
|
||||||
await program(greenfieldRunner, isolatedProbeRunner).parseAsync([
|
|
||||||
'node',
|
|
||||||
'mosaic',
|
|
||||||
'fleet',
|
|
||||||
'--mosaic-home',
|
|
||||||
mosaicHome,
|
|
||||||
'install',
|
|
||||||
'--no-enable',
|
|
||||||
]);
|
|
||||||
} catch (error: unknown) {
|
|
||||||
message = error instanceof Error ? error.message : String(error);
|
|
||||||
}
|
|
||||||
|
|
||||||
expect(message).toContain('check=fleet-cli-executable');
|
|
||||||
expect(message).toContain('binary=mosaic');
|
|
||||||
expect(message).toContain('dependency=node');
|
|
||||||
expect(message).toContain('check=fleet-runtime-available');
|
|
||||||
expect(message).toContain('runtime=pi');
|
|
||||||
expect(message).not.toContain('/usr/bin');
|
|
||||||
expect(await exists(join(mosaicHome, 'fleet', 'holder.id'))).toBe(false);
|
|
||||||
expect(await exists(join(mosaicHome, 'tools'))).toBe(false);
|
|
||||||
});
|
|
||||||
|
|
||||||
it('places the tool files and unit templates', async (): Promise<void> => {
|
it('places the tool files and unit templates', async (): Promise<void> => {
|
||||||
const mosaicHome = await v2Home();
|
const mosaicHome = await v2Home();
|
||||||
capture();
|
capture();
|
||||||
@@ -287,11 +183,9 @@ describe('mosaic fleet install — roster v2', (): void => {
|
|||||||
]) {
|
]) {
|
||||||
expect(await exists(join(systemdUserDir, unit))).toBe(true);
|
expect(await exists(join(systemdUserDir, unit))).toBe(true);
|
||||||
}
|
}
|
||||||
for (const tool of ['start-agent-session.sh', 'pane-runtime-path.sh']) {
|
const launcher = join(mosaicHome, 'tools', 'fleet', 'start-agent-session.sh');
|
||||||
const toolPath = join(mosaicHome, 'tools', 'fleet', tool);
|
expect(await exists(launcher)).toBe(true);
|
||||||
expect(await exists(toolPath)).toBe(true);
|
expect((await stat(launcher)).mode & 0o777).toBe(0o755);
|
||||||
expect((await stat(toolPath)).mode & 0o777).toBe(0o755);
|
|
||||||
}
|
|
||||||
});
|
});
|
||||||
|
|
||||||
it('writes NO generated env — that file belongs to the reconciler (#791)', async (): Promise<void> => {
|
it('writes NO generated env — that file belongs to the reconciler (#791)', async (): Promise<void> => {
|
||||||
|
|||||||
@@ -1277,10 +1277,6 @@ describe('fleet command construction', () => {
|
|||||||
const home = await tempDir();
|
const home = await tempDir();
|
||||||
process.env.HOME = home;
|
process.env.HOME = home;
|
||||||
delete process.env.MOSAIC_HOME;
|
delete process.env.MOSAIC_HOME;
|
||||||
const runtimeDir = join(home, '.npm-global', 'bin');
|
|
||||||
await mkdir(runtimeDir, { recursive: true });
|
|
||||||
await writeFile(join(runtimeDir, 'pi'), '#!/bin/sh\nexit 0\n', { mode: 0o755 });
|
|
||||||
await writeFile(join(runtimeDir, 'mosaic'), '#!/bin/sh\nexit 0\n', { mode: 0o755 });
|
|
||||||
const mosaicHome = join(home, '.config', 'mosaic');
|
const mosaicHome = join(home, '.config', 'mosaic');
|
||||||
const program = new Command();
|
const program = new Command();
|
||||||
program.exitOverride();
|
program.exitOverride();
|
||||||
@@ -1319,10 +1315,6 @@ describe('fleet command construction', () => {
|
|||||||
const originalHome = process.env.HOME;
|
const originalHome = process.env.HOME;
|
||||||
const home = await tempDir();
|
const home = await tempDir();
|
||||||
process.env.HOME = home;
|
process.env.HOME = home;
|
||||||
const runtimeDir = join(home, '.npm-global', 'bin');
|
|
||||||
await mkdir(runtimeDir, { recursive: true });
|
|
||||||
await writeFile(join(runtimeDir, 'pi'), '#!/bin/sh\nexit 0\n', { mode: 0o755 });
|
|
||||||
await writeFile(join(runtimeDir, 'mosaic'), '#!/bin/sh\nexit 0\n', { mode: 0o755 });
|
|
||||||
const mosaicHome = join(home, '.config', 'mosaic');
|
const mosaicHome = join(home, '.config', 'mosaic');
|
||||||
const agentEnvDir = join(mosaicHome, 'fleet', 'agents');
|
const agentEnvDir = join(mosaicHome, 'fleet', 'agents');
|
||||||
const fleetDir = join(mosaicHome, 'fleet');
|
const fleetDir = join(mosaicHome, 'fleet');
|
||||||
|
|||||||
@@ -60,12 +60,6 @@ import {
|
|||||||
writeAgentEnvironmentProjection,
|
writeAgentEnvironmentProjection,
|
||||||
writeManagedFleetRoster,
|
writeManagedFleetRoster,
|
||||||
} from '../fleet/generated-env-boundary.js';
|
} from '../fleet/generated-env-boundary.js';
|
||||||
import {
|
|
||||||
assertFleetRuntimeAvailability,
|
|
||||||
FleetRuntimePreflightError,
|
|
||||||
inspectFleetRuntimeAvailability,
|
|
||||||
type FleetRuntimeProbeRunner,
|
|
||||||
} from '../fleet/fleet-runtime-preflight.js';
|
|
||||||
import { registerFleetBacklogCommand } from './fleet-backlog.js';
|
import { registerFleetBacklogCommand } from './fleet-backlog.js';
|
||||||
import { registerFleetPersonaCommand } from './fleet-personas.js';
|
import { registerFleetPersonaCommand } from './fleet-personas.js';
|
||||||
import { registerFleetProfileCommand } from './fleet-profiles.js';
|
import { registerFleetProfileCommand } from './fleet-profiles.js';
|
||||||
@@ -95,8 +89,6 @@ export type SleepFn = (ms: number) => Promise<void>;
|
|||||||
|
|
||||||
export interface FleetCommandDeps {
|
export interface FleetCommandDeps {
|
||||||
runner?: CommandRunner;
|
runner?: CommandRunner;
|
||||||
/** Executes the pane-PATH helper under a clean launcher environment. */
|
|
||||||
runtimeProbeRunner?: FleetRuntimeProbeRunner;
|
|
||||||
/** Injectable interactive runner for commands needing inherited TTY (e.g., `tmux attach`). */
|
/** Injectable interactive runner for commands needing inherited TTY (e.g., `tmux attach`). */
|
||||||
interactiveRunner?: InteractiveRunner;
|
interactiveRunner?: InteractiveRunner;
|
||||||
/**
|
/**
|
||||||
@@ -1437,10 +1429,6 @@ export function isSendAccepted(capturedOutput: string): SendVerifyResult {
|
|||||||
|
|
||||||
export function registerFleetCommand(program: Command, deps: FleetCommandDeps = {}): Command {
|
export function registerFleetCommand(program: Command, deps: FleetCommandDeps = {}): Command {
|
||||||
const runner = deps.runner ?? runCommand;
|
const runner = deps.runner ?? runCommand;
|
||||||
const runtimeProbeRunner: FleetRuntimeProbeRunner =
|
|
||||||
deps.runtimeProbeRunner ??
|
|
||||||
(async (command: string, args: readonly string[]): Promise<CommandResult> =>
|
|
||||||
runCommand(command, [...args]));
|
|
||||||
const sleepFn = deps.sleepFn ?? defaultSleep;
|
const sleepFn = deps.sleepFn ?? defaultSleep;
|
||||||
const paths = resolveFleetPaths(deps.mosaicHome);
|
const paths = resolveFleetPaths(deps.mosaicHome);
|
||||||
const frameworkRoot = deps.frameworkRoot ?? resolveFrameworkRoot();
|
const frameworkRoot = deps.frameworkRoot ?? resolveFrameworkRoot();
|
||||||
@@ -1539,7 +1527,7 @@ export function registerFleetCommand(program: Command, deps: FleetCommandDeps =
|
|||||||
.description('Install local fleet tools and user systemd units')
|
.description('Install local fleet tools and user systemd units')
|
||||||
.option('--no-enable', 'Skip enabling units for boot-survival')
|
.option('--no-enable', 'Skip enabling units for boot-survival')
|
||||||
.action(async (opts: { enable?: boolean }) => {
|
.action(async (opts: { enable?: boolean }) => {
|
||||||
await installFleet(cmd, frameworkRoot, runtimeProbeRunner);
|
await installFleet(cmd, frameworkRoot);
|
||||||
// Unit enablement needs agent names only, so it reads either version.
|
// Unit enablement needs agent names only, so it reads either version.
|
||||||
const roster = await loadRosterReadModel(cmd);
|
const roster = await loadRosterReadModel(cmd);
|
||||||
await enableFleetUnits(runner, roster, opts);
|
await enableFleetUnits(runner, roster, opts);
|
||||||
@@ -1550,7 +1538,7 @@ export function registerFleetCommand(program: Command, deps: FleetCommandDeps =
|
|||||||
.description('Install local fleet tools and user systemd units')
|
.description('Install local fleet tools and user systemd units')
|
||||||
.option('--no-enable', 'Skip enabling units for boot-survival')
|
.option('--no-enable', 'Skip enabling units for boot-survival')
|
||||||
.action(async (opts: { enable?: boolean }) => {
|
.action(async (opts: { enable?: boolean }) => {
|
||||||
await installFleet(cmd, frameworkRoot, runtimeProbeRunner);
|
await installFleet(cmd, frameworkRoot);
|
||||||
// Unit enablement needs agent names only, so it reads either version.
|
// Unit enablement needs agent names only, so it reads either version.
|
||||||
const roster = await loadRosterReadModel(cmd);
|
const roster = await loadRosterReadModel(cmd);
|
||||||
await enableFleetUnits(runner, roster, opts);
|
await enableFleetUnits(runner, roster, opts);
|
||||||
@@ -2096,8 +2084,6 @@ export function registerFleetCommand(program: Command, deps: FleetCommandDeps =
|
|||||||
});
|
});
|
||||||
registerFleetReconcilerCommands(cmd, {
|
registerFleetReconcilerCommands(cmd, {
|
||||||
runner,
|
runner,
|
||||||
runtimeProbeRunner,
|
|
||||||
frameworkRoot,
|
|
||||||
mosaicHome: deps.mosaicHome,
|
mosaicHome: deps.mosaicHome,
|
||||||
reconcileDeps: deps.reconcileDeps,
|
reconcileDeps: deps.reconcileDeps,
|
||||||
});
|
});
|
||||||
@@ -2363,68 +2349,18 @@ export function registerFleetAgentCommands(
|
|||||||
});
|
});
|
||||||
}
|
}
|
||||||
|
|
||||||
async function installFleet(
|
async function installFleet(cmd: Command, frameworkRoot: string): Promise<void> {
|
||||||
cmd: Command,
|
|
||||||
frameworkRoot: string,
|
|
||||||
runtimeProbeRunner: FleetRuntimeProbeRunner,
|
|
||||||
): Promise<void> {
|
|
||||||
const activePaths = resolveFleetPaths(cmd.opts<{ mosaicHome: string }>().mosaicHome);
|
const activePaths = resolveFleetPaths(cmd.opts<{ mosaicHome: string }>().mosaicHome);
|
||||||
assertDefaultMosaicHomeForSystemd(activePaths.mosaicHome);
|
assertDefaultMosaicHomeForSystemd(activePaths.mosaicHome);
|
||||||
// Read and preflight before the first mkdir/copy/chmod/write. A successful
|
// Read model first: every file this function places is roster-independent, and
|
||||||
// install must mean every roster runtime is executable in the eventual pane,
|
// the v1 parser would reject a v2 roster before any of them were written.
|
||||||
// not merely visible to the operator who invoked this command.
|
|
||||||
const roster = await loadRosterReadModel(cmd);
|
const roster = await loadRosterReadModel(cmd);
|
||||||
const v1Roster = roster.version === 1 ? await loadRosterForCommand(cmd) : undefined;
|
|
||||||
const preflightV1Projections =
|
|
||||||
v1Roster === undefined
|
|
||||||
? []
|
|
||||||
: await Promise.all(
|
|
||||||
v1Roster.agents.map((agent: FleetAgent) =>
|
|
||||||
prepareAgentEnvironmentProjection({
|
|
||||||
mosaicHome: activePaths.mosaicHome,
|
|
||||||
agentEnvDir: activePaths.agentEnvDir,
|
|
||||||
agentName: agent.name,
|
|
||||||
generated: generateAgentEnvValues(v1Roster, agent),
|
|
||||||
}),
|
|
||||||
),
|
|
||||||
);
|
|
||||||
const preflightAgents =
|
|
||||||
v1Roster === undefined
|
|
||||||
? roster.agents
|
|
||||||
: v1Roster.agents.map((agent: FleetAgent, index: number) => {
|
|
||||||
const prepared = preflightV1Projections[index];
|
|
||||||
if (prepared === undefined) {
|
|
||||||
throw new Error(`Missing prepared environment projection for ${agent.name}.`);
|
|
||||||
}
|
|
||||||
const local = parseAgentEnvironment(prepared.local, 'local');
|
|
||||||
return {
|
|
||||||
name: agent.name,
|
|
||||||
runtime: agent.runtime,
|
|
||||||
runtimeBin: local['MOSAIC_RUNTIME_BIN'] ?? '',
|
|
||||||
};
|
|
||||||
});
|
|
||||||
const runtimeInspection = await inspectFleetRuntimeAvailability({
|
|
||||||
mosaicHome: activePaths.mosaicHome,
|
|
||||||
agentEnvDir: activePaths.agentEnvDir,
|
|
||||||
helperPath: join(frameworkRoot, 'tools', 'fleet', 'pane-runtime-path.sh'),
|
|
||||||
agents: preflightAgents,
|
|
||||||
runner: runtimeProbeRunner,
|
|
||||||
});
|
|
||||||
try {
|
|
||||||
assertFleetRuntimeAvailability(runtimeInspection);
|
|
||||||
} catch (error: unknown) {
|
|
||||||
if (error instanceof FleetRuntimePreflightError) {
|
|
||||||
cmd.error(error.message, { code: 'fleet.runtime-preflight', exitCode: 1 });
|
|
||||||
}
|
|
||||||
throw error;
|
|
||||||
}
|
|
||||||
await ensureFleetHolderIdentity(activePaths.mosaicHome);
|
await ensureFleetHolderIdentity(activePaths.mosaicHome);
|
||||||
await mkdir(activePaths.fleetToolsDir, { recursive: true });
|
await mkdir(activePaths.fleetToolsDir, { recursive: true });
|
||||||
await mkdir(activePaths.tmuxToolsDir, { recursive: true });
|
await mkdir(activePaths.tmuxToolsDir, { recursive: true });
|
||||||
await mkdir(activePaths.systemdUserDir, { recursive: true });
|
await mkdir(activePaths.systemdUserDir, { recursive: true });
|
||||||
|
|
||||||
const startAgentSessionPath = join(activePaths.fleetToolsDir, 'start-agent-session.sh');
|
const startAgentSessionPath = join(activePaths.fleetToolsDir, 'start-agent-session.sh');
|
||||||
const paneRuntimePath = join(activePaths.fleetToolsDir, 'pane-runtime-path.sh');
|
|
||||||
const startInteractionServicePath = join(
|
const startInteractionServicePath = join(
|
||||||
activePaths.fleetToolsDir,
|
activePaths.fleetToolsDir,
|
||||||
'start-interaction-service.sh',
|
'start-interaction-service.sh',
|
||||||
@@ -2438,7 +2374,6 @@ async function installFleet(
|
|||||||
const agentSendPath = join(activePaths.tmuxToolsDir, 'agent-send.sh');
|
const agentSendPath = join(activePaths.tmuxToolsDir, 'agent-send.sh');
|
||||||
const executableToolPaths = [
|
const executableToolPaths = [
|
||||||
startAgentSessionPath,
|
startAgentSessionPath,
|
||||||
paneRuntimePath,
|
|
||||||
startInteractionServicePath,
|
startInteractionServicePath,
|
||||||
startTmuxHolderPath,
|
startTmuxHolderPath,
|
||||||
printInteractionPolicyPath,
|
printInteractionPolicyPath,
|
||||||
@@ -2449,7 +2384,6 @@ async function installFleet(
|
|||||||
join(frameworkRoot, 'tools', 'fleet', 'start-agent-session.sh'),
|
join(frameworkRoot, 'tools', 'fleet', 'start-agent-session.sh'),
|
||||||
startAgentSessionPath,
|
startAgentSessionPath,
|
||||||
);
|
);
|
||||||
await copyFile(join(frameworkRoot, 'tools', 'fleet', 'pane-runtime-path.sh'), paneRuntimePath);
|
|
||||||
await copyFile(
|
await copyFile(
|
||||||
join(frameworkRoot, 'tools', 'fleet', 'start-interaction-service.sh'),
|
join(frameworkRoot, 'tools', 'fleet', 'start-interaction-service.sh'),
|
||||||
startInteractionServicePath,
|
startInteractionServicePath,
|
||||||
@@ -2493,9 +2427,7 @@ async function installFleet(
|
|||||||
return;
|
return;
|
||||||
}
|
}
|
||||||
|
|
||||||
if (v1Roster === undefined) {
|
const v1Roster = await loadRosterForCommand(cmd);
|
||||||
throw new Error('Roster version changed while installing fleet files.');
|
|
||||||
}
|
|
||||||
for (const agent of v1Roster.agents) {
|
for (const agent of v1Roster.agents) {
|
||||||
await writeAgentEnvironmentProjection({
|
await writeAgentEnvironmentProjection({
|
||||||
mosaicHome: activePaths.mosaicHome,
|
mosaicHome: activePaths.mosaicHome,
|
||||||
|
|||||||
@@ -1,328 +0,0 @@
|
|||||||
import { spawn } from 'node:child_process';
|
|
||||||
import { chmod, mkdir, mkdtemp, rm, writeFile } from 'node:fs/promises';
|
|
||||||
import { tmpdir } from 'node:os';
|
|
||||||
import { join, resolve } from 'node:path';
|
|
||||||
import { afterEach, describe, expect, it } from 'vitest';
|
|
||||||
import {
|
|
||||||
inspectFleetRuntimeAvailability,
|
|
||||||
type FleetRuntimeProbeResult,
|
|
||||||
type FleetRuntimeProbeRunner,
|
|
||||||
} from './fleet-runtime-preflight.js';
|
|
||||||
|
|
||||||
const helperPath = resolve(process.cwd(), 'framework', 'tools', 'fleet', 'pane-runtime-path.sh');
|
|
||||||
let cleanup: string | undefined;
|
|
||||||
|
|
||||||
afterEach(async (): Promise<void> => {
|
|
||||||
if (cleanup !== undefined) await rm(cleanup, { recursive: true, force: true });
|
|
||||||
cleanup = undefined;
|
|
||||||
});
|
|
||||||
|
|
||||||
interface FleetFixture {
|
|
||||||
readonly root: string;
|
|
||||||
readonly mosaicHome: string;
|
|
||||||
readonly agentEnvDir: string;
|
|
||||||
readonly runtimeDir: string;
|
|
||||||
}
|
|
||||||
|
|
||||||
async function fleetHome(): Promise<FleetFixture> {
|
|
||||||
const root = await mkdtemp(join(tmpdir(), 'mosaic-fleet-runtime-preflight-'));
|
|
||||||
cleanup = root;
|
|
||||||
const mosaicHome = join(root, '.config', 'mosaic');
|
|
||||||
const agentEnvDir = join(mosaicHome, 'fleet', 'agents');
|
|
||||||
const runtimeDir = join(root, '.npm-global', 'bin');
|
|
||||||
await mkdir(agentEnvDir, { recursive: true, mode: 0o700 });
|
|
||||||
await mkdir(runtimeDir, { recursive: true });
|
|
||||||
for (const directory of [mosaicHome, join(mosaicHome, 'fleet'), agentEnvDir]) {
|
|
||||||
await chmod(directory, 0o700);
|
|
||||||
}
|
|
||||||
await writeExecutable(runtimeDir, 'mosaic', '#!/bin/sh\nexit 0\n');
|
|
||||||
return { root, mosaicHome, agentEnvDir, runtimeDir };
|
|
||||||
}
|
|
||||||
|
|
||||||
async function writeExecutable(directory: string, name: string, content: string): Promise<void> {
|
|
||||||
await mkdir(directory, { recursive: true });
|
|
||||||
await writeFile(join(directory, name), content, { mode: 0o755 });
|
|
||||||
}
|
|
||||||
|
|
||||||
const processRunner: FleetRuntimeProbeRunner = async (
|
|
||||||
command: string,
|
|
||||||
args: readonly string[],
|
|
||||||
): Promise<FleetRuntimeProbeResult> =>
|
|
||||||
new Promise((settle) => {
|
|
||||||
const child = spawn(command, [...args], { stdio: ['ignore', 'pipe', 'pipe'] });
|
|
||||||
let stdout = '';
|
|
||||||
let stderr = '';
|
|
||||||
child.stdout.setEncoding('utf8');
|
|
||||||
child.stderr.setEncoding('utf8');
|
|
||||||
child.stdout.on('data', (chunk: string): void => {
|
|
||||||
stdout += chunk;
|
|
||||||
});
|
|
||||||
child.stderr.on('data', (chunk: string): void => {
|
|
||||||
stderr += chunk;
|
|
||||||
});
|
|
||||||
child.on('error', (error: Error): void => {
|
|
||||||
settle({ stdout, stderr: `${stderr}${error.message}`, exitCode: 127 });
|
|
||||||
});
|
|
||||||
child.on('close', (code: number | null): void => {
|
|
||||||
settle({ stdout, stderr, exitCode: code ?? 1 });
|
|
||||||
});
|
|
||||||
});
|
|
||||||
|
|
||||||
describe('fleet runtime preflight', (): void => {
|
|
||||||
it('executes one distinct pane runtime and aggregates every requesting roster row', async (): Promise<void> => {
|
|
||||||
const fixture = await fleetHome();
|
|
||||||
await writeExecutable(fixture.runtimeDir, 'pi', '#!/bin/sh\nexit 0\n');
|
|
||||||
let probes = 0;
|
|
||||||
|
|
||||||
const inspection = await inspectFleetRuntimeAvailability({
|
|
||||||
mosaicHome: fixture.mosaicHome,
|
|
||||||
agentEnvDir: fixture.agentEnvDir,
|
|
||||||
helperPath,
|
|
||||||
agents: [
|
|
||||||
{ name: 'coder1', runtime: 'pi' },
|
|
||||||
{ name: 'coder0', runtime: 'pi' },
|
|
||||||
],
|
|
||||||
runner: async (command, args): Promise<FleetRuntimeProbeResult> => {
|
|
||||||
probes += 1;
|
|
||||||
return processRunner(command, args);
|
|
||||||
},
|
|
||||||
});
|
|
||||||
|
|
||||||
expect(probes).toBe(2);
|
|
||||||
expect(inspection.fleetCliExecutable).toEqual([
|
|
||||||
expect.objectContaining({
|
|
||||||
check: 'fleet-cli-executable',
|
|
||||||
status: 'ok',
|
|
||||||
requestedBy: ['coder0', 'coder1'],
|
|
||||||
binaryPath: join(fixture.runtimeDir, 'mosaic'),
|
|
||||||
dependency: '/bin/sh',
|
|
||||||
}),
|
|
||||||
]);
|
|
||||||
expect(inspection.fleetRuntimeAvailability).toEqual([
|
|
||||||
expect.objectContaining({
|
|
||||||
check: 'fleet-runtime-available',
|
|
||||||
runtime: 'pi',
|
|
||||||
status: 'ok',
|
|
||||||
requestedBy: ['coder0', 'coder1'],
|
|
||||||
binaryPath: join(fixture.runtimeDir, 'pi'),
|
|
||||||
dependency: '/bin/sh',
|
|
||||||
installCommand: 'npm install -g @earendil-works/pi-coding-agent',
|
|
||||||
}),
|
|
||||||
]);
|
|
||||||
expect(inspection.fleetRuntimeAvailability[0]?.panePath).toContain(fixture.runtimeDir);
|
|
||||||
});
|
|
||||||
|
|
||||||
it('returns an actionable non-green check when the pane PATH lacks the runtime', async (): Promise<void> => {
|
|
||||||
const fixture = await fleetHome();
|
|
||||||
|
|
||||||
const inspection = await inspectFleetRuntimeAvailability({
|
|
||||||
mosaicHome: fixture.mosaicHome,
|
|
||||||
agentEnvDir: fixture.agentEnvDir,
|
|
||||||
helperPath,
|
|
||||||
agents: [{ name: 'coder0', runtime: 'pi' }],
|
|
||||||
runner: processRunner,
|
|
||||||
});
|
|
||||||
|
|
||||||
expect(inspection.fleetCliExecutable[0]?.status).toBe('ok');
|
|
||||||
expect(inspection.fleetRuntimeAvailability).toEqual([
|
|
||||||
expect.objectContaining({
|
|
||||||
check: 'fleet-runtime-available',
|
|
||||||
runtime: 'pi',
|
|
||||||
status: 'missing',
|
|
||||||
requestedBy: ['coder0'],
|
|
||||||
installCommand: 'npm install -g @earendil-works/pi-coding-agent',
|
|
||||||
}),
|
|
||||||
]);
|
|
||||||
expect(inspection.fleetRuntimeAvailability[0]?.panePath).not.toContain(
|
|
||||||
process.env['PATH'] ?? 'operator-path-absent',
|
|
||||||
);
|
|
||||||
});
|
|
||||||
|
|
||||||
it('executes the side-effect-free Node version probe for Node-shebang commands', async (): Promise<void> => {
|
|
||||||
const fixture = await fleetHome();
|
|
||||||
const nodeScript = '#!/usr/bin/env node\nconsole.log("should-not-run");\n';
|
|
||||||
await writeExecutable(fixture.runtimeDir, 'mosaic', nodeScript);
|
|
||||||
await writeExecutable(fixture.runtimeDir, 'pi', nodeScript);
|
|
||||||
await writeExecutable(
|
|
||||||
fixture.runtimeDir,
|
|
||||||
'node',
|
|
||||||
'#!/bin/sh\n[ "$1" = --version ] || exit 9\nprintf "v-fixture-node\\n"\n',
|
|
||||||
);
|
|
||||||
|
|
||||||
const inspection = await inspectFleetRuntimeAvailability({
|
|
||||||
mosaicHome: fixture.mosaicHome,
|
|
||||||
agentEnvDir: fixture.agentEnvDir,
|
|
||||||
helperPath,
|
|
||||||
agents: [{ name: 'coder0', runtime: 'pi' }],
|
|
||||||
runner: processRunner,
|
|
||||||
});
|
|
||||||
|
|
||||||
for (const check of [
|
|
||||||
...inspection.fleetCliExecutable,
|
|
||||||
...inspection.fleetRuntimeAvailability,
|
|
||||||
]) {
|
|
||||||
expect(check).toMatchObject({
|
|
||||||
status: 'ok',
|
|
||||||
dependency: 'node',
|
|
||||||
probeCommand: 'node --version',
|
|
||||||
probeExit: 0,
|
|
||||||
probeOutput: 'v-fixture-node',
|
|
||||||
});
|
|
||||||
}
|
|
||||||
});
|
|
||||||
|
|
||||||
it('reddens when resolved Node-shebang commands cannot execute without pane Node', async (): Promise<void> => {
|
|
||||||
const fixture = await fleetHome();
|
|
||||||
const isolatedSystemPath = join(fixture.root, 'system-bin');
|
|
||||||
await mkdir(isolatedSystemPath, { recursive: true });
|
|
||||||
await writeFile(
|
|
||||||
join(fixture.root, '.npmrc'),
|
|
||||||
`prefix=${join(fixture.root, 'absent-prefix')}\n`,
|
|
||||||
);
|
|
||||||
const nodeScript = '#!/usr/bin/env node\nconsole.log("should-not-run");\n';
|
|
||||||
await writeExecutable(fixture.runtimeDir, 'mosaic', nodeScript);
|
|
||||||
await writeExecutable(fixture.runtimeDir, 'pi', nodeScript);
|
|
||||||
|
|
||||||
const inspection = await inspectFleetRuntimeAvailability({
|
|
||||||
mosaicHome: fixture.mosaicHome,
|
|
||||||
agentEnvDir: fixture.agentEnvDir,
|
|
||||||
helperPath,
|
|
||||||
agents: [{ name: 'coder0', runtime: 'pi' }],
|
|
||||||
runner: processRunner,
|
|
||||||
systemPath: isolatedSystemPath,
|
|
||||||
});
|
|
||||||
|
|
||||||
expect(inspection.fleetCliExecutable).toEqual([
|
|
||||||
expect.objectContaining({
|
|
||||||
check: 'fleet-cli-executable',
|
|
||||||
status: 'unexecutable',
|
|
||||||
binaryPath: join(fixture.runtimeDir, 'mosaic'),
|
|
||||||
dependency: 'node',
|
|
||||||
probeCommand: 'node --version',
|
|
||||||
}),
|
|
||||||
]);
|
|
||||||
expect(inspection.fleetRuntimeAvailability).toEqual([
|
|
||||||
expect.objectContaining({
|
|
||||||
check: 'fleet-runtime-available',
|
|
||||||
runtime: 'pi',
|
|
||||||
status: 'unexecutable',
|
|
||||||
binaryPath: join(fixture.runtimeDir, 'pi'),
|
|
||||||
dependency: 'node',
|
|
||||||
probeCommand: 'node --version',
|
|
||||||
}),
|
|
||||||
]);
|
|
||||||
expect(inspection.fleetCliExecutable[0]?.probeOutput).toBe(
|
|
||||||
'shebang command is not on the pane PATH',
|
|
||||||
);
|
|
||||||
expect(inspection.fleetCliExecutable[0]?.panePath).not.toContain('/usr/bin');
|
|
||||||
});
|
|
||||||
|
|
||||||
it('keeps distinct effective local runtime-bin paths as distinct checks', async (): Promise<void> => {
|
|
||||||
const fixture = await fleetHome();
|
|
||||||
const firstBin = join(fixture.root, 'first-bin');
|
|
||||||
const secondBin = join(fixture.root, 'second-bin');
|
|
||||||
for (const override of [
|
|
||||||
{ agent: 'coder0', runtimeBin: firstBin },
|
|
||||||
{ agent: 'coder1', runtimeBin: secondBin },
|
|
||||||
]) {
|
|
||||||
await writeExecutable(override.runtimeBin, 'pi', '#!/bin/sh\nexit 0\n');
|
|
||||||
await writeFile(
|
|
||||||
join(fixture.agentEnvDir, `${override.agent}.env.local`),
|
|
||||||
`MOSAIC_RUNTIME_BIN=${override.runtimeBin}\n`,
|
|
||||||
{ mode: 0o600 },
|
|
||||||
);
|
|
||||||
}
|
|
||||||
|
|
||||||
const inspection = await inspectFleetRuntimeAvailability({
|
|
||||||
mosaicHome: fixture.mosaicHome,
|
|
||||||
agentEnvDir: fixture.agentEnvDir,
|
|
||||||
helperPath,
|
|
||||||
agents: [
|
|
||||||
{ name: 'coder0', runtime: 'pi' },
|
|
||||||
{ name: 'coder1', runtime: 'pi' },
|
|
||||||
],
|
|
||||||
runner: processRunner,
|
|
||||||
});
|
|
||||||
|
|
||||||
expect(inspection.fleetCliExecutable).toHaveLength(2);
|
|
||||||
expect(inspection.fleetRuntimeAvailability).toHaveLength(2);
|
|
||||||
expect(inspection.fleetRuntimeAvailability.map((check) => check.requestedBy)).toEqual([
|
|
||||||
['coder0'],
|
|
||||||
['coder1'],
|
|
||||||
]);
|
|
||||||
expect(inspection.fleetRuntimeAvailability.map((check) => check.binaryPath)).toEqual([
|
|
||||||
join(firstBin, 'pi'),
|
|
||||||
join(secondBin, 'pi'),
|
|
||||||
]);
|
|
||||||
});
|
|
||||||
|
|
||||||
it('reports each distinct roster runtime with its exact install command', async (): Promise<void> => {
|
|
||||||
const fixture = await fleetHome();
|
|
||||||
let probes = 0;
|
|
||||||
|
|
||||||
const inspection = await inspectFleetRuntimeAvailability({
|
|
||||||
mosaicHome: fixture.mosaicHome,
|
|
||||||
agentEnvDir: fixture.agentEnvDir,
|
|
||||||
helperPath,
|
|
||||||
agents: [
|
|
||||||
{ name: 'pi-seat', runtime: 'pi' },
|
|
||||||
{ name: 'claude-seat', runtime: 'claude' },
|
|
||||||
{ name: 'codex-seat', runtime: 'codex' },
|
|
||||||
{ name: 'opencode-seat', runtime: 'opencode' },
|
|
||||||
],
|
|
||||||
runner: async (): Promise<FleetRuntimeProbeResult> => {
|
|
||||||
probes += 1;
|
|
||||||
return {
|
|
||||||
stdout:
|
|
||||||
'pane_path\u0000/fixture/bin:/usr/bin:/bin\u0000status\u0000missing\u0000' +
|
|
||||||
'binary_path\u0000\u0000probe_exit\u0000\u0000probe_output\u0000\u0000',
|
|
||||||
stderr: '',
|
|
||||||
exitCode: 69,
|
|
||||||
};
|
|
||||||
},
|
|
||||||
});
|
|
||||||
|
|
||||||
expect(probes).toBe(5);
|
|
||||||
expect(
|
|
||||||
inspection.fleetRuntimeAvailability.map((check) => ({
|
|
||||||
runtime: check.runtime,
|
|
||||||
installCommand: check.installCommand,
|
|
||||||
})),
|
|
||||||
).toEqual([
|
|
||||||
{
|
|
||||||
runtime: 'claude',
|
|
||||||
installCommand: 'curl -fsSL https://claude.ai/install.sh | bash',
|
|
||||||
},
|
|
||||||
{
|
|
||||||
runtime: 'codex',
|
|
||||||
installCommand: 'npm install -g @openai/codex',
|
|
||||||
},
|
|
||||||
{
|
|
||||||
runtime: 'opencode',
|
|
||||||
installCommand: 'npm install -g opencode-ai',
|
|
||||||
},
|
|
||||||
{
|
|
||||||
runtime: 'pi',
|
|
||||||
installCommand: 'npm install -g @earendil-works/pi-coding-agent',
|
|
||||||
},
|
|
||||||
]);
|
|
||||||
});
|
|
||||||
|
|
||||||
it('fails closed when the shared helper returns malformed evidence', async (): Promise<void> => {
|
|
||||||
const fixture = await fleetHome();
|
|
||||||
|
|
||||||
await expect(
|
|
||||||
inspectFleetRuntimeAvailability({
|
|
||||||
mosaicHome: fixture.mosaicHome,
|
|
||||||
agentEnvDir: fixture.agentEnvDir,
|
|
||||||
helperPath,
|
|
||||||
agents: [{ name: 'coder0', runtime: 'pi' }],
|
|
||||||
runner: async (): Promise<FleetRuntimeProbeResult> => ({
|
|
||||||
stdout: 'not-a-field-protocol',
|
|
||||||
stderr: '',
|
|
||||||
exitCode: 0,
|
|
||||||
}),
|
|
||||||
}),
|
|
||||||
).rejects.toThrow('malformed field output');
|
|
||||||
});
|
|
||||||
});
|
|
||||||
@@ -1,362 +0,0 @@
|
|||||||
import { homedir } from 'node:os';
|
|
||||||
import { getInstallInstructions } from '../runtime/detector.js';
|
|
||||||
import type { RuntimeName } from '../types.js';
|
|
||||||
import { compareCodePoints } from './deterministic-order.js';
|
|
||||||
import {
|
|
||||||
GENERATED_AGENT_ENV_SUPPORTED_RUNTIMES,
|
|
||||||
readAgentLocalEnvironment,
|
|
||||||
} from './generated-env-boundary.js';
|
|
||||||
|
|
||||||
const RUNTIME_SET = new Set<string>(GENERATED_AGENT_ENV_SUPPORTED_RUNTIMES);
|
|
||||||
|
|
||||||
export interface FleetRuntimeRequestedAgent {
|
|
||||||
readonly name: string;
|
|
||||||
readonly runtime: string;
|
|
||||||
/** Planned effective local override, when provisioning has already prepared it. */
|
|
||||||
readonly runtimeBin?: string;
|
|
||||||
}
|
|
||||||
|
|
||||||
export interface FleetRuntimeProbeResult {
|
|
||||||
readonly stdout: string;
|
|
||||||
readonly stderr: string;
|
|
||||||
readonly exitCode: number;
|
|
||||||
}
|
|
||||||
|
|
||||||
export type FleetRuntimeProbeRunner = (
|
|
||||||
command: string,
|
|
||||||
args: readonly string[],
|
|
||||||
) => Promise<FleetRuntimeProbeResult>;
|
|
||||||
|
|
||||||
export interface FleetRuntimePreflightOptions {
|
|
||||||
readonly mosaicHome: string;
|
|
||||||
readonly agentEnvDir: string;
|
|
||||||
readonly helperPath: string;
|
|
||||||
readonly agents: readonly FleetRuntimeRequestedAgent[];
|
|
||||||
readonly runner: FleetRuntimeProbeRunner;
|
|
||||||
/** Test-only system suffix; production and the launcher use the helper default. */
|
|
||||||
readonly systemPath?: string;
|
|
||||||
}
|
|
||||||
|
|
||||||
export type FleetExecutableStatus = 'ok' | 'missing' | 'unexecutable';
|
|
||||||
|
|
||||||
interface FleetExecutableEvidence {
|
|
||||||
readonly status: FleetExecutableStatus;
|
|
||||||
readonly panePath: string;
|
|
||||||
readonly binaryPath?: string;
|
|
||||||
readonly dependency?: string;
|
|
||||||
readonly probeCommand?: string;
|
|
||||||
readonly probeExit?: number;
|
|
||||||
readonly probeOutput?: string;
|
|
||||||
}
|
|
||||||
|
|
||||||
export interface FleetCliExecutableCheck extends FleetExecutableEvidence {
|
|
||||||
readonly check: 'fleet-cli-executable';
|
|
||||||
readonly binary: 'mosaic';
|
|
||||||
readonly requestedBy: readonly string[];
|
|
||||||
}
|
|
||||||
|
|
||||||
export interface FleetRuntimeCheck extends FleetExecutableEvidence {
|
|
||||||
readonly check: 'fleet-runtime-available';
|
|
||||||
readonly runtime: RuntimeName;
|
|
||||||
readonly requestedBy: readonly string[];
|
|
||||||
readonly installCommand: string;
|
|
||||||
}
|
|
||||||
|
|
||||||
export type FleetRuntimePreflightCheck = FleetCliExecutableCheck | FleetRuntimeCheck;
|
|
||||||
|
|
||||||
export interface FleetRuntimeInspection {
|
|
||||||
readonly fleetCliExecutable: readonly FleetCliExecutableCheck[];
|
|
||||||
readonly fleetRuntimeAvailability: readonly FleetRuntimeCheck[];
|
|
||||||
}
|
|
||||||
|
|
||||||
interface EffectiveAgent {
|
|
||||||
readonly name: string;
|
|
||||||
readonly runtime: RuntimeName;
|
|
||||||
readonly runtimeBin: string;
|
|
||||||
}
|
|
||||||
|
|
||||||
interface PaneProbeGroup {
|
|
||||||
readonly runtimeBin: string;
|
|
||||||
readonly requestedBy: string[];
|
|
||||||
}
|
|
||||||
|
|
||||||
interface RuntimeProbeGroup extends PaneProbeGroup {
|
|
||||||
readonly runtime: RuntimeName;
|
|
||||||
}
|
|
||||||
|
|
||||||
interface BinaryProbeRequest {
|
|
||||||
readonly binary: string;
|
|
||||||
readonly runtimeBin: string;
|
|
||||||
}
|
|
||||||
|
|
||||||
export class FleetRuntimePreflightError extends Error {
|
|
||||||
readonly checks: readonly FleetRuntimePreflightCheck[];
|
|
||||||
|
|
||||||
constructor(checks: readonly FleetRuntimePreflightCheck[]) {
|
|
||||||
super(formatFleetRuntimePreflightError(checks));
|
|
||||||
this.name = FleetRuntimePreflightError.name;
|
|
||||||
this.checks = checks;
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
export class FleetRuntimeProbeError extends Error {
|
|
||||||
constructor(message: string) {
|
|
||||||
super(message);
|
|
||||||
this.name = FleetRuntimeProbeError.name;
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
/**
|
|
||||||
* Proves the fleet CLI and every distinct runtime/effective-bin pair resolve
|
|
||||||
* with an executable shebang interpreter through the eventual pane PATH. The
|
|
||||||
* helper runs under the unit's clean launcher environment, so operator PATH can
|
|
||||||
* neither create a false green nor provide a hidden interpreter.
|
|
||||||
*/
|
|
||||||
export async function inspectFleetRuntimeAvailability(
|
|
||||||
options: FleetRuntimePreflightOptions,
|
|
||||||
): Promise<FleetRuntimeInspection> {
|
|
||||||
const agents = await resolveEffectiveAgents(options);
|
|
||||||
const paneGroups = groupPaneRequests(agents);
|
|
||||||
const runtimeGroups = groupRuntimeRequests(agents);
|
|
||||||
|
|
||||||
const fleetCliExecutable: FleetCliExecutableCheck[] = [];
|
|
||||||
for (const group of paneGroups) {
|
|
||||||
const evidence = await probeBinary(options, {
|
|
||||||
binary: 'mosaic',
|
|
||||||
runtimeBin: group.runtimeBin,
|
|
||||||
});
|
|
||||||
fleetCliExecutable.push({
|
|
||||||
check: 'fleet-cli-executable',
|
|
||||||
binary: 'mosaic',
|
|
||||||
requestedBy: sortedRequestedBy(group.requestedBy),
|
|
||||||
...evidence,
|
|
||||||
});
|
|
||||||
}
|
|
||||||
|
|
||||||
const fleetRuntimeAvailability: FleetRuntimeCheck[] = [];
|
|
||||||
for (const group of runtimeGroups) {
|
|
||||||
const evidence = await probeBinary(options, {
|
|
||||||
binary: group.runtime,
|
|
||||||
runtimeBin: group.runtimeBin,
|
|
||||||
});
|
|
||||||
fleetRuntimeAvailability.push({
|
|
||||||
check: 'fleet-runtime-available',
|
|
||||||
runtime: group.runtime,
|
|
||||||
requestedBy: sortedRequestedBy(group.requestedBy),
|
|
||||||
installCommand: getInstallInstructions(group.runtime),
|
|
||||||
...evidence,
|
|
||||||
});
|
|
||||||
}
|
|
||||||
|
|
||||||
return Object.freeze({
|
|
||||||
fleetCliExecutable: Object.freeze(fleetCliExecutable),
|
|
||||||
fleetRuntimeAvailability: Object.freeze(fleetRuntimeAvailability),
|
|
||||||
});
|
|
||||||
}
|
|
||||||
|
|
||||||
export function assertFleetRuntimeAvailability(inspection: FleetRuntimeInspection): void {
|
|
||||||
const checks: FleetRuntimePreflightCheck[] = [
|
|
||||||
...inspection.fleetCliExecutable,
|
|
||||||
...inspection.fleetRuntimeAvailability,
|
|
||||||
];
|
|
||||||
const failures = checks.filter(
|
|
||||||
(check: FleetRuntimePreflightCheck): boolean => check.status !== 'ok',
|
|
||||||
);
|
|
||||||
if (failures.length > 0) throw new FleetRuntimePreflightError(failures);
|
|
||||||
}
|
|
||||||
|
|
||||||
export function formatFleetRuntimePreflightError(
|
|
||||||
checks: readonly FleetRuntimePreflightCheck[],
|
|
||||||
): string {
|
|
||||||
const lines = ['Fleet runtime preflight failed:'];
|
|
||||||
for (const check of checks) {
|
|
||||||
const dependency = check.dependency === undefined ? '' : ` dependency=${check.dependency}`;
|
|
||||||
const probe = check.probeCommand === undefined ? '' : ` dependency_probe=${check.probeCommand}`;
|
|
||||||
const execution =
|
|
||||||
check.status === 'unexecutable'
|
|
||||||
? ` probe_exit=${check.probeExit?.toString() ?? 'not-run'} ` +
|
|
||||||
`probe_output=${JSON.stringify(check.probeOutput ?? '')}`
|
|
||||||
: '';
|
|
||||||
if (check.check === 'fleet-cli-executable') {
|
|
||||||
lines.push(
|
|
||||||
`check=${check.check} binary=${check.binary} ` +
|
|
||||||
`requested_by=${check.requestedBy.join(',')} pane_path=${check.panePath}` +
|
|
||||||
`${dependency}${probe}${execution} ` +
|
|
||||||
'action=repair the Mosaic installation until its pane dependencies resolve',
|
|
||||||
);
|
|
||||||
continue;
|
|
||||||
}
|
|
||||||
lines.push(
|
|
||||||
`check=${check.check} runtime=${check.runtime} ` +
|
|
||||||
`requested_by=${check.requestedBy.join(',')} pane_path=${check.panePath}` +
|
|
||||||
`${dependency}${probe}${execution} install_command=${check.installCommand}`,
|
|
||||||
);
|
|
||||||
}
|
|
||||||
return lines.join('\n');
|
|
||||||
}
|
|
||||||
|
|
||||||
async function resolveEffectiveAgents(
|
|
||||||
options: FleetRuntimePreflightOptions,
|
|
||||||
): Promise<readonly EffectiveAgent[]> {
|
|
||||||
const agents: EffectiveAgent[] = [];
|
|
||||||
for (const agent of options.agents) {
|
|
||||||
if (!isRuntimeName(agent.runtime)) {
|
|
||||||
throw new FleetRuntimeProbeError(`Unsupported fleet runtime: ${agent.runtime}`);
|
|
||||||
}
|
|
||||||
const runtimeBin =
|
|
||||||
agent.runtimeBin ??
|
|
||||||
(
|
|
||||||
await readAgentLocalEnvironment({
|
|
||||||
mosaicHome: options.mosaicHome,
|
|
||||||
agentEnvDir: options.agentEnvDir,
|
|
||||||
agentName: agent.name,
|
|
||||||
})
|
|
||||||
)['MOSAIC_RUNTIME_BIN'] ??
|
|
||||||
'';
|
|
||||||
agents.push({ name: agent.name, runtime: agent.runtime, runtimeBin });
|
|
||||||
}
|
|
||||||
return agents;
|
|
||||||
}
|
|
||||||
|
|
||||||
function groupPaneRequests(agents: readonly EffectiveAgent[]): readonly PaneProbeGroup[] {
|
|
||||||
const groups = new Map<string, PaneProbeGroup>();
|
|
||||||
for (const agent of agents) {
|
|
||||||
const current = groups.get(agent.runtimeBin);
|
|
||||||
if (current === undefined) {
|
|
||||||
groups.set(agent.runtimeBin, { runtimeBin: agent.runtimeBin, requestedBy: [agent.name] });
|
|
||||||
} else {
|
|
||||||
current.requestedBy.push(agent.name);
|
|
||||||
}
|
|
||||||
}
|
|
||||||
return [...groups.values()].sort((left, right): number =>
|
|
||||||
compareCodePoints(left.runtimeBin, right.runtimeBin),
|
|
||||||
);
|
|
||||||
}
|
|
||||||
|
|
||||||
function groupRuntimeRequests(agents: readonly EffectiveAgent[]): readonly RuntimeProbeGroup[] {
|
|
||||||
const groups = new Map<string, RuntimeProbeGroup>();
|
|
||||||
for (const agent of agents) {
|
|
||||||
const key = JSON.stringify([agent.runtime, agent.runtimeBin]);
|
|
||||||
const current = groups.get(key);
|
|
||||||
if (current === undefined) {
|
|
||||||
groups.set(key, {
|
|
||||||
runtime: agent.runtime,
|
|
||||||
runtimeBin: agent.runtimeBin,
|
|
||||||
requestedBy: [agent.name],
|
|
||||||
});
|
|
||||||
} else {
|
|
||||||
current.requestedBy.push(agent.name);
|
|
||||||
}
|
|
||||||
}
|
|
||||||
return [...groups.values()].sort((left, right): number =>
|
|
||||||
compareCodePoints(
|
|
||||||
`${left.runtime}\u0000${left.runtimeBin}`,
|
|
||||||
`${right.runtime}\u0000${right.runtimeBin}`,
|
|
||||||
),
|
|
||||||
);
|
|
||||||
}
|
|
||||||
|
|
||||||
async function probeBinary(
|
|
||||||
options: FleetRuntimePreflightOptions,
|
|
||||||
probe: BinaryProbeRequest,
|
|
||||||
): Promise<FleetExecutableEvidence> {
|
|
||||||
const args = [
|
|
||||||
'-i',
|
|
||||||
`HOME=${process.env['HOME'] ?? homedir()}`,
|
|
||||||
'PATH=/usr/bin:/bin',
|
|
||||||
`MOSAIC_HOME=${options.mosaicHome}`,
|
|
||||||
'/bin/bash',
|
|
||||||
'--noprofile',
|
|
||||||
'--norc',
|
|
||||||
options.helperPath,
|
|
||||||
'--mosaic-home',
|
|
||||||
options.mosaicHome,
|
|
||||||
'--binary',
|
|
||||||
probe.binary,
|
|
||||||
'--check-executable',
|
|
||||||
];
|
|
||||||
if (probe.runtimeBin !== '') args.push('--runtime-bin', probe.runtimeBin);
|
|
||||||
if (options.systemPath !== undefined) args.push('--system-path', options.systemPath);
|
|
||||||
|
|
||||||
const result = await options.runner('/usr/bin/env', args);
|
|
||||||
const fields = parseNulFields(result.stdout);
|
|
||||||
const panePath = requiredField(fields, 'pane_path');
|
|
||||||
const status = requiredField(fields, 'status');
|
|
||||||
if (result.exitCode === 0 && status === 'present') {
|
|
||||||
return executableEvidence('ok', panePath, fields);
|
|
||||||
}
|
|
||||||
if (result.exitCode === 69 && status === 'missing') {
|
|
||||||
return { status: 'missing', panePath };
|
|
||||||
}
|
|
||||||
if (result.exitCode === 70 && status === 'unexecutable') {
|
|
||||||
return executableEvidence('unexecutable', panePath, fields);
|
|
||||||
}
|
|
||||||
throw new FleetRuntimeProbeError(
|
|
||||||
`Fleet executable probe failed: binary=${probe.binary} exit=${result.exitCode.toString()} ` +
|
|
||||||
`stderr=${JSON.stringify(result.stderr.trim())}`,
|
|
||||||
);
|
|
||||||
}
|
|
||||||
|
|
||||||
function executableEvidence(
|
|
||||||
status: 'ok' | 'unexecutable',
|
|
||||||
panePath: string,
|
|
||||||
fields: ReadonlyMap<string, string>,
|
|
||||||
): FleetExecutableEvidence {
|
|
||||||
const dependency = requiredField(fields, 'dependency');
|
|
||||||
const probeCommand = requiredField(fields, 'probe_command');
|
|
||||||
const probeExit = requiredField(fields, 'probe_exit');
|
|
||||||
const probeOutput = requiredField(fields, 'probe_output');
|
|
||||||
return {
|
|
||||||
status,
|
|
||||||
panePath,
|
|
||||||
binaryPath: requiredField(fields, 'binary_path'),
|
|
||||||
...(dependency === '' ? {} : { dependency }),
|
|
||||||
...(probeCommand === '' ? {} : { probeCommand }),
|
|
||||||
...(probeExit === '' ? {} : { probeExit: parseProbeExit(probeExit) }),
|
|
||||||
...(probeOutput === '' ? {} : { probeOutput }),
|
|
||||||
};
|
|
||||||
}
|
|
||||||
|
|
||||||
function sortedRequestedBy(requestedBy: readonly string[]): readonly string[] {
|
|
||||||
return Object.freeze(
|
|
||||||
[...requestedBy].sort((left: string, right: string): number => compareCodePoints(left, right)),
|
|
||||||
);
|
|
||||||
}
|
|
||||||
|
|
||||||
function parseNulFields(source: string): ReadonlyMap<string, string> {
|
|
||||||
const parts = source.split('\u0000');
|
|
||||||
if (parts.at(-1) === '') parts.pop();
|
|
||||||
if (parts.length % 2 !== 0) {
|
|
||||||
throw new FleetRuntimeProbeError('Fleet runtime probe returned malformed field output.');
|
|
||||||
}
|
|
||||||
const fields = new Map<string, string>();
|
|
||||||
for (let index = 0; index < parts.length; index += 2) {
|
|
||||||
const key = parts[index];
|
|
||||||
const value = parts[index + 1];
|
|
||||||
if (key === undefined || value === undefined || key === '' || fields.has(key)) {
|
|
||||||
throw new FleetRuntimeProbeError('Fleet runtime probe returned malformed field output.');
|
|
||||||
}
|
|
||||||
fields.set(key, value);
|
|
||||||
}
|
|
||||||
return fields;
|
|
||||||
}
|
|
||||||
|
|
||||||
function requiredField(fields: ReadonlyMap<string, string>, key: string): string {
|
|
||||||
const value = fields.get(key);
|
|
||||||
if (value === undefined) {
|
|
||||||
throw new FleetRuntimeProbeError(`Fleet runtime probe omitted ${key}.`);
|
|
||||||
}
|
|
||||||
return value;
|
|
||||||
}
|
|
||||||
|
|
||||||
function parseProbeExit(value: string): number {
|
|
||||||
const exitCode = Number(value);
|
|
||||||
if (!Number.isSafeInteger(exitCode) || exitCode < 0) {
|
|
||||||
throw new FleetRuntimeProbeError('Fleet runtime probe returned an invalid execution status.');
|
|
||||||
}
|
|
||||||
return exitCode;
|
|
||||||
}
|
|
||||||
|
|
||||||
function isRuntimeName(value: string): value is RuntimeName {
|
|
||||||
return RUNTIME_SET.has(value);
|
|
||||||
}
|
|
||||||
@@ -25,12 +25,6 @@ export interface AgentGeneratedProjectionDeletionOptions {
|
|||||||
readonly agentName: string;
|
readonly agentName: string;
|
||||||
}
|
}
|
||||||
|
|
||||||
export interface AgentLocalEnvironmentReadOptions {
|
|
||||||
readonly mosaicHome: string;
|
|
||||||
readonly agentEnvDir: string;
|
|
||||||
readonly agentName: string;
|
|
||||||
}
|
|
||||||
|
|
||||||
export interface AgentEnvironmentProjectionResult {
|
export interface AgentEnvironmentProjectionResult {
|
||||||
readonly generatedPath: string;
|
readonly generatedPath: string;
|
||||||
readonly localPath: string;
|
readonly localPath: string;
|
||||||
@@ -151,23 +145,6 @@ export function parseAgentEnvironment(
|
|||||||
return Object.freeze(values);
|
return Object.freeze(values);
|
||||||
}
|
}
|
||||||
|
|
||||||
/**
|
|
||||||
* Reads one agent's optional local overrides through the same path, file-type,
|
|
||||||
* permission, key, and value boundary used by projection/launch handling.
|
|
||||||
*/
|
|
||||||
export async function readAgentLocalEnvironment(
|
|
||||||
options: AgentLocalEnvironmentReadOptions,
|
|
||||||
): Promise<Readonly<Record<string, string>>> {
|
|
||||||
if (!AGENT_NAME.test(options.agentName)) {
|
|
||||||
throw new AgentEnvBoundaryError('unsafe-agent-name', 'MOSAIC_AGENT_NAME', options.agentName);
|
|
||||||
}
|
|
||||||
await validatePrivateProjectionDirectory(options.mosaicHome, options.agentEnvDir);
|
|
||||||
const source = await readOptionalPrivateFile(
|
|
||||||
join(options.agentEnvDir, `${options.agentName}.env.local`),
|
|
||||||
);
|
|
||||||
return source === undefined ? Object.freeze({}) : parseAgentEnvironment(source, 'local');
|
|
||||||
}
|
|
||||||
|
|
||||||
/** Renders the roster-derived generated projection in a stable, complete key order. */
|
/** Renders the roster-derived generated projection in a stable, complete key order. */
|
||||||
export function renderGeneratedAgentEnvironment(values: Readonly<Record<string, string>>): string {
|
export function renderGeneratedAgentEnvironment(values: Readonly<Record<string, string>>): string {
|
||||||
const normalized = normalizeGeneratedValues(values);
|
const normalized = normalizeGeneratedValues(values);
|
||||||
|
|||||||
@@ -19,7 +19,7 @@ const RUNTIME_DEFS: Record<
|
|||||||
label: 'Claude Code',
|
label: 'Claude Code',
|
||||||
command: 'claude',
|
command: 'claude',
|
||||||
versionFlag: '--version',
|
versionFlag: '--version',
|
||||||
installHint: 'curl -fsSL https://claude.ai/install.sh | bash',
|
installHint: 'npm install -g @anthropic-ai/claude-code',
|
||||||
},
|
},
|
||||||
codex: {
|
codex: {
|
||||||
label: 'Codex',
|
label: 'Codex',
|
||||||
@@ -31,13 +31,13 @@ const RUNTIME_DEFS: Record<
|
|||||||
label: 'OpenCode',
|
label: 'OpenCode',
|
||||||
command: 'opencode',
|
command: 'opencode',
|
||||||
versionFlag: 'version',
|
versionFlag: 'version',
|
||||||
installHint: 'npm install -g opencode-ai',
|
installHint: 'See https://opencode.ai for install instructions',
|
||||||
},
|
},
|
||||||
pi: {
|
pi: {
|
||||||
label: 'Pi',
|
label: 'Pi',
|
||||||
command: 'pi',
|
command: 'pi',
|
||||||
versionFlag: '--version',
|
versionFlag: '--version',
|
||||||
installHint: 'npm install -g @earendil-works/pi-coding-agent',
|
installHint: 'curl -fsSL https://pi.dev/install.sh | sh',
|
||||||
},
|
},
|
||||||
};
|
};
|
||||||
|
|
||||||
|
|||||||
Reference in New Issue
Block a user