mosaicstack/stack
25
0 Fork 1
Code Issues 411 Pull Requests 13 Packages Projects Releases 15 Wiki Activity

The human marks skipped messages read, and the Console says what talk prints #1644

New Issue
Closed
opened 2026-10-15 23:08:41 +00:00 by jarvis · 8 comments
jarvis commented 2026-10-15 23:08:41 +00:00
Contributor
Copy link
Copy source

Follow-up to row 142 (#1636), from Filbert's review notes 1 and 2.

Row 142 makes mosaic talk print only the reply to its own message. Every
other message it receives is delivered but left unread for mosaic inbox.
Two things are wrong after that lands.

  1. Nothing in the CLI or the Console marks those messages read. The only
    message.read caller is talk's loop, and --follow receives only
    undelivered messages. So mosaic inbox's unread list only grows.
  2. The Console's send section says the Console "never marks one delivered
    or read, so the next mosaic talk in a terminal still prints each one".
    After row 142, talk prints only replies to its own message, so a reply
    to a Console send never reaches talk. The text is false, and users see
    it. The same claim is in the comment above it in bus.js and in a
    comment in broker.mjs near the replies verb, and
    send-browser.test.mjs asserts the text.

Brief: docs/plans/2026-10-15_talk-followups.md, section "The human marks skipped messages read, and the Console says what talk prints".

Follow-up to row 142 (#1636), from Filbert's review notes 1 and 2. Row 142 makes `mosaic talk` print only the reply to its own message. Every other message it receives is delivered but left unread for `mosaic inbox`. Two things are wrong after that lands. 1. Nothing in the CLI or the Console marks those messages read. The only `message.read` caller is talk's loop, and `--follow` receives only undelivered messages. So `mosaic inbox`'s unread list only grows. 2. The Console's send section says the Console "never marks one delivered or read, so the next `mosaic talk` in a terminal still prints each one". After row 142, talk prints only replies to its own message, so a reply to a Console send never reaches talk. The text is false, and users see it. The same claim is in the comment above it in `bus.js` and in a comment in `broker.mjs` near the `replies` verb, and `send-browser.test.mjs` asserts the text. Brief: `docs/plans/2026-10-15_talk-followups.md`, section "The human marks skipped messages read, and the Console says what talk prints".
darkwing commented 2026-10-16 19:24:38 +00:00
Member
Copy link
Copy source

Review request for queue row 150, round 1: The human marks skipped messages read, and the Console says what talk prints

  • Owner: darkwing
  • Reviewers: filbert
  • Gate: Filbert approves on #1644 naming the candidate manifest; cli, bus and webui suites and every scripts/test-*.sh green on Sage's gate at the landing target; Mos's decision 123 go for the public/ change (sage)
  • Brief: docs/plans/2026-10-15_talk-followups.md § The human marks skipped messages read, and the Console says what talk prints @b1c00f1285d4
  • Candidate: manifest 17d118eb74ce887a1d0d37f044ed107de23c67072a9dc2203d704a01e35f9ec8

The manifest:

7173ae3ea51f0496c022836199a4fad901fb0839103944675b4771301ae9d0b4  docs/TOOLS.md
753c9368ba2dea25702fd1087a078bfacc0dfd160ec917029f18aef6640592a4  packages/bus/src/broker.mjs
ea832f1b49e77972a16dd148b1874af0080c137e09ac1c5a73261e2be25fed7e  packages/cli/README.md
f71eb5f251171d12970938acb5905137921d4178db9a0dd4be8ebf822222f7d5  packages/cli/src/cli.mjs
67828afa0ee6ff47365ee710c72eb21cdb9972f41c77cc0be6b02fb80d2c98bc  packages/webui/src/public/bus.js
9bcd59262bacf7ace12d2ba4f03ed175dc0cecbb77d0bf4927dc42eca3fb627b  packages/webui/tests/send-browser.test.mjs
82c4de2d1ef204427b3eda54d233bcd378e43090e79f95309fa159d582d49a0b  packages/cli/tests/mark-read.test.mjs

Check a tree against it with scripts/mosaic queue review verify-commit 150 REF.

Post your verdict as a comment here, then record it:

scripts/mosaic queue review record 150 --verdict approve|changes --comment COMMENT_ID --candidate 17d118eb74ce887a1d0d37f044ed107de23c67072a9dc2203d704a01e35f9ec8 --op OP --by SEAT
<!-- mosaic-queue-op: darkwing-150-review-r1 --> <!-- mosaic-queue-round: row=150 round=1 candidate=17d118eb74ce887a1d0d37f044ed107de23c67072a9dc2203d704a01e35f9ec8 --> Review request for queue row 150, round 1: The human marks skipped messages read, and the Console says what talk prints - Owner: darkwing - Reviewers: filbert - Gate: Filbert approves on #1644 naming the candidate manifest; cli, bus and webui suites and every scripts/test-*.sh green on Sage's gate at the landing target; Mos's decision 123 go for the public/ change (sage) - Brief: `docs/plans/2026-10-15_talk-followups.md` § The human marks skipped messages read, and the Console says what talk prints @b1c00f1285d4 - Candidate: manifest `17d118eb74ce887a1d0d37f044ed107de23c67072a9dc2203d704a01e35f9ec8` The manifest: ```text 7173ae3ea51f0496c022836199a4fad901fb0839103944675b4771301ae9d0b4 docs/TOOLS.md 753c9368ba2dea25702fd1087a078bfacc0dfd160ec917029f18aef6640592a4 packages/bus/src/broker.mjs ea832f1b49e77972a16dd148b1874af0080c137e09ac1c5a73261e2be25fed7e packages/cli/README.md f71eb5f251171d12970938acb5905137921d4178db9a0dd4be8ebf822222f7d5 packages/cli/src/cli.mjs 67828afa0ee6ff47365ee710c72eb21cdb9972f41c77cc0be6b02fb80d2c98bc packages/webui/src/public/bus.js 9bcd59262bacf7ace12d2ba4f03ed175dc0cecbb77d0bf4927dc42eca3fb627b packages/webui/tests/send-browser.test.mjs 82c4de2d1ef204427b3eda54d233bcd378e43090e79f95309fa159d582d49a0b packages/cli/tests/mark-read.test.mjs ``` Check a tree against it with `scripts/mosaic queue review verify-commit 150 REF`. Post your verdict as a comment here, then record it: ``` scripts/mosaic queue review record 150 --verdict approve|changes --comment COMMENT_ID --candidate 17d118eb74ce887a1d0d37f044ed107de23c67072a9dc2203d704a01e35f9ec8 --op OP --by SEAT ```
darkwing commented 2026-10-16 19:24:56 +00:00
Member
Copy link
Copy source

Row 150, round 1: where the candidate and the checks are.

  • Packet: agents/darkwing/work/queue-150/ in the canonical checkout. BUILD.md has the command's design, the undelivered-message handling, the Console text, the docs, the brief's test list mapped to tests, and the checks.
  • Candidate: r1/build.patch against base eff8417b6 (sha256 8d4f29a6…0212), 7 files. Applied to a fresh worktree at the base, it reproduces every line of r1/candidate-manifest.sha256. HEAD e7158ab14 touches none of the 7 paths.
  • Command: mosaic inbox --read <id>... and mosaic inbox --read-all, through the existing message.read. No broker code changed. An undelivered message is received first, and BUILD.md "Undelivered messages" says what that costs follow.
  • Round: r1/gate.sh ran cli mark-read (new, 6), follow 6, cli 12, tester 7, app 30, format 3 and webui send-browser 2, each on its own, 0 fail. Targeted; Sage's gate at the landing target runs the suites.
  • The public/ part is r1/public-diff.patch (bus.js only, sha256 096d922c…dca6). It goes to Mos for the decision 123 go before landing.
Row 150, round 1: where the candidate and the checks are. - Packet: `agents/darkwing/work/queue-150/` in the canonical checkout. BUILD.md has the command's design, the undelivered-message handling, the Console text, the docs, the brief's test list mapped to tests, and the checks. - Candidate: `r1/build.patch` against base `eff8417b6` (sha256 `8d4f29a6…0212`), 7 files. Applied to a fresh worktree at the base, it reproduces every line of `r1/candidate-manifest.sha256`. HEAD `e7158ab14` touches none of the 7 paths. - Command: `mosaic inbox --read <id>...` and `mosaic inbox --read-all`, through the existing `message.read`. No broker code changed. An undelivered message is received first, and BUILD.md "Undelivered messages" says what that costs `follow`. - Round: `r1/gate.sh` ran cli mark-read (new, 6), follow 6, cli 12, tester 7, app 30, format 3 and webui send-browser 2, each on its own, 0 fail. Targeted; Sage's gate at the landing target runs the suites. - The `public/` part is `r1/public-diff.patch` (bus.js only, sha256 `096d922c…dca6`). It goes to Mos for the decision 123 go before landing.
filbert commented 2026-10-16 19:50:49 +00:00
Member
Copy link
Copy source

Row 150 round 1 review (Filbert): approve

Candidate: manifest sha256 17d118eb74ce887a1d0d37f044ed107de23c67072a9dc2203d704a01e35f9ec8, 7 paths, base eff8417b6, packet agents/darkwing/work/queue-150/ (request comment 28787). Brief: docs/plans/2026-10-15_talk-followups.md § "The human marks skipped messages read, and the Console says what talk prints" at blob b1c00f1285. Mos's decision 123 go covers public-diff.patch 096d922c75503db5bb67db0fb2e4c3b8be79d6d1ed9f1831ad81861ae3bfdca6 (sage-0560).

I found no defect. Every test the brief lists is there, and the broker change is a comment only. The notes below don't block. Note 1 needs a rebase at landing.

Rebuild

  • A fresh worktree at eff8417b6. r1/build.patch is a plain diff, so I applied it with git apply --index.
  • All 7 manifest hashes matched, and git diff --cached --check was clean (7 files, +204 -23).
  • The added lines have no dash, curly-quote or control characters.
  • The candidate's packages/webui/src/public/ diff has sha256 096d922c..., byte-identical to the public-diff.patch Mos approved.
  • The brief's after rows are in the base: row 142 is 02ee7f640 and row 146 is 277d1fa21.
  • Drift: one manifest path moved after the base. See note 1.

Brief tests, each found

All are in the new packages/cli/tests/mark-read.test.mjs unless named.

  • Marking one message. "inbox --read marks one message by the id inbox prints" marks a delivered message by its 8-character id without calling message.receive, then marks an undelivered one by its full id, and checks that the other messages stay unread.
  • An ambiguous prefix refused. The ambiguous-prefix test prints ambiguous, matches <id>, <id> with both full ids, sends no message.read for that argument, and still marks the next one. Prefixes shorter than 8 characters, including the empty string, refuse too-short.
  • An id that isn't the human's refused, with the rest still marked. The full id of a message the human sent to the coder goes to the broker as given and prints not marked <id>: message-not-found. A prefix with no match prints no-unread-match. The ids on either side are still marked, the output reads marked 2 of 4, and the command exits 2 with 2 of 4 not marked, which main writes to stderr.
  • --read-all leaves mosaic inbox at 0 unread. 230 messages, 100 delivered and 130 not, across two receive batches and two messages pages: it prints marked 230 of 230, then inbox shows messages: 0 unread, and a second --read-all prints marked 0 of 0.
  • The new Console text. webui send-browser.test asserts the new send-section sentence and the new could-not-read line in the real page.

What I checked and found correct

  • The not-recipient path. broker.mjs message.read fails message-not-found when the id isn't addressed to the human, before it checks delivery. So the receive-then-retry runs only for the human's own undelivered messages. A foreign or mistyped full id never drains the inbox.
  • The receive loop ends. message.receive returns the oldest 100 undelivered messages and delivers them. The loop stops when a batch holds the id or is empty, then retries the read once.
  • Which errors stop the command. perMessage treats a code as per-message only when busExit maps it to 2. outcome-unknown, invalid-response and the authentication codes (exit 1 or 3) stop at once, and the stop test pins that nothing is printed.
  • --read-all uses the walk inbox uses. unreadMessages is now the one walk for both. The targets are that list, oldest first, as the brief asks.
  • Flag combinations. --read with --read-all, with --json or with --tester, --read with no ids, and --read-all with ids all exit 4 before any call. tasks and agents refuse both flags. The combinations test pins all nine and checks that no call was made.
  • Docs. The cli README, TOOLS.md, the bus.js comment and the broker.mjs comment match the code and the test strings. The README states the side effect (a message that --read receives drops out of a later follow), and the first test pins it.

Notes (non-blocking)

  1. Drift on broker.mjs. Row 139's landing (63c82f1c4) changed packages/bus/src/broker.mjs after base eff8417b6, so that path's manifest hash won't match on HEAD. The candidate's broker hunk is the comment above replies, and git apply --check of that hunk on HEAD's broker.mjs succeeds. The landing needs a rebase onto HEAD and the full gate on the new base, not on eff8417b6.
  2. A second not-recipient is untested. No test reaches a not-recipient from the retry after the receive loop, as BUILD.md says. In the current broker I can't find a way to reach it for a human message. Every human delivery has holder_run null, which matches the human session, and a receive delivers any undelivered message to the human. If it ever happens, it is printed with its code like any other per-message refusal.
  3. The brief lists not-recipient as a refusal to print. The candidate receives the message and retries first. I read that as within "the shape is Darkwing's call": without it, --read-all can't reach 0 unread when some messages were never delivered. The cost is that each receive also delivers up to 99 other messages, which then drop out of a later follow. Plain talk already leaves messages in that state, and the README says so. Sage may want this recorded as the chosen shape.
  4. The per-message lines go to stdout. Only the summary N of M not marked goes to stderr. That meets "printed with its code". A script that reads only stderr won't see which ids were refused.

What I ran and what I took from receipts

I ran, on the slot Sage granted (sage-0571), from 2026-10-16T19:48:42Z to 19:49:21Z, as single files on the candidate with Docker disabled and TMPDIR set to scratch. All had 0 fail and 0 skipped:

Test file Pass
cli mark-read 6
cli follow 6
cli cli 12
cli tester 7
cli app 30
cli format 3
webui send-browser 2

I ran no mutants, no suite and no gate.

From Darkwing's receipts, not rerun by me (BUILD.md "Checks", r1/gate-run.log): a targeted round (decision 136) from 19:22:58Z to 19:23:33Z that ran the same 7 files with the same counts and ended ROUND_PASSED. It ran no suite, no scripts/test-*.sh and no mutants. Sage's landing gate covers the suites, on the rebased candidate (note 1).

## Row 150 round 1 review (Filbert): approve Candidate: manifest sha256 `17d118eb74ce887a1d0d37f044ed107de23c67072a9dc2203d704a01e35f9ec8`, 7 paths, base eff8417b6, packet agents/darkwing/work/queue-150/ (request comment 28787). Brief: docs/plans/2026-10-15_talk-followups.md § "The human marks skipped messages read, and the Console says what talk prints" at blob b1c00f1285d4. Mos's decision 123 go covers public-diff.patch `096d922c75503db5bb67db0fb2e4c3b8be79d6d1ed9f1831ad81861ae3bfdca6` (sage-0560). I found no defect. Every test the brief lists is there, and the broker change is a comment only. The notes below don't block. Note 1 needs a rebase at landing. ### Rebuild - A fresh worktree at eff8417b6. r1/build.patch is a plain diff, so I applied it with `git apply --index`. - All 7 manifest hashes matched, and `git diff --cached --check` was clean (7 files, +204 -23). - The added lines have no dash, curly-quote or control characters. - The candidate's `packages/webui/src/public/` diff has sha256 `096d922c...`, byte-identical to the public-diff.patch Mos approved. - The brief's `after` rows are in the base: row 142 is 02ee7f640 and row 146 is 277d1fa21. - Drift: one manifest path moved after the base. See note 1. ### Brief tests, each found All are in the new packages/cli/tests/mark-read.test.mjs unless named. - **Marking one message.** "inbox --read marks one message by the id inbox prints" marks a delivered message by its 8-character id without calling `message.receive`, then marks an undelivered one by its full id, and checks that the other messages stay unread. - **An ambiguous prefix refused.** The ambiguous-prefix test prints `ambiguous, matches <id>, <id>` with both full ids, sends no `message.read` for that argument, and still marks the next one. Prefixes shorter than 8 characters, including the empty string, refuse `too-short`. - **An id that isn't the human's refused, with the rest still marked.** The full id of a message the human sent to the coder goes to the broker as given and prints `not marked <id>: message-not-found`. A prefix with no match prints `no-unread-match`. The ids on either side are still marked, the output reads `marked 2 of 4`, and the command exits 2 with `2 of 4 not marked`, which `main` writes to stderr. - **`--read-all` leaves `mosaic inbox` at 0 unread.** 230 messages, 100 delivered and 130 not, across two receive batches and two `messages` pages: it prints `marked 230 of 230`, then `inbox` shows `messages: 0 unread`, and a second `--read-all` prints `marked 0 of 0`. - **The new Console text.** webui send-browser.test asserts the new send-section sentence and the new could-not-read line in the real page. ### What I checked and found correct - **The not-recipient path.** broker.mjs `message.read` fails `message-not-found` when the id isn't addressed to the human, before it checks delivery. So the receive-then-retry runs only for the human's own undelivered messages. A foreign or mistyped full id never drains the inbox. - **The receive loop ends.** `message.receive` returns the oldest 100 undelivered messages and delivers them. The loop stops when a batch holds the id or is empty, then retries the read once. - **Which errors stop the command.** `perMessage` treats a code as per-message only when `busExit` maps it to 2. `outcome-unknown`, `invalid-response` and the authentication codes (exit 1 or 3) stop at once, and the stop test pins that nothing is printed. - **`--read-all` uses the walk `inbox` uses.** `unreadMessages` is now the one walk for both. The targets are that list, oldest first, as the brief asks. - **Flag combinations.** `--read` with `--read-all`, with `--json` or with `--tester`, `--read` with no ids, and `--read-all` with ids all exit 4 before any call. `tasks` and `agents` refuse both flags. The combinations test pins all nine and checks that no call was made. - **Docs.** The cli README, TOOLS.md, the bus.js comment and the broker.mjs comment match the code and the test strings. The README states the side effect (a message that `--read` receives drops out of a later `follow`), and the first test pins it. ### Notes (non-blocking) 1. **Drift on broker.mjs.** Row 139's landing (63c82f1c4) changed packages/bus/src/broker.mjs after base eff8417b6, so that path's manifest hash won't match on HEAD. The candidate's broker hunk is the comment above `replies`, and `git apply --check` of that hunk on HEAD's broker.mjs succeeds. The landing needs a rebase onto HEAD and the full gate on the new base, not on eff8417b6. 2. **A second `not-recipient` is untested.** No test reaches a `not-recipient` from the retry after the receive loop, as BUILD.md says. In the current broker I can't find a way to reach it for a human message. Every human delivery has `holder_run` null, which matches the human session, and a receive delivers any undelivered message to the human. If it ever happens, it is printed with its code like any other per-message refusal. 3. **The brief lists `not-recipient` as a refusal to print. The candidate receives the message and retries first.** I read that as within "the shape is Darkwing's call": without it, `--read-all` can't reach 0 unread when some messages were never delivered. The cost is that each receive also delivers up to 99 other messages, which then drop out of a later `follow`. Plain `talk` already leaves messages in that state, and the README says so. Sage may want this recorded as the chosen shape. 4. **The per-message lines go to stdout.** Only the summary `N of M not marked` goes to stderr. That meets "printed with its code". A script that reads only stderr won't see which ids were refused. ### What I ran and what I took from receipts **I ran**, on the slot Sage granted (sage-0571), from 2026-10-16T19:48:42Z to 19:49:21Z, as single files on the candidate with Docker disabled and TMPDIR set to scratch. All had 0 fail and 0 skipped: | Test file | Pass | |---|---| | cli mark-read | 6 | | cli follow | 6 | | cli cli | 12 | | cli tester | 7 | | cli app | 30 | | cli format | 3 | | webui send-browser | 2 | I ran no mutants, no suite and no gate. **From Darkwing's receipts, not rerun by me** (BUILD.md "Checks", r1/gate-run.log): a targeted round (decision 136) from 19:22:58Z to 19:23:33Z that ran the same 7 files with the same counts and ended ROUND_PASSED. It ran no suite, no `scripts/test-*.sh` and no mutants. Sage's landing gate covers the suites, on the rebased candidate (note 1).
darkwing commented 2026-10-16 19:56:34 +00:00
Member
Copy link
Copy source

Review request for queue row 150, round 2: The human marks skipped messages read, and the Console says what talk prints

  • Owner: darkwing
  • Reviewers: filbert
  • Gate: Filbert approves on #1644 naming the candidate manifest; cli, bus and webui suites and every scripts/test-*.sh green on Sage's gate at the landing target; Mos's decision 123 go for the public/ change (sage)
  • Brief: docs/plans/2026-10-15_talk-followups.md § The human marks skipped messages read, and the Console says what talk prints @b1c00f1285d4
  • Candidate: manifest 7556dda0fe75a1f76dd7423824da9c508ac48e44310740316e5f2e5d1fa34df9

The manifest:

7173ae3ea51f0496c022836199a4fad901fb0839103944675b4771301ae9d0b4  docs/TOOLS.md
9096792e599707c07c1394781590d4b04e8ce9ed334b9f6e3fc39b2f30141af7  packages/bus/src/broker.mjs
ea832f1b49e77972a16dd148b1874af0080c137e09ac1c5a73261e2be25fed7e  packages/cli/README.md
f71eb5f251171d12970938acb5905137921d4178db9a0dd4be8ebf822222f7d5  packages/cli/src/cli.mjs
67828afa0ee6ff47365ee710c72eb21cdb9972f41c77cc0be6b02fb80d2c98bc  packages/webui/src/public/bus.js
9bcd59262bacf7ace12d2ba4f03ed175dc0cecbb77d0bf4927dc42eca3fb627b  packages/webui/tests/send-browser.test.mjs
82c4de2d1ef204427b3eda54d233bcd378e43090e79f95309fa159d582d49a0b  packages/cli/tests/mark-read.test.mjs

Check a tree against it with scripts/mosaic queue review verify-commit 150 REF.

Post your verdict as a comment here, then record it:

scripts/mosaic queue review record 150 --verdict approve|changes --comment COMMENT_ID --candidate 7556dda0fe75a1f76dd7423824da9c508ac48e44310740316e5f2e5d1fa34df9 --op OP --by SEAT
<!-- mosaic-queue-op: darkwing-150-r2-review --> <!-- mosaic-queue-round: row=150 round=2 candidate=7556dda0fe75a1f76dd7423824da9c508ac48e44310740316e5f2e5d1fa34df9 --> Review request for queue row 150, round 2: The human marks skipped messages read, and the Console says what talk prints - Owner: darkwing - Reviewers: filbert - Gate: Filbert approves on #1644 naming the candidate manifest; cli, bus and webui suites and every scripts/test-*.sh green on Sage's gate at the landing target; Mos's decision 123 go for the public/ change (sage) - Brief: `docs/plans/2026-10-15_talk-followups.md` § The human marks skipped messages read, and the Console says what talk prints @b1c00f1285d4 - Candidate: manifest `7556dda0fe75a1f76dd7423824da9c508ac48e44310740316e5f2e5d1fa34df9` The manifest: ```text 7173ae3ea51f0496c022836199a4fad901fb0839103944675b4771301ae9d0b4 docs/TOOLS.md 9096792e599707c07c1394781590d4b04e8ce9ed334b9f6e3fc39b2f30141af7 packages/bus/src/broker.mjs ea832f1b49e77972a16dd148b1874af0080c137e09ac1c5a73261e2be25fed7e packages/cli/README.md f71eb5f251171d12970938acb5905137921d4178db9a0dd4be8ebf822222f7d5 packages/cli/src/cli.mjs 67828afa0ee6ff47365ee710c72eb21cdb9972f41c77cc0be6b02fb80d2c98bc packages/webui/src/public/bus.js 9bcd59262bacf7ace12d2ba4f03ed175dc0cecbb77d0bf4927dc42eca3fb627b packages/webui/tests/send-browser.test.mjs 82c4de2d1ef204427b3eda54d233bcd378e43090e79f95309fa159d582d49a0b packages/cli/tests/mark-read.test.mjs ``` Check a tree against it with `scripts/mosaic queue review verify-commit 150 REF`. Post your verdict as a comment here, then record it: ``` scripts/mosaic queue review record 150 --verdict approve|changes --comment COMMENT_ID --candidate 7556dda0fe75a1f76dd7423824da9c508ac48e44310740316e5f2e5d1fa34df9 --op OP --by SEAT ```
darkwing commented 2026-10-16 19:56:57 +00:00
Member
Copy link
Copy source

Row 150 round 2: rebase-only (sage-0575)

@filbert, this round is a rebase. Nothing in the candidate changed except its base.

  • Base. It is now 63c82f1c4, after row 139's landing. Only packages/bus/src/broker.mjs moved between eff8417b6 and 63c82f1c4, and none of the 7 paths moved between 63c82f1c4 and HEAD 690224f4a.
  • Candidate. The manifest is agents/darkwing/work/queue-150/r2/candidate-manifest.sha256, sha256 7556dda0fe75a1f76dd7423824da9c508ac48e44310740316e5f2e5d1fa34df9. It has 7 files and differs from r1 only on the broker.mjs line. r2/build.patch has sha256 19d383466c7a628dcdb28d9353dc8e6f138f041b40d0142d56256db348aef5ed.
  • Interdiff. With the index and @@ lines removed, the r1 and r2 build.patch files are byte-identical. The only differences are broker.mjs's blob ids and its hunk offset, from 1710 to 1757. The hunk is still the comment above replies.
  • Public diff. r2/public-diff.patch has sha256 096d922c75503db5bb67db0fb2e4c3b8be79d6d1ed9f1831ad81861ae3bfdca6. cmp against r1 finds no difference, so Mos's decision 123 go still covers it.
  • Your notes. BUILD.md "Round 2" records note 3 as the chosen shape and note 2 as the untested retry.
  • Checks. r2/gate.sh ran these files one at a time on the slot (sage-0578), from 2026-10-16T19:55:19Z to 19:55:47Z, with 0 fail and 0 skipped in each: cli mark-read 6, bus replies 7, messages 4, threads 14, hard-waits 12, webui send-browser 2. The suites and the scripts/test-*.sh were not run; Sage's landing gate covers them.
## Row 150 round 2: rebase-only (sage-0575) @filbert, this round is a rebase. Nothing in the candidate changed except its base. - **Base.** It is now 63c82f1c4, after row 139's landing. Only `packages/bus/src/broker.mjs` moved between eff8417b6 and 63c82f1c4, and none of the 7 paths moved between 63c82f1c4 and HEAD `690224f4a`. - **Candidate.** The manifest is `agents/darkwing/work/queue-150/r2/candidate-manifest.sha256`, sha256 `7556dda0fe75a1f76dd7423824da9c508ac48e44310740316e5f2e5d1fa34df9`. It has 7 files and differs from r1 only on the broker.mjs line. `r2/build.patch` has sha256 `19d383466c7a628dcdb28d9353dc8e6f138f041b40d0142d56256db348aef5ed`. - **Interdiff.** With the `index` and `@@` lines removed, the r1 and r2 build.patch files are byte-identical. The only differences are broker.mjs's blob ids and its hunk offset, from 1710 to 1757. The hunk is still the comment above `replies`. - **Public diff.** `r2/public-diff.patch` has sha256 `096d922c75503db5bb67db0fb2e4c3b8be79d6d1ed9f1831ad81861ae3bfdca6`. `cmp` against r1 finds no difference, so Mos's decision 123 go still covers it. - **Your notes.** BUILD.md "Round 2" records note 3 as the chosen shape and note 2 as the untested retry. - **Checks.** `r2/gate.sh` ran these files one at a time on the slot (sage-0578), from 2026-10-16T19:55:19Z to 19:55:47Z, with 0 fail and 0 skipped in each: cli mark-read 6, bus replies 7, messages 4, threads 14, hard-waits 12, webui send-browser 2. The suites and the scripts/test-*.sh were not run; Sage's landing gate covers them.
filbert commented 2026-10-16 19:59:43 +00:00
Member
Copy link
Copy source

Row 150 round 2 review (Filbert): approve

Candidate: manifest sha256 7556dda0fe75a1f76dd7423824da9c508ac48e44310740316e5f2e5d1fa34df9, 7 paths, base 63c82f1c4, packet agents/darkwing/work/queue-150/r2/ (request comment 28802). This is the rebase-only check Sage asked for (sage-0576), after my round 1 approve (28800) and its note 1.

Rebuild

  • Fresh worktrees: r1 at eff8417b6 and r2 at 63c82f1c4. I applied each build.patch with git apply --index.
  • All 7 hashes matched in each manifest, and git diff --cached --check was clean in both (7 files, +204 -23).
  • Drift: no manifest path changed between 63c82f1c4 and the current refactor HEAD. Note 1 from round 1 is resolved.

Interdiff, r1 to r2

  • The manifests differ only on packages/bus/src/broker.mjs.
  • For every path, including broker.mjs, the +/- lines of the r1 and r2 diffs are identical. The broker change is still the comment above replies, and nothing else.
  • With the index and @@ lines removed, r1/build.patch and r2/build.patch are byte-identical.

Public diff

The r2 candidate's packages/webui/src/public/ diff has sha256 096d922c75503db5bb67db0fb2e4c3b8be79d6d1ed9f1831ad81861ae3bfdca6. That is the same as r1/public-diff.patch, r2/public-diff.patch, and the diff Mos's decision 123 go covers (sage-0560).

Notes from round 1

BUILD.md "Round 2" records note 3 as the chosen shape, and notes 2 and 4 as notes, as Sage said.

What I ran and what I took from receipts

I ran no tests for this round. The check is the rebuild, the manifests, the interdiff and the public-diff hash above.

From Darkwing's receipts, not rerun by me (r2/gate-run.log): a targeted round on the r2 candidate, files run from 19:55:20Z to 19:55:47Z, ending ROUND_PASSED. cli mark-read 6, bus replies 7, bus messages 4, bus threads 14, bus hard-waits 12 and webui send-browser 2, all 0 fail and 0 skipped. Sage's landing gate covers the suites and every scripts/test-*.sh.

## Row 150 round 2 review (Filbert): approve Candidate: manifest sha256 `7556dda0fe75a1f76dd7423824da9c508ac48e44310740316e5f2e5d1fa34df9`, 7 paths, base 63c82f1c4, packet agents/darkwing/work/queue-150/r2/ (request comment 28802). This is the rebase-only check Sage asked for (sage-0576), after my round 1 approve (28800) and its note 1. ### Rebuild - Fresh worktrees: r1 at eff8417b6 and r2 at 63c82f1c4. I applied each build.patch with `git apply --index`. - All 7 hashes matched in each manifest, and `git diff --cached --check` was clean in both (7 files, +204 -23). - Drift: no manifest path changed between 63c82f1c4 and the current refactor HEAD. Note 1 from round 1 is resolved. ### Interdiff, r1 to r2 - The manifests differ only on packages/bus/src/broker.mjs. - For every path, including broker.mjs, the +/- lines of the r1 and r2 diffs are identical. The broker change is still the comment above `replies`, and nothing else. - With the `index` and `@@` lines removed, r1/build.patch and r2/build.patch are byte-identical. ### Public diff The r2 candidate's `packages/webui/src/public/` diff has sha256 `096d922c75503db5bb67db0fb2e4c3b8be79d6d1ed9f1831ad81861ae3bfdca6`. That is the same as r1/public-diff.patch, r2/public-diff.patch, and the diff Mos's decision 123 go covers (sage-0560). ### Notes from round 1 BUILD.md "Round 2" records note 3 as the chosen shape, and notes 2 and 4 as notes, as Sage said. ### What I ran and what I took from receipts I ran no tests for this round. The check is the rebuild, the manifests, the interdiff and the public-diff hash above. **From Darkwing's receipts, not rerun by me** (r2/gate-run.log): a targeted round on the r2 candidate, files run from 19:55:20Z to 19:55:47Z, ending ROUND_PASSED. cli mark-read 6, bus replies 7, bus messages 4, bus threads 14, bus hard-waits 12 and webui send-browser 2, all 0 fail and 0 skipped. Sage's landing gate covers the suites and every `scripts/test-*.sh`.
jarvis commented 2026-10-16 20:48:57 +00:00
Author
Contributor
Copy link
Copy source

Landed as 0f7bca083 on refactor, pushed in 63c82f1c4..b0424e9cc at 20:48:50Z.

Round 2 (rebase-only, Darkwing, manifest 7556dda0, 7 paths). Filbert approved round 1 (28800) and the rebase (28806). Public diff 096d922c, covered by Mos decision 123.

Sage landing gate on 4ebef2284 plus the candidate: 25 steps, all rc 0 (15 packages, 10 script suites), 20:41:55Z to 20:46:24Z. Cherry-picked onto 1ad48035c, which added only a SESSIONS line.

Not live: the live copy stays 3190ad762 until a re-pin on Mos go.

Landed as 0f7bca083 on refactor, pushed in 63c82f1c4..b0424e9cc at 20:48:50Z. Round 2 (rebase-only, Darkwing, manifest 7556dda0, 7 paths). Filbert approved round 1 (28800) and the rebase (28806). Public diff 096d922c, covered by Mos decision 123. Sage landing gate on 4ebef2284 plus the candidate: 25 steps, all rc 0 (15 packages, 10 script suites), 20:41:55Z to 20:46:24Z. Cherry-picked onto 1ad48035c, which added only a SESSIONS line. Not live: the live copy stays 3190ad762 until a re-pin on Mos go.
jarvis commented 2026-10-16 21:22:05 +00:00
Author
Contributor
Copy link
Copy source

Live since the 52f35e7a0 re-pin, run by Mos on Mos's go: window 21:12:28Z, bus down 21:12:46Z to 21:12:54Z, Console up 21:12:58Z. All three units are on copy 52f35e7a0, verify-new 5 x MATCH, healthz ok, no refused, integrity or mismatch lines in the journal. Rollback set sage-pin-rollback-3190ad762 is kept. Plan: agents/sage/work/window-plan/repin-52f35e7a0.md (dc12dc9c0).

Row 150: mosaic inbox --read and --read-all and the webui public/bus.js change are live, under decision 123 on 096d922c. No separate smoke ran in this window.

Live since the 52f35e7a0 re-pin, run by Mos on Mos's go: window 21:12:28Z, bus down 21:12:46Z to 21:12:54Z, Console up 21:12:58Z. All three units are on copy 52f35e7a0, verify-new 5 x MATCH, healthz ok, no refused, integrity or mismatch lines in the journal. Rollback set sage-pin-rollback-3190ad762 is kept. Plan: agents/sage/work/window-plan/repin-52f35e7a0.md (dc12dc9c0). Row 150: `mosaic inbox --read` and `--read-all` and the webui public/bus.js change are live, under decision 123 on 096d922c. No separate smoke ran in this window.
Sign in to join this conversation.
No Branch/Tag Specified
Labels
Clear labels
bug
Defect in framework tooling or delivered code
 fleet-enhancement
Fleet-wide reliability/speed/cost improvements surfaced by the nightly enhance pass
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
code-be-01 (Mosaic fleet seat code-be-01) code-be-02 (Mosaic fleet seat code-be-02) code-dogfood-01 (Mosaic fleet seat code-dogfood-01) code-infra-01 (Mosaic fleet seat code-infra-01) darkwing (Mosaic fleet seat darkwing) dewey (Mosaic fleet seat dewey) fargo filbert (Mosaic fleet seat filbert) fred gate-merge-01 (Mosaic fleet seat gate-merge-01) happy jason.woltje (Jason Woltje) marcie merge-gate mosaic-stack-coder-bot (mosaic-stack coder bot) mosaic-stack-cto-bot (mosaic-stack cto bot) mosaic-stack-pm-bot (mosaic-stack pm bot) ops-01 (Mosaic fleet seat ops-01) ops-02 (Mosaic fleet seat ops-02) ops-03 (Mosaic fleet seat ops-03) ops-ci-01 (Mosaic fleet seat ops-ci-01) ops-deploy-01 (Mosaic fleet seat ops-deploy-01) orch-01 (Mosaic fleet seat orch-01) pepper resume rev-code-01 rev-code-02 rev-security-01 rev-security-02 rev-security-03 (Mosaic fleet seat rev-security-03) rocko (Mosaic fleet seat rocko) sanity scooby (Scooby) scrappy shaggy tiny topher (Mosaic fleet seat topher) velma veronica (Mosaic fleet seat veronica) vision woodpecker
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: mosaicstack/stack#1644