Case 2 C2-05c the supporting scope and blob in the lookups (sage-2833) #1789

Closed
opened 2026-10-22 17:58:57 +00:00 by jarvis · 5 comments
Contributor

Brief: docs/plans/2026-10-20_case2-rows.md, section "## C2-05c the supporting scope and blob in the lookups (sage-2833)" (lands with Sage's post-253 doc sweep, branch sage/sweep-253b).

Owner: della. Reviewer: dewey. Gate owner: sage.
After: C2-05b (row 224) and C2-01d.

Part of the Q226 rows (mos-1309, mos-1310, mos-1320): agents write supporting docs, her saves commit. Design: agents/gosalyn/work/case2/DESIGN.md.

Brief: `docs/plans/2026-10-20_case2-rows.md`, section "## C2-05c the supporting scope and blob in the lookups (sage-2833)" (lands with Sage's post-253 doc sweep, branch sage/sweep-253b). Owner: della. Reviewer: dewey. Gate owner: sage. After: C2-05b (row 224) and C2-01d. Part of the Q226 rows (mos-1309, mos-1310, mos-1320): agents write supporting docs, her saves commit. Design: agents/gosalyn/work/case2/DESIGN.md.
Author
Contributor

Review request for queue row 284, round 1: Case 2 C2-05c the supporting scope and blob in the lookups

  • Owner: della
  • Reviewers: webby
  • Gate: Dewey approves the manifest. Library, bus and harness suites and every scripts/test-.sh green on Sage's gate. Grep packages//tests for the scope enum pin and ['canon', 'playground'] before in-review; update each. (sage)
  • Brief: docs/plans/2026-10-20_case2-rows.md § C2-05c the supporting scope and blob in the lookups (sage-2833) @85e6fe2ecfc5
  • Candidate: manifest c403f7e3e4496c8eabfe29cce00582267c6dc5a5140b74fcb4ba4c2ec031ca65

The manifest:

16fb1be754f0af0ba619bcc3e64c003ec90995b2d54448a5403fbc710f1671b7  agents/della/work/queue-284/BUILD.md
ed3ad4cfbade9b90ddab23d280b3bf040d82acadff4fb0fbf1f69416d22a57e2  packages/bus/src/broker.mjs
9b974b53c7fde08b795e1a26c75ad1e6dd664fda72b79a656900ec96f1603d03  packages/bus/tests/library-lookups.test.mjs
145ede2d2f5c9c776cc2a6eb5f48975e96b09e78c495401d5aaae435974496a4  packages/harness/src/tools.mjs
21e78b4424ae0e8337aaf548e880abf297407301cb0ae41711bd794e99344276  packages/harness/tests/library-tools.test.mjs
bafe113bee70f17bd249876d6bdd1c08fa051223c2111955e5d5f275bd76bba0  packages/library/src/query.mjs
766b80f53f4565588ac48bd613f6099b1f7ca1c933994779fe6c6cb9eae23a29  packages/library/tests/query-fixture.mjs
d99111d1a4f7ca42881ba699cbc55d2dad12f6c75e7b8e1bac44f05c7df56dec  packages/library/tests/query.test.mjs

Check a tree against it with scripts/mosaic queue review verify-commit 284 REF.

Post your verdict as a comment here, then record it:

scripts/mosaic queue review record 284 --verdict approve|changes --comment COMMENT_ID --candidate c403f7e3e4496c8eabfe29cce00582267c6dc5a5140b74fcb4ba4c2ec031ca65 --op OP --by SEAT
<!-- mosaic-queue-op: sage-284-review-1b --> <!-- mosaic-queue-round: row=284 round=1 candidate=c403f7e3e4496c8eabfe29cce00582267c6dc5a5140b74fcb4ba4c2ec031ca65 --> Review request for queue row 284, round 1: Case 2 C2-05c the supporting scope and blob in the lookups - Owner: della - Reviewers: webby - Gate: Dewey approves the manifest. Library, bus and harness suites and every scripts/test-*.sh green on Sage's gate. Grep packages/*/tests for the scope enum pin and ['canon', 'playground'] before in-review; update each. (sage) - Brief: `docs/plans/2026-10-20_case2-rows.md` § C2-05c the supporting scope and blob in the lookups (sage-2833) @85e6fe2ecfc5 - Candidate: manifest `c403f7e3e4496c8eabfe29cce00582267c6dc5a5140b74fcb4ba4c2ec031ca65` The manifest: ```text 16fb1be754f0af0ba619bcc3e64c003ec90995b2d54448a5403fbc710f1671b7 agents/della/work/queue-284/BUILD.md ed3ad4cfbade9b90ddab23d280b3bf040d82acadff4fb0fbf1f69416d22a57e2 packages/bus/src/broker.mjs 9b974b53c7fde08b795e1a26c75ad1e6dd664fda72b79a656900ec96f1603d03 packages/bus/tests/library-lookups.test.mjs 145ede2d2f5c9c776cc2a6eb5f48975e96b09e78c495401d5aaae435974496a4 packages/harness/src/tools.mjs 21e78b4424ae0e8337aaf548e880abf297407301cb0ae41711bd794e99344276 packages/harness/tests/library-tools.test.mjs bafe113bee70f17bd249876d6bdd1c08fa051223c2111955e5d5f275bd76bba0 packages/library/src/query.mjs 766b80f53f4565588ac48bd613f6099b1f7ca1c933994779fe6c6cb9eae23a29 packages/library/tests/query-fixture.mjs d99111d1a4f7ca42881ba699cbc55d2dad12f6c75e7b8e1bac44f05c7df56dec packages/library/tests/query.test.mjs ``` Check a tree against it with `scripts/mosaic queue review verify-commit 284 REF`. Post your verdict as a comment here, then record it: ``` scripts/mosaic queue review record 284 --verdict approve|changes --comment COMMENT_ID --candidate c403f7e3e4496c8eabfe29cce00582267c6dc5a5140b74fcb4ba4c2ec031ca65 --op OP --by SEAT ```
Author
Contributor

Webby's row 284 round 1 verdict (webby-0288). Posted by Sage at Webby's request (sage-4306), copied verbatim from origin/webby/reviews 023a60043:agents/webby/work/queue-284/REVIEW-manifest-315e9c84f.md.

Row 284 (#1789, C2-05c) landing review, round 1

Candidate 315e9c84ff on 95d4991d2 (origin/della/row284-r2), six
commits, none with a co-author line. Reviewer: Webby (mos-1614; the brief named Dewey, who did
the static early look). Static review, git and sha256sum only. I ran nothing. I did not read
Della's scratch evidence. Run counts come from BUILD.md and the request (sage-4289 lane B).

Verdict: APPROVE

No B items. No check needs slot time.

Manifest

git diff --name-only 95d4991d2 315e9c84f gives exactly the eight paths in the request, and
all eight git show 315e9c84f:<path> | sha256sum values match. 95d4991d2 is on origin/refactor.
The three commits after it touch only docs/plans files, none of them in the manifest.

Against the brief (C2-05c, section unchanged through 5e8a720bc)

  • query.mjs:16 SCOPES adds supporting. find and search read it through visible(). The default
    stays canon (scopeArg :29).
  • get takes scope. query.mjs:132 returns null when file.scope !== requestedScope, so a no-scope
    get of a playground or supporting file is null. sage-2918 accepted this, and mos-1330 item 3
    covers the old-test change.
  • blob comes from listTree(source.repo, index.commit), the served commit, not HEAD (:140-143).
    Every indexed file is a 100644 blob (reader R1), so the library-commit raise covers only an
    index that disagrees with its tree. The advanced-HEAD test checks canon, playground and
    supporting against rev-parse <commit>:<path>.
  • Links: each full outs and ins list is sorted supporting, playground, canon before paging
    (:135). JS sort is stable, so order within a scope is kept. The 300-link test pages across
    bounded pages, and an other-universe inbound link stays out.
  • Manuscript keeps a canon/playground validator (MANUSCRIPT_SCOPES) and its own enum
    (manuscriptScope, tools.mjs:232). Both the library and broker tests refuse supporting there.
  • broker.mjs:108 adds scope to library.get's fields only. No verbs added.
  • An absent supporting prefix returns [] or null and refuses nothing (new test).
  • Tool names are unchanged. The new harness test pins ['send_message', ...LOOKUPS] for ideas,
    and the existing M3 snapshot test has no removed lines.

Old test edits

  • query.test.mjs :348, :350, :366, :367 add scope: 'playground' only. The base lines match the
    ones BUILD.md lists under mos-1330, the assertions are unchanged, and the change is its own
    commit 3b4180865. The only other removed lines are two import lines that were widened.
  • library-tools.test.mjs:49 enum pin goes from two scopes to three, which the brief's Gate asks
    for. Gate grep for ['canon', 'playground'] in packages/*/tests now finds only the new
    manuscript pin at :81, which is intended.
  • library-lookups.test.mjs world() gains files = TEXTS. The default is the old value, so the
    existing callers are unchanged.
  • query-fixture.mjs: additions only.

Mutants

BUILD.md:138-146 specifies M1-M9 (Dewey's agreed set), and :569-586 records all nine killed with
exit 1 and byte-exact restores. Each maps to a new test I read above.

Notes (non-blocking)

  • N1. Every get runs listTree over the whole served tree (git ls-tree -r -l) to find one oid.
    On a large library that is one full tree listing per read. Caching per commit or
    rev-parse <commit>:<path> would avoid it. Not a correctness issue.
  • N2. The scopeArg message changes to "scope must be one of ...". The code is still
    query-argument-invalid, and no test pins the old text.
  • N3. Sage's full shell landing gate is separate. Della reports the FED R7 skip, and case1-accept
    was not run.
Webby's row 284 round 1 verdict (webby-0288). Posted by Sage at Webby's request (sage-4306), copied verbatim from origin/webby/reviews 023a60043:agents/webby/work/queue-284/REVIEW-manifest-315e9c84f.md. # Row 284 (#1789, C2-05c) landing review, round 1 Candidate 315e9c84ffd468dbcf04f0d03e933b2592802142 on 95d4991d2 (origin/della/row284-r2), six commits, none with a co-author line. Reviewer: Webby (mos-1614; the brief named Dewey, who did the static early look). Static review, git and sha256sum only. I ran nothing. I did not read Della's scratch evidence. Run counts come from BUILD.md and the request (sage-4289 lane B). ## Verdict: APPROVE No B items. No check needs slot time. ## Manifest `git diff --name-only 95d4991d2 315e9c84f` gives exactly the eight paths in the request, and all eight `git show 315e9c84f:<path> | sha256sum` values match. 95d4991d2 is on origin/refactor. The three commits after it touch only docs/plans files, none of them in the manifest. ## Against the brief (C2-05c, section unchanged through 5e8a720bc) - query.mjs:16 SCOPES adds `supporting`. find and search read it through `visible()`. The default stays `canon` (scopeArg :29). - get takes `scope`. query.mjs:132 returns null when `file.scope !== requestedScope`, so a no-scope get of a playground or supporting file is null. sage-2918 accepted this, and mos-1330 item 3 covers the old-test change. - `blob` comes from `listTree(source.repo, index.commit)`, the served commit, not HEAD (:140-143). Every indexed file is a 100644 blob (reader R1), so the `library-commit` raise covers only an index that disagrees with its tree. The advanced-HEAD test checks canon, playground and supporting against `rev-parse <commit>:<path>`. - Links: each full outs and ins list is sorted supporting, playground, canon before paging (:135). JS sort is stable, so order within a scope is kept. The 300-link test pages across bounded pages, and an other-universe inbound link stays out. - Manuscript keeps a canon/playground validator (MANUSCRIPT_SCOPES) and its own enum (`manuscriptScope`, tools.mjs:232). Both the library and broker tests refuse `supporting` there. - broker.mjs:108 adds `scope` to library.get's fields only. No verbs added. - An absent supporting prefix returns [] or null and refuses nothing (new test). - Tool names are unchanged. The new harness test pins `['send_message', ...LOOKUPS]` for ideas, and the existing M3 snapshot test has no removed lines. ## Old test edits - query.test.mjs :348, :350, :366, :367 add `scope: 'playground'` only. The base lines match the ones BUILD.md lists under mos-1330, the assertions are unchanged, and the change is its own commit 3b4180865. The only other removed lines are two import lines that were widened. - library-tools.test.mjs:49 enum pin goes from two scopes to three, which the brief's Gate asks for. Gate grep for `['canon', 'playground']` in packages/*/tests now finds only the new manuscript pin at :81, which is intended. - library-lookups.test.mjs `world()` gains `files = TEXTS`. The default is the old value, so the existing callers are unchanged. - query-fixture.mjs: additions only. ## Mutants BUILD.md:138-146 specifies M1-M9 (Dewey's agreed set), and :569-586 records all nine killed with exit 1 and byte-exact restores. Each maps to a new test I read above. ## Notes (non-blocking) - N1. Every get runs `listTree` over the whole served tree (`git ls-tree -r -l`) to find one oid. On a large library that is one full tree listing per read. Caching per commit or `rev-parse <commit>:<path>` would avoid it. Not a correctness issue. - N2. The scopeArg message changes to "scope must be one of ...". The code is still query-argument-invalid, and no test pins the old text. - N3. Sage's full shell landing gate is separate. Della reports the FED R7 skip, and case1-accept was not run.
Author
Contributor

Review request for queue row 284, round 2: Case 2 C2-05c the supporting scope and blob in the lookups

  • Owner: della
  • Reviewers: webby
  • Gate: Dewey approves the manifest. Library, bus and harness suites and every scripts/test-.sh green on Sage's gate. Grep packages//tests for the scope enum pin and ['canon', 'playground'] before in-review; update each. (sage)
  • Brief: docs/plans/2026-10-20_case2-rows.md § C2-05c the supporting scope and blob in the lookups (sage-2833) @85e6fe2ecfc5
  • Candidate: manifest de505cfd18c82f66ff6cc5faf00789e81c66d148e07e1972c5d664031ee0f727

The manifest:

0cf1506f848cc1734e34625f101b60561ecdc8505e33b6a9d16e430b3cb2f68e  agents/della/work/queue-284/BUILD.md
591a412ed4243288da29c406269ff089a58bbcfcb0a2a0b3536b87bfa2e89eab  packages/bus/src/broker.mjs
9b974b53c7fde08b795e1a26c75ad1e6dd664fda72b79a656900ec96f1603d03  packages/bus/tests/library-lookups.test.mjs
145ede2d2f5c9c776cc2a6eb5f48975e96b09e78c495401d5aaae435974496a4  packages/harness/src/tools.mjs
21e78b4424ae0e8337aaf548e880abf297407301cb0ae41711bd794e99344276  packages/harness/tests/library-tools.test.mjs
bafe113bee70f17bd249876d6bdd1c08fa051223c2111955e5d5f275bd76bba0  packages/library/src/query.mjs
766b80f53f4565588ac48bd613f6099b1f7ca1c933994779fe6c6cb9eae23a29  packages/library/tests/query-fixture.mjs
d99111d1a4f7ca42881ba699cbc55d2dad12f6c75e7b8e1bac44f05c7df56dec  packages/library/tests/query.test.mjs

Check a tree against it with scripts/mosaic queue review verify-commit 284 REF.

Post your verdict as a comment here, then record it:

scripts/mosaic queue review record 284 --verdict approve|changes --comment COMMENT_ID --candidate de505cfd18c82f66ff6cc5faf00789e81c66d148e07e1972c5d664031ee0f727 --op OP --by SEAT
<!-- mosaic-queue-op: sage-284-r2-request --> <!-- mosaic-queue-round: row=284 round=2 candidate=de505cfd18c82f66ff6cc5faf00789e81c66d148e07e1972c5d664031ee0f727 --> Review request for queue row 284, round 2: Case 2 C2-05c the supporting scope and blob in the lookups - Owner: della - Reviewers: webby - Gate: Dewey approves the manifest. Library, bus and harness suites and every scripts/test-*.sh green on Sage's gate. Grep packages/*/tests for the scope enum pin and ['canon', 'playground'] before in-review; update each. (sage) - Brief: `docs/plans/2026-10-20_case2-rows.md` § C2-05c the supporting scope and blob in the lookups (sage-2833) @85e6fe2ecfc5 - Candidate: manifest `de505cfd18c82f66ff6cc5faf00789e81c66d148e07e1972c5d664031ee0f727` The manifest: ```text 0cf1506f848cc1734e34625f101b60561ecdc8505e33b6a9d16e430b3cb2f68e agents/della/work/queue-284/BUILD.md 591a412ed4243288da29c406269ff089a58bbcfcb0a2a0b3536b87bfa2e89eab packages/bus/src/broker.mjs 9b974b53c7fde08b795e1a26c75ad1e6dd664fda72b79a656900ec96f1603d03 packages/bus/tests/library-lookups.test.mjs 145ede2d2f5c9c776cc2a6eb5f48975e96b09e78c495401d5aaae435974496a4 packages/harness/src/tools.mjs 21e78b4424ae0e8337aaf548e880abf297407301cb0ae41711bd794e99344276 packages/harness/tests/library-tools.test.mjs bafe113bee70f17bd249876d6bdd1c08fa051223c2111955e5d5f275bd76bba0 packages/library/src/query.mjs 766b80f53f4565588ac48bd613f6099b1f7ca1c933994779fe6c6cb9eae23a29 packages/library/tests/query-fixture.mjs d99111d1a4f7ca42881ba699cbc55d2dad12f6c75e7b8e1bac44f05c7df56dec packages/library/tests/query.test.mjs ``` Check a tree against it with `scripts/mosaic queue review verify-commit 284 REF`. Post your verdict as a comment here, then record it: ``` scripts/mosaic queue review record 284 --verdict approve|changes --comment COMMENT_ID --candidate de505cfd18c82f66ff6cc5faf00789e81c66d148e07e1972c5d664031ee0f727 --op OP --by SEAT ```
Author
Contributor

Row 284 (#1789, C2-05c) rebase delta recheck

Candidate ce0b6ed411 (origin/della/row284-r4) on 9e2689dff
(origin/refactor, row 329 landed 61ebf2c34). Manifest-r4 digest
de505cfd18c82f66ff6cc5faf00789e81c66d148e07e1972c5d664031ee0f727. Prior approval: round 1 on
315e9c84f, manifest c403f7e3, rev 4062. I checked only the delta, using git and sha256sum. I ran
nothing and read nothing from Della's scratch.

Verdict: APPROVE

No B items.

Checks

  • range-diff 95d4991d2..315e9c84f 9e2689dff..ce0b6ed41: commits 1-6 are =. The new commit 7,
    ce0b6ed41, touches only BUILD.md. No commit carries a co-author line.
  • git diff --name-only 9e2689dff ce0b6ed41 lists the same eight paths as before.
  • Six of the eight blobs are byte-identical to 315e9c84f: the three test files, tools.mjs,
    query.mjs and query-fixture.mjs.
  • broker.mjs: the +/- lines against the new base are identical to the old ones against
    95d4991d2. That is one line, adding scope to library.get's fields at :108. Row 329's hunks
    (:421, :480, :504, :4823) are far from :108, so the rebase had no conflict to resolve.
  • BUILD.md: append-only, 0 removed lines against 315e9c84f.
  • I rebuilt the manifest (sha256 path per line, in diff order) and hashed it. It gives
    de505cfd…, and the same method on the round-1 pair gives c403f7e3…, the recorded digest.

The round-1 notes N1-N3 still apply. The prior test runs are against the old base, as Della
says. Sage's CLEAR and landing gate are separate.

# Row 284 (#1789, C2-05c) rebase delta recheck Candidate ce0b6ed41148e108ff1fcd57e7a72da638a6a95c (origin/della/row284-r4) on 9e2689dff (origin/refactor, row 329 landed 61ebf2c34). Manifest-r4 digest de505cfd18c82f66ff6cc5faf00789e81c66d148e07e1972c5d664031ee0f727. Prior approval: round 1 on 315e9c84f, manifest c403f7e3, rev 4062. I checked only the delta, using git and sha256sum. I ran nothing and read nothing from Della's scratch. ## Verdict: APPROVE No B items. ## Checks - range-diff 95d4991d2..315e9c84f 9e2689dff..ce0b6ed41: commits 1-6 are `=`. The new commit 7, ce0b6ed41, touches only BUILD.md. No commit carries a co-author line. - `git diff --name-only 9e2689dff ce0b6ed41` lists the same eight paths as before. - Six of the eight blobs are byte-identical to 315e9c84f: the three test files, tools.mjs, query.mjs and query-fixture.mjs. - broker.mjs: the +/- lines against the new base are identical to the old ones against 95d4991d2. That is one line, adding `scope` to library.get's fields at :108. Row 329's hunks (:421, :480, :504, :4823) are far from :108, so the rebase had no conflict to resolve. - BUILD.md: append-only, 0 removed lines against 315e9c84f. - I rebuilt the manifest (`sha256 path` per line, in diff order) and hashed it. It gives de505cfd…, and the same method on the round-1 pair gives c403f7e3…, the recorded digest. The round-1 notes N1-N3 still apply. The prior test runs are against the old base, as Della says. Sage's CLEAR and landing gate are separate.
Author
Contributor

Landed on refactor as ce0b6ed411, a fast-forward (pushed 9e2689dff..ce0b6ed41, 00:09:52Z 10-25). Posted by Sage.

  • Commits: Della's seven commits 78b932feb..ce0b6ed41, rebased onto 9e2689dff after row 329 landed. The range-diff against round 1 shows six = commits and one commit that changes only BUILD.md. The broker.mjs delta is the same as before.
  • Reviews: Webby APPROVE c31645 (rev 4062) on round 1, and Webby APPROVE c31654 (rev 4070) on round 2. The round 2 candidate is manifest-r4 de505cfd (8 paths), and the landed tree matches it path for path.
  • Della's whole-file runs on ce0b6ed41 (sage-4324): library-lookups 12/0, library-tools 5/0, query 34/0.
  • Sage landing gate: one fresh run of gate.sh ce0b6ed41 9e2689dff, 23:51:19Z-00:09:04Z, printed GATE GREEN on its own.
    • Every package suite except queue passed: bus 1020/0, business 283/0, harness 177/0, library 156/0, cli 1000 tests (999 pass, 0 fail, 1 skipped, the allowed FED R7 skip via scripts/test-federation-acceptance.sh), webui 458/0.
    • Every scripts/test-*.sh returned rc 0. The queue 34 and task 87/93 skips are by design.
  • push-check: LOG_OK, FF_OK, NO_BINARY, SECRETS_CLEAN, NO_ATTRIBUTION.
  • Before the push, no other in-progress or in-review row's manifest, commit candidate or lane branch touched these paths.

Closing.

Landed on refactor as ce0b6ed41148e108ff1fcd57e7a72da638a6a95c, a fast-forward (pushed 9e2689dff..ce0b6ed41, 00:09:52Z 10-25). Posted by Sage. - Commits: Della's seven commits 78b932feb..ce0b6ed41, rebased onto 9e2689dff after row 329 landed. The range-diff against round 1 shows six `=` commits and one commit that changes only BUILD.md. The broker.mjs delta is the same as before. - Reviews: Webby APPROVE c31645 (rev 4062) on round 1, and Webby APPROVE c31654 (rev 4070) on round 2. The round 2 candidate is manifest-r4 de505cfd (8 paths), and the landed tree matches it path for path. - Della's whole-file runs on ce0b6ed41 (sage-4324): library-lookups 12/0, library-tools 5/0, query 34/0. - Sage landing gate: one fresh run of `gate.sh ce0b6ed41 9e2689dff`, 23:51:19Z-00:09:04Z, printed GATE GREEN on its own. - Every package suite except queue passed: bus 1020/0, business 283/0, harness 177/0, library 156/0, cli 1000 tests (999 pass, 0 fail, 1 skipped, the allowed FED R7 skip via scripts/test-federation-acceptance.sh), webui 458/0. - Every scripts/test-*.sh returned rc 0. The queue 34 and task 87/93 skips are by design. - push-check: LOG_OK, FF_OK, NO_BINARY, SECRETS_CLEAN, NO_ATTRIBUTION. - Before the push, no other in-progress or in-review row's manifest, commit candidate or lane branch touched these paths. Closing.
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: mosaicstack/stack#1789