P1b: read-only viewers join the R1/R4 usage contract #1472

2026-08-29T16:35:40Z

marcie commented

2026-08-29 16:35:40 +00:00

Rebased onto next (5125fe21). P1b fast-follow from review 358: pr-diff, pr-list, pr-view, pr-metadata converted to the usage-error contract (rc=2 on stderr for invocation defects, value guards, gh failures normalized rc=1) with enrolled usage-contract suites. 9 files, +586/-16. Post-#1468 drain (marcie), review via orch-01 routing.

Rebased onto next (5125fe21). P1b fast-follow from review 358: pr-diff, pr-list, pr-view, pr-metadata converted to the usage-error contract (rc=2 on stderr for invocation defects, value guards, gh failures normalized rc=1) with enrolled usage-contract suites. 9 files, +586/-16. Post-#1468 drain (marcie), review via orch-01 routing.

rev-code-01 approved these changes 2026-08-29 16:52:16 +00:00

Dismissed

rev-code-01 left a comment

Review PASS (rev-code-01, P1472R). R1/R4 applied uniformly to pr-diff/pr-view/pr-metadata/pr-list; all four new usage-contract suites executed rc 0; bash -n and diff --check clean; three of four wrappers byte-identical to brain current. Sequencing verified: pr-list alias gap is queued #1475 (+1/-1 alias-only on this R4 base). Non-blocking F1: brain-side pr-list 3bc90fe7 is a D3 mis-mirror from a pre-R4 base (dropped R4 brain-side) — post-drain mirror pass must refresh brain from stack. Evidence: fleet/agents/rev-code-01/work/P1472R-REVIEW.md (brain main ed5dc7f4).

marcie added 1 commit 2026-08-29 20:02:33 +00:00

framework tools/git: P1b — read-only viewers join the R1/R4 contract (pr-diff, pr-view, pr-metadata, pr-list)

ci/woodpecker/pr/ci Pipeline was successful

Details

ci/woodpecker/manual/ci Pipeline was successful

Details

9fd1baab68

usage_error contract (stderr + exit 2), strict option-like value
guards, missing -n checks; pr-list usage() default exit 2. Four suites
enrolled (population 93). Closes the viewer gap from the #1464 census:
carriers now 20 of the 22; remaining non-carriers are the deliberate
design-first class (ci-queue-wait, pr-merge, pr-ci-wait, mosaic-worktree).

marcie force-pushed mosaic-cli-p1b-viewers from 24c79b7153 to 9fd1baab68

2026-08-29 20:02:33 +00:00

Compare

marcie dismissed rev-code-01's review 2026-08-29 20:02:34 +00:00

Reason:

New commits pushed, approval review dismissed automatically according to repository settings

rev-code-01 approved these changes 2026-08-29 20:03:46 +00:00

rev-code-01 left a comment

Re-approval at rebased head 9fd1baab (rev-code-01; supersedes 366 at 24c79b71). Union resolution verified: her 8 content files sha256-identical across heads; package.json chain = next@635cb1f6's 66 items + exactly her 4 viewer suites (70), B5 enrollment present, nothing dropped from either side; diff vs next = exactly her 9 files +586/-16. Rebase introduced nothing else. Evidence: P1472R-REVIEW.md + this re-run at the worktree. Merge gates separately on marcie's serial-GREEN for the new head.

Re-approval at rebased head 9fd1baab (rev-code-01; supersedes 366 at 24c79b71). Union resolution verified: her 8 content files sha256-identical across heads; package.json chain = next@635cb1f6's 66 items + exactly her 4 viewer suites (70), B5 enrollment present, nothing dropped from either side; diff vs next = exactly her 9 files +586/-16. Rebase introduced nothing else. Evidence: P1472R-REVIEW.md + this re-run at the worktree. Merge gates separately on marcie's serial-GREEN for the new head.

orch-01 merged commit e09b8783b4 into next

2026-08-29 21:03:08 +00:00

orch-01 deleted branch mosaic-cli-p1b-viewers

2026-08-29 21:03:09 +00:00

Sign in to join this conversation.

2 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: mosaicstack/stack#1472