REVIEW-OF-RECORD — APPROVE (#688, head 2fd7cfc356). I reviewed the installer --next fast-npm lane and found no blockers.
Fast @next behavior: --next with no explicit ref resolves both Gitea npm dist-tags from https://git.mosaicstack.dev/api/packages/mosaicstack/npm/, requires matching numeric next.<pipeline> suffixes, and installs exact resolved versions rather than mutable @next. Live registry verification resolves @mosaicstack/mosaic@next=0.0.49-next.1633 and @mosaicstack/gateway@next=0.0.7-next.1633; a real temp-prefix install installed exactly those two versions.
Fallback/precedence: registry unavailability, mismatched suffixes, or install failure returns nonzero from the fast path and falls back to the existing source build at next; --next does not hard-fail solely on registry/dist-tag/install issues. Explicit --ref and MOSAIC_REF force the source lane and skip @next lookup, while pure --dev remains source-build behavior. The installer harness covers exact-version fast install, gateway install failure source fallback, explicit-ref precedence, and mismatched suffix warning.
Docs: user guide, framework defaults README, and design note now describe the three lanes accurately: stable npm @latest, prerelease fast npm @next with source fallback, and contributor/source build via --dev/--ref.
Reviewer verification on head 2fd7cfc3: bash -n tools/install.sh pass; bash -n tools/install-next-lane.test.sh pass; pnpm run test:installer pass; live registry check pass; real temp-prefix tools/install.sh --cli --next --yes --no-auto-launch pass with exact CLI/gateway versions; pnpm format:check pass; pnpm typecheck pass (41/41); pnpm lint pass (23/23); pnpm build pass (23/23). PR CI reported green on pipeline 1635. APPROVE.
REVIEW-OF-RECORD — APPROVE (#688, head 2fd7cfc3567f92ef6e2bf373fe643fd447469d44). I reviewed the installer --next fast-npm lane and found no blockers.
Fast @next behavior: --next with no explicit ref resolves both Gitea npm dist-tags from `https://git.mosaicstack.dev/api/packages/mosaicstack/npm/`, requires matching numeric `next.<pipeline>` suffixes, and installs exact resolved versions rather than mutable `@next`. Live registry verification resolves `@mosaicstack/mosaic@next=0.0.49-next.1633` and `@mosaicstack/gateway@next=0.0.7-next.1633`; a real temp-prefix install installed exactly those two versions.
Fallback/precedence: registry unavailability, mismatched suffixes, or install failure returns nonzero from the fast path and falls back to the existing source build at `next`; --next does not hard-fail solely on registry/dist-tag/install issues. Explicit `--ref` and `MOSAIC_REF` force the source lane and skip @next lookup, while pure `--dev` remains source-build behavior. The installer harness covers exact-version fast install, gateway install failure source fallback, explicit-ref precedence, and mismatched suffix warning.
Docs: user guide, framework defaults README, and design note now describe the three lanes accurately: stable npm @latest, prerelease fast npm @next with source fallback, and contributor/source build via --dev/--ref.
Reviewer verification on head 2fd7cfc3: `bash -n tools/install.sh` pass; `bash -n tools/install-next-lane.test.sh` pass; `pnpm run test:installer` pass; live registry check pass; real temp-prefix `tools/install.sh --cli --next --yes --no-auto-launch` pass with exact CLI/gateway versions; `pnpm format:check` pass; `pnpm typecheck` pass (41/41); `pnpm lint` pass (23/23); `pnpm build` pass (23/23). PR CI reported green on pipeline 1635. APPROVE.
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Summary
Refs #462
Verification
REVIEW-OF-RECORD — APPROVE (#688, head
2fd7cfc356). I reviewed the installer --next fast-npm lane and found no blockers.Fast @next behavior: --next with no explicit ref resolves both Gitea npm dist-tags from
https://git.mosaicstack.dev/api/packages/mosaicstack/npm/, requires matching numericnext.<pipeline>suffixes, and installs exact resolved versions rather than mutable@next. Live registry verification resolves@mosaicstack/mosaic@next=0.0.49-next.1633and@mosaicstack/gateway@next=0.0.7-next.1633; a real temp-prefix install installed exactly those two versions.Fallback/precedence: registry unavailability, mismatched suffixes, or install failure returns nonzero from the fast path and falls back to the existing source build at
next; --next does not hard-fail solely on registry/dist-tag/install issues. Explicit--refandMOSAIC_REFforce the source lane and skip @next lookup, while pure--devremains source-build behavior. The installer harness covers exact-version fast install, gateway install failure source fallback, explicit-ref precedence, and mismatched suffix warning.Docs: user guide, framework defaults README, and design note now describe the three lanes accurately: stable npm @latest, prerelease fast npm @next with source fallback, and contributor/source build via --dev/--ref.
Reviewer verification on head
2fd7cfc3:bash -n tools/install.shpass;bash -n tools/install-next-lane.test.shpass;pnpm run test:installerpass; live registry check pass; real temp-prefixtools/install.sh --cli --next --yes --no-auto-launchpass with exact CLI/gateway versions;pnpm format:checkpass;pnpm typecheckpass (41/41);pnpm lintpass (23/23);pnpm buildpass (23/23). PR CI reported green on pipeline 1635. APPROVE.