Unclaimed files left in the canonical checkout. Inventory: canonical-cleanup-inventory.md (commit-as-evidence groups). detect-secrets scan clean on 2026-11-02: hits are sha256 pins, git object ids, test sentinels already in tracked tests and unit-file lines.
45 lines
2.3 KiB
Markdown
45 lines
2.3 KiB
Markdown
## Row 132 round 2 confirm review (Filbert): approve
|
|
|
|
Candidate: manifest sha256 `0a0ebbf6313a1df6fa91731222feafdad3d4e1f39bc9bb9a471015c5a1e7048e` (8 paths), base 73fa83a08 (rows 133 and 70 in), packet agents/sage/work/queue-132/r2/ in 17a66cdb0.
|
|
|
|
Rebuild: a fresh worktree at 73fa83a08 with Researcher's round 1 row132.patch applied unchanged. Every manifest hash matched and `git diff --check` was clean. The packet manifest checks. No commit from 73fa83a08 to 17a66cdb0 touches a manifest path.
|
|
|
|
### The rebase changes nothing in the row
|
|
|
|
- The `+` and `-` lines of build.patch are byte-identical to row132.patch.
|
|
- 7 of the 8 hashes are the same as my round 1 manifest (ba644f8d...cf07). Only packages/bus/src/broker.mjs differs, because its base moved with row 133.
|
|
- `git diff -U0` under packages/bus on the candidate is the single line 99 change, `const` to `export const ORGANIZATION_KEYS`, with the same four keys. It is still the only bus change.
|
|
|
|
My round 1 approval (28604) therefore carries over.
|
|
|
|
### Row 133 and the export
|
|
|
|
- Row 133's broker.mjs diff (a622f426c) has no line naming ORGANIZATION_KEYS or organization.
|
|
- In the candidate broker.mjs, the one reader is line 737, `keys(args, ORGANIZATION_KEYS, ["revision"])` for organization.set. `keys()` only reads the list with `includes`.
|
|
- The only importer of the broker's list is harness tools.test.mjs, for the parity check. tools.mjs keeps its own frozen copy and doesn't import the broker.
|
|
|
|
So the export changes no behaviour.
|
|
|
|
### Round 1 notes
|
|
|
|
Both stay non-blocking and unchanged: the "replaces" wording in the change_organization description, and the revision-only call that the writer refuses with invalid-request.
|
|
|
|
### What I ran and what I took from receipts
|
|
|
|
**I ran**, as single files with TMPDIR set and Docker disabled, all with 0 fail and 0 skipped:
|
|
|
|
| Test file | Result |
|
|
|---|---|
|
|
| harness tools | 16/16 |
|
|
| harness bundle | 11/11 |
|
|
| harness runner | 23/23 |
|
|
| bus chief-of-staff | 13/13 |
|
|
| bus broker | 16/16 |
|
|
| bus decision-route | 5/5 |
|
|
| bus messaging | 12/12 |
|
|
| business chief-of-staff | 10/10 |
|
|
|
|
**From Sage's receipts, not rerun by me:** the landing gate on 73fa83a08 plus the candidate. I read the end of out/gate-run.log (GATE_PASSED) and out/script-land-work-rerun.log (84 passed, 0 failed).
|
|
|
|
I took no slot.
|