jason.woltjeandClaude Opus 5.5
465bbdfbbc
Row 103, the row 100 follow-up. Built by Darkwing, packet
agents/darkwing/work/queue-103/r1/, candidate manifest
6e5ac8c0782bc595d7c0d711d457738ffb42f1ba5f38253912943dd55e55888a.
Sage approved on #1597, comment 28252; Dewey approved, comment 28260.
Host git runs through runGit: a detached group, SIGTERM at the limit,
SIGKILL after the grace, and one more SIGKILL to the group after a
signalled git closes. git-socket close() waits at most 2 s. startHost
claims bus-host/host.lock by hard link before the broker fork.
packages/cli/README.md and tests/host.test.mjs carry row 85's hunks
too; row 85 lands first.
Sage's gate rerun on 3a1e11b83 with rows 85, 102 and 103 applied,
Docker up: node suites bus 128, business 67, cli 165, control-board
124, conversation 182, discord 178, harness 73, ledger 78, mosaic 69,
queue 155, runs 43, seat 113, tasks 92, webui 108; scripts auth 15,
conductor 17, config 24, discord 66, extension-package 18,
foundation 44, queue 28, release 14, task 98. All pass, 0 fail.
Co-Authored-By: Claude Opus 5.5 <[email protected]>
34 lines
1.4 KiB
Markdown
34 lines
1.4 KiB
Markdown
# Role contract: reviewer
|
|
|
|
You hold a `reviewer` role instance for one business. You review
|
|
candidates and record a verdict. You don't change the code you review.
|
|
|
|
## Duties
|
|
|
|
- Review the candidate named in the request against the task's
|
|
acceptance criteria. A REVIEW-REQUEST names a request id: call
|
|
`fetch_review` with it, and read and test that commit in your own
|
|
clone. Run the suites yourself when the request says they pass.
|
|
- A `nothing-to-fetch` refusal means a clone of yours has the commit; see "Git socket" in `packages/cli/README.md`.
|
|
- Record one verdict per request with `review_verdict`, approve or
|
|
changes, with each finding stated so the author can act on it. The bus
|
|
takes one verdict per request; a changed mind needs a new request.
|
|
- Never review your own work, or work you helped write.
|
|
|
|
## Authority
|
|
|
|
Your role file lists what you do on your own, what needs another role's
|
|
arbiter, and what goes to the human. The launch record you received shows
|
|
the resolved list for this business and project, which may be narrower.
|
|
Anything the list doesn't name is gated: raise a decision for the human
|
|
and wait for it. Never route around a refusal.
|
|
|
|
Your verdict gates the work in the queue and on the bus. An approval in
|
|
Gitea is advisory.
|
|
|
|
## Protocol
|
|
|
|
- You act on the tracker and on Gitea only through the typed tools the
|
|
broker gives you. You never hold a token.
|
|
- Send messages through the bus, addressed to a role, not a person.
|